- Dillo-dev - lists.mailman3.com

[patch] minor memory reduction

by jcid＠dillo.org

On Wed, May 21, 2008 at 05:14:25PM +0200, Johannes Hofmann wrote: > Ok, here comes a second attempt. It works with your test page and > avoids the memore leak. Please test. Committed. -- Cheers Jorge.-

May 21, 2008

Uncluttering dillos UI - getting rid of the dialog boxes

by jcid＠dillo.org

On Wed, May 21, 2008 at 10:10:59AM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Justus Winter wrote: > > Jorge Arellano Cid wrote: > >> On Sat, May 17, 2008 at 05:46:26PM +0200, Justus Winter wrote: > >>> -----BEGIN PGP SIGNED MESSAGE----- > >>> Hash: SHA1 > >>> > >>> I thought about dillos fullscreen mode, which is not a fullscreen mode > >>> at all but a "get rid of those panels"-mode. So I decided to rename > >>> those functions and variables accordingly (00-*) > >> Committed. > > > >> With the addition that when the Location is already focused, > >> the text is also selected. This helps as a visual clue and also > >> to quickly get rid of the old URL. > > > >> Note: I used a trick in ::handle() to do it. If you know a > >> better way, please send a patch. > > > > Yes, that's a nice feature indeed. Reading the fltk documentation I came > > up with the attached patch. I am pretty sure that strlen is the wrong > > function when dealing with utf-8 character data, but you get the idea. > > > > Justus > > Looking at the fltk source I realized that Input::size() does exactly > what we want and is also much more efficient. Revised patch is attached. Committed (with the comment). -- Cheers Jorge.-

May 21, 2008

Keyboard shortcuts & fullscreen button

by jcid＠dillo.org

On Tue, May 20, 2008 at 11:28:54PM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Jorge Arellano Cid wrote: > > On Sat, May 17, 2008 at 06:09:19PM +0200, Justus Winter wrote: > >> Also I noticed, that the way events are handled is somewhat lax with > >> respect to modifier keys. The code just checks if ctrl is pressed, not > >> if ctrl but none of the other modifiers are pressed. This makes ctrl-l > >> equivalent with ctrl-shift-alt-l. I'd like to hear your opinions, is > >> this a bug or a feature? > > > > Bug I think. > > > > The UI was coded in a hurry to get it running. Lax parts need > > polish. > > The attached patch addresses modifier issue. Committed. -- Cheers Jorge.-

May 21, 2008

Uncluttering dillo, part II: the findbar

by Johannes.Hofmann＠gmx.de

Hi Justus, On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hey everyone :) > > attached is a patch that transforms dillos find in page dialog box into > a firefox style toolbar. There are some issues that I cannot put my > finger on... see the comments in the event handler. Maybe there's some > magic about fltks event model that I did not fully understand... then > again it might be fltks fault. Anyway, I'd be happy for some hints. This is really nice! For text search the popup menus are even more annoying than for entering an url. One minor thing. You can make the CheckButton and Input members of Findbar private if you use static methods for the callbacks instead of functions. Cheers, Johannes

May 21, 2008

[patch] minor memory reduction

by Johannes.Hofmann＠gmx.de

Ok, here comes a second attempt. It works with your test page and avoids the memore leak. Please test. Cheers, Johannes On Tue, May 20, 2008 at 05:50:35PM -0400, Jorge Arellano Cid wrote: > On Tue, May 20, 2008 at 07:16:45PM +0200, Johannes Hofmann wrote: > > Hi, > > > > attached is a small patch to improve memory usage. It creates a > > single word for a sequence of spaces in PRE mode instead of one word > > per character. > > Good idea, but it's not the same rendering. Check the offsets > with the attached file. > > BTW, there's a memory leak when len=0 (bacause Dstr allocates > for the string). While reviewing I thought why not just count the > spaces and use dStrnfill(num_spc, ' '). > > -- > Cheers > Jorge.- > <html> > <pre> > Bla bla bla. Blabla blabla bla blala bla > bla. Blabla blabla bla bla. > > Blala bla. Blabla blabla bla blaba bla bla. Bla > blabla bla bla. > > Blilly blilly bla bla bla. Blabla > blabla bla bla. > <HR> > Lallyla layllaylay layla layla lally lally. > </pre> > </html> > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

May 21, 2008

[patch] minor memory reduction

by Johannes.Hofmann＠gmx.de

On Tue, May 20, 2008 at 05:50:35PM -0400, Jorge Arellano Cid wrote: > On Tue, May 20, 2008 at 07:16:45PM +0200, Johannes Hofmann wrote: > > Hi, > > > > attached is a small patch to improve memory usage. It creates a > > single word for a sequence of spaces in PRE mode instead of one word > > per character. > > Good idea, but it's not the same rendering. Check the offsets > with the attached file. Ouch! Do you think this is a general problem or should I try to get this working somehow? > > BTW, there's a memory leak when len=0 (bacause Dstr allocates > for the string). While reviewing I thought why not just count the > spaces and use dStrnfill(num_spc, ' '). Yes, that would be better. Cheers, Johannes > > -- > Cheers > Jorge.- > <html> > <pre> > Bla bla bla. Blabla blabla bla blala bla > bla. Blabla blabla bla bla. > > Blala bla. Blabla blabla bla blaba bla bla. Bla > blabla bla bla. > > Blilly blilly bla bla bla. Blabla > blabla bla bla. > <HR> > Lallyla layllaylay layla layla lally lally. > </pre> > </html> > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

May 21, 2008

Uncluttering dillos UI - getting rid of the dialog boxes

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Justus Winter wrote: > Jorge Arellano Cid wrote: >> On Sat, May 17, 2008 at 05:46:26PM +0200, Justus Winter wrote: >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA1 >>> >>> I thought about dillos fullscreen mode, which is not a fullscreen mode >>> at all but a "get rid of those panels"-mode. So I decided to rename >>> those functions and variables accordingly (00-*) >> Committed. > >> With the addition that when the Location is already focused, >> the text is also selected. This helps as a visual clue and also >> to quickly get rid of the old URL. > >> Note: I used a trick in ::handle() to do it. If you know a >> better way, please send a patch. > > Yes, that's a nice feature indeed. Reading the fltk documentation I came > up with the attached patch. I am pretty sure that strlen is the wrong > function when dealing with utf-8 character data, but you get the idea. > > Justus Looking at the fltk source I realized that Input::size() does exactly what we want and is also much more efficient. Revised patch is attached. Sorry for the spam. Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM9kSoPmwNWhsaZYRAhaDAKC7A/I3SYJJRYIJ/kzbw0VI/afG0QCgm+WZ VuXGU9/u8Y64FLaYQyP27o8= =hvqx -----END PGP SIGNATURE-----

May 21, 2008

RFC: human interface guidelines

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey everyone :) I was thinking about improving the dillo experience by adding some functionality / shortcuts people have come to expect. But what people expect is influenced by their background, their choice of desktop environment and platform. We could pick one / some user interface guideline(s) ([1] lists some) and try to adhere to it / them. Or we could pick one popular browser and copy its 'feel'. Attached are two patches mapping 'reload' to F5 and 'help' to F1. Let me know what you think of them and the whole interface thing. Justus 1: http://en.wikipedia.org/wiki/Human_Interface_Guidelines - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0jvoPmwNWhsaZYRAveJAJ9ROk+E0VWLzK6G99qcTlpNjeB5igCeJ7r9 Grz4wtWQ+BIEbWrIY8PDCFg= =JnX2 -----END PGP SIGNATURE-----

May 21, 2008

Uncluttering dillo, part II: the findbar

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey everyone :) attached is a patch that transforms dillos find in page dialog box into a firefox style toolbar. There are some issues that I cannot put my finger on... see the comments in the event handler. Maybe there's some magic about fltks event model that I did not fully understand... then again it might be fltks fault. Anyway, I'd be happy for some hints. Jorge, could you update your coding conventions with respect to c++ specific language features? Cheers, Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0pmoPmwNWhsaZYRAi1VAJwO/e+JWmCoMsjOF/hYuF4X1DUOWwCePB96 +X++Veu0Gyv854m0TxSwI7Q= =rc5Z -----END PGP SIGNATURE-----

May 21, 2008

[patch] minor memory reduction

by jcid＠dillo.org

On Tue, May 20, 2008 at 07:16:45PM +0200, Johannes Hofmann wrote: > Hi, > > attached is a small patch to improve memory usage. It creates a > single word for a sequence of spaces in PRE mode instead of one word > per character. Good idea, but it's not the same rendering. Check the offsets with the attached file. BTW, there's a memory leak when len=0 (bacause Dstr allocates for the string). While reviewing I thought why not just count the spaces and use dStrnfill(num_spc, ' '). -- Cheers Jorge.-

May 21, 2008