- Dillo-dev - lists.mailman3.com

tabbed patch crashes when adding bookmark

by Madis Janson

when a_Interface_msg is called. (gdb) bt #0 0x4019752d in gtk_type_check_object_cast () from /usr/lib/libgtk-1.2.so.0 #1 0x08073c05 in a_Interface_msg (bw=0x80a1268, format=0x8278f10 "Hi browser") at interface.c:763 #2 0x08056eab in a_Capi_ccc (Op=2, Branch=138708789, Dir=1, Info=0x80ff670, Data1=0x8278f10, Data2=0x8448730) at capi.c:330 #3 0x08054b2e in a_Chain_fcb (Op=2, Info=0xa, Data1=0x8278f10, Data2=0x8448730) at chain.c:95 #4 0x0807bf64 in Dpi_parse_token (conn=0x82b6fa8) at dpi.c:272 #5 0x0807bfa1 in Dpi_process_io (Op=4, Data1=0xa, conn=0x82b6fa8) at dpi.c:296 #6 0x08054b2e in a_Chain_fcb (Op=2, Info=0xa, Data1=0x823ebd8, Data2=0x0) at chain.c:95 #7 0x0807c9da in IO_read (io=0x823ebd8) at IO.c:420 #8 0x0807cabd in IO_callback (src=0x8120910, cond=G_IO_IN, data=0x617) at IO.c:504 #9 0x40217a56 in g_io_add_watch () from /usr/lib/libglib-1.2.so.0 #10 0x4021903d in g_get_current_time () from /usr/lib/libglib-1.2.so.0 #11 0x402194f4 in g_get_current_time () from /usr/lib/libglib-1.2.so.0 #12 0x40219724 in g_main_run () from /usr/lib/libglib-1.2.so.0 #13 0x4013fc3f in gtk_main () from /usr/lib/libgtk-1.2.so.0 #14 0x08067215 in main (argc=1, argv=0xbffffb04) at dillo.c:298 Bandaid fix seems to be commenting out code, which causes calling a_Interface_msg in dpi code (a_Interface_msg call in a_Capi_ccc and send_status_msg branch in Dpi_parse_token).

June 17, 2003

Re: [Dillo-dev] [RFC] Plans for next version of tab patch

by Jens Arm

Hi The dillo-tab-version is fine work !!! > There might be more, or less. Let me know. Opening new tab instead of window when middle-clicking on a link. Would be nice ;) Perhaps this should be an option in the config-file where this is choosable? Jens

June 17, 2003

[RFC] Plans for next version of tab patch

by Frank de Lange

Hej! Now that the first release of my tab patch is 'out there', I'd like to give a short overview of my plans for the next version of this patch. I do not know when I'll be able to release this next version, as I'm busy this week, followed by a trip to the UK (back the 13th of juli), but I will try to make it relatively soon... Anyway, some plans: Architecture ------------ - further separate interface code out of document code (interface messages currently go directly to the interface, some mediation might be necessary) Functionality ------------- - focus tab contents on tab switch (so key navigation works correctly without having to first click in the tab pane) - focus location bar on switch to empty tab/new tab - new empty tab should show/focus, even when 'tab load in background' is set - after tab delete, switch to NEXT tab instead of PREVIOUS (like mozilla) Coding ------ - clean up code organisation (declarations before g_return/comments) Bugs ---- - full screen off widget does not show after tab switch in full screen (probably hidden, it IS reparented) There might be more, or less. Let me know. Jorge, let me know if/when you plan to commit the patch to CVS Sebastian, do you have any suggestions as to why dw_widget tries to set the cursor on a non-existing bin_window in the mouse event code? See my earlier message on the Gdk-CRITICAL messages which sometimes appear when opening a document in a tab in the background... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo, now available on geocities

by Frank de Lange

On Tue, Jun 17, 2003 at 10:10:22AM +0200, Andreas Schweitzer wrote: > Hi, > > > I put my patch for a tabbed version of Dillo on a geocities page, so if > > you are quick you might be able to download it before Yahoo? shuts it > > down because the site has exceeded its puny transfer allowance. > > I put it as a mirror on > http://www.hs.uni-hamburg.de/~stcd102/dillo-20030615-tabs.patch.gz > > md5 of the ungzipped version is : > MD5 (dillo-20030615-tabs.patch) = 430aa3489ab88e3fec5486786c7d7648 > > Maybe Frank should double check that. I just downloaded your mirrored copy, the uncompressed patch is identical to the one I distributed. Good. > A few notes : > - on first inspection it works ;-) I hope it also works on more than first inspection. It does for me... > - On my FreeBSD 4.8 system with gcc version 2.95.4 I need > to move one line to make it compile like : Yeah, the code needs some cleanup still. I'll go through it for the next patch, and try it on FreeBSD as well. > - and last : the patches against configure and one Makefile.in won't apply, > but this can be ignored if I do another ./autogen.sh; ./configure step after > patching. I will exclude the 'generated' files in the next patch. > Now, on to finding some time to playing with it :-) ... hmmmm .... frames .... Try the tabs first I'd say, and give some feedback on the design of DilloDoc... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo, now available on geocities

by Andreas Schweitzer

Hi, > I put my patch for a tabbed version of Dillo on a geocities page, so if > you are quick you might be able to download it before Yahoo? shuts it > down because the site has exceeded its puny transfer allowance. I put it as a mirror on http://www.hs.uni-hamburg.de/~stcd102/dillo-20030615-tabs.patch.gz md5 of the ungzipped version is : MD5 (dillo-20030615-tabs.patch) = 430aa3489ab88e3fec5486786c7d7648 Maybe Frank should double check that. A few notes : - on first inspection it works ;-) - On my FreeBSD 4.8 system with gcc version 2.95.4 I need to move one line to make it compile like : $ diff -c tab.c.frank tab.c.new *** tab.c.frank Tue Jun 17 10:01:42 2003 --- tab.c.new Tue Jun 17 10:03:30 2003 *************** *** 304,309 **** --- 304,311 ---- void a_Tab_visibility_update(BrowserWindow *bw) { + gboolean hide_tabs; + g_return_if_fail(bw != NULL); /* this gets called in the tab switching code, which in turn gets called when *************** *** 313,320 **** */ if(!GTK_IS_CONTAINER(bw->container)) return; - - gboolean hide_tabs; /* HIDE tab bar IF * - there is only one tab left AND the preference tab_bar_show_single_tab --- 315,320 ---- - and last : the patches against configure and one Makefile.in won't apply, but this can be ignored if I do another ./autogen.sh; ./configure step after patching. Now, on to finding some time to playing with it :-) ... hmmmm .... frames .... Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo

by Frank de Lange

TheStar wrote: > An "unofficial" screenshot of a tabbed dillo would be nice - perhaps a site: > "Unofficial */HaCkEd/* Screenshots"? > > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)lists.auriga.wearlab.de > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev Screenshot on the patch website (geocities, so start your ad-blockers...) http://www.geocities.com/ikbenfrank/ Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo

by TheStar

An "unofficial" screenshot of a tabbed dillo would be nice - perhaps a site: "Unofficial */HaCkEd/* Screenshots"?

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo

by Frank de Lange

Frank de Lange wrote: > Frank de Lange wrote: > >> Raphael Barabas wrote: >> >>> On Tue, Jun 17, 2003 at 12:43:30AM +0200, Frank de Lange wrote: >>> >>>> You decide. >>> >>> >>> >>> >>> i love it. it's just what i've been waiting for. >>> i know, i know. tabbing should be done by the window manager. but >>> until every window manager (or at least, my favorite) has implemented >>> tabbing, i will enjoy this patch. browsing the web is the only thing >>> where i really want tabbing anyway. >>> >>> oh, and i just noticed it segfaults when i middle-click a link. :) >> >> >> >> Hm, yeah it does. Did not used to do that. Must have messed something >> up somewhere. Well, that is why I sent the patch around of course... >> >> Will look into that when I am less sleepy... >> >> Cheers//Frank > > > I see what has gone wrong, I missed a small piece of the patch. Will > include it in a new version tomorrow... If you want to fix it by hand, > just change line 257 of html.c from: > > - a_Commands_open_link_nw_callback(NULL, lb->dd); > + a_Commands_open_link_nw_callback(NULL, lb->dd->bw); > > and it should work again. > > Sorry for the inconvenience... > > Cheers//Frank I fixed the patch on the geocities website: http://www.geocities.com/ikbenfrank/dillo-20030615-tabs.patch.gz So, anyone who got the patch in the first hour or so after release, please get it again... It missed a small, but essential part... The md5sum of the new, fixed patch is a72edfd6c6fe3fab5153df9bde760985, it is 42305 bytes. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo

by Frank de Lange

Frank de Lange wrote: > Raphael Barabas wrote: > >> On Tue, Jun 17, 2003 at 12:43:30AM +0200, Frank de Lange wrote: >> >>> You decide. >> >> >> >> i love it. it's just what i've been waiting for. >> i know, i know. tabbing should be done by the window manager. but >> until every window manager (or at least, my favorite) has implemented >> tabbing, i will enjoy this patch. browsing the web is the only thing >> where i really want tabbing anyway. >> >> oh, and i just noticed it segfaults when i middle-click a link. :) > > > Hm, yeah it does. Did not used to do that. Must have messed something up > somewhere. Well, that is why I sent the patch around of course... > > Will look into that when I am less sleepy... > > Cheers//Frank I see what has gone wrong, I missed a small piece of the patch. Will include it in a new version tomorrow... If you want to fix it by hand, just change line 257 of html.c from: - a_Commands_open_link_nw_callback(NULL, lb->dd); + a_Commands_open_link_nw_callback(NULL, lb->dd->bw); and it should work again. Sorry for the inconvenience... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo, now available on geocities

by Frank de Lange

Todd Slater wrote: > On Tue, 17 Jun 2003 02:07:20 +0200 > Frank de Lange <frank(a)unternet.org> wrote: > > >>Todd Slater wrote: > > >>>This is great, Frank! How does one apply the patch? >>>Todd >> >>First, take a chicken... >> >>Well, no, skip the chicken, get the CVS version of Dillo instead (see >>the Dillo website for how to do this). Go to the base directory >>(/usr/src/dillo-cvs/dillo or something like that), and apply the patch >>using something like zcat name_of_gzipped_patch_file|patch -p1. If >>everything went allright, you now have a patched version of Dillo. >> >>So: >> get CVS version of Dillo >> get patch >> cd /to/where/you/put/dillo >> zcat /where/you/put/dillo-20030615-tabs.patch.gz | patch -p1 >> >> ./autogen.sh (this rebuilds the auto*tools files) >> ./configure (with the usual options like --prefix=, etc) >> (if you want to DISABLE tabs, use --disable-tabs after configure) >> make >> su -c 'make uninstall && make install' >> >>But, err, you already knew that, or you would not be subscribed to a >>developers list, right? >> >>It is late, I should sleep now. >> >>Go'Natt//Frank > > > I was looking forward to the chicken! > > I thought that's what I was supposed to do; however, I get this: > > [todd@clevername dillo]$ zcat ../dillo-20030615-tabs.patch.gz | patch > -p1 > patching file ChangeLog > can't find file to patch at input line 21 > Perhaps you used the wrong -p or --strip option? > The text leading up to this was: > -------------------------- > |diff -pruN dillo/configure dillot/configure > |--- dillo/configure 2003-05-26 14:08:02.000000000 +0200 > |+++ dillot/configure 2003-06-13 19:38:12.000000000 +0200 > -------------------------- > File to patch: > > Do I need to specify the file, or is something else wrong? > > BTW, I'm in the dillo directory when I do this, not the src directory. > Correct? > > Sorry for being such a bonehead! > > Todd You need to run ./autogen.sh on the CVS version of Dillo first (this creates the configure file, and other files), or just skip this file (and the others it might complain about). I might remove the 'generated' files from the next version of the patch - which will result in people asking why they do not get the new configure options (because they forgot to run ./autogen.sh after applying the patch...) Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 17, 2003