- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] Patch to allow setting of initial position

by Eric GAUDET

It works for me with today's CVS and your patch. in dillorc: geometry=320x200+50+50 dillo.pos/src>./dillo Setting geometry from rc to 320x200 50 50 ... The only problem, it seems, is that it still prints the dillorc setting, even when the CLI option is used: dillo.pos/src>./dillo -geometry 700x100+10+400 Setting geometry from CLI to 700x100 10 400 Setting geometry from rc to 320x200 50 50 ... The first one is actually used, but having the second message is confusing. Best, EG -- En reponse de "Re: [Dillo-dev] Patch to allow setting of initial position" de Jan Dittmer, le 30-Nov-2003 : > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Jorge Arellano Cid wrote: >| >| I understand. Maybe the "canonical" solution to this problem is >| to add support for the geometry CLI option. >| >| That is: >| >| -geometry <width>x<height>{+-}<x>{+-}<y> >| >| Can you make the patch this way? >| > > Here is a preliminary version. Only problem is that entering it in the > dillorc doesn't work, because the parser doesn't recognize the + as part > of a string resulting in these errors: > > dillorc:2: unexpected character `+', expected symbol > dillorc:2: unexpected character `0', expected symbol > dillorc:2: unexpected character `+', expected symbol > dillorc:2: unexpected character `0', expected symbol > dillorc:2: error: unexpected character `0', expected symbol > > So I tried changing > > - - "~-_:&%#/.0123456789" > + "~-_:&%#/.0123456789+" > > in prefs.c, which doesn't work. How the parse be changed that it > recognizes + as part of the value? > > Thanks, > > Jan > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.2.3 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org > > iD8DBQE/ygYdLqMJRclVKIYRApfZAJ4jb1fc3Dd8OrMB+Csgyekz74VikwCfaFv5 > s7AZVApr+hS8dRtKK97kS0Y= > =axoU > -----END PGP SIGNATURE----- ------------------------------------------------------------------------ Eric GAUDET <eric(a)rti-zone.org> Le 30-Nov-2003 a 13:41:12 "Parler pour ne rien dire et ne rien dire pour parler sont les deux principes majeurs et rigoureux de tous ceux qui feraient mieux de la fermer avant de l'ouvrir." ------------------------------------------------------------------------

Nov. 30, 2003

Re: [Dillo-dev] Patch to allow setting of initial position

by Jan Dittmer

Eric GAUDET wrote: > It works for me with today's CVS and your patch. > > in dillorc: > geometry=320x200+50+50 > > dillo.pos/src>./dillo > Setting geometry from rc to 320x200 50 50 > ... > > The only problem, it seems, is that it still prints the dillorc setting, > even when the CLI option is used: > > dillo.pos/src>./dillo -geometry 700x100+10+400 > Setting geometry from CLI to 700x100 10 400 > Setting geometry from rc to 320x200 50 50 > ... > > The first one is actually used, but having the second message is confusing. Those can probably both go entirely. It was more for debug uses. Here is an updated patch with those removed. Jan Common subdirectories: org/src/IO and jan/src/IO diff -u org/src/dillo.c jan/src/dillo.c --- org/src/dillo.c Tue Jul 22 22:51:22 2003 +++ jan/src/dillo.c Sun Nov 30 22:48:24 2003 @@ -21,6 +21,7 @@ #include <stdio.h> #include <gtk/gtk.h> +#include <X11/Xlib.h> #include <sys/types.h> #include <sys/stat.h> @@ -66,6 +67,7 @@ DILLO_CLI_HELP = 1 << 3, DILLO_CLI_VERSION = 1 << 4, DILLO_CLI_LOCAL = 1 << 5, + DILLO_CLI_GEOMETRY = 1 << 6, DILLO_CLI_ERROR = 1 << 31 }; @@ -98,6 +100,9 @@ " -f, --fullwindow Start in full window mode."}, {"-l", "--local", 0, DILLO_CLI_LOCAL, " -l, --local Don't follow links for this URL(s)."}, + {"-g", "-geometry", 1, DILLO_CLI_GEOMETRY, + " -g, -geometry GEO Set initial window position where GEO is\n" + " <width>x<height>{+-}<x>{+-}<y>"}, {NULL, NULL, 0, 0, NULL} }; @@ -194,6 +199,8 @@ guint opt_flg; gint i; char **opt_argv = NULL; + gint xpos = D_GEOMETRY_DEFAULT_XPOS, ypos = D_GEOMETRY_DEFAULT_YPOS; + gint width = D_GEOMETRY_DEFAULT_WIDTH, height = D_GEOMETRY_DEFAULT_HEIGHT; /* set locale */ curr_locale = g_strdup(setlocale(LC_ALL, NULL)); @@ -226,6 +233,9 @@ case DILLO_CLI_FULLWINDOW: case DILLO_CLI_LOCAL: break; + case DILLO_CLI_GEOMETRY: + if ( XParseGeometry(opt_argv[0], &xpos, &ypos, &width, &height) ) + break; default: g_print("Error in command line options.\n"); return -1; @@ -265,9 +275,18 @@ if (options_got & DILLO_CLI_FULLWINDOW) prefs.fullwindow_start = TRUE; + /* override dillorc geometry */ + if (options_got & DILLO_CLI_GEOMETRY) { + prefs.width = width; + prefs.height = height; + prefs.xpos = xpos; + prefs.ypos = ypos; + } /* a_Nav_init() has been moved into this call because it needs to be * initialized with the new browser_window structure */ bw = a_Interface_browser_window_new(prefs.width, prefs.height, xid); + if ( (prefs.xpos != D_GEOMETRY_DEFAULT_XPOS) && (prefs.ypos != D_GEOMETRY_DEFAULT_YPOS) ) + gtk_widget_set_uposition(bw->main_window, prefs.xpos, prefs.ypos); a_Bookmarks_init(); diff -u org/src/prefs.c jan/src/prefs.c --- org/src/prefs.c Mon Jul 7 17:40:15 2003 +++ jan/src/prefs.c Sun Nov 30 22:48:36 2003 @@ -19,6 +19,8 @@ */ #include <glib.h> +#include <gtk/gtk.h> +#include <X11/Xlib.h> #include <sys/types.h> #include <sys/stat.h> #include <stdlib.h> @@ -104,14 +106,8 @@ /* assign value and exit successfully */ switch (symbol) { case DRC_TOKEN_GEOMETRY: { - gchar *ptr, *str = scanner->value.v_string; - gint width, height; - - if ( (ptr = strchr(str, 'x')) && (width = strtol(str,NULL,10)) && - (height = strtol(++ptr,NULL,10)) ){ - prefs.width = width; - prefs.height = height; - } + gchar *str = scanner->value.v_string; + XParseGeometry(str, &prefs.xpos, &prefs.ypos, &prefs.width, &prefs.height); } break; case DRC_TOKEN_PROXY: @@ -261,7 +257,7 @@ /* Specifies the chars which can be used in identifiers */ scanner->config->cset_identifier_nth = ( G_CSET_a_2_z - "~-_:&%#/.0123456789" + "~-_:&%#/.0123456789+" G_CSET_A_2_Z G_CSET_LATINS /*??? I don't know if we need these two */ G_CSET_LATINC /*??? */ @@ -329,6 +325,8 @@ prefs.width = D_GEOMETRY_DEFAULT_WIDTH; prefs.height = D_GEOMETRY_DEFAULT_HEIGHT; + prefs.xpos = D_GEOMETRY_DEFAULT_XPOS; + prefs.ypos = D_GEOMETRY_DEFAULT_YPOS; prefs.http_proxy = NULL; prefs.no_proxy = NULL; prefs.no_proxy_vec = NULL; diff -u org/src/prefs.h jan/src/prefs.h --- org/src/prefs.h Thu Jul 10 00:00:34 2003 +++ jan/src/prefs.h Sun Nov 30 15:29:57 2003 @@ -10,6 +10,8 @@ #define DILLO_HOME "http://www.dillo.org/" #define D_GEOMETRY_DEFAULT_WIDTH 640 #define D_GEOMETRY_DEFAULT_HEIGHT 550 +#define D_GEOMETRY_DEFAULT_XPOS -9999 +#define D_GEOMETRY_DEFAULT_YPOS -9999 #define DW_COLOR_DEFAULT_GREY 0xd6d6d6 #define DW_COLOR_DEFAULT_BLACK 0x000000 @@ -70,6 +72,8 @@ struct _DilloPrefs { gint width; gint height; + gint xpos; + gint ypos; DilloUrl *http_proxy; gchar *no_proxy; gchar **no_proxy_vec;

Nov. 30, 2003

Re: [Dillo-dev] How do you un-subscribe to this list

by Patrick Shanahan

* Ronald W. Henderson <rwhalb(a)nycap.rr.com> [11-30-03 12:27]: > Folks: > > I looked on this site and do not know how to un-subscribe to this list. > Thanks in advance... > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)lists.auriga.wearlab.de > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev Almost all mail-lists have subscribe/unsubscribe info in their headers, as does the one you posted: List-Unsubscribe: <http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev>, <mailto:dillo-dev-request@lists.auriga.wearlab.de?subject=unsubscribe> and the url listed at the bottom of every posting, included above. -- Patrick Shanahan Registered Linux User #207535 http://wahoo.no-ip.org @ http://counter.li.org

Nov. 30, 2003

Re: [Dillo-dev] How do you un-subscribe to this list

by Mattias Östergren

On Sun, 30 Nov 2003 11:34:20 -0500 "Ronald W. Henderson" <rwhalb(a)nycap.rr.com> wrote: > Folks: > > I looked on this site and do not know how to un-subscribe to this list. > Thanks in advance... Go to the URL in the bottom of this mail and then fill in your email address in the box at the bottom of that page.

Nov. 30, 2003

How do you un-subscribe to this list

by Ronald W. Henderson

Folks: I looked on this site and do not know how to un-subscribe to this list. Thanks in advance...

Nov. 30, 2003

Re: [Dillo-dev] Patch to allow setting of initial position

by Jan Dittmer

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jorge Arellano Cid wrote: | | I understand. Maybe the "canonical" solution to this problem is | to add support for the geometry CLI option. | | That is: | | -geometry <width>x<height>{+-}<x>{+-}<y> | | Can you make the patch this way? | Here is a preliminary version. Only problem is that entering it in the dillorc doesn't work, because the parser doesn't recognize the + as part of a string resulting in these errors: dillorc:2: unexpected character `+', expected symbol dillorc:2: unexpected character `0', expected symbol dillorc:2: unexpected character `+', expected symbol dillorc:2: unexpected character `0', expected symbol dillorc:2: error: unexpected character `0', expected symbol So I tried changing - - "~-_:&%#/.0123456789" + "~-_:&%#/.0123456789+" in prefs.c, which doesn't work. How the parse be changed that it recognizes + as part of the value? Thanks, Jan -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQE/ygYdLqMJRclVKIYRApfZAJ4jb1fc3Dd8OrMB+Csgyekz74VikwCfaFv5 s7AZVApr+hS8dRtKK97kS0Y= =axoU -----END PGP SIGNATURE----- Common subdirectories: org/src/IO and jan/src/IO diff -u org/src/dillo.c jan/src/dillo.c --- org/src/dillo.c Tue Jul 22 22:51:22 2003 +++ jan/src/dillo.c Sun Nov 30 15:59:29 2003 @@ -21,6 +21,7 @@ #include <stdio.h> #include <gtk/gtk.h> +#include <X11/Xlib.h> #include <sys/types.h> #include <sys/stat.h> @@ -66,6 +67,7 @@ DILLO_CLI_HELP = 1 << 3, DILLO_CLI_VERSION = 1 << 4, DILLO_CLI_LOCAL = 1 << 5, + DILLO_CLI_GEOMETRY = 1 << 6, DILLO_CLI_ERROR = 1 << 31 }; @@ -98,6 +100,9 @@ " -f, --fullwindow Start in full window mode."}, {"-l", "--local", 0, DILLO_CLI_LOCAL, " -l, --local Don't follow links for this URL(s)."}, + {"-g", "-geometry", 1, DILLO_CLI_GEOMETRY, + " -g, -geometry GEO Set initial window position where GEO is\n" + " <width>x<height>{+-}<x>{+-}<y>"}, {NULL, NULL, 0, 0, NULL} }; @@ -194,6 +199,8 @@ guint opt_flg; gint i; char **opt_argv = NULL; + gint xpos = D_GEOMETRY_DEFAULT_XPOS, ypos = D_GEOMETRY_DEFAULT_YPOS; + gint width = D_GEOMETRY_DEFAULT_WIDTH, height = D_GEOMETRY_DEFAULT_HEIGHT; /* set locale */ curr_locale = g_strdup(setlocale(LC_ALL, NULL)); @@ -226,6 +233,11 @@ case DILLO_CLI_FULLWINDOW: case DILLO_CLI_LOCAL: break; + case DILLO_CLI_GEOMETRY: + if ( XParseGeometry(opt_argv[0], &xpos, &ypos, &width, &height) ) { + g_print("Setting geometry from CLI to %dx%d %d %d\n", width, height, xpos, ypos); + break; + } default: g_print("Error in command line options.\n"); return -1; @@ -265,9 +277,18 @@ if (options_got & DILLO_CLI_FULLWINDOW) prefs.fullwindow_start = TRUE; + /* override dillorc geometry */ + if (options_got & DILLO_CLI_GEOMETRY) { + prefs.width = width; + prefs.height = height; + prefs.xpos = xpos; + prefs.ypos = ypos; + } /* a_Nav_init() has been moved into this call because it needs to be * initialized with the new browser_window structure */ bw = a_Interface_browser_window_new(prefs.width, prefs.height, xid); + if ( (prefs.xpos != D_GEOMETRY_DEFAULT_XPOS) && (prefs.ypos != D_GEOMETRY_DEFAULT_YPOS) ) + gtk_widget_set_uposition(bw->main_window, prefs.xpos, prefs.ypos); a_Bookmarks_init(); diff -u org/src/prefs.c jan/src/prefs.c --- org/src/prefs.c Mon Jul 7 17:40:15 2003 +++ jan/src/prefs.c Sun Nov 30 16:00:14 2003 @@ -19,6 +19,8 @@ */ #include <glib.h> +#include <gtk/gtk.h> +#include <X11/Xlib.h> #include <sys/types.h> #include <sys/stat.h> #include <stdlib.h> @@ -104,14 +106,9 @@ /* assign value and exit successfully */ switch (symbol) { case DRC_TOKEN_GEOMETRY: { - gchar *ptr, *str = scanner->value.v_string; - gint width, height; - - if ( (ptr = strchr(str, 'x')) && (width = strtol(str,NULL,10)) && - (height = strtol(++ptr,NULL,10)) ){ - prefs.width = width; - prefs.height = height; - } + gchar *str = scanner->value.v_string; + XParseGeometry(str, &prefs.xpos, &prefs.ypos, &prefs.width, &prefs.height); + g_print("Setting geometry from rc to %dx%d %d %d\n", prefs.width, prefs.height, prefs.xpos, prefs.ypos); } break; case DRC_TOKEN_PROXY: @@ -261,7 +258,7 @@ /* Specifies the chars which can be used in identifiers */ scanner->config->cset_identifier_nth = ( G_CSET_a_2_z - "~-_:&%#/.0123456789" + "~-_:&%#/.0123456789+" G_CSET_A_2_Z G_CSET_LATINS /*??? I don't know if we need these two */ G_CSET_LATINC /*??? */ @@ -329,6 +326,8 @@ prefs.width = D_GEOMETRY_DEFAULT_WIDTH; prefs.height = D_GEOMETRY_DEFAULT_HEIGHT; + prefs.xpos = D_GEOMETRY_DEFAULT_XPOS; + prefs.ypos = D_GEOMETRY_DEFAULT_YPOS; prefs.http_proxy = NULL; prefs.no_proxy = NULL; prefs.no_proxy_vec = NULL; diff -u org/src/prefs.h jan/src/prefs.h --- org/src/prefs.h Thu Jul 10 00:00:34 2003 +++ jan/src/prefs.h Sun Nov 30 15:29:57 2003 @@ -10,6 +10,8 @@ #define DILLO_HOME "http://www.dillo.org/" #define D_GEOMETRY_DEFAULT_WIDTH 640 #define D_GEOMETRY_DEFAULT_HEIGHT 550 +#define D_GEOMETRY_DEFAULT_XPOS -9999 +#define D_GEOMETRY_DEFAULT_YPOS -9999 #define DW_COLOR_DEFAULT_GREY 0xd6d6d6 #define DW_COLOR_DEFAULT_BLACK 0x000000 @@ -70,6 +72,8 @@ struct _DilloPrefs { gint width; gint height; + gint xpos; + gint ypos; DilloUrl *http_proxy; gchar *no_proxy; gchar **no_proxy_vec;

Nov. 30, 2003

Re: [Dillo-dev] Re: about feedback

by Maurice McCarthy

Indan I actually thought you were a developer! Just to add to what others have said, your efforts are certainly appreciated in this quarter. As a complete numpty in programming little things like your install script are a joy to me. Look, copy and learn. Still have not managed to install Frank's tabs patch yet but I've by no means exhausted all I can do yet, so I'm not prepared to ask for help but want to plug away at it. I'll try to get your https patch in too. I suppose email suffers from what it fails to communicate, the nod of appreciation, the look of admiration, saying please and thank you etc. Well, thank you. Maurice

Nov. 29, 2003

Re: [Dillo-dev] Patch to allow setting of initial position

by Jorge Arellano Cid

On Fri, 28 Nov 2003, Jan Dittmer wrote: > Hi, > > for a TV Terminal I needed dillo to come up at a different position than > 0,0. As there is no window manager running I wrote a small patch which > allows to set the initial position of the upper left corner. Essentially > it just clones the geometry code and adds a config option > position=<xpos>x<ypos>. If it is not set or 0x0 specified it just takes > it's default position. > Perhaps this is of some use to anyone else. (Patch is against 0.7.3) I understand. Maybe the "canonical" solution to this problem is to add support for the geometry CLI option. That is: -geometry <width>x<height>{+-}<x>{+-}<y> Can you make the patch this way? Cheers Jorge.-

Nov. 29, 2003

Patch to allow setting of initial position

by Jan Dittmer

Hi, for a TV Terminal I needed dillo to come up at a different position than 0,0. As there is no window manager running I wrote a small patch which allows to set the initial position of the upper left corner. Essentially it just clones the geometry code and adds a config option position=<xpos>x<ypos>. If it is not set or 0x0 specified it just takes it's default position. Perhaps this is of some use to anyone else. (Patch is against 0.7.3) Thanks, Jan diff -u org/src/dillo.c jan/src/dillo.c --- org/src/dillo.c Tue Jul 22 22:51:22 2003 +++ jan/src/dillo.c Fri Nov 28 14:34:35 2003 @@ -268,6 +268,8 @@ /* a_Nav_init() has been moved into this call because it needs to be * initialized with the new browser_window structure */ bw = a_Interface_browser_window_new(prefs.width, prefs.height, xid); + if ((prefs.xpos + prefs.ypos) > 0) + gtk_widget_set_uposition(bw->main_window, prefs.xpos, prefs.ypos); a_Bookmarks_init(); diff -u org/src/prefs.c jan/src/prefs.c --- org/src/prefs.c Mon Jul 7 17:40:15 2003 +++ jan/src/prefs.c Fri Nov 28 14:39:21 2003 @@ -35,6 +35,7 @@ guint token; } symbols[] = { { "geometry", DRC_TOKEN_GEOMETRY }, + { "position", DRC_TOKEN_POSITION }, { "http_proxy", DRC_TOKEN_PROXY }, { "no_proxy", DRC_TOKEN_NOPROXY }, { "link_color", DRC_TOKEN_LINK_COLOR }, @@ -114,6 +115,18 @@ } } break; + case DRC_TOKEN_POSITION: { + gchar *ptr, *str = scanner->value.v_string; + gint xpos, ypos; + + if ( (ptr = strchr(str, 'x')) && (xpos = strtol(str,NULL,10)) && + (ypos = strtol(++ptr,NULL,10)) ){ + prefs.xpos = xpos; + prefs.ypos = ypos; + } + } + break; + case DRC_TOKEN_PROXY: a_Url_free(prefs.http_proxy); prefs.http_proxy = a_Url_new(scanner->value.v_string, NULL, 0, 0); @@ -329,6 +342,8 @@ prefs.width = D_GEOMETRY_DEFAULT_WIDTH; prefs.height = D_GEOMETRY_DEFAULT_HEIGHT; + prefs.xpos = D_GEOMETRY_DEFAULT_XPOS; + prefs.ypos = D_GEOMETRY_DEFAULT_YPOS; prefs.http_proxy = NULL; prefs.no_proxy = NULL; prefs.no_proxy_vec = NULL; diff -u org/src/prefs.h jan/src/prefs.h --- org/src/prefs.h Thu Jul 10 00:00:34 2003 +++ jan/src/prefs.h Fri Nov 28 14:37:17 2003 @@ -10,6 +10,8 @@ #define DILLO_HOME "http://www.dillo.org/" #define D_GEOMETRY_DEFAULT_WIDTH 640 #define D_GEOMETRY_DEFAULT_HEIGHT 550 +#define D_GEOMETRY_DEFAULT_XPOS 0 +#define D_GEOMETRY_DEFAULT_YPOS 0 #define DW_COLOR_DEFAULT_GREY 0xd6d6d6 #define DW_COLOR_DEFAULT_BLACK 0x000000 @@ -27,6 +29,7 @@ typedef enum { DRC_TOKEN_FIRST = G_TOKEN_LAST, DRC_TOKEN_GEOMETRY, + DRC_TOKEN_POSITION, DRC_TOKEN_PROXY, DRC_TOKEN_NOPROXY, DRC_TOKEN_LINK_COLOR, @@ -70,6 +73,8 @@ struct _DilloPrefs { gint width; gint height; + gint xpos; + gint ypos; DilloUrl *http_proxy; gchar *no_proxy; gchar **no_proxy_vec;

Nov. 28, 2003

Re: about feedback

by Indan Zupancic

Hi, To clear up some things to avoid misunderstandings: I will continue keeping the https patch up to date, no matter what else I'll do. As there seems to be enough demand, I will update the installer once a while too. > Sometimes, it took quite some time before Jorge looked at the patches and > fixed or accepted (or rejected) them. I had zero feedback the last 3 weeks, not very motivating. Merely a short email to say that it will be looked at or that it has no priority would be appreciated, I mean, _any_ feedback is. Now it's just a black hole where you pour patches into. Don't forget that it's their program you spend time writing a patch for, but currently it feels like it's a privilege to have your patch integreted in Dillo, even expecting some feedback is asked too much for. May I come to the conclusion that I should spend my time on something else instead of wasting it on Dillo? If they aren't willing to spend 10 minutes writing a short email, why should I spend hours or even days writing and testing some Dillo patch? I don't expect the Dillo developers to just integrate my https patch or so, I wouldn't either without a lot testing and making sure it's stable, but I would expect that they give some feedback about it, I mean, it's their program, they wrote it, so I would expect that they know the code better, so could give good advice about pitfals etc. Or just simply say "no, we don't like your approach, let us keep using wget for https". But for the IO.c patch it's a different case, all it is is a cleanup of their code, naive as I am, I would expected them to want cleaner code, even if it's a small step like I made with the patch. > Anyways, that's how it works here. I got used to it. Working with one feedback per month is impossible if you want to do major IO cleanups as I want. > However, the core developers probably need to read all mails and keep track > with a whole lot more patches - therefore, even they may miss one or two > patches/suggestions. Whole lot more patches? Looking at the CVS activity then I'm not too sure. Also there is a reasonable amount of old patches for Dillo already: multiple https implementations (I only found the last one when I started on mine), UTF8 support, server/client mode, and other I can't remember/didn't found. And looking at the mailing list, they didn't get much feedback either. All those people hooked off as far as I can tell, except Frank. > So, please stay with the project ... hmmm ... some semi-serious > suggestion ;-) : do some christmas shopping, enjoy the holidays > and wait for the feedback from the developers ...:-) Christmas shopping? Need money for that I suppose. Enjoy the holidays? Have no job, so it's always holiday for me ;-). And don't know where you live, but christmas is just a commercial paradise here. > However, overall, I like the dpi idea. There are certain advantages: As with many things, the idea is good, the implementating isn't, IMHO. > - For me, it makes it rather easy to contribute, since I need to only > write a program and not to dig through dillo's code (if only I did > write more than my simplistic finger plugin ;-) ...) True, but if I look at the default plugins they're not as easy to make as it should be. > - The concept of extra processes instead of extra code has advantages : > - with the download plugin being a seperate process you can even log > out of X while the download continues (e.g. over night on dial-up). That is true. I don't know if you noticed, but if you want to use the current download plugin, you need to start up 3 processes... First, the dpid, then the download dpi, which in turn starts wget. I'm so naive to think it could be only wget, with a simple "handle this protocol with this program with this parameters in this way" system. This way you could also startup your favourite email program when encountering mailto:, to give just one example. Don't forget that there is specific code in Dillo to handle certain plugins like the bookmark and download plugins. The plugins aren't really standalone. Sure, it's not finished yet, but the current dpi system can't solve that problem. What I would do is make a clear library plugin api, then you can implement the download and bookmark GUI in a library, and let the library start up wget. You can even implement a library plugin that handels the dpi plugins, instead of adding the code to Dillo's core as now happened (I mean moving the dpi code into a library plugin). This way you can have relative simple and small library plugins that don't do much, which let external programs like wget do the real work. Or add the features directly in the library plugin, whatever you want. > - the bookmark plugin allows for a real bookark server ! This is something > I am contemplating about : wouldn't it be cool if you could access the > same bookamrks from different machines via a sophisticated bookmark server > ? No, it doesn't. Not with the current dpi system anyway. As I said in an earlier email, the bookmark plugin should probably be a real, standalone daemon, so that it can also be used with other browser, from different pc's. It can even be hosted by some site, so that wherever you go, you can get your bookmarks :). Of course Dillo could have special support for it, so that it's easier to add bookmarks, and that it's started when it isn't running yet, but the main point is that the bookmark server won't be a dpi plugin, or can't be because you can't use unix sockets as the current dpi system uses now (which is fine for a plugin system, but not when you want to connect to non-local pc's). Greetings, Indan

Nov. 28, 2003