- Dillo-dev - lists.mailman3.com

New design of tag nesting cleanup within the parser.

by johannes.hofmann＠gmx.de

Hi Jorge, it seems to fix too narrow forum posts on http://forum.xda-developers.com/ - very nice! Cheers, Johannes On Tue, Jun 21, 2016 at 06:18:58PM -0400, Jorge Arellano Cid wrote: > Hi there, > > This is an important patchset that's just been committed. > There're plenty of details in the hg comments (hg log -v). > > This are changes that affect the way dillo copes with Tag Soup > (i.e. bad formed HTML). The idea is to create a valid doc tree > before passing it to Dw for rendering, so yes, rendering may change. > > Please check the comments, then browse your regular sites and give it > a test drive, then send some feedback. > > At least in my case there were nice surprises! > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev at dillo.org > http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev

June 23, 2016

New design of tag nesting cleanup within the parser.

by jcid＠dillo.org

On Wed, Jun 22, 2016 at 11:15:36PM +0000, eocene wrote: > Jorge wrote: > > I just don't want the bug meter to sound harsh or pedantic. > > > > This phrase sounds well to me: (*advice*) > > > > " has to be closed before </td>" // *advice* > > > > instead of: > > > > " must be closed before </td>" // *reproach* > > > > > > If that's the correct interpretation of meaning, I'd prefer to > > use the "has to be closed" expression. > > Yet another possibility is: "needs to be closed". It also sounds OK to me. Which one is better? -- Cheers Jorge.-

June 23, 2016

New design of tag nesting cleanup within the parser.

by jcid＠dillo.org

On Wed, Jun 22, 2016 at 03:30:30PM -0400, Jorge Arellano Cid wrote: > On Wed, Jun 22, 2016 at 02:18:00PM +0000, eocene wrote: > > Jorge wrote: > > > Please check the comments, then browse your regular sites and give it > > > a test drive, then send some feedback. > > > > The links to articles on arstechnica.com aren't working for me today. > > The bug meter has lots of "<a> can't contain <figure>". > > Yes, this is the new HTML5's "transparent" mode. > > A is a transparent container, which is not yet handled by dillo. > > Let me think it a bit... OK, we don't yet have HTML5 handling in dillo (besides ad-hoc), but this new design is simpler to tailor to a new set of rules, so that's the way to go. Although it'll take some time, incremental patches will give a better HTML5 experience step by step. Just as a quick and dirty patch so arstecnica, BBC and others may be read before I come with something more structured, you may try: diff -r ca794cd4c182 src/html.cc --- a/src/html.cc Tue Jun 21 18:04:00 2016 -0400 +++ b/src/html.cc Wed Jun 22 19:30:15 2016 -0400 @@ -3735,6 +3735,8 @@ static void Html_stack_cleanup_at_open(D continue; // close } else if (!(Tags[ni].Flags & 1) && !(Tags[ti].Flags & 4)) { // Block element over a NON block container + if (ti == i_A && html->DocTypeVersion >= 5.0f) + break; continue; // close } HTH. -- Cheers Jorge.-

June 22, 2016

New design of tag nesting cleanup within the parser.

by eocene＠gmx.com

Jorge wrote: > I just don't want the bug meter to sound harsh or pedantic. > > This phrase sounds well to me: (*advice*) > > " has to be closed before </td>" // *advice* > > instead of: > > " must be closed before </td>" // *reproach* > > > If that's the correct interpretation of meaning, I'd prefer to > use the "has to be closed" expression. Yet another possibility is: "needs to be closed".

June 22, 2016

New design of tag nesting cleanup within the parser.

by jcid＠dillo.org

On Wed, Jun 22, 2016 at 08:46:28PM +0000, eocene wrote: > Jorge wrote: > > Yes, "must be closed" is the intended meaning. > > > > Is there a way to have the _same_ message in a softer tone? > > Umm...in ordinary spoken English, we'd be more likely to say > "has to be closed", but I might be missing what you're getting at. I like it! I just don't want the bug meter to sound harsh or pedantic. This phrase sounds well to me: (*advice*) " has to be closed before </td>" // *advice* instead of: " must be closed before </td>" // *reproach* If that's the correct interpretation of meaning, I'd prefer to use the "has to be closed" expression. -- Cheers Jorge.-

June 22, 2016

valgrind errors

by eocene＠gmx.com

I wrote: > Was just having a look at the valgrind errors, and I think the > main one is in textblock.cc: > > int leftBorder = boxOffsetX () + leftInnerPadding > + (lines->size () == 0 ? line1OffsetEff : 0); > > leftBorder being set to line1OffsetEff when line1OffsetEff > has not been initialized. I should have said 'making use of the value of line1OffsetEff'. I wasn't paying any attention to the specifics of the calculation because textblock has changed a lot since I worked on it...

June 22, 2016

valgrind errors

by eocene＠gmx.com

Another one is containerAllocationState not getting initialized in OOFPositionedMgr.

June 22, 2016

valgrind errors

by eocene＠gmx.com

Was just having a look at the valgrind errors, and I think the main one is in textblock.cc: int leftBorder = boxOffsetX () + leftInnerPadding + (lines->size () == 0 ? line1OffsetEff : 0); leftBorder being set to line1OffsetEff when line1OffsetEff has not been initialized.

June 22, 2016

New design of tag nesting cleanup within the parser.

by eocene＠gmx.com

Jorge wrote: > Yes, "must be closed" is the intended meaning. > > Is there a way to have the _same_ message in a softer tone? Umm...in ordinary spoken English, we'd be more likely to say "has to be closed", but I might be missing what you're getting at.

June 22, 2016

New design of tag nesting cleanup within the parser.

by jcid＠dillo.org

Hi, On Wed, Jun 22, 2016 at 05:18:12PM +0000, eocene wrote: > Jorge wrote: > > Please check the comments, then browse your regular sites and give it > > a test drive, then send some feedback. Oh, I meant the comments in hg! :-) Anyway checking the bug meter's messages doesn't hurt. > A fltk.org page gave the warning > "... must have been closed before </td>..." > and it wasn't clear what that meant. > > The src has > <td>some text</td> > > and in that case " must be closed before </td>" sounds right > to me. Oh, I didn't know until now that the phrase "must have been" can have two meanings in english. Yes, "must be closed" is the intended meaning. Is there a way to have the _same_ message in a softer tone? -- Cheers Jorge.-

June 22, 2016