- Dillo-dev - lists.mailman3.com

[PATCH]: Table::apportionRowSpan()

by jcid＠dillo.org

On Fri, Feb 01, 2008 at 06:10:39AM +0000, Jeremy Henty wrote: > > OK, please ignore my previous attempt at reworking Dillo's ROWSPAN > handling. I have a simple fix for the bugs I reported at > http://starurchin.singularity/dillo/bugs/table_rowspan.html . This > patch tweaks dw::Table::apportionRowSpan() to handle the special case > where all the rows being spanned have zero height. This fixes the > special cases that were breaking without changing the behaviour in any > other case. Committed. > (BTW, I still think there is a case for reworking Dillo's ROWSPAN > algorithms along the lines I suggested, but it's nice to fix bugs > without such efforts.) If you want to go further, please keep in the O(n) realm. -- Cheers Jorge.-

Feb. 1, 2008

a couple of patches: referer and image_off

by jcid＠dillo.org

On Fri, Feb 01, 2008 at 12:39:41AM +0000, place wrote: > Jorge wrote: > > >From the updated dillorc2: > > > > # Set the HTTP Referer information (WARNING: affects privacy) > > * # We use the same URI, not the refering page (to avoid cross-site tracking). > > # none : No referer at all (full privacy). > > # host : Default value. Send same URI's hostname (no sensible info is sent). > > # path : same URI is sent (NO PRIVACY). > > http_referer=host > > What do you mean by "NO PRIVACY"? I meant that if we send the referring page's path, there would be no privacy. Later I changed the referer approach by using the same URI, which worked surprisingly well on tests, and this new approach obsoleted the comments. Note that "path" is not sending the same URI, it strips the query and fragment parts. In brief, using the same URI, the three options offer good privacy (because no new information is sent), and if we ever enable using the referring page, the old comments apply. i.e. Using Same URI: # none : No referer at all (nothing is sent) # host : Default value. Send same URI's hostname (no new info is sent). # path : same URI is sent (no new info is sent). Using referring page (not implemented): # none : No referer at all (nothing is sent) # host : Default value. Send URI's hostname (referring hostname is known). # path : referring URI is sent (NO PRIVACY, fine grained tracking # of the pages/sites you visit). Using referring page only if hostname matches (not implemented): # none : No referer at all (nothing is sent) # host : Default value. Send URI's hostname (no new info is sent). # path : referring URI is sent (NO PRIVACY, fine-grained per-site # tracking of the pages you visit). I'll fix the comments (of implemented part) upon finishing this thread. Thanks for the question. -- Cheers Jorge.-

Feb. 1, 2008

patch: [Dillo-dev] a couple of patches: referer and image_off

by jcid＠dillo.org

On Fri, Feb 01, 2008 at 01:50:35AM +0000, place wrote: > linebreaks... Ooops!, committed. -- Cheers Jorge.-

Feb. 1, 2008

[PATCH]: Table::apportionRowSpan()

by onepoint＠starurchin.org

OK, please ignore my previous attempt at reworking Dillo's ROWSPAN handling. I have a simple fix for the bugs I reported at http://starurchin.singularity/dillo/bugs/table_rowspan.html . This patch tweaks dw::Table::apportionRowSpan() to handle the special case where all the rows being spanned have zero height. This fixes the special cases that were breaking without changing the behaviour in any other case. (BTW, I still think there is a case for reworking Dillo's ROWSPAN algorithms along the lines I suggested, but it's nice to fix bugs without such efforts.) Regards, Jeremy Henty

Feb. 1, 2008

patch: [Dillo-dev] a couple of patches: referer and image_off

by place＠gobigwest.com

linebreaks... diff -pur dillo2/src/IO/http.c dillo2-cur/src/IO/http.c --- dillo2/src/IO/http.c 2008-01-31 23:55:04.000000000 +0000 +++ dillo2-cur/src/IO/http.c 2008-02-01 01:40:08.000000000 +0000 @@ -158,11 +158,11 @@ static char *Http_get_referer(const Dill if (!strcmp(prefs.http_referer, "host")) { referer = dStrconcat("Referer: ", URL_SCHEME(url), "://", - URL_AUTHORITY(url), "/", NULL); + URL_AUTHORITY(url), "/\r\n", NULL); } else if (!strcmp(prefs.http_referer, "path")) { referer = dStrconcat("Referer: ", URL_SCHEME(url), "://", URL_AUTHORITY(url), - URL_PATH_(url) ? URL_PATH(url) : "/", NULL); + URL_PATH_(url) ? URL_PATH(url) : "/", "\r\n", NULL); } if (!referer) referer = strdup("");

Feb. 1, 2008

a couple of patches: referer and image_off

by place＠gobigwest.com

Jorge wrote: > >From the updated dillorc2: > > # Set the HTTP Referer information (WARNING: affects privacy) > * # We use the same URI, not the refering page (to avoid cross-site tracking). > # none : No referer at all (full privacy). > # host : Default value. Send same URI's hostname (no sensible info is sent). > # path : same URI is sent (NO PRIVACY). > http_referer=host What do you mean by "NO PRIVACY"?

Feb. 1, 2008

Various minor patches

by jcid＠dillo.org

On Thu, Jan 31, 2008 at 03:35:56PM +0100, Christian Kellermann wrote: > * Jorge Arellano Cid <jcid(a)dillo.org> [080131 13:25]: > > > > Before this patch, we had no test for iconv. Did it work for you then? > > > In a way yes. because my solution was to add -liconv to my LDFLAGS. > > > > Did the new test in configure.in work? > Nope it did not. > > > You wrote: > > > In a way yes. because my solution was to add -liconv to my LDFLAGS. > > and > > > This breaks configure for me (OpenBSD/386 -stable). seems the > > > test does not use the LDFLAGS=-L/usr/local/lib... My knowledge > > > (and motivation) to fiddle with this autoconf hell is limited, > > > so I'd kindly hand the ball over to someone else. > > > > I assume you set LDFLAGS=-L/usr/local/lib... > > > > but this is expected to be done by the test at configure.in:96. > > The test can fail though! Would you mind posting the output of: > > > > cpp -v > > > > in your system. > > $ cpp -v > Reading specs from /usr/libexec/../lib/gcc-lib/i386-unknown-openbsd4.2/3.3.5/specs > Configured with: > Thread model: single > gcc version 3.3.5 (propolice) > /usr/libexec/../lib/gcc-lib/i386-unknown-openbsd4.2/3.3.5/cc1 -E -traditional-cpp -quiet -nostdinc -v -I/usr/include -iprefix /usr/libexec/../lib/gcc-lib/i386-unknown-openbsd4.2/3.3.5/ -D__GNUC__ - > #include "..." search starts here: > #include <...> search starts here: > /usr/include > End of search list. > > Hope this helps, OK, then configure.in:96 should be adding /usr/local/lib to LDFLAGS. If I understood correctly, the missing part is "-liconv" in LIBS. The CVS has new code for this. Please test, tweak and report back. Making a blind patch with auto*tools is not easy. -- Cheers Jorge.-

Feb. 1, 2008

a couple of patches: referer and image_off

by jcid＠dillo.org

Hi there, - Added a text placeholder: "[IMG]" for img_off mode. - Added a http_referer preference. See details in dillorc2. This couple plays well together. When in img_off mode, non loaded images will show "[IMG]" (or original alt text), and the partial referer helps with getting images from sites that don't allow external sources. >From the updated dillorc2: # Set the HTTP Referer information (WARNING: affects privacy) * # We use the same URI, not the refering page (to avoid cross-site tracking). # none : No referer at all (full privacy). # host : Default value. Send same URI's hostname (no sensible info is sent). # path : same URI is sent (NO PRIVACY). http_referer=host Note: please read the "*"-marked line twice. ;) -- Cheers Jorge.-

Feb. 1, 2008

[PATCH]: improved ROWSPAN handling

by onepoint＠starurchin.org

> Here's a page demonstrating some problems Dillo has when all the cells > in a table have ROWSPAN > 1 . > > http://starurchin.org/dillo/bugs/table_rowspan.html Actually, on second thoughts I'm not so happy with this patch. It resolves all the slack in the row boundaries by pushing them up as far as possible. Let me see if I can get it to spread things out better. Jeremy Henty

Jan. 31, 2008

Various minor patches

by Christian.Kellermann＠nefkom.net

* Jorge Arellano Cid <jcid(a)dillo.org> [080131 13:25]: > > > Before this patch, we had no test for iconv. Did it work for you then? > > In a way yes. because my solution was to add -liconv to my LDFLAGS. > > Did the new test in configure.in work? Nope it did not. > You wrote: > > In a way yes. because my solution was to add -liconv to my LDFLAGS. > and > > This breaks configure for me (OpenBSD/386 -stable). seems the > > test does not use the LDFLAGS=-L/usr/local/lib... My knowledge > > (and motivation) to fiddle with this autoconf hell is limited, > > so I'd kindly hand the ball over to someone else. > > I assume you set LDFLAGS=-L/usr/local/lib... > > but this is expected to be done by the test at configure.in:96. > The test can fail though! Would you mind posting the output of: > > cpp -v > > in your system. $ cpp -v Reading specs from /usr/libexec/../lib/gcc-lib/i386-unknown-openbsd4.2/3.3.5/specs Configured with: Thread model: single gcc version 3.3.5 (propolice) /usr/libexec/../lib/gcc-lib/i386-unknown-openbsd4.2/3.3.5/cc1 -E -traditional-cpp -quiet -nostdinc -v -I/usr/include -iprefix /usr/libexec/../lib/gcc-lib/i386-unknown-openbsd4.2/3.3.5/ -D__GNUC__ - #include "..." search starts here: #include <...> search starts here: /usr/include End of search list. Hope this helps, Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)

Jan. 31, 2008