- Dillo-dev - lists.mailman3.com

[patch] reduce malloc/free use a bit

by jcid＠dillo.org

On Wed, Mar 12, 2008 at 09:26:52PM +0100, Johannes Hofmann wrote: > Hi, > > the patch below reduces the use of malloc/free a bit. For loading > http://www.w3.org/TR/xslt for example it reduces the number of calls > to dMalloc() from 76735 to 50478 (according to gprof). > > I have removed the SPCBuf member of html, as it seems not to be > used. Please correct me if I'm wrong or it is intended to be used > for in the future. Committed. It may remain from the old way of handling whitespace... -- Cheers Jorge.-

March 13, 2008

Re: patch: reorder headers in query string

by jcid＠dillo.org

On Wed, Mar 12, 2008 at 07:49:46PM +0000, place wrote: > Jorge wrote: > > On Wed, Mar 12, 2008 at 03:51:24PM +0000, place wrote: > > > My idea of what seems like a good ordering, for what that's worth :) > > > When I watch the headers, I always wonder why I didn't put Accept-Encoding > > > next to Accept-Charset, for one thing... > > > > AFAIR headers are ordered as they appear in the RFC. > > I'm not sure whether this is relevant, please check. > > Oh! Let's see. The RFC says: > > The order in which header fields with differing field names are > received is not significant. However, it is "good practice" to send > general-header fields first, followed by request-header or response- > header fields, and ending with the entity-header fields. > > Following that, placing them in order of appearance, yields: > > POST > > Connection > > Accept-Charset > Accept-Encoding > Host > Proxy-Authorization > Referer > User-Agent > > Content-Length > Content-Type > > Cookie > > GET > > Cache-Control > Connection > Pragma > > Accept-Charset > Accept-Encoding > Host > Proxy-Authorization > Referer > User-Agent > > Cookie > > Which is pretty close to what dillo has already if you don't count the headers > that I have added, since I never realized there was any ordering. Thanks for the info. I'd be good to keep the suggested ordering then. -- Cheers Jorge.-

March 13, 2008

patch: meta charset changes decoder

by jcid＠dillo.org

Hi, On Fri, Mar 07, 2008 at 06:17:17AM +0000, place wrote: > This is no sort of proper fix whatsoever, but I was tired > of seeing the "would set charset" message. It's actually > surprisingly useful for remote files, since they're generally > still at the javascript-and-css point at the end of the first packet. In CVS there is a new approach that restarts parsing the whole page. It works with local/remote files, and page title. Please test it. -- Cheers Jorge.-

March 13, 2008

Re: patch: reorder headers in query string

by kelson＠pobox.com

place wrote: > - There's some kind of blog thing that knows which browsers send an Accept > header. If I pretend to use one of them, I get a meaningless error page. > This is good because it saves me from wasting time looking at blogs. Probably this: http://www.bad-behavior.ioerror.us/ It's a filter written in PHP to block spambots and harvesters that pretend to be well-known user-agents. If a user-agent always sends certain headers, then a request that claims to be that UA but lacks those headers can be treated with suspicion. If a UA claims to be Opera, Gecko, Safari, IE, etc., it will check for an Accept header. One check that I find interesting is looking for invalid Windows versions. IE will always list the internal Windows version, like "Windows NT 5.1", but people programming bots will often forget this and tell it to use "Windows XP" instead. It also checks for bots that claim to be well-known search spiders. Some bots will pretend to be Googlebot, for instance, but won't come from a Google-owned IP address. Occasionally it does run into problems with personal firewalls that strip out headers. -- Kelson Vibber www.hyperborea.org

March 13, 2008

[patch] reduce malloc/free use a bit

by Johannes.Hofmann＠gmx.de

Hi, the patch below reduces the use of malloc/free a bit. For loading http://www.w3.org/TR/xslt for example it reduces the number of calls to dMalloc() from 76735 to 50478 (according to gprof). I have removed the SPCBuf member of html, as it seems not to be used. Please correct me if I'm wrong or it is intended to be used for in the future. Cheers, Johannes diff --git a/src/html.cc b/src/html.cc --- a/src/html.cc +++ b/src/html.cc @@ -295,8 +295,6 @@ public: //BUG: for now everything is pu Dstr *Stash; bool_t StashSpace; - - char *SPCBuf; /* Buffer for white space */ int pre_column; /* current column, used in PRE tags with tabs */ bool_t PreFirstChar; /* used to skip the first CR or CRLF in PRE tags */ @@ -823,8 +821,6 @@ DilloHtml::DilloHtml(BrowserWindow *p_bw Stash = dStr_new(""); StashSpace = FALSE; - SPCBuf = NULL; - pre_column = 0; PreFirstChar = FALSE; PrevWasCR = FALSE; @@ -1011,7 +1007,6 @@ void DilloHtml::closeParser(int ClientKe delete (stack); dStr_free(Stash, TRUE); - dFree(SPCBuf); dStr_free(attr_data, TRUE); /* Fit the UTF-8 buffer */ @@ -1430,9 +1425,7 @@ static void Html_process_space(DilloHtml html->SPCPending = FALSE; } else if (parse_mode == DILLO_HTML_PARSE_MODE_VERBATIM) { - char *Pword = dStrndup(space, spacesize); - dStr_append(html->Stash, Pword); - dFree(Pword); + dStr_append_l(html->Stash, space, spacesize); html->SPCPending = FALSE; } else if (parse_mode == DILLO_HTML_PARSE_MODE_PRE) { @@ -1475,8 +1468,6 @@ static void Html_process_space(DilloHtml /* SGML_SPCDEL ignores white space inmediately after an open tag */ html->SPCPending = FALSE; } else { - dFree(html->SPCBuf); - html->SPCBuf = dStrndup(space, spacesize); html->SPCPending = TRUE; } @@ -1510,9 +1501,7 @@ static void Html_process_word(DilloHtml } else if (parse_mode == DILLO_HTML_PARSE_MODE_VERBATIM) { /* word goes in untouched, it is not processed here. */ - Pword = dStrndup(word, size); - dStr_append(html->Stash, Pword); - dFree(Pword); + dStr_append_l(html->Stash, word, size); } if (parse_mode == DILLO_HTML_PARSE_MODE_STASH ||

March 12, 2008

Re: patch: reorder headers in query string

by place＠gobigwest.com

Jorge wrote: > On Wed, Mar 12, 2008 at 03:51:24PM +0000, place wrote: > > My idea of what seems like a good ordering, for what that's worth :) > > When I watch the headers, I always wonder why I didn't put Accept-Encoding > > next to Accept-Charset, for one thing... > > AFAIR headers are ordered as they appear in the RFC. > I'm not sure whether this is relevant, please check. Oh! Let's see. The RFC says: The order in which header fields with differing field names are received is not significant. However, it is "good practice" to send general-header fields first, followed by request-header or response- header fields, and ending with the entity-header fields. Following that, placing them in order of appearance, yields: POST Connection Accept-Charset Accept-Encoding Host Proxy-Authorization Referer User-Agent Content-Length Content-Type Cookie GET Cache-Control Connection Pragma Accept-Charset Accept-Encoding Host Proxy-Authorization Referer User-Agent Cookie Which is pretty close to what dillo has already if you don't count the headers that I have added, since I never realized there was any ordering.

March 12, 2008

Re: patch: rm ^F shortcut from menu.cc

by jcid＠dillo.org

Committed. -- Cheers Jorge.-

March 12, 2008

Re: patch: reorder headers in query string

by place＠gobigwest.com

Jorge wrote: > On Wed, Mar 12, 2008 at 03:51:24PM +0000, place wrote: > > [...] > > BTW, I sent a User-Agent patch long ago and never heard anything. > > I could send another... > > I seem to remember that you finally didn't think of it as > a very helpful idea, but don't find any email saying so... It's useful on the whole, but a user does have to keep it in mind when things start to act differently. - If I pretend to use Firefox, google will finally use UTF-8 like the headers specify -- but I have to type in "&start=n" a lot. That's frustrating that they don't like to listen to Accept-Charset. - I think more sites listen to Accept-Encoding when I pretend to use a big browser. - It's hard to feel any degree of anonymity on the web when there are... how many dillo users? Not a lot. - There's some kind of blog thing that knows which browsers send an Accept header. If I pretend to use one of them, I get a meaningless error page. This is good because it saves me from wasting time looking at blogs. Hmm. Maybe I'm talking myself out of having it in the real dillo for general use -- and maybe that's what happened last time, too.

March 12, 2008

Re: patch: reorder headers in query string

by jcid＠dillo.org

On Wed, Mar 12, 2008 at 03:51:24PM +0000, place wrote: > [...] > BTW, I sent a User-Agent patch long ago and never heard anything. > I could send another... I seem to remember that you finally didn't think of it as a very helpful idea, but don't find any email saying so... -- Cheers Jorge.-

March 12, 2008

Re: patch: reorder headers in query string

by jcid＠dillo.org

On Wed, Mar 12, 2008 at 03:51:24PM +0000, place wrote: > My idea of what seems like a good ordering, for what that's worth :) > When I watch the headers, I always wonder why I didn't put Accept-Encoding > next to Accept-Charset, for one thing... AFAIR headers are ordered as they appear in the RFC. I'm not sure whether this is relevant, please check. -- Cheers Jorge.-

March 12, 2008