- Dillo-dev - lists.mailman3.com

dillo-fltk exits on SIGPIPE

by onepoint＠starurchin.org

On Wed, Apr 23, 2008 at 05:24:01PM +0000, corvid wrote: > Johannes wrote: > > do you also see exits on SIGPIPE e.g. on: > > http://daily.daemonnews.org > > dillo 1 had signal(SIGPIPE, SIG_IGN); > > which dillo-fltk is missing. > > No, I just get: > > ** WARNING **: IO_write, closing with pending data not sent I see the same thing as corvid . (Details: Linux 2.6.25 , gcc 3.4.3 , glibc 2.3.4 .) Regards, Jeremy Henty

April 23, 2008

patch: motionNotify when scrolling (Re: patch: Re: [Dillo-dev] start on image maps (dw-part))

by corvid＠lavabit.com

Johannes wrote: > On Wed, Apr 23, 2008 at 06:08:27AM +0000, corvid wrote: > > Johannes wrote: > > > On Tue, Apr 22, 2008 at 02:05:43PM +0000, corvid wrote: > > > > Speaking of motionNotify, the other day I was looking into getting the > > > > link in the status bar to change when scrolling. I'd gotten as far as > > > > figuring out that maybe *checks notes* Layout::scrollPosChanged could call > > > > Layout::motionNotify, but then I got stuck because I didn't know where to > > > > get current cursor coordinates from. > > > > > > In fltk one can call get_mouse(int &x, int &y). But I'm not sure > > > how to wrap this properly. Perhaps adding a similar method to > > > Platform? What about different views, can they all have separate > > > pointer devices? > > > Just checked dillo1. It handles at least the scrolling case > > > properly. > > > > Ah, indeed. It turns out that old dillo sets viewport->mouse_[xy] in > > Dw_gtk_viewport_motion_notify() > > and then has a > > static void Dw_gtk_viewport_adj_changed (GtkAdjustment *adj, > > GtkDwViewport *viewport) > > { > > Dw_gtk_viewport_mouse_event (GTK_WIDGET (viewport), > > viewport->mouse_x, viewport->mouse_y, NULL); > > } > > > > Attached is a patch similar to this. > > > > It works for scrolling and when I close a window that had been > > obscuring the viewport (it gets ENTER and FOCUS. I chose ENTER). > > It does not work when I page around with my window manager because the only > > event the viewport handler sees is KEYUP, and I didn't like the idea > > of using KEYUP for this. > > Nice! But there is still other cases, like going back with > <Backspace> such that the cursor ends up over a link. > Or incremental rendering such that the cursor ends up over a link ( > (to reproduce go to a slow page, move the cursor over a link and > press <Ctrl>-r to reload). > > I'm not sure how to handle these cases where the movement is > initiated by the layout rather than the view. I ignored it at the time because I figured it was probably hard to deal with. It also incorrectly shows links when text searching causes scrolling. I have this case fixed in my copy now. And it could be made to deal with moving into scrollbars, although that's probably for a separate patch at some point (with cursor resetting as well). > I'd like to have a general mechanism like > Layout::canvasMousePosChanged () that can be called in all these > cases. I'll at least try to figure out something...

April 23, 2008

dillo-fltk exits on SIGPIPE

by corvid＠lavabit.com

Johannes wrote: > do you also see exits on SIGPIPE e.g. on: > http://daily.daemonnews.org > dillo 1 had signal(SIGPIPE, SIG_IGN); > which dillo-fltk is missing. No, I just get: ** WARNING **: IO_write, closing with pending data not sent

April 23, 2008

patch: motionNotify when scrolling (Re: patch: Re: [Dillo-dev] start on image maps (dw-part))

by Johannes.Hofmann＠gmx.de

On Wed, Apr 23, 2008 at 06:08:27AM +0000, corvid wrote: > Johannes wrote: > > On Tue, Apr 22, 2008 at 02:05:43PM +0000, corvid wrote: > > > Speaking of motionNotify, the other day I was looking into getting the > > > link in the status bar to change when scrolling. I'd gotten as far as > > > figuring out that maybe *checks notes* Layout::scrollPosChanged could call > > > Layout::motionNotify, but then I got stuck because I didn't know where to > > > get current cursor coordinates from. > > > > In fltk one can call get_mouse(int &x, int &y). But I'm not sure > > how to wrap this properly. Perhaps adding a similar method to > > Platform? What about different views, can they all have separate > > pointer devices? > > Just checked dillo1. It handles at least the scrolling case > > properly. > > Ah, indeed. It turns out that old dillo sets viewport->mouse_[xy] in > Dw_gtk_viewport_motion_notify() > and then has a > static void Dw_gtk_viewport_adj_changed (GtkAdjustment *adj, > GtkDwViewport *viewport) > { > Dw_gtk_viewport_mouse_event (GTK_WIDGET (viewport), > viewport->mouse_x, viewport->mouse_y, NULL); > } > > Attached is a patch similar to this. > > It works for scrolling and when I close a window that had been > obscuring the viewport (it gets ENTER and FOCUS. I chose ENTER). > It does not work when I page around with my window manager because the only > event the viewport handler sees is KEYUP, and I didn't like the idea > of using KEYUP for this. Nice! But there is still other cases, like going back with <Backspace> such that the cursor ends up over a link. Or incremental rendering such that the cursor ends up over a link ( (to reproduce go to a slow page, move the cursor over a link and press <Ctrl>-r to reload). I'm not sure how to handle these cases where the movement is initiated by the layout rather than the view. I'd like to have a general mechanism like Layout::canvasMousePosChanged () that can be called in all these cases. Johannes

April 23, 2008

dillo-fltk exits on SIGPIPE

by Johannes.Hofmann＠gmx.de

Hi, do you also see exits on SIGPIPE e.g. on: http://daily.daemonnews.org dillo 1 had signal(SIGPIPE, SIG_IGN); which dillo-fltk is missing. Cheers, Johannes

April 23, 2008

patch: motionNotify when scrolling (Re: patch: Re: [Dillo-dev] start on image maps (dw-part))

by corvid＠lavabit.com

Johannes wrote: > On Tue, Apr 22, 2008 at 02:05:43PM +0000, corvid wrote: > > Speaking of motionNotify, the other day I was looking into getting the > > link in the status bar to change when scrolling. I'd gotten as far as > > figuring out that maybe *checks notes* Layout::scrollPosChanged could call > > Layout::motionNotify, but then I got stuck because I didn't know where to > > get current cursor coordinates from. > > In fltk one can call get_mouse(int &x, int &y). But I'm not sure > how to wrap this properly. Perhaps adding a similar method to > Platform? What about different views, can they all have separate > pointer devices? > Just checked dillo1. It handles at least the scrolling case > properly. Ah, indeed. It turns out that old dillo sets viewport->mouse_[xy] in Dw_gtk_viewport_motion_notify() and then has a static void Dw_gtk_viewport_adj_changed (GtkAdjustment *adj, GtkDwViewport *viewport) { Dw_gtk_viewport_mouse_event (GTK_WIDGET (viewport), viewport->mouse_x, viewport->mouse_y, NULL); } Attached is a patch similar to this. It works for scrolling and when I close a window that had been obscuring the viewport (it gets ENTER and FOCUS. I chose ENTER). It does not work when I page around with my window manager because the only event the viewport handler sees is KEYUP, and I didn't like the idea of using KEYUP for this.

April 23, 2008

dillo seems to close file descriptors twice

by Johannes.Hofmann＠gmx.de

Hi, I just noticed, that dillo seems to close file descriptors twice via IO_close_fd, which causes problems when other threads run in parallel for name server queries. Here are the two call stacks via which IO_close_fd is called for each fd: (gdb) b IO_close_fd Breakpoint 1 at 0x8070781: file IO.c, line 137. (gdb) r dillo.org Starting program: /home/hofmann/projects/dillo/plain/dillo2-hg/src/dillo-fltk dillo.org dillo_dns_init: Here we go! (threaded) Enabling cookies as from cookiesrc... Nav_open_url: new url='http://dillo.org' Dns_server [0]: dillo.org is 0x28559680 Connecting to 134.102.206.165 Nav_open_url: new url='http://www.dillo.org/' Breakpoint 1, IO_close_fd (io=0x28550a00, CloseCode=2) at IO.c:137 137 fprintf(stderr,"====> begin IO close (%d)\n", io->FD); Current language: auto; currently c (gdb) bt #0 IO_close_fd (io=0x28550a00, CloseCode=2) at IO.c:137 #1 0x0807094e in a_IO_ccc (Op=4, Branch=1, Dir=2, Info=0x285509e0, Data1=0x0, Data2=0x0) at IO.c:392 #2 0x0805633e in a_Chain_bcb (Op=4, Info=0x28550a00, Data1=0x0, Data2=0x0) at chain.c:98 #3 0x0806ea14 in a_Http_ccc (Op=4, Branch=1, Dir=2, Info=0x2854df60, Data1=0x0, Data2=0x0) at http.c:522 #4 0x0805633e in a_Chain_bcb (Op=4, Info=0x28550a00, Data1=0x0, Data2=0x0) at chain.c:98 #5 0x0805a514 in a_Capi_ccc (Op=4, Branch=1, Dir=2, Info=0x2854df40, Data1=0x0, Data2=0x0) at capi.c:491 #6 0x0805a39c in a_Capi_ccc (Op=4, Branch=2, Dir=1, Info=0x285509a0, Data1=0x0, Data2=0x0) at capi.c:601 #7 0x0805630a in a_Chain_fcb (Op=4, Info=0x28550a00, Data1=0x0, Data2=0x0) at chain.c:86 #8 0x0806ffd1 in a_Dpi_ccc (Op=4, Branch=2, Dir=1, Info=0x28550bc0, Data1=0x0, Data2=0x0) at dpi.c:671 #9 0x0805630a in a_Chain_fcb (Op=4, Info=0x28550a00, Data1=0x0, Data2=0x0) at chain.c:86 #10 0x08070891 in a_IO_ccc (Op=4, Branch=2, Dir=1, Info=0x28550c00, Data1=0x28550c20, Data2=0x0) at IO.c :410 #11 0x08070b64 in IO_callback (fd=<value optimized out>, io=0x28550c20) at IO.c:201 #12 0x08070beb in IO_fd_read_cb (fd=7, data=0x2) at IO.c:277 #13 0x080bcfe5 in fltk::wait () #14 0x080bd195 in fltk::run () #15 0x0804eadb in main (argc=0, argv=0x0) at dillo.cc:110 (gdb) c Continuing. ====> begin IO close (7) Breakpoint 1, IO_close_fd (io=0x28550c20, CloseCode=2) at IO.c:137 137 fprintf(stderr,"====> begin IO close (%d)\n", io->FD); (gdb) bt #0 IO_close_fd (io=0x28550c20, CloseCode=2) at IO.c:137 #1 0x0807089e in a_IO_ccc (Op=4, Branch=2, Dir=1, Info=0x28550c00, Data1=0x28550c20, Data2=0x0) at IO.c:411 #2 0x08070b64 in IO_callback (fd=<value optimized out>, io=0x28550c20) at IO.c:201 #3 0x08070beb in IO_fd_read_cb (fd=7, data=0x2) at IO.c:277 #4 0x080bcfe5 in fltk::wait () #5 0x080bd195 in fltk::run () #6 0x0804eadb in main (argc=0, argv=0x0) at dillo.cc:110 (gdb) c Continuing. ====> begin IO close (7) A line like fprintf(stderr,"====> begin IO close (%d)\n", io->FD); at the beginning of IO_close_fd() also shows the problem. Cheers, Johannes

April 22, 2008

[patch] phrase search

by Johannes.Hofmann＠gmx.de

Hi, attached is a patch that make phrase search work. I'm not 100% sure about the CharIterator::prev() change. CharIterator::next() returned \0 between words, prev() didn't. So something was wrong. I decided to go with current next() behaviour and made prev() return \0 as word separator too. Also the current implementation only works if one enters exactly one blank between words in the search dialog. Should we collapse multiple blanks into one automatically? Cheers, Johannes

April 22, 2008

patch: Re: [Dillo-dev] start on image maps (dw-part)

by Johannes.Hofmann＠gmx.de

On Tue, Apr 22, 2008 at 02:05:43PM +0000, corvid wrote: > Johannes wrote: > > On Tue, Apr 22, 2008 at 04:50:32AM +0000, corvid wrote: > > > dillo: > > > - I imagine the setUseMap() in open_img() is probably supposed to be > > > routed through DilloImage. > > > - Html_read_coords() was borrowed from 0.8.6 and modified a fair amount. > > > For one thing, the old code couldn't handle whitespace preceding a comma. > > > - I didn't really like that dReturn_if_fail so far down in open_area() > > > since coords is dynamically allocated now, but I left it there. > > > > > > What about deleting coords earlier? I think they are no longer > > needed once the shape has been constructed. > > That's true. I had just reached a point where the code was already tested > and I didn't want to mess with anything for fear of introducing some error > at the last moment ("this doesn't work at all! did you even compile it?" :)) > > > Regarding your comment in Image::enterNotifyImpl(). I noticed that > > too, but enterNotifyImpl() simply notifies about the enter > > event, so no coordinates are needed. > > Don't you think that implementing map aware Image::motionNotifyImpl() > > is enough? > > You're probably right. I wasn't sure whether it would get a motionNotify > when it first entered the image. > > Speaking of motionNotify, the other day I was looking into getting the > link in the status bar to change when scrolling. I'd gotten as far as > figuring out that maybe *checks notes* Layout::scrollPosChanged could call > Layout::motionNotify, but then I got stuck because I didn't know where to > get current cursor coordinates from. > In fltk one can call get_mouse(int &x, int &y). But I'm not sure how to wrap this properly. Perhaps adding a similar method to Platform? What about different views, can they all have separate pointer devices? Just checked dillo1. It handles at least the scrolling case properly.

April 22, 2008

patch: Re: [Dillo-dev] start on image maps (dw-part)

by corvid＠lavabit.com

Johannes wrote: > On Tue, Apr 22, 2008 at 04:50:32AM +0000, corvid wrote: > > dillo: > > - I imagine the setUseMap() in open_img() is probably supposed to be > > routed through DilloImage. > > - Html_read_coords() was borrowed from 0.8.6 and modified a fair amount. > > For one thing, the old code couldn't handle whitespace preceding a comma. > > - I didn't really like that dReturn_if_fail so far down in open_area() > > since coords is dynamically allocated now, but I left it there. > > > What about deleting coords earlier? I think they are no longer > needed once the shape has been constructed. That's true. I had just reached a point where the code was already tested and I didn't want to mess with anything for fear of introducing some error at the last moment ("this doesn't work at all! did you even compile it?" :)) > Regarding your comment in Image::enterNotifyImpl(). I noticed that > too, but enterNotifyImpl() simply notifies about the enter > event, so no coordinates are needed. > Don't you think that implementing map aware Image::motionNotifyImpl() > is enough? You're probably right. I wasn't sure whether it would get a motionNotify when it first entered the image. Speaking of motionNotify, the other day I was looking into getting the link in the status bar to change when scrolling. I'd gotten as far as figuring out that maybe *checks notes* Layout::scrollPosChanged could call Layout::motionNotify, but then I got stuck because I didn't know where to get current cursor coordinates from.

April 22, 2008