- Dillo-dev - lists.mailman3.com

Dillo freeze

by corvid＠lavabit.com

Jorge wrote: > Dillo freezes on this page: > > http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.24.6.tar.bz2.sign > > Dillo bug or FLTK2? I ran into this a few months ago with http://p3p.yahoo.com/w3c/p3p.xml (and then eventually forgot about it). They are both tiny and fit in a packet, which might be significant...

May 6, 2008

Dillo freeze

by jcid＠dillo.org

Hi there, Dillo freezes on this page: http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.24.6.tar.bz2.sign Dillo bug or FLTK2? -- Cheers Jorge.-

May 5, 2008

ListResources: version 3

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jorge Arellano Cid wrote: > [..] > * Used (long) cast for 64bit compatibility (please somebody test). That would be me ;) I haven't looked into whether the added functionality works (didn't know where to look), but it compiles cleanly and runs just fine. It's nice that you kept an eye on the platform issue ;) Cheers, Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIH37koPmwNWhsaZYRAk+fAJ48XIMCFjaD/TbxOSYjciW1brFG+ACeJGvV qgdJPm591wlzYHgXEJxfG9Y= =xmAr -----END PGP SIGNATURE-----

May 5, 2008

patch: dialog.cc window deletion

by jcid＠dillo.org

On Sat, May 03, 2008 at 04:39:34AM +0000, corvid wrote: > Using the crude tool of top(1), I learned that viewing the source of a > 500K file meant losing 500K down the drain. > > - If I give the text to the TextDisplay's initial buffer, it knows that > it owns it. > > - Window::destroy() doesn't delete. The header comment in > fltk/src/Window.cxx says it's some sort of 'hide' function: > > "Hides the window and also deletes all window system information > about the window, and thus returns it back to the state it was in > before the first show(). It is harmless to call this if the window > is already destroyed." > > > - And while I was in there, I threw in some callback(window_close_cb, ...)s > for closing windows using the window mgr instead of a button. > Committed! Funny how the Escape key started working again as close shortcut. -- Cheers Jorge.-

May 5, 2008

ListResources: version 3

by jcid＠dillo.org

Hi Jeremy, In a nutshell: 00__html_dlist_fix.dillo2 10__html_select_multiple.dillo2 10__listresource.dw2 15__listresource_selection.dw2 16__listresource_sizerequest.dw2 committed with minor changes! Some minor changes: * Used (long) cast for 64bit compatibility (please somebody test). * single return point in FltkListResource::widgetCallback. * added some comments. * Removed: //blindly copied from FltkOptionMenuResource, is it necessary? R: yes, it's necessary. Each new added item may change the Width. On Fri, May 02, 2008 at 11:42:18PM +0100, Jeremy Henty wrote: > > I am attaching two patches that get ListResource selection working > properly, ie. you can click items as you wish and > FltkListResource::isSelected() will now return the correct value. > > The first patch is my previous selection patch, unchanged. The second > is a small fix that I proposed in the lout::misc::StringBuffer fix > thread: it makes FltkListResource::addItem call Widget::set_selected() > on fltk::Item widgets, and the call to Menu::set_item() becomes > conditional on a virtual boolean hook that defaults to false, but is > redefined to true in FltkOptionMenuResource() . Yes, it looks simple enough. Added a reminding comment anyway. > [...] > Currently FltkListResource::sizeRequest() is a stub with some > hardwired values that are not very useful. This patch replaces it > with something more appropriate (closely following the existing > implementation of FltkOptionMenuResource::sizeRequest() ). Added some minor adjustments to fit the new size. Good work! -- Cheers Jorge.-

May 5, 2008

[patch]: FltkListResource::sizeRequest()

by onepoint＠starurchin.org

Currently FltkListResource::sizeRequest() is a stub with some hardwired values that are not very useful. This patch replaces it with something more appropriate (closely following the existing implementation of FltkOptionMenuResource::sizeRequest() ). Comments are welcome, Jeremy Henty

May 5, 2008

[BUG]: html.cc: broken Dlist iteration

by Johannes.Hofmann＠gmx.de

On Mon, May 05, 2008 at 10:41:00AM +0100, Jeremy Henty wrote: > > Html_build_query_data() and Html_make_multipart_boundary() iterate > over a Dlist while destructively modifying it *and* recalculating the > list length each time, so the iteration terminates prematurely. This > makes Html_build_query_data() mangle the result when an input returns > multiple values: half of the values get attached to the next input! > > This patch fixes the problem by caching the length of the list before > modifying it so that the entire list is processed. Cool, I also tried to hook up your ListResource code in html.cc, but could not find the reason why some of the selected items were missing on submit. Regards, Johannes > > Regards, > > Jeremy Henty > diff -pru -- 00_pre/src/html.cc 01_post/src/html.cc > --- 00_pre/src/html.cc 2008-05-02 18:25:13.000000000 +0100 > +++ 01_post/src/html.cc 2008-05-05 10:10:18.000000000 +0100 > @@ -4191,7 +4191,8 @@ static char *Html_make_multipart_boundar > dStr_free(dstr, 1); > } > } > - for (int i = 0; i < dList_length(values); i++) { > + int length = dList_length(values); > + for (int i = 0; i < length; i++) { > dstr = (Dstr *) dList_nth_data(values, 0); > dList_remove(values, dstr); > if (input->type != DILLO_HTML_INPUT_FILE) > @@ -4283,8 +4284,8 @@ static Dstr *Html_build_query_data(Dillo > Html_urlencode_append(DataStr, val->str); > dStr_free(val, 1); > } else { > - int i; > - for (i = 0; i < dList_length(values); i++) { > + int length = dList_length(values), i; > + for (i = 0; i < length; i++) { > Dstr *val = (Dstr *) dList_nth_data(values, 0); > dList_remove(values, val); > val = Html_encode_text(encoder, &val); > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

May 5, 2008

[patch]: select multiple

by onepoint＠starurchin.org

This patch implements the MULTIPLE attribute for SELECT elements. It's small but it depends on the various patches and bugfixes I have already posted. Please comment. Regards, Jeremy Henty

May 5, 2008

[BUG]: html.cc: broken Dlist iteration

by onepoint＠starurchin.org

Html_build_query_data() and Html_make_multipart_boundary() iterate over a Dlist while destructively modifying it *and* recalculating the list length each time, so the iteration terminates prematurely. This makes Html_build_query_data() mangle the result when an input returns multiple values: half of the values get attached to the next input! This patch fixes the problem by caching the length of the list before modifying it so that the entire list is processed. Regards, Jeremy Henty

May 5, 2008

ListResources: version 3

by Johannes.Hofmann＠gmx.de

On Fri, May 02, 2008 at 11:42:18PM +0100, Jeremy Henty wrote: > > I am attaching two patches that get ListResource selection working > properly, ie. you can click items as you wish and > FltkListResource::isSelected() will now return the correct value. > > The first patch is my previous selection patch, unchanged. The second > is a small fix that I proposed in the lout::misc::StringBuffer fix > thread: it makes FltkListResource::addItem call Widget::set_selected() > on fltk::Item widgets, and the call to Menu::set_item() becomes > conditional on a virtual boolean hook that defaults to false, but is > redefined to true in FltkOptionMenuResource() . > > The second patch looks bigger than it really is: most of it is just > reindenting a block of code that moved inside an "if" statement. (And > diff doesn't help by insisting on choosing an unnecessarily > complicated set of changes.) It's not a pretty hack, but it's simple > and I am wary of making deeper changes until I understand the code > better. > > Please comment, Very nice! Works great. Now I realized that it already supports submenus... Johannes

May 3, 2008