- Dillo-dev - lists.mailman3.com

Bug that aborts Dillo

by corvid＠lavabit.com

Jorge wrote: > Hi there, > > I reviewed my personal notes on dillo segfaults and all of them > but one are fixed now. This is: > > BUG: > http://episteme.arstechnica.com/groupee/forums/a/tpc/f/96509133 > /m/151006647731/r/264004847731 > Aborts dillo. I tried it and it crashed. Then I dug up the - requisition->width += getStyle()->boxDiffHeight (); + requisition->width += getStyle()->boxDiffWidth (); in sizeRequestImpl from http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-January/003690.html and it no longer wanted to crash for me.

May 17, 2008

Bug that aborts Dillo

by jcid＠dillo.org

Hi there, I reviewed my personal notes on dillo segfaults and all of them but one are fixed now. This is: BUG: http://episteme.arstechnica.com/groupee/forums/a/tpc/f/96509133 /m/151006647731/r/264004847731 Aborts dillo. If you wget that URL to a local file, it's easier to debug because the problem is with a requested image. A negative number is propagated down from image.cc:199 #13 0x0807d083 in dw::Image::sizeAllocateImpl (this=0x81eca98,allocation=0xbfc69fb8) at image.cc:201 (gdb) p *allocation $4 = {x = 366, y = 941, width = 3, ascent = 2, descent = 1} (gdb) p dx $5 = 8 (gdb) p dy $6 = 26607 (gdb) allocation->width - dx = -5. from there width=-5 wreaks havoc. Please someone more seasoned in the (dx,dy) offsets give it a look. -- Cheers Jorge.-

May 17, 2008

Dillo freeze

by jcid＠dillo.org

On Fri, May 16, 2008 at 04:28:12PM -0400, Jorge Arellano Cid wrote: > On Mon, May 12, 2008 at 09:29:11PM +0200, Johannes Hofmann wrote: > > On Mon, May 05, 2008 at 05:41:32PM -0400, Jorge Arellano Cid wrote: > > > Hi there, > > > > > > Dillo freezes on this page: > > > > > > http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.24.6.tar.bz2.sign > > > > > > Dillo bug or FLTK2? > > > > Other than I initially thought it is a Dillo bug. The IOwatch for > > reading is not removed properly. As a result the select call in the > > fltk event loop keeps failing with EBADF. > > Attached is a fix for the problem, but I'm not sure whether it is > > correct. Jorge, can you please have a look at it? > > Committed. > > After a really long review. :-P > > Related CCC patches pending here... Ok, the pending patches are now committed. The Changelog reads: - CCC: added reentrancy control to the OpEnd and OpAbort operations. - CCC: enhanced the debug function and implemented OpAbort for dpi. This fixes: - A ftp problem with short files not being sent back. - Downloading short ftp files freezing the downloader. - Cancel on download dialog for ftp file aborting dillo (SEGFAULT). Maybe more... :) Please test. -- Cheers Jorge.-

May 17, 2008

website FAQ update

by corvid＠lavabit.com

Justus wrote: > Jorge Arellano Cid wrote: > > On Fri, May 16, 2008 at 08:21:25PM +0000, corvid wrote: > >> Are "dillo1" and "dillo2" official names? If so, I'll add in some text to > >> make it clear what's what. > > > > They're not official, but good mnemonics! > > > > When there was GTK1 dillo only, there was no confusion. > > Currently the CVS is using dillo-fltk, but I'd much prefer > > to have a binary named "dillo2". > > > > Probably this is a good choice. Let's hear what dillo-dev > > people say. Here's the proposal: > > > > * call the new binary "dillo2", and refer to the old 0.8.x series > > as dillo1. > > I think it's problematic to have a digit in the official name (or in the > name of the binary) since people will think it's the version. I'd > suggest something along these lines: > > * Dillo is the name of the brand > * dillo2 is the codename for the fltk branch > * for marketing reasons sell any snapshots / upcoming releases of that > branch as the all new dillo version 2.x.y with tons of new features > * the binary is called dillo (it's what people expect to type in to > start the lightweight web browser thingie [at least I tried to run > $PREFIX/bin/dillo a couple of times now...]) I also prefer to have a binary named dillo. (and dillorc2 -> dillorc)

May 17, 2008

website FAQ update

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jorge Arellano Cid wrote: > On Fri, May 16, 2008 at 08:21:25PM +0000, corvid wrote: >> Are "dillo1" and "dillo2" official names? If so, I'll add in some text to >> make it clear what's what. > > They're not official, but good mnemonics! > > When there was GTK1 dillo only, there was no confusion. > Currently the CVS is using dillo-fltk, but I'd much prefer > to have a binary named "dillo2". > > Probably this is a good choice. Let's hear what dillo-dev > people say. Here's the proposal: > > * call the new binary "dillo2", and refer to the old 0.8.x series > as dillo1. I think it's problematic to have a digit in the official name (or in the name of the binary) since people will think it's the version. I'd suggest something along these lines: * Dillo is the name of the brand * dillo2 is the codename for the fltk branch * for marketing reasons sell any snapshots / upcoming releases of that branch as the all new dillo version 2.x.y with tons of new features * the binary is called dillo (it's what people expect to type in to start the lightweight web browser thingie [at least I tried to run $PREFIX/bin/dillo a couple of times now...]) Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFILf4BoPmwNWhsaZYRAor2AJ0U728787tvENHwVuxFW000e/DC/gCgpqZD JVaxk8o+/yROgKeKOapZlA4= =ym7X -----END PGP SIGNATURE-----

May 16, 2008

website FAQ update

by corvid＠lavabit.com

Jorge wrote: > Please try to contact J?rgen. If he doesn't answer, leave dillo-dev > as the only contact until we find somebody else. His dillo address redirects to an address where I get User Unknown. I found a telia.com address, but that also gave me User Unknown.

May 16, 2008

website FAQ update

by jcid＠dillo.org

On Fri, May 16, 2008 at 08:21:25PM +0000, corvid wrote: > Are "dillo1" and "dillo2" official names? If so, I'll add in some text to > make it clear what's what. They're not official, but good mnemonics! When there was GTK1 dillo only, there was no confusion. Currently the CVS is using dillo-fltk, but I'd much prefer to have a binary named "dillo2". Probably this is a good choice. Let's hear what dillo-dev people say. Here's the proposal: * call the new binary "dillo2", and refer to the old 0.8.x series as dillo1. -- Cheers Jorge.-

May 16, 2008

Dillo freeze

by jcid＠dillo.org

On Mon, May 12, 2008 at 09:29:11PM +0200, Johannes Hofmann wrote: > On Mon, May 05, 2008 at 05:41:32PM -0400, Jorge Arellano Cid wrote: > > Hi there, > > > > Dillo freezes on this page: > > > > http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.24.6.tar.bz2.sign > > > > Dillo bug or FLTK2? > > Other than I initially thought it is a Dillo bug. The IOwatch for > reading is not removed properly. As a result the select call in the > fltk event loop keeps failing with EBADF. > Attached is a fix for the problem, but I'm not sure whether it is > correct. Jorge, can you please have a look at it? Committed. After a really long review. :-P Related CCC patches pending here... -- Cheers Jorge.-

May 16, 2008

website FAQ update

by corvid＠lavabit.com

Are "dillo1" and "dillo2" official names? If so, I'll add in some text to make it clear what's what. BTW, I misspelled 'publicly' :(

May 16, 2008

Uncluttering dillos UI - getting rid of the dialog boxes

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Johannes Hofmann wrote: > Cool! I like it already better than the dialog box. > What do you mean by "on-blur" events? I like to be notified the moment the input box loses focus. For some reason the code works quite well as it is (a comment in the source code mentions this might be a fltk bug :-/), but it is possible to leave the location box without triggering the event handler. But relying on some undocumented and or buggy behavior is obviously not an option ;). I'd expect something like inputbox->when(WHEN_ENTER_KEY | UNFOCUS) but I have no experience with fltk at all and a quick look into the callback section of their documentation didn't help either. Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFILei8oPmwNWhsaZYRAqidAJwMMweoNyvL+yMLbPXv6udUU7BiNQCgiSU3 VxfMpr6FsBJifzC/ecmqJ0o= =P3yn -----END PGP SIGNATURE-----

May 16, 2008