- Dillo-dev - lists.mailman3.com

Re: [PATCH] User defined new tab page

by a1ex＠dismail.de

> >Hopefully this won't be a problem, because now the about:blank is > >pre-selected and you can just start typing over it. > > It only works well with about:blank. As soon as you load another page > (like dpi:/bm/) it deselects the location bar. Maybe there is a way to do something like this to retake the selection after the page has finished loading (or earlier?) from ui.cc: 139 // Make text selected when already focused. 140 position(size(), 0); ... 836 // Make text selected when already focused. 837 Location->position(Location->size(), 0); Sorry if I'm stating the obvious, just thinking aloud :) Alex

April 11, 2024

Re: [PATCH] User defined new tab page

by a1ex＠dismail.de

On Thu, 11 Apr 2024 13:26:50 +0200 Rodrigo Arias <rodarima(a)gmail.com> wrote: > >Here is a patch to add a new tab page to dillo. You can define any > >url in dillorc preference 'new_tab_page', and it will be > >automatically opened in new tabs. Setting the value "about:blank" > >will retain the default blank page behavior. I tried to make it work > >with an empty value of "", but for some reason dillo prepends > >'http:' to the value. > > I would be nice to have an exception for "" so it is kept as-is. I'm looking at lines 401-411 in url.c, and almost have it working as you suggest. My code is undoubtedly ugly and incorrect, so I might need some help with this one. Will keep trying. > >Hopefully this won't be a problem, because now the about:blank is > >pre-selected and you can just start typing over it. > > It only works well with about:blank. As soon as you load another page > (like dpi:/bm/) it deselects the location bar. Right, the pre-selection doesn't seem to work with other urls. I still haven't figured out how to fix that, but am guessing that as soon as content starts to load, it deselects the text. I think the feature is still useful given that caveat, but surely there must be some solution. Regards, Alex

April 11, 2024

Re: [PATCH] User defined new tab page

by Rodrigo Arias

>Here is a patch to add a new tab page to dillo. You can define any url >in dillorc preference 'new_tab_page', and it will be automatically >opened in new tabs. Setting the value "about:blank" will retain the >default blank page behavior. I tried to make it work with an empty >value of "", but for some reason dillo prepends 'http:' to the value. I would be nice to have an exception for "" so it is kept as-is. >Hopefully this won't be a problem, because now the about:blank is >pre-selected and you can just start typing over it. It only works well with about:blank. As soon as you load another page (like dpi:/bm/) it deselects the location bar. Rodrigo.

April 11, 2024

Re: [PATCH] User defined new tab page

by Rodrigo Arias

>Try again, last message was mangled: Please use "git send-email" to send patches, so they can be applied with "git am". Follow this guide to set it up: https://git-send-email.io/ Rodrigo.

April 11, 2024

Re: [PATCH] User defined new tab page

by a1ex＠dismail.de

Try again, last message was mangled: --- dillorc Thu Apr 11 11:11:01 2024 +++ dillorc Thu Apr 11 11:14:18 2024 @@ -154,6 +154,11 @@ # home="file:/home/jcid/HomePage/Home.html" #home="https://dillo-browser.github.io/" +# Set the new tab page. +# new_tab_page="dpi:/bm/" +# new_tab_page="https://example.com/" +#new_tab_page="about:blank" + # Set the URLs used by the web search dialog. # "%s" is replaced with the search keywords separated by '+'. # Format: search_url="[prefix ][<label> ]<url>" --- src/prefs.c Thu Apr 11 11:18:24 2024 +++ src/prefs.c Thu Apr 11 11:21:16 2024 @@ -14,6 +14,7 @@ #define PREFS_START_PAGE "about:splash" #define PREFS_HOME "https://dillo-browser.github.io/" +#define PREFS_NEW_TAB_PAGE "about:blank" #define PREFS_FONT_SERIF "DejaVu Serif" #define PREFS_FONT_SANS_SERIF "DejaVu Sans" #define PREFS_FONT_CURSIVE "URW Chancery L" @@ -109,6 +110,7 @@ prefs.show_ui_tooltip = TRUE; prefs.small_icons = FALSE; prefs.start_page = a_Url_new(PREFS_START_PAGE, NULL); + prefs.new_tab_page = a_Url_new(PREFS_NEW_TAB_PAGE, NULL); prefs.theme = dStrdup(PREFS_THEME); prefs.ui_button_highlight_color = -1; prefs.ui_fg_color = -1; @@ -143,6 +145,7 @@ dFree(prefs.font_sans_serif); dFree(prefs.font_serif); a_Url_free(prefs.home); + a_Url_free(prefs.new_tab_page); dFree(prefs.http_language); a_Url_free(prefs.http_proxy); dFree(prefs.http_proxyuser); --- src/prefs.h Thu Apr 11 11:23:35 2024 +++ src/prefs.h Thu Apr 11 11:24:35 2024 @@ -48,6 +48,7 @@ char *no_proxy; DilloUrl *start_page; DilloUrl *home; + DilloUrl *new_tab_page; bool_t allow_white_bg; int32_t white_bg_replacement; int32_t bg_color; --- src/prefsparser.cc Thu Apr 11 11:26:31 2024 +++ src/prefsparser.cc Thu Apr 11 11:28:12 2024 @@ -171,6 +171,7 @@ { "fullwindow_start", &prefs.fullwindow_start, PREFS_BOOL, 0 }, { "geometry", NULL, PREFS_GEOMETRY, 0 }, { "home", &prefs.home, PREFS_URL, 0 }, + { "new_tab_page", &prefs.new_tab_page, PREFS_URL, 0 }, { "http_language", &prefs.http_language, PREFS_STRING, 0 }, { "http_max_conns", &prefs.http_max_conns, PREFS_INT32, 0 }, { "http_persistent_conns", &prefs.http_persistent_conns, PREFS_BOOL, 0 }, --- src/uicmd.cc Thu Apr 11 11:31:18 2024 +++ src/uicmd.cc Thu Apr 11 12:06:13 2024 @@ -778,6 +778,7 @@ a_UIcmd_set_location_text(new_bw, URL_STR(url)); BW2UI(new_bw)->focus_main(); } else { + a_UIcmd_open_url((BrowserWindow*)new_bw, prefs.new_tab_page); BW2UI(new_bw)->focus_location(); a_UIcmd_set_buttons_sens(new_bw); }

April 11, 2024

[PATCH] User defined new tab page

by a1ex＠dismail.de

Hi list, Here is a patch to add a new tab page to dillo. You can define any url in dillorc preference 'new_tab_page', and it will be automatically opened in new tabs. Setting the value "about:blank" will retain the default blank page behavior. I tried to make it work with an empty value of "", but for some reason dillo prepends 'http:' to the value. Hopefully this won't be a problem, because now the about:blank is pre-selected and you can just start typing over it. If there is a better way to do this, I'm open to suggestions. Regards, Alex --- dillorc Thu Apr 11 11:11:01 2024 +++ dillorc Thu Apr 11 11:14:18 2024 @@ -154,6 +154,11 @@ # home="file:/home/jcid/HomePage/Home.html" #home="https://dillo-browser.github.io/" +# Set the new tab page. +# new_tab_page="dpi:/bm/" +# new_tab_page="https://example.com/" #new_tab_page="about:blank" + # Set the URLs used by the web search dialog. # "%s" is replaced with the search keywords separated by '+'. # Format: search_url="[prefix ][<label> ]<url>" --- src/prefs.c Thu Apr 11 11:18:24 2024 +++ src/prefs.c Thu Apr 11 11:21:16 2024 @@ -14,6 +14,7 @@ #define PREFS_START_PAGE "about:splash" #define PREFS_HOME "https://dillo-browser.github.io/" +#define PREFS_NEW_TAB_PAGE "about:blank" #define PREFS_FONT_SERIF "DejaVu Serif" #define PREFS_FONT_SANS_SERIF "DejaVu Sans" #define PREFS_FONT_CURSIVE "URW Chancery L" @@ -109,6 +110,7 @@ prefs.show_ui_tooltip = TRUE; prefs.small_icons = FALSE; prefs.start_page = a_Url_new(PREFS_START_PAGE, NULL); + prefs.new_tab_page = a_Url_new(PREFS_NEW_TAB_PAGE, NULL); prefs.theme = dStrdup(PREFS_THEME); prefs.ui_button_highlight_color = -1; prefs.ui_fg_color = -1; @@ -143,6 +145,7 @@ dFree(prefs.font_sans_serif); dFree(prefs.font_serif); a_Url_free(prefs.home); + a_Url_free(prefs.new_tab_page); dFree(prefs.http_language); a_Url_free(prefs.http_proxy); dFree(prefs.http_proxyuser); --- src/prefs.h Thu Apr 11 11:23:35 2024 +++ src/prefs.h Thu Apr 11 11:24:35 2024 @@ -48,6 +48,7 @@ char *no_proxy; DilloUrl *start_page; DilloUrl *home; + DilloUrl *new_tab_page; bool_t allow_white_bg; int32_t white_bg_replacement; int32_t bg_color; --- src/prefsparser.cc Thu Apr 11 11:26:31 2024 +++ src/prefsparser.cc Thu Apr 11 11:28:12 2024 @@ -171,6 +171,7 @@ { "fullwindow_start", &prefs.fullwindow_start, PREFS_BOOL, 0 }, { "geometry", NULL, PREFS_GEOMETRY, 0 }, { "home", &prefs.home, PREFS_URL, 0 }, + { "new_tab_page", &prefs.new_tab_page, PREFS_URL, 0 }, { "http_language", &prefs.http_language, PREFS_STRING, 0 }, { "http_max_conns", &prefs.http_max_conns, PREFS_INT32, 0 }, { "http_persistent_conns", &prefs.http_persistent_conns, PREFS_BOOL, 0 }, --- src/uicmd.cc Thu Apr 11 11:31:18 2024 +++ src/uicmd.cc Thu Apr 11 12:06:13 2024 @@ -778,6 +778,7 @@ a_UIcmd_set_location_text(new_bw, URL_STR(url)); BW2UI(new_bw)->focus_main(); } else { + a_UIcmd_open_url((BrowserWindow*)new_bw, prefs.new_tab_page); BW2UI(new_bw)->focus_location(); a_UIcmd_set_buttons_sens(new_bw); }

April 11, 2024

Re: New feature idea: 'Open link with...' item

by Rodrigo Arias

On Wed, Apr 10, 2024 at 03:55:11PM +0200, a1ex(a)dismail.de wrote: >Another feature which could be useful is an 'Open link with...' item. > >An item in the link menu which runs a command with the link as an >argument. > >For example: Open link with... mpv (open a media stream or yt link) > wget (save link/custom download) > etc... This feature is partially covered by the issue #3 [1] (opened long time ago): [1]: https://github.com/dillo-browser/dillo/issues/3 Check also dilloNG patches: https://github.com/w00fpack/dilloNG/commit/d8b885b3d2d4f755f1f7755543962ee9… https://github.com/w00fpack/dilloNG/commit/7bd6b1c4592466d6e717eaf795e98b7c… >Commands could be defined in dillorc, or maybe a separate text file is >better (like bm.txt)? > >Any interest in this? Not sure how far I would get, it's probably a bit >more complicated than my previous ideas. I think it is useful as long as you can specify which actions you want in a configuration file, not just opening videos. As we probably would need a syntax for specifying the content handling too[2], we may want to reuse the same syntax and/or file to specify the "open with" options, so the actions can also be used when writing other rules for content matching. [2]: https://github.com/dillo-browser/dillo/issues/56 Rodrigo.

April 10, 2024

Re: new tab page

by Rodrigo Arias

> Nice, I'm sure there are people who will only browse the archive > without actually subscribing to the list. I noticed that the > mailman3.com web archive is not working great, for example our > conversation from yesterday has not showed up there at all yet. Yeah, and is nice to have threads indexed too. Replying to an email (usually) sets the In-Reply-To header: > In-Reply-To: <ZhRJOjltTdCFqPj-(a)hop.home> Which causes the thread to continue, even if you change the subject. The same happens in mailman3 and mail-archive: https://lists.mailman3.com/hyperkitty/list/dillo-dev@mailman3.com/message/I… https://www.mail-archive.com/dillo-dev@mailman3.com/msg00001.html To start a new thread remove the In-Reply-To header. All emails should be archived in both services, provided dillo-dev is in the recipient list. Otherwise, please report. Rodrigo.

April 10, 2024

New feature idea: 'Open link with...' item

by a1ex＠dismail.de

Another feature which could be useful is an 'Open link with...' item. An item in the link menu which runs a command with the link as an argument. For example: Open link with... mpv (open a media stream or yt link) wget (save link/custom download) etc... Commands could be defined in dillorc, or maybe a separate text file is better (like bm.txt)? Any interest in this? Not sure how far I would get, it's probably a bit more complicated than my previous ideas.

April 10, 2024

Re: new tab page

by a1ex＠dismail.de

> If you follow the UI::focus_location() method you will see that we > already select the location text[2]. However, something else is > causing the selection to get lost shortly after. Ok, this at least confirms that I was looking in the right spot. I guess it will take a deeper dive to figure out whats wrong then. > >Maybe we could have a pref named 'new_tab_page', and if it's > >undefined, the default blank tab behavior would remain. Otherwise > >the user defined url would be loaded on new tabs. > > It sounds reasonable to me. I would use the empty string ("") as the > default value to mean "don't open anything" (but still focus on the > location bar). So we only add functionality retaining the same > behavior we have now. Sounds good, I will try to come up with a patch when time permits, maybe sometime next week. > Also, I added the ML to mail-archive[3], which should be easier to > browse with Dillo without JS. Nice, I'm sure there are people who will only browse the archive without actually subscribing to the list. I noticed that the mailman3.com web archive is not working great, for example our conversation from yesterday has not showed up there at all yet. Regards, Alex

April 10, 2024