- Dillo-dev - lists.mailman3.com

include guard naming

by Johannes.Hofmann＠gmx.de

On Sun, May 24, 2009 at 03:09:53PM -0400, corvid(a)lavabit.com wrote: > I was just going through and changing the include guards > that don't follow the dillo convention, and then > I glanced at http://en.wikipedia.org/wiki/Include_guard > and it reminds me that the C++ standard prohibits '_'s > at the beginning. > > Does anyone care enough to have an opinion? > If we want to rm the leading or surrounding underscores, > I might as well do that too before committing. +1 for removing the undescores

May 24, 2009

Spotted a tiny dillo bug with tabs

by Johannes.Hofmann＠gmx.de

On Sun, May 24, 2009 at 12:16:11PM -0700, Freya wrote: > > > Tiny bug: When dillo changes tabs it doesn't update the main window header thing. Also the same if you close a tab. This can lead to weird effects such as the top header thing having info about a webpage that you don't have open at all. That was fixed recently by Jorge. At least here it works fine now. Please make sure you are running the latest version from: http://hg.dillo.org/dillo Please report back if you are still seeing issues with that version. Cheers, Johannes

May 24, 2009

Spotted a tiny dillo bug with tabs

by freya128＠yahoo.com

Tiny bug: When dillo changes tabs it doesn't update the main window header thing. Also the same if you close a tab. This can lead to weird effects such as the top header thing having info about a webpage that you don't have open at all. Hope that helps! :) love Freya

May 24, 2009

include guard naming

by corvid＠lavabit.com

I was just going through and changing the include guards that don't follow the dillo convention, and then I glanced at http://en.wikipedia.org/wiki/Include_guard and it reminds me that the C++ standard prohibits '_'s at the beginning. Does anyone care enough to have an opinion? If we want to rm the leading or surrounding underscores, I might as well do that too before committing. [pop/smtp isn't working at the moment, so I'm sending this through webmail. Let's hope they doesn't mangle line wrapping or anything.]

May 24, 2009

[bug]: uint32_t not declared

by onepoint＠starurchin.org

On Sun, May 24, 2009 at 02:06:07PM +0000, corvid wrote: > Does tip work for you now? Yes. Thanks! Jeremy Henty

May 24, 2009

[bug]: uint32_t not declared

by corvid＠lavabit.com

Joerg wrote: > On Sun, May 24, 2009 at 02:06:57PM +0100, Jeremy Henty wrote: > > It's stdint.h , which is on my system and correctly found by autoconf. > > You should conditionally include both stdint.h and inttypes.h, some > system miss one or both of them. > > > Patch attached. But what happens if HAVE_STDINT_H is undefined? > > You can also use AC_TYPE_UINT32_T and friends, it will define uint32_t > if necessary. It looks like they were introduced in 2006 in autoconf 2.60. That's the version I happen to have, but...

May 24, 2009

[bug]: uint32_t not declared

by joerg.sonnenberger＠web.de

On Sun, May 24, 2009 at 02:06:57PM +0100, Jeremy Henty wrote: > It's stdint.h , which is on my system and correctly found by autoconf. You should conditionally include both stdint.h and inttypes.h, some system miss one or both of them. > Patch attached. But what happens if HAVE_STDINT_H is undefined? You can also use AC_TYPE_UINT32_T and friends, it will define uint32_t if necessary. Joerg

May 24, 2009

[bug]: uint32_t not declared

by corvid＠lavabit.com

Jeremy wrote: > The latest tip fails to build for me. I don't have uint32_t. Which > header should include it? I'm using gcc 4.1.2. Does tip work for you now?

May 24, 2009

[bug]: uint32_t not declared

by onepoint＠starurchin.org

Answering myself: On Sun, May 24, 2009 at 01:47:20PM +0100, Jeremy Henty wrote: > > I don't have uint32_t. Which header should include it? It's stdint.h , which is on my system and correctly found by autoconf. /* Define to 1 if you have the <stdint.h> header file. */ #define HAVE_STDINT_H 1 Patch attached. But what happens if HAVE_STDINT_H is undefined? Regards, Jeremy Henty

May 24, 2009

[bug]: uint32_t not declared

by onepoint＠starurchin.org

The latest tip fails to build for me. I don't have uint32_t. Which header should include it? I'm using gcc 4.1.2. Regards, Jeremy Henty

May 24, 2009