- Dillo-dev - lists.mailman3.com

patch: save bookmark segfault when dpis not found

by corvid＠lavabit.com

Jorge wrote: > On Wed, Jun 24, 2009 at 02:50:17PM +0000, corvid wrote: > > A new one seen in the bugtracker... > > > > a_Bookmarks_chat_add() sets URL to NULL, so it needs to be handled. > > > > Anyway, the reason this is interesting is that I had always figured > > the URL_*() macros were protecting against a NULL URL, when really > > they protect against NULL fields in URLs. > > Right. > > Please commit (with changelog entry) and update the > bug track entry as "done". The entry is also partly about the fact that the dpis aren't working with their deb package. Perhaps something is broken in it with sysconfdir changing.

June 25, 2009

dillo 2.1]

by jcid＠dillo.org

On Wed, Jun 24, 2009 at 06:59:00PM +0000, corvid wrote: > Jorge wrote: > > On Tue, Jun 23, 2009 at 11:05:07PM +0000, corvid wrote: > > > Jorge wrote: > > > > On Mon, Jun 22, 2009 at 11:01:12PM +0300, Tomas Rimkus wrote: > > > > > > > > > > Accidentally sent to corvid only. Forwarding to dillo-dev. > > > > > > > > > > > > > It seems whoever designed the new website theme has no idea what > > > > > > > > READABILITY means... It looks like someone just used some stupid online > > > > > > > > color picker, which just picks some similar colors to the one user > > > > > > > > chooses. The old website looked MUCH MUCH better. Imho, it's a > > > > > > > > regression... > > > > > > > > > > > > > > Hm I like the new design, but I agree that readability might be a problem. > > > > > > > Let's see what other say. > > > > > > > > > > > > I still find visited text to be hard to read, but I know I should > > > > > > break down and get a new display... > > > > > > > > > > > > > > > > I wonder if you are the only dillo user with old display... BTW, I am using > > > > > pretty new LCD display and still find it hard to read. > > > > > > > > OK, we also had readability concerns but we agreed that it was > > > > enough. OTOH some people bashed the old design as prehistoric! > > > > > > > > After all it's a matter of taste. > > > > Usability is a different thing. Maybe you need higher contrast > > > > to see clearly (I suffer with white backgrounds). Do you find > > > > this one better to read [1]? > > > > > > > > What do other people think about the new web design? > > > > Aesthetically and from a readability point of view. > > > > Please comment. > > > > > > > > > > > > [1] http://www.dillo.org/test/website/dillo2.2.html > > > > > > The test page's visited text is easier for me to read than > > > the home page's visited text. > > > > Funny how it's the reverse effect for me! :-) > > > > > > Please test: > > > > :visited {color: #403090 !important} > > > > and > > > > :visited {color: #603060 !important} > > > > on http://www.dillo.org/ and FAQ. > > > > I prefer the first one because it fits the palette better. > > First one is easier. Is it good enough for you? -- Cheers Jorge.-

June 24, 2009

dillo 2.1]

by corvid＠lavabit.com

Jorge wrote: > On Tue, Jun 23, 2009 at 11:05:07PM +0000, corvid wrote: > > Jorge wrote: > > > On Mon, Jun 22, 2009 at 11:01:12PM +0300, Tomas Rimkus wrote: > > > > > > > > Accidentally sent to corvid only. Forwarding to dillo-dev. > > > > > > > > > > > It seems whoever designed the new website theme has no idea what > > > > > > > READABILITY means... It looks like someone just used some stupid online > > > > > > > color picker, which just picks some similar colors to the one user > > > > > > > chooses. The old website looked MUCH MUCH better. Imho, it's a > > > > > > > regression... > > > > > > > > > > > > Hm I like the new design, but I agree that readability might be a problem. > > > > > > Let's see what other say. > > > > > > > > > > I still find visited text to be hard to read, but I know I should > > > > > break down and get a new display... > > > > > > > > > > > > > I wonder if you are the only dillo user with old display... BTW, I am using > > > > pretty new LCD display and still find it hard to read. > > > > > > OK, we also had readability concerns but we agreed that it was > > > enough. OTOH some people bashed the old design as prehistoric! > > > > > > After all it's a matter of taste. > > > Usability is a different thing. Maybe you need higher contrast > > > to see clearly (I suffer with white backgrounds). Do you find > > > this one better to read [1]? > > > > > > What do other people think about the new web design? > > > Aesthetically and from a readability point of view. > > > Please comment. > > > > > > > > > [1] http://www.dillo.org/test/website/dillo2.2.html > > > > The test page's visited text is easier for me to read than > > the home page's visited text. > > Funny how it's the reverse effect for me! :-) > > > Please test: > > :visited {color: #403090 !important} > > and > > :visited {color: #603060 !important} > > on http://www.dillo.org/ and FAQ. > > I prefer the first one because it fits the palette better. First one is easier.

June 24, 2009

dillo 2.1]

by jcid＠dillo.org

On Tue, Jun 23, 2009 at 11:05:07PM +0000, corvid wrote: > Jorge wrote: > > On Mon, Jun 22, 2009 at 11:01:12PM +0300, Tomas Rimkus wrote: > > > > > > Accidentally sent to corvid only. Forwarding to dillo-dev. > > > > > > > > > It seems whoever designed the new website theme has no idea what > > > > > > READABILITY means... It looks like someone just used some stupid online > > > > > > color picker, which just picks some similar colors to the one user > > > > > > chooses. The old website looked MUCH MUCH better. Imho, it's a > > > > > > regression... > > > > > > > > > > Hm I like the new design, but I agree that readability might be a problem. > > > > > Let's see what other say. > > > > > > > > I still find visited text to be hard to read, but I know I should > > > > break down and get a new display... > > > > > > > > > > I wonder if you are the only dillo user with old display... BTW, I am using > > > pretty new LCD display and still find it hard to read. > > > > OK, we also had readability concerns but we agreed that it was > > enough. OTOH some people bashed the old design as prehistoric! > > > > After all it's a matter of taste. > > Usability is a different thing. Maybe you need higher contrast > > to see clearly (I suffer with white backgrounds). Do you find > > this one better to read [1]? > > > > What do other people think about the new web design? > > Aesthetically and from a readability point of view. > > Please comment. > > > > > > [1] http://www.dillo.org/test/website/dillo2.2.html > > The test page's visited text is easier for me to read than > the home page's visited text. Funny how it's the reverse effect for me! :-) Please test: :visited {color: #403090 !important} and :visited {color: #603060 !important} on http://www.dillo.org/ and FAQ. I prefer the first one because it fits the palette better. -- Cheers Jorge.-

June 24, 2009

patch: viewport keybindings

by jcid＠dillo.org

On Wed, Jun 24, 2009 at 05:13:51AM +0000, corvid wrote: > Here is an idea for viewport keybindings. > > It just builds a SimpleVector once and lets all of the viewports point to it, > which I think goes against the dillo/dw boundary rules, but we'll see how > the general idea goes over... > Well, that's one way to do it... I'm more inclined to have an scrolling keys enum in fltkviewport.hh, and to export another scrollTo() function that receives them as parameter. Then we can catch the shortcut in UI::handle(), and map between KEYS_* and the enum in a function like a_UIcmd_set_scroll_xy(). That avoids stepping over the dillo/dw boundaries. -- Cheers Jorge.-

June 24, 2009

[PATCH] warning: ignoring return value of ???int chdir(const char*)???

by jcid＠dillo.org

On Wed, Jun 24, 2009 at 11:03:26AM +0200, Michal Nowak wrote: > gcc-4.4.0-4.i586 > > HG tip: > > newman src $ make | grep -i warning > [...] > paths.cc: In static member function ???static void Paths::init()???: > paths.cc:38: warning: ignoring return value of ???int chdir(const char*)???, declared with attribute warn_unused_result > > With the patch dillo-guard-chdir.patch no warning. But this > patch alone won't have any effect, all MSG(...) from > Paths::init() won't write anything to output due to > prefs.show_msg not being set to TRUE at that moment. Patch > dillo-use-MSG-asap.patch moves a_Prefs_init() > before Paths::init() is called. Hope it's not breaking > anything. > > Tested > - setting non-existing directory instead of /tmp > - Dillo won't crash on start, basic browsing works Committed. There're also: cookies.c:90: warning: ignoring return value of 'write', cookies.c:249: warning: ignoring return value of 'fgets', dpid.c:754: warning: ignoring return value of 'write' bookmarks.c:696: warning: ignoring return value of 'system' bookmarks.c:698: warning: ignoring return value of 'system' cookies.c:188: warning: ignoring return value of 'write' cookies.c:276: warning: ignoring return value of 'fgets' cookies.c:341: warning: ignoring return value of 'fgets' cookies.c:428: warning: ignoring return value of 'ftruncate' cookies.c:1234: warning: ignoring return value of 'fgets' datauri.c:283: warning: ignoring return value of 'chdir' ftp.c:280: warning: ignoring return value of 'chdir' Can you please make a patch for those too? -- Cheers Jorge.-

June 24, 2009

patch: a binding for stop

by jcid＠dillo.org

On Wed, Jun 24, 2009 at 12:20:54AM +0000, corvid wrote: > How about if we just don't give it any default binding: Committed. -- Cheers Jorge.-

June 24, 2009

patch: save bookmark segfault when dpis not found

by jcid＠dillo.org

On Wed, Jun 24, 2009 at 02:50:17PM +0000, corvid wrote: > A new one seen in the bugtracker... > > a_Bookmarks_chat_add() sets URL to NULL, so it needs to be handled. > > Anyway, the reason this is interesting is that I had always figured > the URL_*() macros were protecting against a NULL URL, when really > they protect against NULL fields in URLs. Right. Please commit (with changelog entry) and update the bug track entry as "done". -- Cheers Jorge.-

June 24, 2009

patch: save bookmark segfault when dpis not found

by corvid＠lavabit.com

A new one seen in the bugtracker... a_Bookmarks_chat_add() sets URL to NULL, so it needs to be handled. Anyway, the reason this is interesting is that I had always figured the URL_*() macros were protecting against a NULL URL, when really they protect against NULL fields in URLs.

June 24, 2009

dillo 2.1

by sandshrew＠gmail.com

On Wed, 24 Jun 2009 14:24:41 +0200 Johannes Hofmann <Johannes.Hofmann(a)gmx.de> wrote: > hg tip now has support for color definitions of the form > rgb(255,255,255). > > Please give it a try. > Thanks. It seems to work ok. I have also tried the patch which makes text wrapping work in textareas ( http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-April/006267.html ). The text does wrap but it doesn't automatically scroll down. Maybe the patch could be committed with some adjustments? -- Brain: an apparatus with which we think we think. - A. Bierce

June 24, 2009