- Dillo-dev - lists.mailman3.com

patch: text-indent

by Johannes.Hofmann＠gmx.de

On Sun, Nov 07, 2010 at 12:43:42AM +0000, corvid wrote: > Johannes wrote: > > On Sat, Nov 06, 2010 at 03:04:16PM +0000, corvid wrote: > > > "Percentage values: refer to parent element's width" > > > > > > So a Textblock wants to decide how big it is, and it asks its children > > > how big they are, and the child has, say, text-indent: 50%, and so it > > > gets to wordWrap and asks "So, ah...how big are _you_?". And the parent > > > doesn't know yet. > > > > Ah interesting.... > > > > What about using something like availWidth in Textblock::wordWrap() as an > > aproximation of the future width of the Textblock? > > Maybe this would be good enough. > > In which cases would this be way off? > > That's a good idea! > It seems to work pretty well in general... Wow nice! >From looking at the specs I think it should use the whole width of the block including margin and padding, like this: indent = misc::roundInt(this->availWidth * core::style::perLengthVal (getStyle()->textIndent)); As far as I can tell firefox is also doing it that way in: <div style="text-indent: 50%; border: 1px solid; padding: 2cm; margin: 2cm"> foo bar </div> Cheers, Johannes PS: Feel free to commit your patch!

Nov. 7, 2010

patch: text-indent

by corvid＠lavabit.com

Johannes wrote: > On Sat, Nov 06, 2010 at 03:04:16PM +0000, corvid wrote: > > "Percentage values: refer to parent element's width" > > > > So a Textblock wants to decide how big it is, and it asks its children > > how big they are, and the child has, say, text-indent: 50%, and so it > > gets to wordWrap and asks "So, ah...how big are _you_?". And the parent > > doesn't know yet. > > Ah interesting.... > > What about using something like availWidth in Textblock::wordWrap() as an > aproximation of the future width of the Textblock? > Maybe this would be good enough. > In which cases would this be way off? That's a good idea! It seems to work pretty well in general... (You will note that this ignores negative values (LENGTH_PERCENTAGE) and allows overflow.)

Nov. 7, 2010

vertical gaps

by jcid＠dillo.org

On Tue, Nov 02, 2010 at 08:59:05PM +0100, Johannes Hofmann wrote: > On Tue, Nov 02, 2010 at 11:02:55AM -0300, Jorge Arellano Cid wrote: > > Hi, > > > > Just noticed large vertical rendering gaps with: > > > > http://www.monotone.ca/ > > > > I'd guess it's: > > padding-bottom: 300em; > margin-bottom: -300em; > > in .box-small style. > I'm not sure what it's supposed to do, but negative margins > currently don't work. Oh, I thought it could be related with the uninitialized values Jeremy reported. > > Note1: dillo-2.1.1 doesn't have the problem > > Probabely because CSS didn't work with multiple classes > (class="box box-small" in this case) back then. Thanks for the explanation. -- Cheers Jorge.-

Nov. 3, 2010

vertical gaps

by Johannes.Hofmann＠gmx.de

On Tue, Nov 02, 2010 at 11:02:55AM -0300, Jorge Arellano Cid wrote: > Hi, > > Just noticed large vertical rendering gaps with: > > http://www.monotone.ca/ > I'd guess it's: padding-bottom: 300em; margin-bottom: -300em; in .box-small style. I'm not sure what it's supposed to do, but negative margins currently don't work. > Note1: dillo-2.1.1 doesn't have the problem Probabely because CSS didn't work with multiple classes (class="box box-small" in this case) back then. Cheers, Johannes

Nov. 2, 2010

vertical gaps

by jcid＠dillo.org

Hi, Just noticed large vertical rendering gaps with: http://www.monotone.ca/ Note1: dillo-2.1.1 doesn't have the problem Note2: I haven't investigated the problem -- Cheers Jorge.-

Nov. 2, 2010

Dillo confused by embedded NULL characters

by corvid＠lavabit.com

Jeremy wrote: > On Sat, Oct 23, 2010 at 09:19:45PM +0000, corvid wrote: > > Jeremy wrote: > > > On Sat, Oct 23, 2010 at 08:02:04PM +0000, corvid wrote: > > > > Jeremy wrote: > > > > > http://makespace.org/ has some NULL characters in its header, > > > > > which causes it to disappear in Dillo. Firefox and links have > > > > > no problems. What's the fix? > > > > > > > > It seems to be showing up fine for me. > > > > > > So it is! It's my local patches that are trying to parse quoted > > > attributes like Firefox that are doing it. > > I have yet to look at it in detail, but I think the problem is that > strcspn() assumes that there are no NULLs in its argument apart from > the terminating NULL so it may give the wrong result when there are > embedded NULLs. The current logic assumes that the return value will > be the index of one of the terminating characters or the index of the > terminating NULL. But here it might be the index of an embedded NULL > which is a case that the current code does not handle. I *suspect* > that Dillo does the right thing more by accident than design. > > > I think the SGML declaration in section 20.1 of the 4.01 spec means > > that NULLs are not legal. > > So we have a choice: do we treat embedded NULLs as undefined > behaviour? If we decide "No, Dillo must handle embedded NULLs in the > 'right' way" then we have to rewrite Html_write_raw() (and possibly > a_Html_parse_entities() and Html_get_javascript_link() too) to not use > strcspn(). Ouch! This seems to be a pretty rare case so maybe it is > not worth the effort? I personally lean toward not handling it if it's illegal in particular because it's so rarely encountered that I imagine we'll forget about it at some point and accidentally make it stop working. PS Speaking of embedded NULLs, we still need to make HTTPS queries with embedded NULLs work properly at some point. (Submit a form with a file input.) a_Dpip_build_cmd() is not built to handle that case.

Oct. 26, 2010

Https remote certificate cannot be verified

by corvid＠lavabit.com

Dennis wrote: > The "The remote certificate cannot be verified (code 20)" dialog popup > window, that presumably pops up when accessing an unverifiable https > site, often pops up many times while loading a page -- probably a > separate instance for each image? Can it not pop up only once? (per > unverifiable https domain?) I think everyone wants that, and we just need someone to put in the work. > (And perhaps the current window title "Choice5" could be a bit more > informative? And maybe there should be an option to save such > certificates to avoid future warnings?) IIRC, adding an option to save certificates would be easy. I was sort of thinking about it once, but my concern was that not too many users would quite understand that they were now trusting something in perpetuity that they shouldn't necessarily. (Maybe making sure that the warning is alarming enough would suffice, though.)

Oct. 26, 2010

Dillo confused by embedded NULL characters

by onepoint＠starurchin.org

On Sat, Oct 23, 2010 at 09:19:45PM +0000, corvid wrote: > Jeremy wrote: > > On Sat, Oct 23, 2010 at 08:02:04PM +0000, corvid wrote: > > > Jeremy wrote: > > > > http://makespace.org/ has some NULL characters in its header, > > > > which causes it to disappear in Dillo. Firefox and links have > > > > no problems. What's the fix? > > > > > > It seems to be showing up fine for me. > > > > So it is! It's my local patches that are trying to parse quoted > > attributes like Firefox that are doing it. I have yet to look at it in detail, but I think the problem is that strcspn() assumes that there are no NULLs in its argument apart from the terminating NULL so it may give the wrong result when there are embedded NULLs. The current logic assumes that the return value will be the index of one of the terminating characters or the index of the terminating NULL. But here it might be the index of an embedded NULL which is a case that the current code does not handle. I *suspect* that Dillo does the right thing more by accident than design. > I think the SGML declaration in section 20.1 of the 4.01 spec means > that NULLs are not legal. So we have a choice: do we treat embedded NULLs as undefined behaviour? If we decide "No, Dillo must handle embedded NULLs in the 'right' way" then we have to rewrite Html_write_raw() (and possibly a_Html_parse_entities() and Html_get_javascript_link() too) to not use strcspn(). Ouch! This seems to be a pretty rare case so maybe it is not worth the effort? Regards, Jeremy Henty

Oct. 26, 2010

Https remote certificate cannot be verified

by dennisn＠dennisn.dyndns.org

The "The remote certificate cannot be verified (code 20)" dialog popup window, that presumably pops up when accessing an unverifiable https site, often pops up many times while loading a page -- probably a separate instance for each image? Can it not pop up only once? (per unverifiable https domain?) (And perhaps the current window title "Choice5" could be a bit more informative? And maybe there should be an option to save such certificates to avoid future warnings?)

Oct. 24, 2010

Dillo confused by embedded NULL characters

by corvid＠lavabit.com

Jeremy wrote: > On Sat, Oct 23, 2010 at 08:02:04PM +0000, corvid wrote: > > Jeremy wrote: > > > http://makespace.org/ has some NULL characters in its header, which > > > causes it to disappear in Dillo. Firefox and links have no problems. > > > What's the fix? > > > > It seems to be showing up fine for me. > > So it is! It's my local patches that are trying to parse quoted > attributes like Firefox that are doing it. Very strange! However, if > you go to http://makespace.org/ and then view the page source, the > result is truncated, even in vanilla Dillo. I think the SGML declaration in section 20.1 of the 4.01 spec means that NULLs are not legal.

Oct. 23, 2010