- Dillo-dev - lists.mailman3.com

What's currently broken in... (Re: [Dillo-dev] 1.3 port)

by corvid＠lavabit.com

Rob wrote: > > Thank you sir. > > As an aside, when I went to build I ran into some trouble. I think this might be an appropriate fix, though one of you fellows will have to confirm: All that C++ makes my head want to explode. :S > > --- old.fltkui.cc 2011-05-16 18:27:23.892000731 -0400+++ fltkui.cc 2011-05-16 18:24:59.000000000 -0400@@ -1022,7 +1022,7 @@ bool FltkOptionMenuResource::isSelected (int index) {- return index == (int)((Fl_Choice *)widget)->mvalue()->user_data();+ return index == (long)((Fl_Choice *)widget)->mvalue()->user_data(); } int FltkOptionMenuResource::getNumberOfItems() > > > > Sorry about the crappy patch - I hardly ever generate those things, and don't really know what the protocol is. I guess I should take some time to learn those things. > > Ouch - that is ugly. ?Have a look here: > http://www3.sympatico.ca/rsquared/lib/patch Patch committed.

May 17, 2011

What's currently broken in... (Re: [Dillo-dev] 1.3 port)

by mr_semantics＠hotmail.com

> Thank you sir. > As an aside, when I went to build I ran into some trouble. I think this might be an appropriate fix, though one of you fellows will have to confirm: All that C++ makes my head want to explode. :S > --- old.fltkui.cc 2011-05-16 18:27:23.892000731 -0400+++ fltkui.cc 2011-05-16 18:24:59.000000000 -0400@@ -1022,7 +1022,7 @@ bool FltkOptionMenuResource::isSelected (int index) {- return index == (int)((Fl_Choice *)widget)->mvalue()->user_data();+ return index == (long)((Fl_Choice *)widget)->mvalue()->user_data(); } int FltkOptionMenuResource::getNumberOfItems() > > Sorry about the crappy patch - I hardly ever generate those things, and don't really know what the protocol is. I guess I should take some time to learn those things. Ouch - that is ugly. ?Have a look here: http://www3.sympatico.ca/rsquared/lib/patch

May 17, 2011

What's currently broken in... (Re: [Dillo-dev] 1.3 port)

by mr_semantics＠hotmail.com

> Fix committed. Thank you sir. As an aside, when I went to build I ran into some trouble. ?I think this might be an appropriate fix, though one of you fellows will have to confirm: ?All that C++ makes my head want to explode. ?:S --- old.fltkui.cc ? ? ? 2011-05-16 18:27:23.892000731 -0400+++ fltkui.cc ? 2011-05-16 18:24:59.000000000 -0400@@ -1022,7 +1022,7 @@??bool FltkOptionMenuResource::isSelected (int index)?{- ? return index == (int)((Fl_Choice *)widget)->mvalue()->user_data();+ ? return index == (long)((Fl_Choice *)widget)->mvalue()->user_data();?}??int FltkOptionMenuResource::getNumberOfItems() Sorry about the crappy patch - I hardly ever generate those things, and don't really know what the protocol is. ?I guess I should take some time to learn those things.

May 17, 2011

What's currently broken in... (Re: [Dillo-dev] 1.3 port)

by corvid＠lavabit.com

Rob wrote: > When using a captcha system, I am unable to select text in order to copy. ?For example, go here: > http://dragcave.net/login > Then click on the IFRAME link. ?Type the words of the challenge into the text field. ?Assuming you have managed to pass as a human, you will be given (on a new page) a key to copy and paste to a field seen on the intial login screen. ?The trouble is that the text cannot be selected. Fix committed. In http://lists.auriga.wearlab.de/pipermail/dillo-dev/2010-March/007408.html , I didn't particularly want to check NumPendingStyleSheets directly from forms, but if anyone wants to make a more respectable interface someday, we can always use it.

May 16, 2011

What's currently broken in... (Re: [Dillo-dev] 1.3 port)

by jcid＠dillo.org

On Mon, May 16, 2011 at 03:20:17AM +0000, corvid wrote: > Jorge wrote: > > On Sun, May 15, 2011 at 06:15:35PM +0000, corvid wrote: > > > > > > - drawing with nested layouts > > > > Any example besides dw-ui-test? > > Any <button> or image input, I think. > The youtube site, for instance, is filled with buttons. Fix committed. Note: there're still problems: 1) The complexbutton doesn't render as an inline element. 2) It takes the whole width. but these are inherited from dillo2. -- Cheers Jorge.-

May 16, 2011

What's currently broken in... (Re: [Dillo-dev] 1.3 port)

by corvid＠lavabit.com

Jorge wrote: > On Sun, May 15, 2011 at 06:15:35PM +0000, corvid wrote: > > > > - drawing with nested layouts > > Any example besides dw-ui-test? Any <button> or image input, I think. The youtube site, for instance, is filled with buttons.

May 16, 2011

configure.in -Wno-unused-parameter

by corvid＠lavabit.com

Jorge wrote: > On Mon, May 16, 2011 at 01:17:45AM +0000, corvid wrote: > > Jorge wrote: > > > On Sun, May 15, 2011 at 10:34:00PM +0000, corvid wrote: > > > > > > > > if eval "test x$GCC = xyes"; then > > > > .. > > > > if test "`echo $CFLAGS | grep '\-W[^a]' 2> /dev/null`" = ""; then > > > > if test "`$CC -v 2>&1 | grep 'version 3'`" != ""; then > > > > CFLAGS="$CFLAGS -W -Wno-unused-parameter" > > > > fi > > > > fi > > > > .. > > > > fi > > > > > > > > It checks for 3.x specifically. > > > > 3.0 came out on June 18, 2001. > > > > > > > > And of course 4.x has been out since...let's see...April 20, 2005. > > > > > > > > 2.95 was still apparently around back in > > > > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-December/001565.html , > > > > which prompted this code at the time. > > > > > > > > Can I rip out the version-checking and make it into an ordinary > > > > case of adding the argument if it isn't already in CFLAGS? > > > > Right after committing it, I thought, "Wait, this is -Wno-unused-parameter, > > not -Wunused-parameter. Why do we want this?" > > Some callbacks don't make use of default parameters and > this option avoids a lot of noise (making it simpler to spot > other warnings). I know we had that one in a_Http_ccc() that is suppressed with a (void)Data2; but I never see any other warnings around.

May 16, 2011

What's currently broken in... (Re: [Dillo-dev] 1.3 port)

by jcid＠dillo.org

On Sun, May 15, 2011 at 06:15:35PM +0000, corvid wrote: > > - drawing with nested layouts Any example besides dw-ui-test? -- Cheers Jorge.-

May 16, 2011

configure.in -Wno-unused-parameter

by jcid＠dillo.org

On Mon, May 16, 2011 at 01:17:45AM +0000, corvid wrote: > Jorge wrote: > > On Sun, May 15, 2011 at 10:34:00PM +0000, corvid wrote: > > > > > > if eval "test x$GCC = xyes"; then > > > .. > > > if test "`echo $CFLAGS | grep '\-W[^a]' 2> /dev/null`" = ""; then > > > if test "`$CC -v 2>&1 | grep 'version 3'`" != ""; then > > > CFLAGS="$CFLAGS -W -Wno-unused-parameter" > > > fi > > > fi > > > .. > > > fi > > > > > > It checks for 3.x specifically. > > > 3.0 came out on June 18, 2001. > > > > > > And of course 4.x has been out since...let's see...April 20, 2005. > > > > > > 2.95 was still apparently around back in > > > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-December/001565.html , > > > which prompted this code at the time. > > > > > > Can I rip out the version-checking and make it into an ordinary > > > case of adding the argument if it isn't already in CFLAGS? > > Right after committing it, I thought, "Wait, this is -Wno-unused-parameter, > not -Wunused-parameter. Why do we want this?" Some callbacks don't make use of default parameters and this option avoids a lot of noise (making it simpler to spot other warnings). > So, new proposal: How about I remove it completely? Currently I use gcc-4.4.3, and somehow the option gets into the compiler parameters, so I guess it makes its job. (I haven't checked without it to be sure). -- Cheers Jorge.-

May 16, 2011

configure.in -Wno-unused-parameter

by mr_semantics＠hotmail.com

> From: corvid(a)lavabit.com > Apparently -Wextra came along in 3.4, which is from 2004. > I personally lean toward leaving it alone unless they give the > impression that they are actually going to remove -W at some point. Yeah - probably best to leave well enough alone, seeing as somewhere someone could ?be trying to build with an older version of gcc. ?If and when the gcc devs break it, then it can be changed accordingly.

May 16, 2011