- Dillo-dev - lists.mailman3.com

ascii string comparison [Re: use C locale for LC_CTYPE]

by Johannes.Hofmann＠gmx.de

On Tue, Nov 08, 2011 at 08:15:57PM +0000, corvid wrote: > Johannes wrote: > > On Tue, Nov 08, 2011 at 05:42:26PM +0000, corvid wrote: > > > I think I'll go with D_ASCII_TOUPPER because the argument gets > > > evaluated more than once, and we don't want nasty surprises. > > > > Hm, not sure what you mean. An inline function should behave just as > > a normal function that's the nice thing about them. > > If I'm in dlib.h and it's C90, can I use inline? I was under the > impression that I couldn't. Argh, I knew there was a catch :-) So all uppercase macros then or just not trying to inline and use a normal function. Cheers, Johannes

Nov. 8, 2011

ascii string comparison [Re: use C locale for LC_CTYPE]

by corvid＠lavabit.com

Johannes wrote: > On Tue, Nov 08, 2011 at 05:42:26PM +0000, corvid wrote: > > I think I'll go with D_ASCII_TOUPPER because the argument gets > > evaluated more than once, and we don't want nasty surprises. > > Hm, not sure what you mean. An inline function should behave just as > a normal function that's the nice thing about them. If I'm in dlib.h and it's C90, can I use inline? I was under the impression that I couldn't.

Nov. 8, 2011

ascii string comparison [Re: use C locale for LC_CTYPE]

by Johannes.Hofmann＠gmx.de

On Tue, Nov 08, 2011 at 05:42:26PM +0000, corvid wrote: > Jorge wrote: > > On Mon, Nov 07, 2011 at 10:25:39PM +0100, Johannes Hofmann wrote: > > > On Sun, Nov 06, 2011 at 08:19:07PM +0000, corvid wrote: > > > > Johannes wrote: > > > > > I'd just go with the approach in your first patch. > > > > > > > > All right then. Do you have any thoughts on what function names > > > > would be least unwieldy / most descriptive / best fitting in > > > > with their surroundings? > > > > > > > > I'm thinking maybe dAsciiToupper() and dStrAsciiCasecmp(). > > > > > > Let's see what others do: > > > > > > * KDE: kAsciiToUpper() [1] > > > * glib: g_ascii_toupper() [2] > > > * ffmpeg: av_toupper() [3] > > > * libevent: evutil_ascii_strcasecmp() [4] > > > > > > So dAsciiToupper() and dStrAsciiCasecmp() look good to me. > > > > +1 > > I think I'll go with D_ASCII_TOUPPER because the argument gets > evaluated more than once, and we don't want nasty surprises. Hm, not sure what you mean. An inline function should behave just as a normal function that's the nice thing about them. Let's test: #include <stdio.h> static inline int test(int i) { return i > 0 ? i - 1 : i; } #define TEST(i) ((i) > 0 ? (i) - 1 : (i)) int main (int argc, char **argv) { int i = atoi(argv[1]); int j = atoi(argv[1]); printf("%d\n", test(i++)); printf("%d\n", TEST(j++)); } ./inline 2 1 2 Cheers, Johannes

Nov. 8, 2011

ascii string comparison [Re: use C locale for LC_CTYPE]

by corvid＠lavabit.com

And *sigh* dStristr -> dStriAsciiStr, which seems more readable than dStrAsciiIStr.

Nov. 8, 2011

ascii string comparison [Re: use C locale for LC_CTYPE]

by corvid＠lavabit.com

Jorge wrote: > On Mon, Nov 07, 2011 at 10:25:39PM +0100, Johannes Hofmann wrote: > > On Sun, Nov 06, 2011 at 08:19:07PM +0000, corvid wrote: > > > Johannes wrote: > > > > I'd just go with the approach in your first patch. > > > > > > All right then. Do you have any thoughts on what function names > > > would be least unwieldy / most descriptive / best fitting in > > > with their surroundings? > > > > > > I'm thinking maybe dAsciiToupper() and dStrAsciiCasecmp(). > > > > Let's see what others do: > > > > * KDE: kAsciiToUpper() [1] > > * glib: g_ascii_toupper() [2] > > * ffmpeg: av_toupper() [3] > > * libevent: evutil_ascii_strcasecmp() [4] > > > > So dAsciiToupper() and dStrAsciiCasecmp() look good to me. > > +1 I think I'll go with D_ASCII_TOUPPER because the argument gets evaluated more than once, and we don't want nasty surprises. (I'm tempted to say "Or ASCII_TOUPPER?", but it'd be nice for the whole topic to come to an end, wouldn't it? :)

Nov. 8, 2011

ascii string comparison [Re: use C locale for LC_CTYPE]

by jcid＠dillo.org

On Mon, Nov 07, 2011 at 10:25:39PM +0100, Johannes Hofmann wrote: > On Sun, Nov 06, 2011 at 08:19:07PM +0000, corvid wrote: > > Johannes wrote: > > > I'd just go with the approach in your first patch. > > > > All right then. Do you have any thoughts on what function names > > would be least unwieldy / most descriptive / best fitting in > > with their surroundings? > > > > I'm thinking maybe dAsciiToupper() and dStrAsciiCasecmp(). > > Let's see what others do: > > * KDE: kAsciiToUpper() [1] > * glib: g_ascii_toupper() [2] > * ffmpeg: av_toupper() [3] > * libevent: evutil_ascii_strcasecmp() [4] > > So dAsciiToupper() and dStrAsciiCasecmp() look good to me. +1 -- Cheers Jorge.-

Nov. 8, 2011

ascii string comparison [Re: use C locale for LC_CTYPE]

by Johannes.Hofmann＠gmx.de

On Sun, Nov 06, 2011 at 08:19:07PM +0000, corvid wrote: > Johannes wrote: > > I'd just go with the approach in your first patch. > > All right then. Do you have any thoughts on what function names > would be least unwieldy / most descriptive / best fitting in > with their surroundings? > > I'm thinking maybe dAsciiToupper() and dStrAsciiCasecmp(). Let's see what others do: * KDE: kAsciiToUpper() [1] * glib: g_ascii_toupper() [2] * ffmpeg: av_toupper() [3] * libevent: evutil_ascii_strcasecmp() [4] So dAsciiToupper() and dStrAsciiCasecmp() look good to me. Cheers, Johannes [1] http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/kascii_8h.html [2] http://developer.gnome.org/glib/2.28/glib-String-Utility-Functions.html [3] http://permalink.gmane.org/gmane.comp.video.ffmpeg.cvs/43420 [4] http://www.wangafu.net/~nickm/libevent-2.0/doxygen/html/util_8h.html

Nov. 7, 2011

ascii string comparison [Re: use C locale for LC_CTYPE]

by corvid＠lavabit.com

Johannes wrote: > I'd just go with the approach in your first patch. All right then. Do you have any thoughts on what function names would be least unwieldy / most descriptive / best fitting in with their surroundings? I'm thinking maybe dAsciiToupper() and dStrAsciiCasecmp().

Nov. 6, 2011

ascii string comparison [Re: use C locale for LC_CTYPE]

by Johannes.Hofmann＠gmx.de

On Sun, Nov 06, 2011 at 04:03:47AM +0000, corvid wrote: > I wrote: > > Johannes wrote: > > > Or maybe > > > test for strncasecmp_l() in configure and provide a custom solution > > > if it doesn't exist? > > > > I'm willing to give that a look as well. At first I was reluctant to > > have extra locale calls when the string functions are so cheap to > > begin with, but... > > I thought the extra argument to the *_l functions was a string like "C", > but it's a locale_t, which also appears to be something new. This makes > it not very nice to simulate. Hmph. I'd just go with the approach in your first patch.

Nov. 6, 2011

ascii string comparison [Re: use C locale for LC_CTYPE]

by corvid＠lavabit.com

I wrote: > Johannes wrote: > > Or maybe > > test for strncasecmp_l() in configure and provide a custom solution > > if it doesn't exist? > > I'm willing to give that a look as well. At first I was reluctant to > have extra locale calls when the string functions are so cheap to > begin with, but... I thought the extra argument to the *_l functions was a string like "C", but it's a locale_t, which also appears to be something new. This makes it not very nice to simulate. Hmph.

Nov. 6, 2011