- Dillo-dev - lists.mailman3.com

Re: Question regarding styling input checkbox element

by Kevin Koster

a1ex-J7K0XVabL0iELgA04lAiVw(a)public.gmane.org wrote: > When using a dark css theme (I like to use a black background), putting > a checkmark in a checkbox is invisible (black). I tried messing around > with style.css with various configurations for input, but it seems > impossible to make the checkmark anything other than black. > > It's not a huge issue, but when editing bookmarks it becomes a little > annoying. I've got visible checkboxes on a black background with this style.css in Dillo 3.2.0: * {color: #00f400} html {background-color: gray !important} body, div, span, nav, p, a, form, h1, h2, h3, h4, h5, h6, ul, ol, li, table, tr, td {background-color: black} img, map {background-color: gray !important} :link {text-decoration: none !important; color: #00f5e8 !important} :visited {text-decoration: none !important; color: #a020f0 !important} That style does make the bookmarks page look pretty odd with its CSS enabled, but it's intended to avoid dark-on-black content on some websites.

May 20, 2025

Re: Question regarding styling input checkbox element

by Rodrigo Arias

Hi, On Tue, May 20, 2025 at 01:33:43PM +0000, a1ex(a)dismail.de wrote: >Hi, > >When using a dark css theme (I like to use a black background), putting >a checkmark in a checkbox is invisible (black). I tried messing around >with style.css with various configurations for input, but it seems >impossible to make the checkmark anything other than black. > >It's not a huge issue, but when editing bookmarks it becomes a little >annoying. > >Any suggestions, or is this just a limitation of the css implementation? For some reason is always hardcoded to be black. Here is making it always red: diff --git a/dw/fltkui.cc b/dw/fltkui.cc index db7c94e2..2d3882d2 100644 --- a/dw/fltkui.cc +++ b/dw/fltkui.cc @@ -1172,7 +1172,7 @@ void FltkToggleButtonResource::setWidgetStyle (Fl_Widget *widget, { FltkResource::setWidgetStyle(widget, style); - widget->selection_color(FL_BLACK); + widget->selection_color(FL_RED); } See commit fa967f233fe6da82a98aaf3e2149d7aa5e1516cc for context, but not sure why is not just inheriting the CSS foreground color. Best, Rodrigo.

May 20, 2025

Question regarding styling input checkbox element

by a1ex＠dismail.de

Hi, When using a dark css theme (I like to use a black background), putting a checkmark in a checkbox is invisible (black). I tried messing around with style.css with various configurations for input, but it seems impossible to make the checkmark anything other than black. It's not a huge issue, but when editing bookmarks it becomes a little annoying. Any suggestions, or is this just a limitation of the css implementation? Thanks, Alex

May 20, 2025

Re: [PATCH] Revert "Use right button to close tabs by default"

by Plasma (David Paul)

On Wed, 30 Apr 2025 22:52:57 +0200 Rodrigo Arias <rodarima(a)gmail.com> wrote: > On Wed, Apr 30, 2025 at 03:31:21PM -0500, Plasma (David Paul) wrote: > >This reverts commit 6392699316bbdfd027862fa28050cd54253f25d4. > >--- > > > >Notes: > > This change addresses two issues: > > > > 1. This restores the ability to close a tab by middle-clicking on > > it. This matches long-supported behaviour of other browsers. > > Since when do we follow what other browsers do? Ok, maybe that wasn't the best way to phrase that. It's not just browsers that support closing a tab by middle-clicking; it is also the standard behaviour in both my IRC client and my graphical text editor (in addition to my other browsers). Dillo having a different default is disorienting in a similar manner (though, admittedly, not to the same severity) as driving a vehicle and discovering that the functions of the pedals are flipped. > > 2. Right-clicking a tab is now no longer a destructive action. > > It is common user expectation that right-clicking may produce a > > contextual menu. This expectation should not result in a lost tab. > > Not interested in this patch, not all systems have 3 mouse button, > specially old netbooks. If you prefer to use the middle button change > the option in dillorc. Alas. -- Plasma

May 1, 2025

Re: [PATCH] Revert "Use right button to close tabs by default"

by Rodrigo Arias

Hi, On Wed, Apr 30, 2025 at 03:31:21PM -0500, Plasma (David Paul) wrote: >This reverts commit 6392699316bbdfd027862fa28050cd54253f25d4. >--- > >Notes: > This change addresses two issues: > > 1. This restores the ability to close a tab by middle-clicking on >it. This matches long-supported behaviour of other browsers. Since when do we follow what other browsers do? > 2. Right-clicking a tab is now no longer a destructive action. It is > common user expectation that right-clicking may produce a >contextual menu. This expectation should not result in a lost tab. Not interested in this patch, not all systems have 3 mouse button, specially old netbooks. If you prefer to use the middle button change the option in dillorc. Rodrigo.

April 30, 2025

[PATCH] Revert "Use right button to close tabs by default"

by Plasma (David Paul)

This reverts commit 6392699316bbdfd027862fa28050cd54253f25d4. --- Notes: This change addresses two issues: 1. This restores the ability to close a tab by middle-clicking on it. This matches long-supported behaviour of other browsers. 2. Right-clicking a tab is now no longer a destructive action. It is common user expectation that right-clicking may produce a contextual menu. This expectation should not result in a lost tab. dillorc | 2 +- src/prefs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dillorc b/dillorc index dbe36f53..a3d22adc 100644 --- a/dillorc +++ b/dillorc @@ -424,7 +424,7 @@ ui_tab_bg_color=#b7beb7 # A mouse's middle click over a tab closes the Tab. # With mousewheel mouses, right click feels way better (set to YES). -#right_click_closes_tab=YES +#right_click_closes_tab=NO # Scroll over tabs (using the mouse wheel) to switch among tabs. # If set to NO, the page will be scrolled instead. diff --git a/src/prefs.c b/src/prefs.c index a57c792c..09b693a2 100644 --- a/src/prefs.c +++ b/src/prefs.c @@ -81,7 +81,7 @@ void a_Prefs_init(void) prefs.load_stylesheets=TRUE; prefs.middle_click_drags_page = TRUE; prefs.middle_click_opens_new_tab = TRUE; - prefs.right_click_closes_tab = TRUE; + prefs.right_click_closes_tab = FALSE; prefs.scroll_switches_tabs = TRUE; prefs.scroll_switches_tabs_reverse = FALSE; prefs.no_proxy = dStrdup(PREFS_NO_PROXY); -- Plasma

April 30, 2025

Re: [PATCH v2] middle click on nav buttons to open in new tab

by Rodrigo Arias

Hi, On Wed, Apr 30, 2025 at 08:37:33PM +0200, Rodrigo Arias wrote: >https://github.com/dillo-browser/dillo/pull/387 > >When the tests pass we can merge it. Merged: To github.com:dillo-browser/dillo.git e6364911..19559f53 master -> master Best, Rodrigo.

April 30, 2025

Re: [PATCH v2] middle click on nav buttons to open in new tab

by Rodrigo Arias

Hi, On Wed, Apr 30, 2025 at 05:01:28PM +0000, a1ex(a)dismail.de wrote: >Hi, > >Here is an updated version of the patch which addresses most of >Rodrigos comments. Not sure how much more I can improve on it, but open >to suggestions. Thanks, it looks good. I reworded the documentation and moved it to the history section. See: https://github.com/dillo-browser/dillo/pull/387 When the tests pass we can merge it. Best, Rodrigo.

April 30, 2025

[PATCH v2] middle click on nav buttons to open in new tab

by a1ex＠dismail.de

Hi, Here is an updated version of the patch which addresses most of Rodrigos comments. Not sure how much more I can improve on it, but open to suggestions. Regards, Alex diff -upr a/doc/user_help.in.html b/doc/user_help.in.html --- a/doc/user_help.in.html Sun Apr 27 18:56:44 2025 +++ b/doc/user_help.in.html Wed Apr 30 16:47:28 2025 @@ -349,6 +349,9 @@ pressed while left-clicking a link. The same applies t form. A new tab can also be opened from the <code>File</code> menu or using the shortcut <code>Ctrl+T</code>. +To open the previous page in a new tab, middle-click the back button. To open +the next page in a new tab, middle-click the forward button. + Press <code>Shift</code> while opening a page in a new tab to focus the tab. If you want this behaviour to be the default, set the following option in the <a href="#dillorc">dillorc</a> configuration file: diff -upr a/src/nav.c b/src/nav.c --- a/src/nav.c Sun Apr 27 18:56:44 2025 +++ b/src/nav.c Wed Apr 30 16:49:55 2025 @@ -447,6 +447,19 @@ void a_Nav_back(BrowserWindow *bw) } /* + * Send the browser back to previous page in new tab + */ +void a_Nav_back_nt(BrowserWindow *bw) +{ + int idx = a_Nav_stack_ptr(bw); + + if (--idx >= 0){ + a_UIcmd_set_msg(bw, ""); + a_UIcmd_open_url_nt(bw, a_History_get_url(NAV_UIDX(bw, idx)), -1); + } +} + +/* * Send the browser to next page in the history list */ void a_Nav_forw(BrowserWindow *bw) @@ -457,6 +470,19 @@ void a_Nav_forw(BrowserWindow *bw) if (++idx < a_Nav_stack_size(bw)) { a_UIcmd_set_msg(bw, ""); Nav_open_url(bw, a_History_get_url(NAV_UIDX(bw,idx)), NULL, +1); + } +} + +/* + * Send the browser to next page in the history list in new tab + */ +void a_Nav_forw_nt(BrowserWindow *bw) +{ + int idx = a_Nav_stack_ptr(bw); + + if (++idx < a_Nav_stack_size(bw)) { + a_UIcmd_set_msg(bw, ""); + a_UIcmd_open_url_nt(bw, a_History_get_url(NAV_UIDX(bw, idx)), +1); } } diff -upr a/src/nav.h b/src/nav.h --- a/src/nav.h Sun Apr 27 18:56:44 2025 +++ b/src/nav.h Wed Apr 30 16:49:55 2025 @@ -18,7 +18,9 @@ void a_Nav_push(BrowserWindow *bw, const DilloUrl *url const DilloUrl *requester); void a_Nav_repush(BrowserWindow *bw); void a_Nav_back(BrowserWindow *bw); +void a_Nav_back_nt(BrowserWindow *bw); void a_Nav_forw(BrowserWindow *bw); +void a_Nav_forw_nt(BrowserWindow *bw); void a_Nav_home(BrowserWindow *bw); void a_Nav_reload(BrowserWindow *bw); void a_Nav_jump(BrowserWindow *bw, int offset, int new_bw); diff -upr a/src/ui.cc b/src/ui.cc --- a/src/ui.cc Sun Apr 27 18:56:44 2025 +++ b/src/ui.cc Wed Apr 30 16:49:55 2025 @@ -312,6 +312,8 @@ static void b1_cb(Fl_Widget *wid, void *cb_data) case UI_BACK: if (b == FL_LEFT_MOUSE) { a_UIcmd_back(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_MIDDLE_MOUSE) { + a_UIcmd_back_nt(a_UIcmd_get_bw_by_widget(wid)); } else if (b == FL_RIGHT_MOUSE) { a_UIcmd_back_popup(a_UIcmd_get_bw_by_widget(wid), wid->x(), wid->y() + wid->h()); @@ -320,6 +322,8 @@ static void b1_cb(Fl_Widget *wid, void *cb_data) case UI_FORW: if (b == FL_LEFT_MOUSE) { a_UIcmd_forw(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_MIDDLE_MOUSE) { + a_UIcmd_forw_nt(a_UIcmd_get_bw_by_widget(wid)); } else if (b == FL_RIGHT_MOUSE) { a_UIcmd_forw_popup(a_UIcmd_get_bw_by_widget(wid), wid->x(), wid->y() + wid->h()); diff -upr a/src/uicmd.cc b/src/uicmd.cc --- a/src/uicmd.cc Sun Apr 27 18:56:44 2025 +++ b/src/uicmd.cc Wed Apr 30 16:49:55 2025 @@ -868,6 +868,14 @@ void a_UIcmd_back(void *vbw) } /* + * Send the browser back to previous page in a new tab + */ +void a_UIcmd_back_nt(void *vbw) +{ + a_Nav_back_nt((BrowserWindow*)vbw); +} + +/* * Popup the navigation menu of the Back button */ void a_UIcmd_back_popup(void *vbw, int x, int y) @@ -881,6 +889,14 @@ void a_UIcmd_back_popup(void *vbw, int x, int y) void a_UIcmd_forw(void *vbw) { a_Nav_forw((BrowserWindow*)vbw); +} + +/* + * Send the browser to next page in the history list in new tab + */ +void a_UIcmd_forw_nt(void *vbw) +{ + a_Nav_forw_nt((BrowserWindow*)vbw); } /* diff -upr a/src/uicmd.hh b/src/uicmd.hh --- a/src/uicmd.hh Sun Apr 27 18:56:44 2025 +++ b/src/uicmd.hh Wed Apr 30 16:49:55 2025 @@ -29,8 +29,10 @@ void a_UIcmd_open_url(BrowserWindow *bw, const DilloUr void a_UIcmd_open_url_nw(BrowserWindow *bw, const DilloUrl *url); void a_UIcmd_open_url_nt(void *vbw, const DilloUrl *url, int focus); void a_UIcmd_back(void *vbw); +void a_UIcmd_back_nt(void *vbw); void a_UIcmd_back_popup(void *vbw, int x, int y); void a_UIcmd_forw(void *vbw); +void a_UIcmd_forw_nt(void *vbw); void a_UIcmd_forw_popup(void *vbw, int x, int y); void a_UIcmd_home(void *vbw); void a_UIcmd_zoom_in(void *vbw); diff -upr a/doc/user_help.in.html b/doc/user_help.in.html --- a/doc/user_help.in.html Sun Apr 27 18:56:44 2025 +++ b/doc/user_help.in.html Wed Apr 30 16:47:28 2025 @@ -349,6 +349,9 @@ pressed while left-clicking a link. The same applies t form. A new tab can also be opened from the <code>File</code> menu or using the shortcut <code>Ctrl+T</code>. +To open the previous page in a new tab, middle-click the back button. To open +the next page in a new tab, middle-click the forward button. + Press <code>Shift</code> while opening a page in a new tab to focus the tab. If you want this behaviour to be the default, set the following option in the <a href="#dillorc">dillorc</a> configuration file: diff -upr a/src/nav.c b/src/nav.c --- a/src/nav.c Sun Apr 27 18:56:44 2025 +++ b/src/nav.c Wed Apr 30 16:49:55 2025 @@ -447,6 +447,19 @@ void a_Nav_back(BrowserWindow *bw) } /* + * Send the browser back to previous page in new tab + */ +void a_Nav_back_nt(BrowserWindow *bw) +{ + int idx = a_Nav_stack_ptr(bw); + + if (--idx >= 0){ + a_UIcmd_set_msg(bw, ""); + a_UIcmd_open_url_nt(bw, a_History_get_url(NAV_UIDX(bw, idx)), -1); + } +} + +/* * Send the browser to next page in the history list */ void a_Nav_forw(BrowserWindow *bw) @@ -457,6 +470,19 @@ void a_Nav_forw(BrowserWindow *bw) if (++idx < a_Nav_stack_size(bw)) { a_UIcmd_set_msg(bw, ""); Nav_open_url(bw, a_History_get_url(NAV_UIDX(bw,idx)), NULL, +1); + } +} + +/* + * Send the browser to next page in the history list in new tab + */ +void a_Nav_forw_nt(BrowserWindow *bw) +{ + int idx = a_Nav_stack_ptr(bw); + + if (++idx < a_Nav_stack_size(bw)) { + a_UIcmd_set_msg(bw, ""); + a_UIcmd_open_url_nt(bw, a_History_get_url(NAV_UIDX(bw, idx)), +1); } } diff -upr a/src/nav.h b/src/nav.h --- a/src/nav.h Sun Apr 27 18:56:44 2025 +++ b/src/nav.h Wed Apr 30 16:49:55 2025 @@ -18,7 +18,9 @@ void a_Nav_push(BrowserWindow *bw, const DilloUrl *url const DilloUrl *requester); void a_Nav_repush(BrowserWindow *bw); void a_Nav_back(BrowserWindow *bw); +void a_Nav_back_nt(BrowserWindow *bw); void a_Nav_forw(BrowserWindow *bw); +void a_Nav_forw_nt(BrowserWindow *bw); void a_Nav_home(BrowserWindow *bw); void a_Nav_reload(BrowserWindow *bw); void a_Nav_jump(BrowserWindow *bw, int offset, int new_bw); diff -upr a/src/ui.cc b/src/ui.cc --- a/src/ui.cc Sun Apr 27 18:56:44 2025 +++ b/src/ui.cc Wed Apr 30 16:49:55 2025 @@ -312,6 +312,8 @@ static void b1_cb(Fl_Widget *wid, void *cb_data) case UI_BACK: if (b == FL_LEFT_MOUSE) { a_UIcmd_back(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_MIDDLE_MOUSE) { + a_UIcmd_back_nt(a_UIcmd_get_bw_by_widget(wid)); } else if (b == FL_RIGHT_MOUSE) { a_UIcmd_back_popup(a_UIcmd_get_bw_by_widget(wid), wid->x(), wid->y() + wid->h()); @@ -320,6 +322,8 @@ static void b1_cb(Fl_Widget *wid, void *cb_data) case UI_FORW: if (b == FL_LEFT_MOUSE) { a_UIcmd_forw(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_MIDDLE_MOUSE) { + a_UIcmd_forw_nt(a_UIcmd_get_bw_by_widget(wid)); } else if (b == FL_RIGHT_MOUSE) { a_UIcmd_forw_popup(a_UIcmd_get_bw_by_widget(wid), wid->x(), wid->y() + wid->h()); diff -upr a/src/uicmd.cc b/src/uicmd.cc --- a/src/uicmd.cc Sun Apr 27 18:56:44 2025 +++ b/src/uicmd.cc Wed Apr 30 16:49:55 2025 @@ -868,6 +868,14 @@ void a_UIcmd_back(void *vbw) } /* + * Send the browser back to previous page in a new tab + */ +void a_UIcmd_back_nt(void *vbw) +{ + a_Nav_back_nt((BrowserWindow*)vbw); +} + +/* * Popup the navigation menu of the Back button */ void a_UIcmd_back_popup(void *vbw, int x, int y) @@ -881,6 +889,14 @@ void a_UIcmd_back_popup(void *vbw, int x, int y) void a_UIcmd_forw(void *vbw) { a_Nav_forw((BrowserWindow*)vbw); +} + +/* + * Send the browser to next page in the history list in new tab + */ +void a_UIcmd_forw_nt(void *vbw) +{ + a_Nav_forw_nt((BrowserWindow*)vbw); } /* diff -upr a/src/uicmd.hh b/src/uicmd.hh --- a/src/uicmd.hh Sun Apr 27 18:56:44 2025 +++ b/src/uicmd.hh Wed Apr 30 16:49:55 2025 @@ -29,8 +29,10 @@ void a_UIcmd_open_url(BrowserWindow *bw, const DilloUr void a_UIcmd_open_url_nw(BrowserWindow *bw, const DilloUrl *url); void a_UIcmd_open_url_nt(void *vbw, const DilloUrl *url, int focus); void a_UIcmd_back(void *vbw); +void a_UIcmd_back_nt(void *vbw); void a_UIcmd_back_popup(void *vbw, int x, int y); void a_UIcmd_forw(void *vbw); +void a_UIcmd_forw_nt(void *vbw); void a_UIcmd_forw_popup(void *vbw, int x, int y); void a_UIcmd_home(void *vbw); void a_UIcmd_zoom_in(void *vbw);

April 30, 2025

Re: [PATCH] Middle-click on back button to open prev. page in new tab

by Rodrigo Arias

Hi, >But, I think it's still useful to have, since now the action can be >performed with just 1 click, instead of 2. Also browsers like Firefox >offer the middle-click back feature like this, so it might be more >intuitive for some users. I think it makes sense for Dillo to behave in that way as well. However, the current patch needs some changes. See below: >diff -upr a/src/nav.c b/src/nav.c >--- a/src/nav.c Mon Apr 21 21:42:32 2025 >+++ b/src/nav.c Sun Apr 27 10:11:36 2025 >@@ -447,6 +447,20 @@ void a_Nav_back(BrowserWindow *bw) > } > > /* >+ * Send the browser back to previous page in new tab >+ */ >+void a_Nav_back_nt(BrowserWindow *bw) >+{ >+ int idx = a_Nav_stack_ptr(bw); >+ >+ a_Nav_cancel_expect(bw); I think you don't want to a_Nav_cancel_expect(), as this will make the current tab stop loading. >+ if (--idx >= 0){ >+ a_UIcmd_set_msg(bw, ""); >+ a_UIcmd_open_url_nt(bw, a_History_get_url(NAV_UIDX(bw,idx)), -1); ^add space The problem with this approach is that the newly opened tab lacks the history of the previous tab. The same problem happens with the current mechanism by opening the history menu and middle clicking an item, but it would be nice to keep it if not too hard. This new behavior needs to be added to doc/user_help.in.html as well, as otherwise it will be hard to guess. >+ } >+} >+ >+/* > * Send the browser to next page in the history list > */ > void a_Nav_forw(BrowserWindow *bw) >diff -upr a/src/nav.h b/src/nav.h >--- a/src/nav.h Mon Apr 21 21:42:32 2025 >+++ b/src/nav.h Sun Apr 27 10:12:00 2025 >@@ -18,6 +18,7 @@ void a_Nav_push(BrowserWindow *bw, const DilloUrl *url > const DilloUrl *requester); > void a_Nav_repush(BrowserWindow *bw); > void a_Nav_back(BrowserWindow *bw); >+void a_Nav_back_nt(BrowserWindow *bw); > void a_Nav_forw(BrowserWindow *bw); We probably should add another one for the forward button too, right? > void a_Nav_home(BrowserWindow *bw); > void a_Nav_reload(BrowserWindow *bw); >diff -upr a/src/ui.cc b/src/ui.cc >--- a/src/ui.cc Mon Apr 21 21:42:32 2025 >+++ b/src/ui.cc Sun Apr 27 10:13:45 2025 >@@ -312,6 +312,8 @@ static void b1_cb(Fl_Widget *wid, void *cb_data) > case UI_BACK: > if (b == FL_LEFT_MOUSE) { > a_UIcmd_back(a_UIcmd_get_bw_by_widget(wid)); >+ } else if (b == FL_MIDDLE_MOUSE) { >+ a_UIcmd_back_nt(a_UIcmd_get_bw_by_widget(wid)); > } else if (b == FL_RIGHT_MOUSE) { > a_UIcmd_back_popup(a_UIcmd_get_bw_by_widget(wid), wid->x(), > wid->y() + wid->h()); >diff -upr a/src/uicmd.cc b/src/uicmd.cc >--- a/src/uicmd.cc Mon Apr 21 21:42:32 2025 >+++ b/src/uicmd.cc Sun Apr 27 10:12:30 2025 >@@ -868,6 +868,14 @@ void a_UIcmd_back(void *vbw) > } > > /* >+ * Send the browser back to previous page in a new tab >+ */ >+void a_UIcmd_back_nt(void *vbw) >+{ >+ a_Nav_back_nt((BrowserWindow*)vbw); >+} >+ >+/* > * Popup the navigation menu of the Back button > */ > void a_UIcmd_back_popup(void *vbw, int x, int y) >diff -upr a/src/uicmd.hh b/src/uicmd.hh >--- a/src/uicmd.hh Mon Apr 21 21:42:32 2025 >+++ b/src/uicmd.hh Sun Apr 27 10:12:51 2025 >@@ -29,6 +29,7 @@ void a_UIcmd_open_url(BrowserWindow *bw, const DilloUr > void a_UIcmd_open_url_nw(BrowserWindow *bw, const DilloUrl *url); > void a_UIcmd_open_url_nt(void *vbw, const DilloUrl *url, int focus); > void a_UIcmd_back(void *vbw); >+void a_UIcmd_back_nt(void *vbw); > void a_UIcmd_back_popup(void *vbw, int x, int y); > void a_UIcmd_forw(void *vbw); > void a_UIcmd_forw_popup(void *vbw, int x, int y); >

April 28, 2025