- Dillo-dev - lists.mailman3.com

here's 3.0.4.1 RC1

by jcid＠dillo.org

On Mon, Dec 08, 2014 at 11:07:48PM -0300, Jorge Arellano Cid wrote: > Hi Sebastian, > > On Mon, Dec 08, 2014 at 12:40:48PM +0100, Sebastian Geerken wrote: > > On Mon, Dec 08, 2014, v4hn wrote: > > > On Mon, Dec 08, 2014 at 01:11:38AM +0100, Sebastian Geerken wrote: > > > > On Mon, Dec 08, 2014, v4hn wrote: > > > > > Talking about bugs... I just found out this version segfaults over here > > > > > if I enter any string containing a space character. For example entering > > > > > "foo bar" into the adress line and hitting enter segfaults over here. > > > > > Can anyone reproduce this? > > > > > > > > Yes, if and only if "search_url" is not defined. (I'm happy with DDG.) > > > > This bug occurs already in release 3.0.4. > > > > > > Yes, setting search_url makes the bug disappear. Thanks for investigating! > > > > It seems that this change fixes it: > > > > ---------------------------------------------------------------------- > > diff -r 9aa37b81c609 src/prefs.c > > --- a/src/prefs.c Tue Dec 02 16:33:49 2014 +0100 > > +++ b/src/prefs.c Mon Dec 08 12:37:15 2014 +0100 > > @@ -18,7 +18,7 @@ > > #define PREFS_FONT_CURSIVE "URW Chancery L" > > #define PREFS_FONT_FANTASY "DejaVu Sans" /* TODO: find good default */ > > #define PREFS_FONT_MONOSPACE "DejaVu Sans Mono" > > -#define PREFS_SEARCH_URL "http://duckduckgo.com/lite/?kp=-1&q=%s" > > +#define PREFS_SEARCH_URL "dd http://duckduckgo.com/lite/?kp=-1&q=%s" > > #define PREFS_NO_PROXY "localhost 127.0.0.1" > > #define PREFS_SAVE_DIR "/tmp/" > > #define PREFS_HTTP_REFERER "host" > > @@ -82,7 +82,6 @@ > > prefs.save_dir = dStrdup(PREFS_SAVE_DIR); > > prefs.search_urls = dList_new(16); > > dList_append(prefs.search_urls, dStrdup(PREFS_SEARCH_URL)); > > - dList_append(prefs.search_urls, NULL); /* flags a default search URL */ > > prefs.search_url_idx = 0; > > prefs.show_back = TRUE; > > prefs.show_bookmarks = TRUE; > > ---------------------------------------------------------------------- > > > > Not committed yet, since I'm not sure about the rationale. > > I'd also add: > > diff -r 978377ed5605 src/uicmd.cc > --- a/src/uicmd.cc Mon Dec 08 15:32:25 2014 +0100 > +++ b/src/uicmd.cc Mon Dec 08 22:58:53 2014 -0300 > @@ -682,7 +682,7 @@ static char *UIcmd_find_search_str(const > for (p = 0; p < dList_length(prefs.search_urls); p++) { > const char *search = > (const char *)dList_nth_data(prefs.search_urls, p); > - if (strncasecmp(str, search, len) == 0) { > + if (search && strncasecmp(str, search, len) == 0) { > prefs.search_url_idx = p; > url = UIcmd_make_search_str(str + len + 1); > break; > > (which solves the problem alone), but the cleanups above look > OK to me since AFAICS: > > * dd as default prefix for the DDG URL is fine. > * the NULL flag item is not used anymore. > * dialog.cc explicitly adds the extra item for menu building (n_it+1), > so the decreased number of elements is safe. Committed. @corvid: AFAICS it landed in the 3.0.4.1 branch as intended ;) BTW, now the patch is mentioned in the ChangeLog, but not in the splash screen (not sure what's better, no strong feeling either). If there're no more issues with 3.0.4.1, we may pack rc2 after some feedback. -- Cheers Jorge.-

Dec. 10, 2014

here's 3.0.4.1 RC1

by jcid＠dillo.org

Hi Sebastian, On Mon, Dec 08, 2014 at 12:40:48PM +0100, Sebastian Geerken wrote: > On Mon, Dec 08, 2014, v4hn wrote: > > On Mon, Dec 08, 2014 at 01:11:38AM +0100, Sebastian Geerken wrote: > > > On Mon, Dec 08, 2014, v4hn wrote: > > > > Talking about bugs... I just found out this version segfaults over here > > > > if I enter any string containing a space character. For example entering > > > > "foo bar" into the adress line and hitting enter segfaults over here. > > > > Can anyone reproduce this? > > > > > > Yes, if and only if "search_url" is not defined. (I'm happy with DDG.) > > > This bug occurs already in release 3.0.4. > > > > Yes, setting search_url makes the bug disappear. Thanks for investigating! > > It seems that this change fixes it: > > ---------------------------------------------------------------------- > diff -r 9aa37b81c609 src/prefs.c > --- a/src/prefs.c Tue Dec 02 16:33:49 2014 +0100 > +++ b/src/prefs.c Mon Dec 08 12:37:15 2014 +0100 > @@ -18,7 +18,7 @@ > #define PREFS_FONT_CURSIVE "URW Chancery L" > #define PREFS_FONT_FANTASY "DejaVu Sans" /* TODO: find good default */ > #define PREFS_FONT_MONOSPACE "DejaVu Sans Mono" > -#define PREFS_SEARCH_URL "http://duckduckgo.com/lite/?kp=-1&q=%s" > +#define PREFS_SEARCH_URL "dd http://duckduckgo.com/lite/?kp=-1&q=%s" > #define PREFS_NO_PROXY "localhost 127.0.0.1" > #define PREFS_SAVE_DIR "/tmp/" > #define PREFS_HTTP_REFERER "host" > @@ -82,7 +82,6 @@ > prefs.save_dir = dStrdup(PREFS_SAVE_DIR); > prefs.search_urls = dList_new(16); > dList_append(prefs.search_urls, dStrdup(PREFS_SEARCH_URL)); > - dList_append(prefs.search_urls, NULL); /* flags a default search URL */ > prefs.search_url_idx = 0; > prefs.show_back = TRUE; > prefs.show_bookmarks = TRUE; > ---------------------------------------------------------------------- > > Not committed yet, since I'm not sure about the rationale. I'd also add: diff -r 978377ed5605 src/uicmd.cc --- a/src/uicmd.cc Mon Dec 08 15:32:25 2014 +0100 +++ b/src/uicmd.cc Mon Dec 08 22:58:53 2014 -0300 @@ -682,7 +682,7 @@ static char *UIcmd_find_search_str(const for (p = 0; p < dList_length(prefs.search_urls); p++) { const char *search = (const char *)dList_nth_data(prefs.search_urls, p); - if (strncasecmp(str, search, len) == 0) { + if (search && strncasecmp(str, search, len) == 0) { prefs.search_url_idx = p; url = UIcmd_make_search_str(str + len + 1); break; (which solves the problem alone), but the cleanups above look OK to me since AFAICS: * dd as default prefix for the DDG URL is fine. * the NULL flag item is not used anymore. * dialog.cc explicitly adds the extra item for menu building (n_it+1), so the decreased number of elements is safe. -- Cheers Jorge.-

Dec. 9, 2014

here's 3.0.4.1 RC1

by eocene＠gmx.com

v4hn wrote: > On Mon, Dec 08, 2014 at 04:13:44PM +0100, Johannes Hofmann wrote: > > Cool. If somebody confirms, that it doesn't break setups that worked > > before, I will commit it tonight. > > I already confirmed that for one setup :) I haven't seen any breakage either...

Dec. 8, 2014

here's 3.0.4.1 RC1

by me＠v4hn.de

On Mon, Dec 08, 2014 at 04:13:44PM +0100, Johannes Hofmann wrote: > Cool. If somebody confirms, that it doesn't break setups that worked > before, I will commit it tonight. I already confirmed that for one setup :) v4hn

Dec. 8, 2014

here's 3.0.4.1 RC1

by johannes.hofmann＠gmx.de

On Mon, Dec 08, 2014 at 01:46:37PM +0100, Jan Diegelmann wrote: > Johannes Hofmann wrote: > > >I have a fix that works on my system so far: > > Works also for Irix. Thanks for your patch. Cool. If somebody confirms, that it doesn't break setups that worked before, I will commit it tonight. Cheers, Johannes

Dec. 8, 2014

here's 3.0.4.1 RC1

by diegel＠work.de

Johannes Hofmann wrote: > I have a fix that works on my system so far: Works also for Irix. Thanks for your patch.

Dec. 8, 2014

here's 3.0.4.1 RC1

by sgeerken＠dillo.org

On Mon, Dec 08, 2014, v4hn wrote: > On Mon, Dec 08, 2014 at 01:11:38AM +0100, Sebastian Geerken wrote: > > On Mon, Dec 08, 2014, v4hn wrote: > > > Talking about bugs... I just found out this version segfaults over here > > > if I enter any string containing a space character. For example entering > > > "foo bar" into the adress line and hitting enter segfaults over here. > > > Can anyone reproduce this? > > > > Yes, if and only if "search_url" is not defined. (I'm happy with DDG.) > > This bug occurs already in release 3.0.4. > > Yes, setting search_url makes the bug disappear. Thanks for investigating! It seems that this change fixes it: ---------------------------------------------------------------------- diff -r 9aa37b81c609 src/prefs.c --- a/src/prefs.c Tue Dec 02 16:33:49 2014 +0100 +++ b/src/prefs.c Mon Dec 08 12:37:15 2014 +0100 @@ -18,7 +18,7 @@ #define PREFS_FONT_CURSIVE "URW Chancery L" #define PREFS_FONT_FANTASY "DejaVu Sans" /* TODO: find good default */ #define PREFS_FONT_MONOSPACE "DejaVu Sans Mono" -#define PREFS_SEARCH_URL "http://duckduckgo.com/lite/?kp=-1&q=%s" +#define PREFS_SEARCH_URL "dd http://duckduckgo.com/lite/?kp=-1&q=%s" #define PREFS_NO_PROXY "localhost 127.0.0.1" #define PREFS_SAVE_DIR "/tmp/" #define PREFS_HTTP_REFERER "host" @@ -82,7 +82,6 @@ prefs.save_dir = dStrdup(PREFS_SAVE_DIR); prefs.search_urls = dList_new(16); dList_append(prefs.search_urls, dStrdup(PREFS_SEARCH_URL)); - dList_append(prefs.search_urls, NULL); /* flags a default search URL */ prefs.search_url_idx = 0; prefs.show_back = TRUE; prefs.show_bookmarks = TRUE; ---------------------------------------------------------------------- Not committed yet, since I'm not sure about the rationale. Sebastian

Dec. 8, 2014

here's 3.0.4.1 RC1

by me＠v4hn.de

On Mon, Dec 08, 2014 at 01:11:38AM +0100, Sebastian Geerken wrote: > On Mon, Dec 08, 2014, v4hn wrote: > > Talking about bugs... I just found out this version segfaults over here > > if I enter any string containing a space character. For example entering > > "foo bar" into the adress line and hitting enter segfaults over here. > > Can anyone reproduce this? > > Yes, if and only if "search_url" is not defined. (I'm happy with DDG.) > This bug occurs already in release 3.0.4. Yes, setting search_url makes the bug disappear. Thanks for investigating! v4hn

Dec. 8, 2014

here's 3.0.4.1 RC1

by sgeerken＠dillo.org

On Mon, Dec 08, 2014, v4hn wrote: > On Wed, Dec 03, 2014 at 12:13:08AM +0000, eocene wrote: > > Even though 3.0.4.1 only has a few changes, it's nice to have an RC and > > make sure that everything is all right, so: > > > > http://www.dillo.org/download/dillo-3.0.4.1-rc1.tar.bz2 > > Talking about bugs... I just found out this version segfaults over here > if I enter any string containing a space character. For example entering > "foo bar" into the adress line and hitting enter segfaults over here. > Can anyone reproduce this? Yes, if and only if "search_url" is not defined. (I'm happy with DDG.) This bug occurs already in release 3.0.4. Segfault is in UIcmd_find_search_str, with these values: (gdb) p dList_length(prefs.search_urls) $1 = 2 (gdb) p (char*)dList_nth_data(prefs.search_urls, 0) $2 = 0x710f40 "http://duckduckgo.com/lite/?kp=-1&q=%s" (gdb) p (char*)dList_nth_data(prefs.search_urls, 1) $3 = 0x0 Sebastian

Dec. 8, 2014

here's 3.0.4.1 RC1

by higuita7＠yahoo.co.uk

Hi On Mon, 8 Dec 2014 00:28:08 +0100, v4hn <me at v4hn.de> wrote: > Talking about bugs... I just found out this version segfaults over here > if I enter any string containing a space character. For example entering > "foo bar" into the adress line and hitting enter segfaults over here. > Can anyone reproduce this? Works fine here, linux 64bit, fltk 1.3.3 higuita -- Naturally the common people don't want war... but after all it is the leaders of a country who determine the policy, and it is always a simple matter to drag the people along, whether it is a democracy, or a fascist dictatorship, or a parliament, or a communist dictatorship. Voice or no voice, the people can always be brought to the bidding of the leaders. That is easy. All you have to do is tell them they are being attacked, and denounce the pacifists for lack of patriotism and exposing the country to danger. It works the same in every country. -- Hermann Goering, Nazi and war criminal, 1883-1946

Dec. 8, 2014