- Dillo-dev - lists.mailman3.com

--xid option

by corvid＠lavabit.com

Johannes wrote: > On Fri, May 29, 2009 at 04:25:18PM -0400, Jorge Arellano Cid wrote: > > On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote: > > > Jorge wrote: > > > > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > > > > Of course naturally I think, "I hope my MSG macros count as polishing... > > > > > I hope my UTF-8 file.c code counts as polishing..." > > > > > > > > Send them to me when they're ready. > > > > > > It looks like I sent the UTF-8 one on the 17th, and > > > the MSG macros on the 16th, with another mail on the > > > 18th discovering that, whatever the gnu info text might say, > > > "" is safer than an empty argument. > > > > Both committed (thanks for the bump). > > > > @all: please compile test. > > Is this non_ascci instead of non_ascii in misc.c a typo? I've always left it alone when working in that bit of the code (either in misc or in file) under the assumption that it dated back to prehistory and therefore had become 'venerable' somehow, but the cvs log shows it only being introduced in 2006.

May 29, 2009

--xid option

by Johannes.Hofmann＠gmx.de

On Fri, May 29, 2009 at 04:25:18PM -0400, Jorge Arellano Cid wrote: > On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote: > > Jorge wrote: > > > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > > > Of course naturally I think, "I hope my MSG macros count as polishing... > > > > I hope my UTF-8 file.c code counts as polishing..." > > > > > > Send them to me when they're ready. > > > > It looks like I sent the UTF-8 one on the 17th, and > > the MSG macros on the 16th, with another mail on the > > 18th discovering that, whatever the gnu info text might say, > > "" is safer than an empty argument. > > Both committed (thanks for the bump). > > @all: please compile test. Is this non_ascci instead of non_ascii in misc.c a typo? Cheers, Johannes PS: Compiles fine here.

May 29, 2009

--xid option

by jcid＠dillo.org

On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote: > Jorge wrote: > > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > > Of course naturally I think, "I hope my MSG macros count as polishing... > > > I hope my UTF-8 file.c code counts as polishing..." > > > > Send them to me when they're ready. > > It looks like I sent the UTF-8 one on the 17th, and > the MSG macros on the 16th, with another mail on the > 18th discovering that, whatever the gnu info text might say, > "" is safer than an empty argument. Both committed (thanks for the bump). @all: please compile test. -- Cheers Jorge.-

May 29, 2009

patch: a binding for stop

by corvid＠lavabit.com

Jorge wrote: > On Fri, May 29, 2009 at 02:39:04AM +0000, corvid wrote: > > > I don't like much Esc for stop, but if that's FFs default, > > > it may be better than another (as the Ctrl-x clash you spot). > > > Afterall this is what configurable keybindings is suppossed to > > > solve so Esc is OK for me as default. > > > > I'll have to rip out the mysterious HIDE_PANELS in order to > > take back Escape which it is using. > > AFAIS, in the sense of: > > > What is the purpose of KEYS_HIDE_PANELS when we have KEYS_FULLSCREEN? > > The idea is to handle the case of a "search text" request on > hidden panels. In which case the search panel is temporarily > shown, until Esc is pressed. > > If it can be done with less variables, no problem. So it was added on purpose. All right. > Now, Esc is used to: > > - Close dialog windows > - Hide the search panel > > Please don't rip that functionality. The idea is Esc to stop > when there's no search bar. I don't want to use escape for stop if the search bar conflicts with it.

May 29, 2009

--xid option

by corvid＠lavabit.com

Jorge wrote: > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > Of course naturally I think, "I hope my MSG macros count as polishing... > > I hope my UTF-8 file.c code counts as polishing..." > > Send them to me when they're ready. It looks like I sent the UTF-8 one on the 17th, and the MSG macros on the 16th, with another mail on the 18th discovering that, whatever the gnu info text might say, "" is safer than an empty argument.

May 29, 2009

repo

by Johannes.Hofmann＠gmx.de

On Fri, May 29, 2009 at 12:05:48PM -0400, Jorge Arellano Cid wrote: > Johannes, > > In patch fd2b0634abe9 there's a long-word splitter, please add > a comment on why it's there. IIRC it was discussed in dillo-dev > recently but memory is fragile. Oh that slipped in accidentally. I removed it. We may need something like that in the future but that needs more thought. > > BTW, there's a warning too: > > xembed.cc: In member function 'void Xembed::createInternal(uint32_t)': > xembed.cc:126: warning: unused variable 'x' Fixed. Cheers, Johannes

May 29, 2009

repo

by jcid＠dillo.org

Johannes, In patch fd2b0634abe9 there's a long-word splitter, please add a comment on why it's there. IIRC it was discussed in dillo-dev recently but memory is fragile. BTW, there's a warning too: xembed.cc: In member function 'void Xembed::createInternal(uint32_t)': xembed.cc:126: warning: unused variable 'x' TIA. -- Cheers Jorge.-

May 29, 2009

--xid option

by jcid＠dillo.org

On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > Johannes wrote: > > On Wed, May 27, 2009 at 05:25:15PM -0400, Jorge Arellano Cid wrote: > > > AFAIS the current repo is almost dillo-2.1. I'd freeze here > > > and only accept bug fixes and polish from now. Opinions? > > > > Ok for me. > > A release sounds good. > Of course naturally I think, "I hope my MSG macros count as polishing... > I hope my UTF-8 file.c code counts as polishing..." Send them to me when they're ready. > The auth crash that Tim reported is the one thing clearly in the way. It'd be good to solve this one. > Bits of polish that I see in skimming through my mail is the matter > of the sysconf dir, and of the keybindings changing and the mystery of > KEYS_HIDE_PANELS. And putting together sample style.css and keysrc. Yes. I have other items here, but more on this later. -- Cheers Jorge.-

May 29, 2009

patch: a binding for stop

by jcid＠dillo.org

On Fri, May 29, 2009 at 02:39:04AM +0000, corvid wrote: > > I don't like much Esc for stop, but if that's FFs default, > > it may be better than another (as the Ctrl-x clash you spot). > > Afterall this is what configurable keybindings is suppossed to > > solve so Esc is OK for me as default. > > I'll have to rip out the mysterious HIDE_PANELS in order to > take back Escape which it is using. AFAIS, in the sense of: > What is the purpose of KEYS_HIDE_PANELS when we have KEYS_FULLSCREEN? The idea is to handle the case of a "search text" request on hidden panels. In which case the search panel is temporarily shown, until Esc is pressed. If it can be done with less variables, no problem. Now, Esc is used to: - Close dialog windows - Hide the search panel Please don't rip that functionality. The idea is Esc to stop when there's no search bar. -- Cheers Jorge.-

May 29, 2009

x offset > 64k

by Johannes.Hofmann＠gmx.de

On Thu, May 28, 2009 at 12:36:05PM +0000, corvid wrote: > Johannes wrote: > > On Thu, May 28, 2009 at 03:55:57AM +0000, corvid wrote: > > > I tried looking at a stylesheet, but nothing displayed. > > > It was a one-line document about 7k chars long. > > > > > > It turned out that fltk::getwidth() calls XftTextExtents32() > > > and the width comes back in a short, so it wrapped at 32k. > > > > > > I chopped the line into 1k-long "words", and now I saw > > > text, but once I made a line somewhere over 8k chars long, drawing > > > would wrap and start at the beginning again. Everything looked > > > all right in fltk::drawtext_transformed() as it called > > > XftDrawString32()... > > > > > > I have no idea whether this is something easy to deal with > > > in some way, or a limitation in X... > > > > > > > Oh. This is extremely nasty. Yes, it is a limitation of X. And > > someone (fltk or dillo) needs to workaround it. Fltk2 has 32bit > > coordinate space, but single drawing operations seem still to be > > limited in size, as they are directly mapped to their X > > counterparts. > > The individual drawing requests weren't too big after splitting > them up, so far as I could tell. I was trying > > data = a_Misc_expand_tabs(Start + i - len, len); > while (data->len > 1000) { > char *s = dStrndup(data->str, 1000); > DW2TB(dw)->addText(s, widgetStyle); > dStr_erase(data, 0, 1000); > dFree(s); > } > DW2TB(dw)->addText(data->str, widgetStyle); > > where data had become a Dstr*. That's fltk not checking the coordinates for 16bit overflow before passing it to XftDrawString32(). Of course one could argue that Xft should do that check. We probabely need to do it ourselfes in fltkviewbase.cc by adding checks for coordinates >= USHRT_MAX. But what is our general plan to fix these issues? I'd say in the long run we could try to make all the draw* methods in fltkviewbase.cc work properly with arbitrary int coordinates by breaking them down to equivalent (as far as the visible area is concerned) drawrequests with smaller coordinates. Cheers, Johannes

May 28, 2009