- Dillo-dev - lists.mailman3.com

problems with very long alt text

by Johannes.Hofmann＠gmx.de

On Thu, Aug 25, 2011 at 08:03:05PM +0000, corvid wrote: > Jorge wrote: > > On Thu, Aug 25, 2011 at 02:36:56PM -0300, Jorge Arellano Cid wrote: > > > On Thu, Aug 25, 2011 at 05:15:00PM +0000, corvid wrote: > > > > Jorge wrote: > > > > > On Thu, Aug 25, 2011 at 01:53:32AM +0000, corvid wrote: > > > > > > > > > > > > With remote stylesheets off and images off, opening > > > > > > http://www.dillo.org/test/long_alt_text.html > > > > > > and dragging the horizontal scrollbar left and right > > > > > > for a little while will make my machine suddenly start > > > > > > to page madly. > > > > > > > > > > Whoooooohooooo! > > > > > > > > > > Good catch: I got an instantaneous X server crash here. > > > > > > > > > > Will look into it. > > > > > > > > With XFT disabled, this page doesn't give me any memory difficulties. > > > > > > *it surprises me* > > > > > > I've found this: > > > > > > * fl_width() returns OK when called by FltkPlatform::textWidth() > > > * dillo-2.2.1 also crashes my X server. > > > > > > With this little data I tend to think there's a bug in Dillo. > > > Maybe a huge allocation request... > > > > * There's no need to disable CSS nor images here to have a > > crash. > > > > To discard an utf8 kill-sequence, I changed the testcase into a > > 1106 'a' character repetition (attached). After applying the > > attached debug-patch, it crashes consistently [1] with max_c=734 > > but not with max_c=733. I see the expected memory usage with > > max_c=733 . > > > > Is this also true in your machine? > > With 733, I scroll back and forth, and mem used in the Mem line in > top goes up, up, up, while nothing out of the ordinary happens to dillo > or X, and the paging begins, and it takes a minute or so to notice the > ctrl-Q. A MSG() in drawSimpleWrappedText() says "width 5864 height 17", > which adds to the evidence that it may not be a 16-bit overflow. > > 733 vs 734 makes no difference for me. Maybe it has to do with MAXBUF in fl_draw.cxx?

Aug. 25, 2011

problems with very long alt text

by corvid＠lavabit.com

Jorge wrote: > On Thu, Aug 25, 2011 at 02:36:56PM -0300, Jorge Arellano Cid wrote: > > On Thu, Aug 25, 2011 at 05:15:00PM +0000, corvid wrote: > > > Jorge wrote: > > > > On Thu, Aug 25, 2011 at 01:53:32AM +0000, corvid wrote: > > > > > > > > > > With remote stylesheets off and images off, opening > > > > > http://www.dillo.org/test/long_alt_text.html > > > > > and dragging the horizontal scrollbar left and right > > > > > for a little while will make my machine suddenly start > > > > > to page madly. > > > > > > > > Whoooooohooooo! > > > > > > > > Good catch: I got an instantaneous X server crash here. > > > > > > > > Will look into it. > > > > > > With XFT disabled, this page doesn't give me any memory difficulties. > > > > *it surprises me* > > > > I've found this: > > > > * fl_width() returns OK when called by FltkPlatform::textWidth() > > * dillo-2.2.1 also crashes my X server. > > > > With this little data I tend to think there's a bug in Dillo. > > Maybe a huge allocation request... > > * There's no need to disable CSS nor images here to have a > crash. > > To discard an utf8 kill-sequence, I changed the testcase into a > 1106 'a' character repetition (attached). After applying the > attached debug-patch, it crashes consistently [1] with max_c=734 > but not with max_c=733. I see the expected memory usage with > max_c=733 . > > Is this also true in your machine? With 733, I scroll back and forth, and mem used in the Mem line in top goes up, up, up, while nothing out of the ordinary happens to dillo or X, and the paging begins, and it takes a minute or so to notice the ctrl-Q. A MSG() in drawSimpleWrappedText() says "width 5864 height 17", which adds to the evidence that it may not be a 16-bit overflow. 733 vs 734 makes no difference for me.

Aug. 25, 2011

problems with very long alt text

by jcid＠dillo.org

On Thu, Aug 25, 2011 at 02:36:56PM -0300, Jorge Arellano Cid wrote: > On Thu, Aug 25, 2011 at 05:15:00PM +0000, corvid wrote: > > Jorge wrote: > > > On Thu, Aug 25, 2011 at 01:53:32AM +0000, corvid wrote: > > > > > > > > With remote stylesheets off and images off, opening > > > > http://www.dillo.org/test/long_alt_text.html > > > > and dragging the horizontal scrollbar left and right > > > > for a little while will make my machine suddenly start > > > > to page madly. > > > > > > Whoooooohooooo! > > > > > > Good catch: I got an instantaneous X server crash here. > > > > > > Will look into it. > > > > With XFT disabled, this page doesn't give me any memory difficulties. > > *it surprises me* > > I've found this: > > * fl_width() returns OK when called by FltkPlatform::textWidth() > * dillo-2.2.1 also crashes my X server. > > With this little data I tend to think there's a bug in Dillo. > Maybe a huge allocation request... * There's no need to disable CSS nor images here to have a crash. To discard an utf8 kill-sequence, I changed the testcase into a 1106 'a' character repetition (attached). After applying the attached debug-patch, it crashes consistently [1] with max_c=734 but not with max_c=733. I see the expected memory usage with max_c=733 . Is this also true in your machine? *puzzled* [1] Before and after rebooting the machine. -- Cheers Jorge.-

Aug. 25, 2011

problems with very long alt text

by jcid＠dillo.org

On Thu, Aug 25, 2011 at 05:15:00PM +0000, corvid wrote: > Jorge wrote: > > On Thu, Aug 25, 2011 at 01:53:32AM +0000, corvid wrote: > > > > > > With remote stylesheets off and images off, opening > > > http://www.dillo.org/test/long_alt_text.html > > > and dragging the horizontal scrollbar left and right > > > for a little while will make my machine suddenly start > > > to page madly. > > > > Whoooooohooooo! > > > > Good catch: I got an instantaneous X server crash here. > > > > Will look into it. > > With XFT disabled, this page doesn't give me any memory difficulties. *it surprises me* I've found this: * fl_width() returns OK when called by FltkPlatform::textWidth() * dillo-2.2.1 also crashes my X server. With this little data I tend to think there's a bug in Dillo. Maybe a huge allocation request... -- Cheers Jorge.-

Aug. 25, 2011

problems with very long alt text

by corvid＠lavabit.com

Jorge wrote: > On Thu, Aug 25, 2011 at 01:53:32AM +0000, corvid wrote: > > > > With remote stylesheets off and images off, opening > > http://www.dillo.org/test/long_alt_text.html > > and dragging the horizontal scrollbar left and right > > for a little while will make my machine suddenly start > > to page madly. > > Whoooooohooooo! > > Good catch: I got an instantaneous X server crash here. > > Will look into it. With XFT disabled, this page doesn't give me any memory difficulties.

Aug. 25, 2011

problems with very long alt text

by jcid＠dillo.org

On Thu, Aug 25, 2011 at 01:53:32AM +0000, corvid wrote: > > With remote stylesheets off and images off, opening > http://www.dillo.org/test/long_alt_text.html > and dragging the horizontal scrollbar left and right > for a little while will make my machine suddenly start > to page madly. Whoooooohooooo! Good catch: I got an instantaneous X server crash here. Will look into it. -- Cheers Jorge.-

Aug. 25, 2011

problems with very long alt text

by corvid＠lavabit.com

With remote stylesheets off and images off, opening http://www.dillo.org/test/long_alt_text.html and dragging the horizontal scrollbar left and right for a little while will make my machine suddenly start to page madly. from what I could see from valgrind and top, nothing looked amiss in dillo or X, but even after dillo can finally close (if it can), too many resources are tied up somehow and I need to restart X to have a really usable system. I changed the alt text back to using drawText(), and it didn't matter much that I could see. I tried using a width of 16K instead of the 25K or so that was the real value. This didn't seem to help either.

Aug. 25, 2011

What's pending for RC2

by corvid＠lavabit.com

Jorge wrote: > BTW, at this point the Changelog has a summary of user-visible > changes, which reduces clutter given that the full history is in hg. > Please vote. > me: +1 on keeping it this way. *agrees, as you'd expect* > [ ] default search engine > I've been using search_url="http://duckduckgo.com/lite/?kp=-1&q=%s" > and it works quite well for me. > Please vote. > me: +1 for making it the default I hadn't known about this lighter version. It's nice.

Aug. 24, 2011

What's pending for RC2

by abe＠deuxchevaux.org

Hi, On Wed, Aug 24, 2011 at 01:21:58PM -0300, Jorge Arellano Cid wrote: > Subject: What's pending for RC2 > > So far we have: [big list of ok-checks] Yay! > [ok] update the Changelog > Corvid and Johannes may have some pending items to add. > BTW, at this point the Changelog has a summary of user-visible > changes, which reduces clutter given that the full history is in hg. > Please vote. > me: +1 on keeping it this way. +1 > [ ] default search engine > I've been using search_url="http://duckduckgo.com/lite/?kp=-1&q=%s" > and it works quite well for me. > Please vote. > me: +1 for making it the default +1 > Also I'd like to add some default search engines. For instance, > this one is very useful for me: > search_url="Free Dictionary http://www.thefreedictionary.com/%s" > Comments/suggestions? search_url="Scroogle https://ssl.scroogle.org/cgi-bin/nbbwssl.cgi?Gw=%s" Kind regards, Axel -- /~\ Plain Text Ribbon Campaign | Axel Beckert \ / Say No to HTML in E-Mail and News | abe(a)deuxchevaux.org (Mail) X See http://www.asciiribbon.org/ | abe(a)noone.org (Mail+Jabber) / \ I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)

Aug. 24, 2011

What's pending for RC2

by jcid＠dillo.org

Hi there, So far we have: [ok] moveToWidget(). Jorge has code for this. [ok] downloads dpi string escaping. [ok] alt text wrapping (which looks like a nice feature). [ok] remove large panel. [ok] https dialog storm (BUG#868). [ok] The findbar input doesn't know about Ctrl+{a,e,d,k}. [ok] something other than "ctab%d" for initial tab label. [ok] single close tab button with tooltip. [ok] valgrind logs: close window [ok] valgrind logs: cancel expected url [ok] segfault with Ctrl-s (web search) [ok] UI_TEMPORARILY_SHOW_PANELS [ok] leave link into a native FLTK widget [ok] remove pointeronlink(), panelmode_cb_i() [ok] the panel problems when resizing from very small. [ok] resize problems when tabs overflow [ok] URL_ILLEGAL_CHARS [ok] Fixed CustLightButton "light" color deactivation. [ok] hoverTooltip glitch (tooltip linger when going into a child DIV). [ok] tab overflow (code a handler) [ok] valgrind error for first tab close, then resize(). [ok] update the Changelog [ ] default search engine [ ] new-tab and window title [ ] CSS adjacent sibling selectors I'd like to comment some: [ok] tab overflow (code a handler) Please send feedback on how it works. Remember that polish and eye candy was left for the next release. [ok] update the Changelog Corvid and Johannes may have some pending items to add. BTW, at this point the Changelog has a summary of user-visible changes, which reduces clutter given that the full history is in hg. Please vote. me: +1 on keeping it this way. [ ] default search engine I've been using search_url="http://duckduckgo.com/lite/?kp=-1&q=%s" and it works quite well for me. Please vote. me: +1 for making it the default Also I'd like to add some default search engines. For instance, this one is very useful for me: search_url="Free Dictionary http://www.thefreedictionary.com/%s" Comments/suggestions? [ ] new-tab and window title This is a simple deatail that I'll look into quickly. [ ] CSS adjacent sibling selectors Johannes has to decide on this. -- Cheers Jorge.-

Aug. 24, 2011