- Dillo-dev - lists.mailman3.com

valgrind doctree leak

by corvid＠lavabit.com

(from Jeremy's logs) ==2186== 928 (32 direct, 896 indirect) bytes in 1 blocks are definitely lost in loss record 815 of 958 ==2186== at 0x40275CC: operator new(unsigned int) (vg_replace_malloc.c:255) ==2186== by 0x806E258: Doctree::push() (doctree.hh:67) ==2186== by 0x806C1FC: StyleEngine::startElement(int) (styleengine.cc:93) ==2186== by 0x8076DB8: Html_process_tag(DilloHtml*, char*, int) (html.cc:3507) ==2186== by 0x8077A33: Html_write_raw(DilloHtml*, char*, int, int) (html.cc:3822) ==2186== by 0x8070543: DilloHtml::write(char*, int, int) (html.cc:552) ==2186== by 0x80775BD: Html_callback(int, _CacheClient*) (html.cc:3725) ==2186== by 0x80627AD: Cache_process_queue (cache.c:1195) ==2186== by 0x80629A2: Cache_delayed_process_queue_callback (cache.c:1260) ==2186== by 0x40C0876: Fl::wait(double) (in /usr/lib/libfltk.so.1.3) ==2186== by 0x40C0A30: Fl::run() (in /usr/lib/libfltk.so.1.3) ==2186== by 0x804F08A: main (dillo.cc:436)

Aug. 28, 2011

margin-bottom counted twice

by Johannes.Hofmann＠gmx.de

On Fri, Aug 26, 2011 at 04:48:46PM -0300, Jorge Arellano Cid wrote: > On Fri, Aug 26, 2011 at 09:43:39PM +0200, Johannes Hofmann wrote: > > On Fri, Aug 26, 2011 at 04:21:04PM +0000, corvid wrote: > > > Johannes wrote: > > > > I'm not 100% sure about removing the "if" in Textblock::wordWrap(), > > > > but why shouldn't a widget's top margin count in the first line of a > > > > paragraph? > > > > > > My first thought was that maybe it has something to do with cases like > > > > > > <div style="margin-top: 100px"> > > > <div style="margin-top: 100px"> > > > <img src="http://www.dillo.org/wearlab.png" style="margin-top: 100px"> > > > </div> > > > </div> > > > > > > where I was thinking those were all supposed to collapse. I haven't looked > > > into the spec at all yet, but we get a total of 300px on dillo, and firefox > > > has the divs collapse and the img margin is separate (maybe a block/inline > > > distinction?). > > > > seems so. changing it to > > <img src="http://www.dillo.org/wearlab.png" style="display: block; margin-top: 100px"> > > causes firefox to also collapse the img margin. > > I have margin collapsing also on my list. > > And on the textblock side, it seems to render just as before with > the patch. > > Johannes, please decide on whether to apply it before the release. > I'll try to pack RC2 this Monday. Committed, including some margin collapsing.

Aug. 27, 2011

margin-bottom counted twice

by jcid＠dillo.org

On Fri, Aug 26, 2011 at 09:43:39PM +0200, Johannes Hofmann wrote: > On Fri, Aug 26, 2011 at 04:21:04PM +0000, corvid wrote: > > Johannes wrote: > > > I'm not 100% sure about removing the "if" in Textblock::wordWrap(), > > > but why shouldn't a widget's top margin count in the first line of a > > > paragraph? > > > > My first thought was that maybe it has something to do with cases like > > > > <div style="margin-top: 100px"> > > <div style="margin-top: 100px"> > > <img src="http://www.dillo.org/wearlab.png" style="margin-top: 100px"> > > </div> > > </div> > > > > where I was thinking those were all supposed to collapse. I haven't looked > > into the spec at all yet, but we get a total of 300px on dillo, and firefox > > has the divs collapse and the img margin is separate (maybe a block/inline > > distinction?). > > seems so. changing it to > <img src="http://www.dillo.org/wearlab.png" style="display: block; margin-top: 100px"> > causes firefox to also collapse the img margin. > I have margin collapsing also on my list. And on the textblock side, it seems to render just as before with the patch. Johannes, please decide on whether to apply it before the release. I'll try to pack RC2 this Monday. -- Cheers Jorge.-

Aug. 26, 2011

What's pending for RC2

by jcid＠dillo.org

Hi, [ok] new-tab and window title [ok] CSS adjacent sibling selectors [ ] default search engine [ ] margin-bottom > [ ] default search engine > I've been using search_url="http://duckduckgo.com/lite/?kp=-1&q=%s" > and it works quite well for me. > Please vote. > me: +1 for making it the default > > Also I'd like to add some default search engines. For instance, > this one is very useful for me: > search_url="Free Dictionary http://www.thefreedictionary.com/%s" > Comments/suggestions? Last chance to vote... > [ ] margin-bottom In evaluation stage. -- Cheers Jorge.-

Aug. 26, 2011

margin-bottom counted twice

by Johannes.Hofmann＠gmx.de

On Fri, Aug 26, 2011 at 04:21:04PM +0000, corvid wrote: > Johannes wrote: > > I'm not 100% sure about removing the "if" in Textblock::wordWrap(), > > but why shouldn't a widget's top margin count in the first line of a > > paragraph? > > My first thought was that maybe it has something to do with cases like > > <div style="margin-top: 100px"> > <div style="margin-top: 100px"> > <img src="http://www.dillo.org/wearlab.png" style="margin-top: 100px"> > </div> > </div> > > where I was thinking those were all supposed to collapse. I haven't looked > into the spec at all yet, but we get a total of 300px on dillo, and firefox > has the divs collapse and the img margin is separate (maybe a block/inline > distinction?). seems so. changing it to <img src="http://www.dillo.org/wearlab.png" style="display: block; margin-top: 100px"> causes firefox to also collapse the img margin. I have margin collapsing also on my list.

Aug. 26, 2011

problems with very long alt text

by jcid＠dillo.org

On Fri, Aug 26, 2011 at 07:29:21PM +0200, hiro wrote: > With tinycorelinux and Xorg-7.5 i915 on 1024x768 I get a completely > garbled screen and unresponsive system, CPU ran hot and I had to > reboot. > I can reboot into VESA if you want. [later hiro wrote:] > Ok I don't get the bug with Xvesa, tinycorelinux' default Xserver. Excellent! This proves the point (AFAICS). Thank you very much. -- Cheers Jorge.-

Aug. 26, 2011

margin-bottom counted twice

by jcid＠dillo.org

On Fri, Aug 26, 2011 at 10:20:43AM +0200, Johannes Hofmann wrote: > Hi, > > I found that current dillo uses twice the given > margin-bottom: value. See attached margin_bottom.html. > It is related to commented out code in textblock.cc. > Attached patch tries to fix it while not breaking the test cases in > http://www.dillo.org/test/img/ > I'm not 100% sure about removing the "if" in Textblock::wordWrap(), > but why shouldn't a widget's top margin count in the first line of a > paragraph? AFAIR there was the "line1" offset stuff (which seem not to apply here because it's horizontal), and the handOverBreak() code which dealt with spacing between textblocks. I'm for applying the patch, but would give first a second look to handOverBreak() just to be sure. BTW, after a quick review it looks weird, as the value seems inherited (copied from previous stack object) most of the time... -- Cheers Jorge.-

Aug. 26, 2011

margin-bottom counted twice

by corvid＠lavabit.com

Johannes wrote: > I'm not 100% sure about removing the "if" in Textblock::wordWrap(), > but why shouldn't a widget's top margin count in the first line of a > paragraph? My first thought was that maybe it has something to do with cases like <div style="margin-top: 100px"> <div style="margin-top: 100px"> <img src="http://www.dillo.org/wearlab.png" style="margin-top: 100px"> </div> </div> where I was thinking those were all supposed to collapse. I haven't looked into the spec at all yet, but we get a total of 300px on dillo, and firefox has the divs collapse and the img margin is separate (maybe a block/inline distinction?).

Aug. 26, 2011

problems with very long alt text

by jcid＠dillo.org

On Fri, Aug 26, 2011 at 12:47:24PM -0300, Jorge Arellano Cid wrote: > On Fri, Aug 26, 2011 at 04:51:53PM +0300, Rogut??s Sparnuotos wrote: > > > try booting with the 'i915.modeset=0' kernel parameter? > > It made no difference :-P Actually it made a difference. I can't change the resolution without the kernel argument. Thanks. BTW, although my custom xorg.conf says: Section "Device" Identifier "Card0" Driver "vesa" BusID "PCI:0:2:0" EndSection Section "Screen" Identifier "Screen0" Device "Card0" Monitor "Monitor0" SubSection "Display" Viewport 0 0 Depth 16 Modes "800x600" "1024x768" EndSubSection EndSection ... lsmod shows i915 is loaded. -- Cheers Jorge.-

Aug. 26, 2011

problems with very long alt text

by johannes.hofmann＠gmx.de

On Fri, Aug 26, 2011 at 12:47:24PM -0300, Jorge Arellano Cid wrote: > On Fri, Aug 26, 2011 at 04:51:53PM +0300, Rogut??s Sparnuotos wrote: > > Jorge Arellano Cid (2011-08-26 09:34): > > > I can't get this Debian to go VESA. Hints welcomed. > > > > Perhaps make sure that you have the 'xserver-xorg-video-vesa' package > > It is there. > > > and > > try booting with the 'i915.modeset=0' kernel parameter? > > It made no difference :-P > > > But probably it is > > more stubborn than that, e.g. only the i915 driver knows how to initialize > > enough video RAM for the native resolution. > > I have a "Tiny Core" linux live CD that works without the intel > driver (AFAICT). No native resolution though. > > > > In such a case running > > `X -depth 8` could work, but delving any deeper is probably not worth the > > trouble. > > This gave me an idea, and guess what, if I run with the same > kernel/intel-driver that crashes but with a different resolution > (1024x768) there's no crash. > > Now, if VESA can't do the native resolution, I don't know how > to get closer to a proof of a bug in the i915 driver. Maybe with http://sourceforge.net/projects/xtrace/ you can determine the problematic X11 request. I can't reproduce the crash btw. Cheers, Johannes

Aug. 26, 2011