- Dillo-dev - lists.mailman3.com

Doxygen \todos

by p37sitdu＠lavabit.com

Patch replaces TODOs in dw/* files with \todos so they are listed on Doxygen Todo List. One BUG also replaced with \bug.

May 27, 2012

dillorc and src/keysrc

by p37sitdu＠lavabit.com

By the way Scroogle is closed but it is still present in dillorc.

May 27, 2012

Doxyfile

by p37sitdu＠lavabit.com

By the way new Doxygen supports Markdown[1] and it is enabled by default. It is easier to read and write than HTML. index.doc rewritten using markdown is attached. Existing documentation (especially .txt files) can be converted to markdown too. [1] http://daringfireball.net/projects/markdown/

May 26, 2012

Doxyfile

by p37sitdu＠lavabit.com

I have removed all boilerplate from Doxyfile, now it is much shorter and there are less empty/default vairables. I was looking for some way to change layout to something simplier (no CSS-based tabs for example), but looks it is easier to just disable CSS. Cleaned up Doxyfile attached. I have enabled DOT_MULTI_TARGETS to make building faster and left TODO for Dillo logo.

May 26, 2012

dpid patches

by joerg.sonnenberger＠web.de

On Sat, May 26, 2012 at 11:05:28PM +0400, 123 wrote: > One patch for using random instead of rand. [1] Guessing the intention here, I would recomment to use arc4random on systems that have it. time(0) should likely be spelled as time(NULL). > Reordered headers and removed old comments (what is ckt_write?). umask > is actually in sys/stat.h and not in unistd.h umask in sys/stat.h is correct. Joerg

May 26, 2012

dpid patches

by jcid＠dillo.org

On Sat, May 26, 2012 at 11:05:28PM +0400, 123 wrote: > One patch for using random instead of rand. [1] Ack. > Reordered headers and removed old comments (what is ckt_write?). umask > is actually in sys/stat.h and not in unistd.h Dillo compiles in several OSes/platforms, which sometimes have declarations in different files. This is the to-be-tested point. > (what is ckt_write?). ckd_write() an EINTR-protected write() (see dpid/dpid_common.c). > Also removed expired TODO item about dpi_service.[c|h]. Ack. -- Cheers Jorge.-

May 26, 2012

dillorc and src/keysrc

by p37sitdu＠lavabit.com

dillorc is in the root of repo and keysrc is in src/keysrc. Not a serious issue, but I think keysrc should be located in root too.

May 26, 2012

dpid patches

by p37sitdu＠lavabit.com

One patch for using random instead of rand. [1] Reordered headers and removed old comments (what is ckt_write?). umask is actually in sys/stat.h and not in unistd.h Also removed expired TODO item about dpi_service.[c|h]. [1] https://www.securecoding.cert.org/confluence/display/seccode/MSC30-C.+Do+no…

May 26, 2012

cleanup patches

by Johannes.Hofmann＠gmx.de

On Sat, May 26, 2012 at 03:59:12PM +0200, Alexander Voigt wrote: > Hi 123, > > why not introducing a macro like > > #define LENGTH(X) (sizeof (X) / sizeof (X)[0]) > > which could be used in all these for loops? I think this would make > the code simpler and less error prone. I'm not a fan of hiding this in macros. Something like struct foo * f = malloc(sizeof(struct foo) * 10); for(int i = 0; i < LENGTH(f); i++) { looks even more unsuspicious than with the sizeof stuff visible. Cheers, Johannes

May 26, 2012

cleanup patches

by Hole.destructor＠gmx.de

Hi 123, why not introducing a macro like #define LENGTH(X) (sizeof (X) / sizeof (X)[0]) which could be used in all these for loops? I think this would make the code simpler and less error prone. Best, Alexander

May 26, 2012