- Dillo-dev - lists.mailman3.com

Minor bug in test/cookies.c

by jcid＠dillo.org

On Sun, May 01, 2016 at 11:05:27AM +0100, Nick Warne wrote: > Hi Jorge, > > I saw the two minor fixes you done today - here's another: > > :~/slackbuilds/dillo/hg/dillo$ grep -Rin "} if" * > test/cookies.c:426: } if ((ret = Dpi_blocking_read(sock_fd)) == NULL) { Right, committed, thks! -- Cheers Jorge.-

May 1, 2016

Minor bug in test/cookies.c

by nick＠linicks.net

Hi Jorge, I saw the two minor fixes you done today - here's another: :~/slackbuilds/dillo/hg/dillo$ grep -Rin "} if" * test/cookies.c:426: } if ((ret = Dpi_blocking_read(sock_fd)) == NULL) { Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

May 1, 2016

"ok" for unnested body

by genoob＠yandex.com

Hello! I'm a noob, so I'm sorry if this is actually not an issue, but I've searched and haven't found anything on this. When creating a simple list using `ul` (I've replaced < > with `` in order to avoid html parsing by some readers) tags I accidentally placed it after `/body``/html` and to my surprise It wasn't marked as an html error and the data was correctly displayed, jus like it would be had the list been placed inside the `html``body` `/body``/html` tags. Unnesting `li` from `ul` however displayed nesting problem, but only referring to the `li` being out of `ul` or `ol` tags, not from it being unnested from `html` `body`. I realize my explanation might be a little confusing at this point, so this is what I mean: I put it on bpaste so this message wouldn't be flagged as spam: https://bpaste.net/show/ed1374304997 And this is a screenshot of the data being displayed and getting a thumbs-up from the browser in case its relevant: http://i.imgur.com/d1f9Pv9.png I'd like to report this in case it's a bug(invalid html being marked valid), however if it's a valid html you can disregard/exclude this message from the list with no hard feelings. I'm using dillo-3.0.5-r1 by the way. I'm sorry if this was confusing and wasted your time. In case you need more info on my system I'm happy to help however I can. And thanks for maintaining such a nice project (It really helped me a lot thus far). Cheers!

April 30, 2016

image overlaps text

by jcid＠dillo.org

On Sat, Apr 30, 2016 at 01:31:48PM +0200, Sebastian Geerken wrote: > On Fr, Apr 29, 2016, Jorge Arellano Cid wrote: > > On Fri, Apr 29, 2016 at 06:41:32PM +0200, Sebastian Geerken wrote: > > > On Fri, Apr 29, 2016, Nick Warne wrote: > > > > > > > > > > > > On 29/04/16 16:46, Alexander Voigt wrote: > > > > >I noticed, that in current Dillo (tip) there are cases where images > > > > >overlap surrounding text, making in unreadable. Here is an example page: > > > > > > > > > > https://netzpolitik.org/2016/massenbeschlagnahme-von-mobiltelefonen-in-leip… > > > > > > > > Strange, renders here OK (latest hg pull). > > > > > > As I wrote, this is hard to reproduce. > > > > Yes. > > > > (I can't reproduce it with your best URL :) > > > > Fortunately, today I managed to find&reduce a case that works all the time > > here. Attached it goes. Just resize horizontally to see the overlap. > > > > I hope it works there! > > Thanks, Jorge, for the perfect testcase. So far, I've tracked down the > problem, Great! :) :) > but I'm not yet sure how to fix it. Hopefully, the fix will > also solve the other issues with overlapping floats. Yes, I also hope in the same direction! FWIW, yesternight, without knowing whether the example would tackle it, I came with a different approach to testing (just in case). Do you remember our slow.cgi testing program? It can be made to serve adjustable chunks of data with adjustable delays, this way: slow.cgi?2048:1:/tmp/testcase.html for 2048 bytes in 1 second (for instance). This could help to reproduce the bug in the network dependent cases by finding the combination that triggers it. Just let me know if you need it as plan B. HTH. -- Cheers Jorge.-

April 30, 2016

image overlaps text

by sgeerken＠dillo.org

On Fr, Apr 29, 2016, Jorge Arellano Cid wrote: > On Fri, Apr 29, 2016 at 06:41:32PM +0200, Sebastian Geerken wrote: > > On Fri, Apr 29, 2016, Nick Warne wrote: > > > > > > > > > On 29/04/16 16:46, Alexander Voigt wrote: > > > >I noticed, that in current Dillo (tip) there are cases where images > > > >overlap surrounding text, making in unreadable. Here is an example page: > > > > > > > > https://netzpolitik.org/2016/massenbeschlagnahme-von-mobiltelefonen-in-leip… > > > > > > Strange, renders here OK (latest hg pull). > > > > As I wrote, this is hard to reproduce. > > Yes. > > (I can't reproduce it with your best URL :) > > Fortunately, today I managed to find&reduce a case that works all the time > here. Attached it goes. Just resize horizontally to see the overlap. > > I hope it works there! Thanks, Jorge, for the perfect testcase. So far, I've tracked down the problem, but I'm not yet sure how to fix it. Hopefully, the fix will also solve the other issues with overlapping floats. Sebastian

April 30, 2016

image overlaps text

by jcid＠dillo.org

On Fri, Apr 29, 2016 at 10:11:37PM +0100, higuita wrote: > On Fri, 29 Apr 2016 13:41:16 -0300, Jorge Arellano Cid <jcid at dillo.org> > wrote: > > Does going Back and Forward fix the problem? > > Yes, it solves the problem. Reload also solves this. > > For me, i can reproduce this ~70% of the attempts. > it seems just a race drawing the page and getting the resources > from the internet. That's my point. The rendering algorithm seems to make a decision on incomplete data (sometimes depending on available data) and, also sometimes, it can't recover when all data is got. Now, if you feed it the whole of the data, it seldom fails. I hope the reduced test case fails because it gets to that point in the algorithm and not because it always fails. -- Cheers Jorge.-

April 29, 2016

image overlaps text

by jcid＠dillo.org

On Fri, Apr 29, 2016 at 06:26:50PM -0300, Jorge Arellano Cid wrote: > [...] > > Fortunately, today I managed to find&reduce a case that works all the time > here. Attached it goes. Just resize horizontally to see the overlap. > > I hope it works there! Ooops, I forgot to attach the image. Here it goes. -- Cheers Jorge.-

April 29, 2016

image overlaps text

by jcid＠dillo.org

On Fri, Apr 29, 2016 at 06:41:32PM +0200, Sebastian Geerken wrote: > On Fri, Apr 29, 2016, Nick Warne wrote: > > > > > > On 29/04/16 16:46, Alexander Voigt wrote: > > >I noticed, that in current Dillo (tip) there are cases where images > > >overlap surrounding text, making in unreadable. Here is an example page: > > > > > > https://netzpolitik.org/2016/massenbeschlagnahme-von-mobiltelefonen-in-leip… > > > > Strange, renders here OK (latest hg pull). > > As I wrote, this is hard to reproduce. Yes. (I can't reproduce it with your best URL :) Fortunately, today I managed to find&reduce a case that works all the time here. Attached it goes. Just resize horizontally to see the overlap. I hope it works there! -- Cheers Jorge.- PD: subliminal message in the example. ;)

April 29, 2016

image overlaps text

by higuita7＠yahoo.co.uk

On Fri, 29 Apr 2016 13:41:16 -0300, Jorge Arellano Cid <jcid at dillo.org> wrote: > Does going Back and Forward fix the problem? Yes, it solves the problem. Reload also solves this. For me, i can reproduce this ~70% of the attempts. it seems just a race drawing the page and getting the resources from the internet. Best regards higuita -- Naturally the common people don't want war... but after all it is the leaders of a country who determine the policy, and it is always a simple matter to drag the people along, whether it is a democracy, or a fascist dictatorship, or a parliament, or a communist dictatorship. Voice or no voice, the people can always be brought to the bidding of the leaders. That is easy. All you have to do is tell them they are being attacked, and denounce the pacifists for lack of patriotism and exposing the country to danger. It works the same in every country. -- Hermann Goering, Nazi and war criminal, 1883-1946

April 29, 2016

dillo redraws part II

by jcid＠dillo.org

Hi there, Just committed the second part of this patch. It further reduces the number of redraws (see details in hg). The debug messages are active and will be shut after a brief testing period. Screen drawing *feels* cleaner here! :-) YMMV. -- Cheers Jorge.-

April 29, 2016