- Dillo-dev - lists.mailman3.com

[PATCH] initialise FltkViewport::{scrollDX,scrollDY}

by onepoint＠starurchin.org

On Sat, Dec 22, 2007 at 09:48:30AM +0100, Johannes Hofmann wrote: > I also know now why I could no longer reproduce the problem: To > debug the problem I had used some MALLOC_OPTIONS that cause malloced > data to be initialized with some weird pattern. With this option I > could reproduce the failure. Later I forgot to set the option and > the problem seemed to be gone. Good, that confirms we know the real cause of the problem. > I would still suggest to use my latest patch that calls layout() of > child widgets from FltkWidgetView. > > Can you make a combined patch for Jorge? Yes, I will. Jeremy Henty

Dec. 22, 2007

[PATCH] initialise FltkViewport::{scrollDX,scrollDY}

by Johannes.Hofmann＠gmx.de

Hi Jeremy, On Sat, Dec 22, 2007 at 02:10:32AM +0000, Jeremy Henty wrote: > > This patch initialises FltkViewport::{scrollDX,scrollDY}. This > removes a valgrind warning about a conditional jump depending on > uninitialised data. It also fixes the mysterious sporadic > disappearing page bug that was afflicting the development of the > TextEditor patch. This makes me very happy, and confirms yet again > that valgrind is awesome! Excellent! scrollDX, scrollDY were introduced by one of my scrolling patches btw.... I also know now why I could no longer reproduce the problem: To debug the problem I had used some MALLOC_OPTIONS that cause malloced data to be initialized with some weird pattern. With this option I could reproduce the failure. Later I forgot to set the option and the problem seemed to be gone. And I can only agree that valgrind is a awesome tool. It helped a lot with the style reference bug too. I would still suggest to use my latest patch that calls layout() of child widgets from FltkWidgetView. Can you make a combined patch for Jorge? Regards, Johannes > > Regards, > > Jeremy Henty > > > diff -pru -- dw2-ref/dw/fltkviewport.cc dw2-cur/dw/fltkviewport.cc > --- dw2-ref/dw/fltkviewport.cc 2007-12-22 01:23:39.000000000 +0000 > +++ dw2-cur/dw/fltkviewport.cc 2007-12-22 01:46:11.000000000 +0000 > @@ -46,7 +46,7 @@ FltkViewport::FltkViewport (int x, int y > vscrollbar->set_vertical(); > vscrollbar->callback (vscrollbarCallback, this); > > - scrollX = scrollY = 0; > + scrollX = scrollY = scrollDX = scrollDY = 0; > dragScrolling = 0; > > gadgetOrientation[0] = GADGET_HORIZONTAL; > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 22, 2007

[PATCH] initialise FltkViewport::{scrollDX,scrollDY}

by onepoint＠starurchin.org

This patch initialises FltkViewport::{scrollDX,scrollDY}. This removes a valgrind warning about a conditional jump depending on uninitialised data. It also fixes the mysterious sporadic disappearing page bug that was afflicting the development of the TextEditor patch. This makes me very happy, and confirms yet again that valgrind is awesome! Regards, Jeremy Henty diff -pru -- dw2-ref/dw/fltkviewport.cc dw2-cur/dw/fltkviewport.cc --- dw2-ref/dw/fltkviewport.cc 2007-12-22 01:23:39.000000000 +0000 +++ dw2-cur/dw/fltkviewport.cc 2007-12-22 01:46:11.000000000 +0000 @@ -46,7 +46,7 @@ FltkViewport::FltkViewport (int x, int y vscrollbar->set_vertical(); vscrollbar->callback (vscrollbarCallback, this); - scrollX = scrollY = 0; + scrollX = scrollY = scrollDX = scrollDY = 0; dragScrolling = 0; gadgetOrientation[0] = GADGET_HORIZONTAL;

Dec. 22, 2007

[PATCH] TEXTAREA controls submit their contents

by onepoint＠starurchin.org

On Thu, Dec 20, 2007 at 07:12:56PM +0100, Johannes Hofmann wrote: > On Wed, Dec 19, 2007 at 09:41:20PM +0000, Jeremy Henty wrote: > > > > Not fixed yet. :-( The bug appears to be sporadic now: sometimes > > a middle-click brings up a blank page, sometimes not. I *think* > > that a left-click still always works. NB: the test page includes > > an input widget and it is affected too, so this is not AFAICT > > specific to the FLTK TextEditor. > > > > Can you reproduce this at all? Maybe it's affected by the window > > manager? I'm running Linux 2.6.23 + X windows 7.1 + icewm. > > Yes, I could reproduce it - sporadically. But I no longer can with > my change... I will keep on trying. I believe I have fixed it. FltkViewport::{scrollDX,scrollDY} were not being initialised. This explains why sometimes the form rendered but displaced vertically (which I forgot to mention). I imagine the blank pages were due to the same bug scrolling the form right off the page. I'll post the fix and the complete textarea patch to new threads: this is getting confusing! Johannes, you'll need to tell me which of your viewport patches I should use; it's possible that once this scrolling fix is committed some of your earlier efforts may turn out to be sufficient. Regards, Jeremy Henty

Dec. 22, 2007

[PATCH] TEXTAREA controls submit their contents

by Johannes.Hofmann＠gmx.de

On Wed, Dec 19, 2007 at 09:41:20PM +0000, Jeremy Henty wrote: > On Wed, Dec 19, 2007 at 07:28:44PM +0100, Johannes Hofmann wrote: > > > attached is a new patch. Please test it carefully instead of my > > initial one. > > Not fixed yet. :-( The bug appears to be sporadic now: sometimes a > middle-click brings up a blank page, sometimes not. I *think* that a > left-click still always works. NB: the test page includes an input > widget and it is affected too, so this is not AFAICT specific to the > FLTK TextEditor. > > Can you reproduce this at all? Maybe it's affected by the window > manager? I'm running Linux 2.6.23 + X windows 7.1 + icewm. Yes, I could reproduce it - sporadically. But I no longer can with my change... I will keep on trying. Johannes > > Jeremy Henty > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 20, 2007

[PATCH] TEXTAREA controls submit their contents

by Johannes.Hofmann＠gmx.de

On Wed, Dec 19, 2007 at 09:35:01PM +0000, Jeremy Henty wrote: > On Wed, Dec 19, 2007 at 06:34:19PM +0100, Johannes Hofmann wrote: > > > When you leave a page that has a textarea field you get a double > > free(). The TextBuffer is deleted first, then the TextEditor widgets > > are deleted and these access member methods of of the TextBuffer in > > their destructors. > > Ouch! Yes, since the derived class manages the buffer and the > superclass manages the widgets C++ insists on deleting the buffer > first. > > > I have no idea yet how to fix this. Perhaps we can disassociate the > > TextBuffer from the TextEditor widgets in the > > FltkMultiLineTextResource destructor before deleting it? > > I think we must, since we have no way of postponing the deletion of > the buffer. Here's the patch. > > Jeremy Henty > > > diff -pru -- dw2-ref/dw/fltkui.cc dw2-cur/dw/fltkui.cc > --- dw2-ref/dw/fltkui.cc 2007-12-19 14:13:25.000000000 +0000 > +++ dw2-cur/dw/fltkui.cc 2007-12-19 21:10:16.000000000 +0000 > @@ -541,6 +541,11 @@ FltkMultiLineTextResource::FltkMultiLine > > FltkMultiLineTextResource::~FltkMultiLineTextResource () > { > + for (Iterator <ViewAndWidget> it = viewsAndWidgets->iterator (); > + it.hasNext(); ) { > + ViewAndWidget *viewAndWidget = it.getNext (); > + ((::fltk::TextEditor *) viewAndWidget->widget)->buffer (0); > + } > delete buffer; > } > Yes, fixed! Regards, Johannes > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 20, 2007

Fixed a bug in the textblock's wrapping algorithm.

by jcid＠dillo.org

A small bug fix in the textblock's wrapping algorithm was committed. It fixes some border cases like the attached page. -- Cheers Jorge.-

Dec. 20, 2007

[PATCH] TEXTAREA controls submit their contents

by onepoint＠starurchin.org

On Wed, Dec 19, 2007 at 07:28:44PM +0100, Johannes Hofmann wrote: > attached is a new patch. Please test it carefully instead of my > initial one. Not fixed yet. :-( The bug appears to be sporadic now: sometimes a middle-click brings up a blank page, sometimes not. I *think* that a left-click still always works. NB: the test page includes an input widget and it is affected too, so this is not AFAICT specific to the FLTK TextEditor. Can you reproduce this at all? Maybe it's affected by the window manager? I'm running Linux 2.6.23 + X windows 7.1 + icewm. Jeremy Henty

Dec. 19, 2007

[PATCH] TEXTAREA controls submit their contents

by onepoint＠starurchin.org

On Wed, Dec 19, 2007 at 06:34:19PM +0100, Johannes Hofmann wrote: > When you leave a page that has a textarea field you get a double > free(). The TextBuffer is deleted first, then the TextEditor widgets > are deleted and these access member methods of of the TextBuffer in > their destructors. Ouch! Yes, since the derived class manages the buffer and the superclass manages the widgets C++ insists on deleting the buffer first. > I have no idea yet how to fix this. Perhaps we can disassociate the > TextBuffer from the TextEditor widgets in the > FltkMultiLineTextResource destructor before deleting it? I think we must, since we have no way of postponing the deletion of the buffer. Here's the patch. Jeremy Henty diff -pru -- dw2-ref/dw/fltkui.cc dw2-cur/dw/fltkui.cc --- dw2-ref/dw/fltkui.cc 2007-12-19 14:13:25.000000000 +0000 +++ dw2-cur/dw/fltkui.cc 2007-12-19 21:10:16.000000000 +0000 @@ -541,6 +541,11 @@ FltkMultiLineTextResource::FltkMultiLine FltkMultiLineTextResource::~FltkMultiLineTextResource () { + for (Iterator <ViewAndWidget> it = viewsAndWidgets->iterator (); + it.hasNext(); ) { + ViewAndWidget *viewAndWidget = it.getNext (); + ((::fltk::TextEditor *) viewAndWidget->widget)->buffer (0); + } delete buffer; }

Dec. 19, 2007

[PATCH] TEXTAREA controls submit their contents

by Johannes.Hofmann＠gmx.de

Hi, attached is a new patch. Please test it carefully instead of my initial one. * It moves the call to layout from FltkViewport to FltkWidgetView. This is just a cleanup - no functional change * FltkViewbase now call Group::draw() always if DAMAGE_CHILD is set even if other flags are set too. That seems to fix the issue you have noticed when opening a window with the middle mouse button. Cheers, Johannes On Wed, Dec 19, 2007 at 03:11:55PM +0000, Jeremy Henty wrote: > On Wed, Dec 19, 2007 at 02:22:26PM +0000, Jeremy Henty wrote: > > > I have a dillo page with a link to a test page with a form. If I > > middle-click on the link then the test page comes up blank. I have > > to hit reload before the form widgets appear. Left-clicking the > > link works OK. I hope this is simple to fix! > > Follow-up: this bug only appears when the window is large enough to > fit the whole form in vertically. If I resize the window vertically > so that it will be too small to hold the whole form, then middle-click > the link, the new window displays the form properly. > > I guess the widgets aren't getting marked as damaged if they all fit > in the new window, so they don't display themselves? > > Regards, > > Jeremy Henty > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 19, 2007