- Dillo-dev - lists.mailman3.com

[patch] make TopGroup a PackedGroup

by jcid＠dillo.org

Hi Johannes, On Fri, Dec 28, 2007 at 05:26:19PM +0100, Johannes Hofmann wrote: > Hello, > > as I didn't get any feedback from Sebastian yet on my proposal > to make the scrollbars part of UI instead of FltkViewport, I > decided to split my initial patch. > Below is a version that still uses a PackedGroup in UI, but leaves > the scrollbars in FltkViewport. > Here comes the details: > > * Make scrollbars really children of FltkViewport, as it was > probabely intended. > * Use widget local coordinates in FltkViewport::adjustScrollbarsAndGadgets. > * Adjust draw() and handle() so that scrollbars work properly. > * As a consequence replace() now works properly, so remove the > workaround. > * Make TopGroup a PackedGroup and let it do the layout. > * Simplify fullscreen mode. > > This also fixes annoying problems with the statusbar when new windows > are created in fullscreen mode. Reviewing the patch made me remember the struggle I had, to develop those workarounds to have the UI working. As you may intuit I'm more than willing to commit. ;-) The question is: Do you agree with commiting now or do you prefer to hold them for comment as the former patch? -- Cheers Jorge.-

Jan. 1, 2008

[PATCH] initialise Layout::scrollIdleNotInterrupted

by onepoint＠starurchin.org

This is another valgrind pacifier; it squashes an error "Conditional jump or move depends on uninitialised value(s)" at "dw::core::Layout::updateAnchor() (layout.cc:474)" from "valgrind dw2-cur/test/dw-lists". Regards, Jeremy Henty

Jan. 1, 2008

Best wishes for this year 2008

by jcid＠dillo.org

Hi guys, I want to start the year expressing my gratitude to all of you who have contributed your time and effort to make the Dillo project continue forward. The working atmosphere is very nice and that's a very important asset! Our ability to keep working steadily and to attract more developers is probably the cornerstone that can make Dillo --as a project-- thrive and evolve. The manpower behind a project is what pushes it forward. Once again, thanks to you all, and receive my best wishes. -- Cheers Jorge.-

Jan. 1, 2008

[patch] segfault when closing window while it is loading

by Johannes.Hofmann＠gmx.de

Happy new year! Below is a small patch to fix a crash that happens when I open a new window (e.g. with the middle mouse button) and close it immediately while it is still loading the page. Johannes --- a/src/uicmd.cc Mon Dec 31 22:49:02 2007 +0100 +++ b/src/uicmd.cc Tue Jan 01 12:38:14 2008 +0100 @@ -125,6 +125,7 @@ void a_UIcmd_close_bw(void *vbw) Layout *layout = (Layout*)bw->render_layout; MSG("a_UIcmd_close_bw\n"); + a_Bw_stop_clients(bw, BW_Root + BW_Img + Bw_Force); ui->destroy(); delete(layout); a_Bw_free(bw);

Jan. 1, 2008

hook up the limit_text_width pref

by place＠gobigwest.com

I'm not sure under what circumstances this pref. actually changes anything, but here it is anyway. (I didn't notice a difference when I enabled it in my old dillo either...)

Jan. 1, 2008

[PATCH] SELECT form controls

by jcid＠dillo.org

On Sun, Dec 30, 2007 at 07:52:35AM +0000, Jeremy Henty wrote: > > This patch adds (partial) support for SELECT controls in forms. Good work Jeremy, committed! I was also eager to have this working. :-) > Please note: > > * SELECTED and DISABLED are supported. > > * If no item is selected in the HTML source then the first item is > selected by default. This means the code must delay adding any > items until the SELECT is closed, since the DW API forces us to > choose whether to select an item when creating it and won't let us > change that later. > > * MULTI and SIZE are not supported: we render all SELECT controls as > option menus that allow only one choice. I believe more work > needs to be done on the DW ListResource before we can support > multiple selections. > > * I added IN_OPTION to the HTML parsing flags. The code is also > more careful than before to set/unset IN_FORM, IN_TEXTAREA, > IN_SELECT and IN_OPTION. This may be a little redundant but I > wanted to be sure that HTML tag soup can't make the flags > inconsistent. I doubt the overhead of the extra bit-flipping is > significant. A more detailed comment probably next year. I just wanted to commit this cookie!. -- Cheers Jorge.-

Dec. 31, 2007

Re: patch: here are some consts for pixmaps.h

by jcid＠dillo.org

Committed. -- Cheers Jorge.-

Dec. 31, 2007

Re: patch: removing extraneous header inclusion

by jcid＠dillo.org

On Sat, Dec 29, 2007 at 12:54:05AM +0000, place wrote: > Removed some where I couldn't see that they were being used for anything in > that file. > In one case, I added a prefs.h include (I had deleted a msg.h include, > and prefs.h is included in msg.h). > Committed. -- Cheers Jorge.-

Dec. 31, 2007

Re: patch: here are a few more statics for dpi

by jcid＠dillo.org

Committed. -- Cheers Jorge.-

Dec. 31, 2007

[PATCH] SELECT form controls

by onepoint＠starurchin.org

On Sun, Dec 30, 2007 at 08:33:44PM +0000, place wrote: > Jeremy wrote: > > What happens if you > > confine the scope of those variables by putting the body of the case > > clause inside {...} ? Does the compiler still complain? > > That works. OK, that confirms it's an issue with the scope of those variables, though like you I'm surprised that the compiler complains when you don't even use them. Regards, Jeremy Henty

Dec. 31, 2007