- Dillo-dev - lists.mailman3.com

a highlighting colors proposal (with code)

by place＠gobigwest.com

(Maybe this one deserves to be called a patch. It seems pretty clearly to be an improvement to me, at least...) If a page has, e.g., black text on a black background, it is nice to be able to highlight it to read it. So this changes the behavior from highlighted background is inverted background and highlighted text is inverted text to highlighted background is inverted background and highlighted text is normal background. And that is a good improvement in most cases, but then bg_color=#808080 inverts to 7f7f7f. So I changed SHADING_INVERSE so that it's really more of a SHADING_CONTRAST (I left the name alone because you might have chosen to apply my recent widget coloring code, which had SHADING_INVERSE in it somewhere, and it's nice to have patches compile cleanly.) The one negative point I've seen is in something like: <html><head></head><body bgcolor=#808080 text=#808080 link=blue> words words <s>strike</s> <u>underline</u> <a href=link>link</a> words. </body></html> The highlighted text will show no distinction between the underlined text and the link. It didn't seem important enough to bother with at the moment...

Jan. 29, 2008

[PATCH]: escape illegal characters instead of stripping them

by onepoint＠starurchin.org

Oops, I broke the indentation! Here's the same patch, but with corrected whitespace. Jeremy Henty

Jan. 28, 2008

[PATCH]: escape illegal characters instead of stripping them

by onepoint＠starurchin.org

HREF attributes often contain unescaped spaces, even though this is illegal. This is unfortunate because Dillo deletes illegal URL characters, which breaks the link. See, eg. http://www.labreporter.com/Films.html This patch makes Dillo escape all illegal URL characters instead of stripping them. Regards, Jeremy Henty

Jan. 27, 2008

Q: "Yes, enough memory!", really?

by onepoint＠starurchin.org

On Sun, Jan 27, 2008 at 06:17:21PM +0100, Johannes Hofmann wrote: > Hi, > > On Sun, Jan 27, 2008 at 05:11:30PM +0000, Jeremy Henty wrote: > > > > I'm worried about dillo2/src/url.c, line 361: > > > > p = str1 = dNew(char, strlen(url_str)); /* Yes, enough memory! */ > > > > The code after this line copies url_str to str1 , skipping illegal > > characters. It seems to me it should allocate one more character for > > the terminating null character. Does the comment "enough memory" mean > > that I am missing something, or is it talking about some other issue? > > Yeah, looks scary! But this code path is only reached if there is at > least one illegal character, so at least one char will be skipped > and then there is enough room for the \0. OK, I get it! Thanks. I thought I must be missing something since otherwise Dillo would have segfaulted everytime it created a URL, which obviously does not happen. Regards, Jeremy Henty

Jan. 27, 2008

Q: "Yes, enough memory!", really?

by Johannes.Hofmann＠gmx.de

Hi, On Sun, Jan 27, 2008 at 05:11:30PM +0000, Jeremy Henty wrote: > > I'm worried about dillo2/src/url.c, line 361: > > p = str1 = dNew(char, strlen(url_str)); /* Yes, enough memory! */ > > The code after this line copies url_str to str1 , skipping illegal > characters. It seems to me it should allocate one more character for > the terminating null character. Does the comment "enough memory" mean > that I am missing something, or is it talking about some other issue? Yeah, looks scary! But this code path is only reached if there is at least one illegal character, so at least one char will be skipped and then there is enough room for the \0. Regards, Johannes > > Regards, > > Jeremy Henty > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Jan. 27, 2008

Q: "Yes, enough memory!", really?

by onepoint＠starurchin.org

I'm worried about dillo2/src/url.c, line 361: p = str1 = dNew(char, strlen(url_str)); /* Yes, enough memory! */ The code after this line copies url_str to str1 , skipping illegal characters. It seems to me it should allocate one more character for the terminating null character. Does the comment "enough memory" mean that I am missing something, or is it talking about some other issue? Regards, Jeremy Henty

Jan. 27, 2008

Various minor patches

by Christian.Kellermann＠nefkom.net

Skipped content of type multipart/mixed

Jan. 27, 2008

New table layout rocks!

by onepoint＠starurchin.org

On Fri, Jan 25, 2008 at 08:09:14PM +0100, Johannes Hofmann wrote: > > Yes, Jorge did a great job. I've not yet found any regressions and > on some pages it's better than dillo1 was. Another improvement I forgot to mention: I had several links where huge areas of whitespace appeared inside the page. These now render sensibly. The new code seems to be much better at allocating space between the rows and columns. Regards, Jeremy Henty

Jan. 26, 2008

an experiment in widget coloring (with code)

by place＠gobigwest.com

With my color settings, my buttons were light grey with unreadable white labels. Well, that's no good. And standard gui widget colors scream "I'm using a Windows Office Productivity Suite!" to me. So here is something to play with. I currently have the widgets using background color and the labels/text either black or white. fltk_black to make black work right widget_colors.dillo to set backgroundColor in Style. widget_colors.dw where you set the widget colors.

Jan. 25, 2008

Various minor patches

by Johannes.Hofmann＠gmx.de

On Mon, Jan 21, 2008 at 04:03:47PM +0100, Christian Kellermann wrote: > > On Sun, Jan 13, 2008 at 05:07:04PM +0100, Thomas-Martin Seck wrote: > > > 1) detect_libiconv.diff > > > > > > src/decode.c uses iconv_open but - at least on FreeBSD - libiconv > > > is not in the default linker path, making the build abort. Add > > > a simple test to configure.in to check for libiconv's presence > > > and usability and a substitution for ICONV_LIBS to src/Makefile.am. > > > > Very nice! The same problem exists on DragonFly... > > This breaks configure for me (OpenBSD/386 -stable). seems the test does not use the LDFLAGS=-L/usr/local/lib... My knowledge (and motivation) to fiddle with this autoconf hell is limited, so I'd kindly hand the ball over to someone else. What exactly is breaking? Can you provide config.log? Here on DragonFly linking was failing with unresolved symbols, but it turned out that the problem was caused by a libiconv package that was no longer needed. The iconv stuff is now handled in libc on DragonFly... Regards, Johannes > > I am using autoconf-2.61 and automake-1.9. > > Kind regards, > > Christian > > -- > You may use my gpg key for replies: > pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)

Jan. 25, 2008