- Dillo-dev - lists.mailman3.com

patch: meta charset changes decoder

by place＠gobigwest.com

This is no sort of proper fix whatsoever, but I was tired of seeing the "would set charset" message. It's actually surprisingly useful for remote files, since they're generally still at the javascript-and-css point at the end of the first packet.

March 7, 2008

patch: entities in options

by place＠gobigwest.com

I was getting crashes on the dFree(tok) in Html_parse_entity() on a page that I whittled down to: <html> <head> <title></title> </head> <body> <form> <select> <option>&Someword </select> </form> </body> </html> It turns out that strchr(":_.-", '\0') finds the null terminator in the string. diff -pur dillo2/src/html.cc dillo2-cur/src/html.cc --- dillo2/src/html.cc 2008-03-06 14:58:56.000000000 +0000 +++ dillo2-cur/src/html.cc 2008-03-07 05:46:52.000000000 +0000 @@ -1350,7 +1350,7 @@ static int Html_parse_entity(DilloHtml * } else if (isalpha(*s)) { /* character entity reference */ - while (isalnum(*++s) || strchr(":_.-", *s)); + while (*++s && (isalnum(*s) || strchr(":_.-", *s))); c = *s; *s = 0;

March 7, 2008

patch: form data character encoding

by akemnade＠tzi.de

Hi, On Thu, 6 Mar 2008 15:24:37 +0000 "place" <place(a)gobigwest.com> wrote: > Jorge wrote: > > Committed with this change: > > > > - dFree(input); > > + dStr_free(input, 1); > > oops :) > > I hope this goes well because next I have some experimental code > that encodes non-ascii mime parameters (input names). From > what I've read on the web, my suspicion is that it's still not > well-supported by servers and not going to work -- although there's > been some clamoring for it for filename parameters specifically. > > Speaking of files, would anybody have a use for file inputs? > It's the big remaining gap in form submission, but the only > site I use with file inputs is quite javascripty. > Yes, me! As far as I can remember, I had to switch browsers several times because of dillo's lack of file input support. At least one site I use quite often has such a file input. Greetings Andreas Kemnade

March 6, 2008

[patch] simplify Region::addRectangle ()

by Johannes.Hofmann＠gmx.de

On Wed, Mar 05, 2008 at 03:22:09PM -0300, Jorge Arellano Cid wrote: > On Wed, Mar 05, 2008 at 06:19:49PM +0100, Johannes Hofmann wrote: > > Hi, > > > > the patch below simplifies Region::addRectangle () quite a bit. It > > now simply tries to minimize the sum of the areas of all rectangles > > in the Region while still covering all rectangles that have been > > added with addRectangle (). For example if we have > > > > Thereby the total area that is actually redrawn is reduced > > and the code gets much simpler. > > However it may now happen that small parts of the > > screen are drawn that were not requested to be drawn. > > It looks like a part of the explanation got trimmed. > Would you mind resend it? Yeah, I had started some fancy ASCII art which got more complex than the code involved :-) Cheers, Johannes

March 6, 2008

patch: form data character encoding

by place＠gobigwest.com

Jorge wrote: > Committed with this change: > > - dFree(input); > + dStr_free(input, 1); oops :) I hope this goes well because next I have some experimental code that encodes non-ascii mime parameters (input names). From what I've read on the web, my suspicion is that it's still not well-supported by servers and not going to work -- although there's been some clamoring for it for filename parameters specifically. Speaking of files, would anybody have a use for file inputs? It's the big remaining gap in form submission, but the only site I use with file inputs is quite javascripty.

March 6, 2008

patch: form data character encoding

by jcid＠dillo.org

On Wed, Mar 05, 2008 at 08:23:30PM +0000, place wrote: > It seems to be working well. > For example, you can go to www.google.gr and paste in ????????????????. > Instead of 2530 hits of gibberish, you now get 57,400,000 of Greek. > > I ran it through various tests, but of course it'll get better testing > from those of you who routinely use ?'s and ?'s and so on. > It's an annoyance that fltk won't allow normal X character composing. > I don't want to learn their special rules, so I have to paste anything > non-ascii from an xterm. Committed with this change: - dFree(input); + dStr_free(input, 1); Please check... ;-) -- Cheers Jorge.-

March 6, 2008

[patch] simplify Region::addRectangle ()

by jcid＠dillo.org

On Wed, Mar 05, 2008 at 06:19:49PM +0100, Johannes Hofmann wrote: > Hi, > > the patch below simplifies Region::addRectangle () quite a bit. It > now simply tries to minimize the sum of the areas of all rectangles > in the Region while still covering all rectangles that have been > added with addRectangle (). For example if we have > > Thereby the total area that is actually redrawn is reduced > and the code gets much simpler. > However it may now happen that small parts of the > screen are drawn that were not requested to be drawn. OK, forget the extra explanation, I read and understood the code and it looks quite reasonable. Committed. -- Cheers Jorge.-

March 5, 2008

patch: form data character encoding

by place＠gobigwest.com

It seems to be working well. For example, you can go to www.google.gr and paste in ????????. Instead of 2530 hits of gibberish, you now get 57,400,000 of Greek. I ran it through various tests, but of course it'll get better testing from those of you who routinely use ?'s and ?'s and so on. It's an annoyance that fltk won't allow normal X character composing. I don't want to learn their special rules, so I have to paste anything non-ascii from an xterm.

March 5, 2008

[patch] simplify Region::addRectangle ()

by jcid＠dillo.org

On Wed, Mar 05, 2008 at 06:19:49PM +0100, Johannes Hofmann wrote: > Hi, > > the patch below simplifies Region::addRectangle () quite a bit. It > now simply tries to minimize the sum of the areas of all rectangles > in the Region while still covering all rectangles that have been > added with addRectangle (). For example if we have > > Thereby the total area that is actually redrawn is reduced > and the code gets much simpler. > However it may now happen that small parts of the > screen are drawn that were not requested to be drawn. It looks like a part of the explanation got trimmed. Would you mind resend it? -- Cheers Jorge.-

March 5, 2008

[patch] simplify Region::addRectangle ()

by Johannes.Hofmann＠gmx.de

Hi, the patch below simplifies Region::addRectangle () quite a bit. It now simply tries to minimize the sum of the areas of all rectangles in the Region while still covering all rectangles that have been added with addRectangle (). For example if we have Thereby the total area that is actually redrawn is reduced and the code gets much simpler. However it may now happen that small parts of the screen are drawn that were not requested to be drawn. This patch does not reduce any flickering. Cheers, Johannes diff --git a/dw/types.cc b/dw/types.cc --- a/dw/types.cc +++ b/dw/types.cc @@ -240,40 +240,22 @@ void Region::addRectangle (Rectangle *rP for (it = rectangleList->iterator (); it.hasNext (); ) { Rectangle *ownRect = it.getNext (); - /* check if r an ownRect can be combined vertically */ - if (r->x == ownRect->x && r->width == ownRect->width) { - int combinedHeight = - misc::max(r->y + r->height, ownRect->y + ownRect->height) - - misc::min(r->y, ownRect->y); + int combinedHeight = + misc::max(r->y + r->height, ownRect->y + ownRect->height) - + misc::min(r->y, ownRect->y); + int combinedWidth = + misc::max(r->x + r->width, ownRect->x + ownRect->width) - + misc::min(r->x, ownRect->x); - if (combinedHeight <= r->height + ownRect->height) { + if (combinedWidth * combinedHeight <= + ownRect->width * ownRect->height + r->width * r->height) { + + r->x = misc::min(r->x, ownRect->x); r->y = misc::min(r->y, ownRect->y); + r->width = combinedWidth; r->height = combinedHeight; + rectangleList->removeRef (ownRect); - } - - /* check if r an ownRect can be combined horizontally */ - } else if (r->y == ownRect->y && r->height == ownRect->height) { - int combinedWidth = - misc::max(r->x + r->width, ownRect->x + ownRect->width) - - misc::min(r->x, ownRect->x); - - if (combinedWidth <= r->width + ownRect->width) { - r->x = misc::min(r->x, ownRect->x); - r->width = combinedWidth; - rectangleList->removeRef (ownRect); - } - } - } - - for (it = rectangleList->iterator (); it.hasNext (); ) { - Rectangle *ownRect = it.getNext (); - - if (r->isSubsetOf (ownRect)) { - delete r; - return; - } else if (ownRect->isSubsetOf (r)) { - rectangleList->removeRef (ownRect); } } diff --git a/dw/types.hh b/dw/types.hh --- a/dw/types.hh +++ b/dw/types.hh @@ -121,6 +121,8 @@ public: * \brief dw::core::Shape implementation for a point set. * Currently represented as a set of rectangles not containing * each other. + * It is guaranteed that the rectangles returned by rectangles () + * cover all rectangles that were added with addRectangle (). */ class Region: public Shape {

March 5, 2008