- Dillo-dev - lists.mailman3.com

[patch] don't allocate tagnames on stack

by jcid＠dillo.org

On Sun, Mar 16, 2008 at 05:05:57PM +0100, Johannes Hofmann wrote: > On Sun, Mar 16, 2008 at 10:47:07AM -0400, Jorge Arellano Cid wrote: > > On Thu, Mar 13, 2008 at 09:01:37PM +0100, Johannes Hofmann wrote: > > > Hi, > > > > > > here is another patch that avoids some malloc/free calls. > > > > > > > I decided to completely remove tag_name, and to use Tags[tag_idx]. > > Please check the patch in CVS. > > Cool. That's even better. > > > > > BTW, with regard to these optimizations (which I was very fond of), > > profiling showed me that the zen of speed is to attack the main bottleneck... > > Can you build a statically linked binary with > profiling enabled? Here it does not work for some reason, so the > timings in the gprof output are bogus. Only the counters work > reliably. I've done it lots of times in the past, with: ./configure --enable-gprof or CFLAGS="-g -O0" CXXFLAGS="-g -O0" ./configure --enable-gprof but now that I test, it doesn't work anymore! !? -- Cheers Jorge.-

March 20, 2008

https plugin status

by jcid＠dillo.org

On Sat, Mar 15, 2008 at 08:21:23PM +0000, Jeremy Henty wrote: > On Sat, Mar 15, 2008 at 03:31:52PM -0400, Jorge Arellano Cid wrote: > > > > [Jeremey wrote] > > > Or maybe Capi_url_uses_dpi() should be checking for "https" and > > > *not* adding the "proto." prefix? > > > > "proto.https" is the right patch. > > OK, what about my patch to redirect MSG debugging messages from stdout > to stderr? Is that correct? Dpi programs are reading and writing from the stdin descriptor, and all of them send debug messages to stdout. I think this is correct, or at least standard by now. -- Cheers Jorge.-

March 20, 2008

patch: conditionally sending Cookie2: Re: [Dillo-dev] Re: patch: cookies string leak

by jcid＠dillo.org

On Wed, Mar 19, 2008 at 07:55:35PM +0000, place wrote: > Jorge wrote: > > I just noticed that calling current CVS with: > > > > http://www.fltk.org/newsgroups.php?gfltk.general+v:24912 > > > > completely blocks the browser. > > > > It doesn't happen with older dillo2 versions. > > > > Please give it a look. > > No problems for me, either with or without cookies. Oh! I'm on dialup now and have: www.fltk.org ACCEPT_SESSION in cookiesrc. It blocks for me on every try... -- Cheers Jorge.-

March 20, 2008

patch: conditionally sending Cookie2: Re: [Dillo-dev] Re: patch: cookies string leak

by onepoint＠starurchin.org

On Wed, Mar 19, 2008 at 07:55:35PM +0000, place wrote: > Jorge wrote: > > I just noticed that calling current CVS with: > > > > http://www.fltk.org/newsgroups.php?gfltk.general+v:24912 > > > > completely blocks the browser. > > > > It doesn't happen with older dillo2 versions. > > > > Please give it a look. > > No problems for me, either with or without cookies. It consistently hangs the latest CVS for me. I have attached the gdb backtrace. For a while not so long ago one of my ISP's pages also hung Dillo in a_Dpi_send_blocking_cmd() . The problem went away before I got round to investigating it properly. I don't know if it fixed itself due to a change in the page, a change in Dillo or some other factor. I mention it now to point out that this problem *may* have been around for a little while in some form or other (though I can't be certain). Regards, Jeremy Henty

March 20, 2008

patch: conditionally sending Cookie2: Re: [Dillo-dev] Re: patch: cookies string leak

by place＠gobigwest.com

Jorge wrote: > I just noticed that calling current CVS with: > > http://www.fltk.org/newsgroups.php?gfltk.general+v:24912 > > completely blocks the browser. > > It doesn't happen with older dillo2 versions. > > Please give it a look. No problems for me, either with or without cookies.

March 19, 2008

patch: conditionally sending Cookie2: Re: [Dillo-dev] Re: patch: cookies string leak

by jcid＠dillo.org

On Mon, Feb 04, 2008 at 08:10:25PM +0000, place wrote: > Jorge wrote: > > On Fri, Feb 01, 2008 at 06:26:56PM +0000, place wrote: > > > Also, what would you think of me either > > > > > > - stuffing the "Cookie2: $Version=\"1\"\r\n" header into a_Cookies_get(url) > > > > OK. > > attached. > > I renamed it a_Cookies_get_query() in an effort > to suggest that it now returned more than just > the cookies. > > > Everything looks fine when I watch the headers, > but I don't use dillo for anything that _relies_ > on cookies working properly. > > So...anyone who habitually uses cookies might want > to give this a bit of a test. I just noticed that calling current CVS with: http://www.fltk.org/newsgroups.php?gfltk.general+v:24912 completely blocks the browser. It doesn't happen with older dillo2 versions. Please give it a look. -- Cheers Jorge.-

March 19, 2008

[jcid@dillo.org: Re: [Dillo-dev] Re: patch: concatenate Dstrs]

by jcid＠dillo.org

-- Cheers Jorge.-

March 19, 2008

Re: patch: concatenate Dstrs

by jcid＠dillo.org

On Tue, Mar 18, 2008 at 07:48:00PM +0000, place wrote: > Jorge wrote: > > Does anybody else have some experience/theory/article/knowledge on API > > design that can enlighten us? > > > > ;) > > I just meant "okay, never mind". Understood. My point is there're other places in dillo where a more formal API definition is needed, and I'd like to know whether there's some theory or guiding experience that could help. -- Cheers Jorge.-

March 19, 2008

Re: patch: concatenate Dstrs

by place＠gobigwest.com

Jorge wrote: > Does anybody else have some experience/theory/article/knowledge on API > design that can enlighten us? > > ;) I just meant "okay, never mind".

March 18, 2008

Re: patch: concatenate Dstrs

by jcid＠dillo.org

On Tue, Mar 18, 2008 at 02:14:06PM +0000, place wrote: > > On Mon, Mar 17, 2008 at 11:35:05PM +0000, place wrote: > > > I made a dStr_dstrcat(). > > > > > > > What's the main advantage of it, over dStr_append_l() ? > > > > I see the convenience and clarity of passing two parameters instead > > of three, but on the other hand, keeping APIs reduced to a functional > > minimum, helps to remember and to choose the right function call. > > > > There may be a point I don't yet see... > > Nope, that's all there was to it. > And I don't have a strong opinion about it, so that's fine. Does anybody else have some experience/theory/article/knowledge on API design that can enlighten us? ;) -- Cheers Jorge.-

March 18, 2008