- Dillo-dev - lists.mailman3.com

[patch] dw2 memory reduction

by Johannes.Hofmann＠gmx.de

On Sat, May 24, 2008 at 04:39:42PM -0400, Jorge Arellano Cid wrote: > On Sat, May 24, 2008 at 02:58:08PM +0200, Johannes Hofmann wrote: > > Hi, > > > > attached is patch to reduce the memory usage of dw2: > > Excellent! > (AFAIU this is near 30% memory usage reduction in dw2) > > Committed. > > > > > * Styles are now reused if they are equal. This brings down the > > number of Style objects on the mysql page from around 180000 to > > 23000 and reduces memory usage by about 25M at the cost of an > > additional HashTable. > > Maybe the hash table should be part of fltkplatform > > as the hash tables for Color and Font? > > There would be even more sharing of styles possible, if > > x_link would not be part of style. On the other hand about 3M for > > styles on the huge mysql page is pretty ok. > > > > * Size of struct Word is reduced by 4 integers by using shorts. I > > know that this is questionable, but I think in the case of struct > > Word that can be allocated a lot it is worth the hassle. > > Please check whether my assumption that space lengths and word > > lengths can be stored in shorts are valid in general. > > It looks OK at first sight, but to be sure it'd be good to know > what happens when the limit is surpassed. > > BTW, "unsigned short" looks like a good idea for origSpace and effSpace. > > > Also memory usage gets pretty high (250M with images disabled). > > I'm experimenting with reducing the size of struct Word in > > textblock.hh by moving the highlight stuff out of struct Word and > > into Textblock. This brings memory usage down to 199M. > > However, I don't know the highlighting stuff enough to be sure I > > don't break anything. This probabely falls into the > > "premature optimization" category anyway. > > hlStart and hlEnd use -1 as a value, so they can't be unsigned. > I don't know whether they can be taken out, and how much impact > it can have (alignment issues are strange sometimes). I have a version here where hlStart and hlEnd are taken out of struct Word. Instead I have just one hlStart and hlEnd containing the also the word index in Textblock. This is under the assumption that highlighting is only possible for one contiguous region per layer. Unfortunately this patch is still in the "works almost" state. Cheers, Johannes

May 25, 2008

[patch] dw2 memory reduction

by jcid＠dillo.org

On Sat, May 24, 2008 at 02:58:08PM +0200, Johannes Hofmann wrote: > Hi, > > attached is patch to reduce the memory usage of dw2: Excellent! (AFAIU this is near 30% memory usage reduction in dw2) Committed. > > * Styles are now reused if they are equal. This brings down the > number of Style objects on the mysql page from around 180000 to > 23000 and reduces memory usage by about 25M at the cost of an > additional HashTable. > Maybe the hash table should be part of fltkplatform > as the hash tables for Color and Font? > There would be even more sharing of styles possible, if > x_link would not be part of style. On the other hand about 3M for > styles on the huge mysql page is pretty ok. > > * Size of struct Word is reduced by 4 integers by using shorts. I > know that this is questionable, but I think in the case of struct > Word that can be allocated a lot it is worth the hassle. > Please check whether my assumption that space lengths and word > lengths can be stored in shorts are valid in general. It looks OK at first sight, but to be sure it'd be good to know what happens when the limit is surpassed. BTW, "unsigned short" looks like a good idea for origSpace and effSpace. > Also memory usage gets pretty high (250M with images disabled). > I'm experimenting with reducing the size of struct Word in > textblock.hh by moving the highlight stuff out of struct Word and > into Textblock. This brings memory usage down to 199M. > However, I don't know the highlighting stuff enough to be sure I > don't break anything. This probabely falls into the > "premature optimization" category anyway. hlStart and hlEnd use -1 as a value, so they can't be unsigned. I don't know whether they can be taken out, and how much impact it can have (alignment issues are strange sometimes). > * SimpleVector no longer preallocates memory if it's not necessary. > This actually saves some megabytes here! > > With these changes memory usage on the mysql page is 179M here. Great. -- Cheers Jorge.-

May 25, 2008

remaining preferences

by corvid＠lavabit.com

# Dicache is where the Decompressed Images are cached (not the original ones). # If you have a lot of memory and a slow CPU, use YES, otherwise use NO use_dicache The code always behaves like use_dicache=NO /* * Unrefs the counter of a dicache entry, and _if_ no DwImage is acessing * this buffer, then we call Dicache_free to do the dirty job. */ void a_Dicache_unref(const DilloUrl *Url, int version) { DICacheEntry *entry; if ((entry = Dicache_get_entry_version(Url, version))) { /*if (--entry->RefCount == 0 && (entry->next || !prefs.use_dicache)) {*/ if (--entry->RefCount == 0) { Dicache_remove(Url, version); } } } Perhaps this was done for a reason. # If you prefer oblique over italic fonts, uncoment next line use_oblique FLTK doesn't know about oblique. I don't know whether anybody cares enough to change that. I don't. # Show tooltip popup for images? # Note: We use the "title" attribute and not "alt". # More info at: http://bugzilla.mozilla.org/show_bug.cgi?id=25537 show_tooltip I did the easy part of tooltips long ago, but I haven't been able to care enough to want to do the fltk part. # Set this to YES, if you want to limit the word wrap width to the vieport # width (may be useful for iPAQ) limit_text_width It doesn't do anything. I don't think it's ever done anything. It sure would be nice if it did something. But I don't have the expertise to change that. # Here you can choose to hide some widgets of the dillo panel... show_menubar Not currently used. Meaningless with the current panel-cycling with right click on the search button (which I imagine is not going to be the permanent way to do that). # Enabling this will restrain OpenUrl and FindText, but may be required # for the ION window manager. transient_dialogs from fltk::Window::child_of(): Tell the system that this window will not have an icon, it will dissappear and reappear when \a parent is iconized or shown, and it is forced to always be above \a parent. On X this is called a "Transient window", and Windows calls this a "overlapping child". \a parent is different than the parent(), which must be zero. (and down in fltk::CreatedWindow::create, there's a if (window->child_of() && window->child_of()->shown()) XSetTransientForHint(xdisplay, x->xid, window->child_of()->i->xid);) If Justus gets rid of the dialogs, obviously the pref can be removed. Enabling this means making our own dialogs for message(), choice(), input(). # When filling forms, our default behaviour is to submit on enterpress, # but only when there's a single text entry (to avoid incomplete submits). # OTOH, if you have to fill the same form lots of times, you may find # useful to keep away from the mouse by forcing enter to submit. enterpress_forces_submit The code currently always submits on enter. I like it that way and didn't realize that it wasn't supposed to.

May 24, 2008

Q: why does Nav_stack_clean() free the data and Nav_stack_truncate() not?

by onepoint＠starurchin.org

While reviewing nav.c to figure out the reload crash bug I noticed something that seems inconsistent: both Nav_stack_truncate() and Nav_stack_clean() remove items from the navigation stack, yet Nav_stack_truncate() does not free the data it removes and Nav_stack_clean() does. Is this a bug? If not, what haven't I understood? Regards, Jeremy Henty

May 24, 2008

[BUG]: Redirect to previous page + Reload crashes

by onepoint＠starurchin.org

On Sat, May 24, 2008 at 03:22:10AM +0000, corvid wrote: > Jeremy wrote: > > Dillo crashes as follows: > > * Point Dillo at http://starurchin.org:8080/dillo/here > > * Click the "There" link. Dillo is redirected back to the "Here" > > page. > > * Click the "Reload" button. > > * Dillo crashes inside a_Nav_reload() (nav.c) at the line "if > > (URL_FLAGS(url) & URL_Post) {" because url is NULL. > > The problem went away when I tried the attached change, > but I may be treating the symptom rather than the disease. > diff -pur dillo2/src/nav.c dillo2-cur/src/nav.c > --- dillo2/src/nav.c 2008-05-10 20:02:22.000000000 +0000 > +++ dillo2-cur/src/nav.c 2008-05-24 03:03:50.000000000 +0000 > @@ -185,6 +185,8 @@ static void Nav_stack_clean(BrowserWindo > void *data = dList_nth_data (bw->nav_stack, i - 1); > dList_remove_fast (bw->nav_stack, data); > dFree(data); > + if (bw->nav_stack_ptr >= a_Nav_stack_size(bw)) > + bw->nav_stack_ptr = a_Nav_stack_size(bw) - 1; > } > } > I think this addresses the real problem, which is that bw->nav_stack_ptr is an index into bw->nav_stack , so if we modify the latter we must ensure the former is valid. Reviewing the rest of nav.c I think there is a similar potential problem with Nav_stack_insert() , which also modifies bw->nav_stack . Shouldn't it increment bw->nav_stack_ptr if it is after the insertion point? Otherwise the displayed item might change unexpectedly. Regards, Jeremy Henty

May 24, 2008

Profiling works!

by jcid＠dillo.org

On Sat, May 24, 2008 at 05:15:40PM +0100, Jeremy Henty wrote: > On Sat, May 24, 2008 at 05:03:31PM +0100, Jeremy Henty wrote: > > > [Dillo] puts [gmon.prof] in /tmp (perhaps that's why it didn't seem > > to be working). Dillo also dumps its core to /tmp ... > > Well, duh, after writing that I thought to check the source, and > main() calls a_Dir_init() which calls chdir("/tmp") . No wonder > everything ends up in /tmp ! LOL! :-) Even more, I downloaded the profile data posted by Johannes to /tmp, so it was no surprise to find a gprof data file there. -- Cheers Jorge.-

May 24, 2008

patch: trim Local_Buf

by jcid＠dillo.org

On Fri, May 23, 2008 at 05:31:30PM +0200, Johannes Hofmann wrote: > Hey that's cool! I thought about doing something like this, but > didn't find a good way. I thought it would grow much more complicated. Committed with some changes. Note that this may help when fetching a huge page through the network (i.e. in chunks). When it comes from the cache, it's one big chunk of data. -- Cheers Jorge.-

May 24, 2008

Profiling works!

by onepoint＠starurchin.org

On Sat, May 24, 2008 at 05:03:31PM +0100, Jeremy Henty wrote: > [Dillo] puts [gmon.prof] in /tmp (perhaps that's why it didn't seem > to be working). Dillo also dumps its core to /tmp ... Well, duh, after writing that I thought to check the source, and main() calls a_Dir_init() which calls chdir("/tmp") . No wonder everything ends up in /tmp ! Regards, Jeremy Henty

May 24, 2008

Profiling works!

by onepoint＠starurchin.org

I added -pg to LDFLAGS, CFLAGS and CXXFLAGS and dillo generated a nice gmon.prof ! However, it puts it in /tmp (perhaps that's why it didn't seem to be working). Dillo also dumps its core to /tmp when it crashes, perhaps for the same reason? Regards, Jeremy Henty

May 24, 2008

Uncluttering dillo, part II: the findbar

by jcid＠dillo.org

On Fri, May 23, 2008 at 07:01:51PM +0200, Johannes Hofmann wrote: > On Thu, May 22, 2008 at 12:32:07PM -0400, Jorge Arellano Cid wrote: > > On Wed, May 21, 2008 at 05:43:05PM +0200, Johannes Hofmann wrote: > > > Hi Justus, > > > > > > On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote: > > > > -----BEGIN PGP SIGNED MESSAGE----- > > > > Hash: SHA1 > > > > > > > > Hey everyone :) > > > > > > > > attached is a patch that transforms dillos find in page dialog box into > > > > a firefox style toolbar. There are some issues that I cannot put my > > > > finger on... see the comments in the event handler. Maybe there's some > > > > magic about fltks event model that I did not fully understand... then > > > > again it might be fltks fault. Anyway, I'd be happy for some hints. > > > > > > This is really nice! For text search the popup menus are even more > > > annoying than for entering an url. > > > > > > One minor thing. You can make the CheckButton and Input members of > > > Findbar private if you use static methods for the callbacks instead > > > of functions. > > > > Yes, I agree. > > Patch attached. Committed. -- Cheers Jorge.-

May 24, 2008