- Dillo-dev - lists.mailman3.com

html.cc: convert Html_*_reset functions to methods

by jcid＠dillo.org

On Tue, May 27, 2008 at 05:03:13PM +0100, Jeremy Henty wrote: > > This changes Html_reset_form() to DilloHtmlForm::reset() and > Html_reset_input() to DilloHtmlInput::reset() . It's part of the plan > to move code that accesses DilloHtmlForm and DilloHtmlInput internals > into methods and make the internals private. > > The patch is in two parts: the first makes the changes and the second > moves the new methods to the right place in the file. If I roll the > changes and the move into one then "diff" gets confused and creates an > unreadable monster of a patch. I'd recommend feeding the two > attachments to patch separately; it might do the right thing given the > whole message in one go, but then again it might not. > > Comments are welcome. Patch committed. BTW, here diff made a nice single patch. BUG: Please notice that forms "reset" doesn't reset selection lists. (it also wasn't working before the patch). > There are several other functions in html.cc > that are really just methods in disguise and are future targets for > the same treatment as Html_reset_form() and Html_reset_input() get > here. OK. -- Cheers Jorge.-

May 27, 2008

html.cc: convert Html_*_reset functions to methods

by onepoint＠starurchin.org

This changes Html_reset_form() to DilloHtmlForm::reset() and Html_reset_input() to DilloHtmlInput::reset() . It's part of the plan to move code that accesses DilloHtmlForm and DilloHtmlInput internals into methods and make the internals private. The patch is in two parts: the first makes the changes and the second moves the new methods to the right place in the file. If I roll the changes and the move into one then "diff" gets confused and creates an unreadable monster of a patch. I'd recommend feeding the two attachments to patch separately; it might do the right thing given the whole message in one go, but then again it might not. Comments are welcome. There are several other functions in html.cc that are really just methods in disguise and are future targets for the same treatment as Html_reset_form() and Html_reset_input() get here. Regards, Jeremy Henty

May 27, 2008

html.cc: small tweak for consistency and debugging

by onepoint＠starurchin.org

This renames a local variable from "size" to "nf". This is consistent with the names of similar local variables elsewhere in the file and also ensures that the _MSG statement will compile if debugging is enabled. Jeremy Henty

May 27, 2008

Re: (working) prototype of charset decoding in cache.c

by jcid＠dillo.org

On Mon, May 26, 2008 at 08:50:19PM +0000, corvid wrote: > Jorge wrote: > > > But I mean it finishes seeing the first head, enables view source, > > > user views the source, and then the charset in the second head causes > > > a repush. Is the parser avoiding that? > > > > Yes, once you are IN_BODY, HEAD can't be re-opened, > > and META doesn't work outside HEAD. > > But if I give it a page containing > > <html> > <head> <title>first head</title> </head> > <body> body </body> > <head> > <meta http-equiv="content-type" content="text/html; charset=iso-8859-1"> > </head> > </html> > > I get > > .. > META Content-Type changes charset to: iso-8859-1 > .. > META Content-Type gave charset as: iso-8859-1 > a_Nav_expect_done: repush! That's a corner case bug. It passed because you closed BODY explicitly (i.e. if you remove the </body> tag, the fault is caught. Patch committed. > > I'd prefer to try the dpi before optimizing. > > I don't know dpis, so to me that's the difficult way... Then let's focus in the decoder. -- Cheers Jorge.-

May 27, 2008

[patch]: html.cc: DilloHtmlInput class: WAS: DilloHtmlForm::getCurrentInput()

by jcid＠dillo.org

On Tue, May 27, 2008 at 10:43:51AM +0100, Jeremy Henty wrote: > > This turns DilloHtmlInput into a class and adds a constructor and > destructor to manage its data members. Note that > DilloHtmlForm::inputs is now a vector of pointers instead of structs. > This is consistent with the earlier change to DilloHtml::forms . OK. Committed. -- Cheers Jorge.-

May 27, 2008

[patch]: html.cc: DilloHtmlForm::getCurrentInput()

by jcid＠dillo.org

On Tue, May 27, 2008 at 01:26:26AM +0100, Jeremy Henty wrote: > > Except that I didn't include the patch. Here it is. Committed. -- Cheers Jorge.-

May 27, 2008

[patch]: html.cc: DilloHtmlInput class: WAS: DilloHtmlForm::getCurrentInput()

by onepoint＠starurchin.org

This turns DilloHtmlInput into a class and adds a constructor and destructor to manage its data members. Note that DilloHtmlForm::inputs is now a vector of pointers instead of structs. This is consistent with the earlier change to DilloHtml::forms . I think the next task is to move code that accesses DilloHtmlInput internals into DilloHtmlInput methods. In particular, if we can make the type member private we can consider replacing it in favour of a class hierarchy. Comments are welcome, Jeremy Henty

May 27, 2008

[patch]: html.cc: DilloHtmlForm::getCurrentInput()

by onepoint＠starurchin.org

Except that I didn't include the patch. Here it is. Jeremy Henty

May 27, 2008

an experiment in widget coloring

by corvid＠lavabit.com

I saw a page that reminded me that the matter of when to have light text vs. dark text on widgets was not decided. earlier discussion: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-February/003760.html trimmed-down bit of the page I saw: <form> <table bgcolor="#F8C473"> <tr><td> <input type="submit" value="I can hardly see the text"> </table> </form>

May 27, 2008

[patch]: html.cc: DilloHtmlForm::getCurrentInput()

by onepoint＠starurchin.org

This refactors DilloHtmlForm code into a new "inline DilloHtmlInput *getCurrentInput()" method. It's just like the earlier patch that created DilloHtml::getCurrentForm() . Comments are welcome, although I hope it is uncontroversial. Regards, Jeremy Henty

May 27, 2008