- Dillo-dev - lists.mailman3.com

Previous patches a la camelCase

by jcid＠dillo.org

On Wed, May 28, 2008 at 05:29:35PM +0100, Jeremy Henty wrote: > > In case Jorge prefers them, here are revised versions of today's > patches with camelCased method names. Patch set Committed! -- Cheers Jorge.-

May 29, 2008

[patch]: html.cc: change Html_add_input() to HtmlForm::add_input()

by jcid＠dillo.org

On Wed, May 28, 2008 at 02:31:54PM +0100, Jeremy Henty wrote: > [...] > As before I'm submitting this as a "change diff" + "move > diff" to make it easier to review. Reviewers please tell me if it > makes things harder instead! So far it's been a pleasure to review in this format, but this is not a definitive answer because this is not a complex changeset. For the later case I'd like to have it munched like this anyway. ;) -- Cheers Jorge.-

May 29, 2008

[patch]: simplify a_Html_form_event_handler(): part II

by onepoint＠starurchin.org

More simplification of form handling. Several functions that used an index to an input in the form's input list have been changed to use a pointer to the input, which removed some useless indirection. This enabled refactoring the code in a_Html_form_event_handler() that found the input from the resource into a new method "DilloHtmlInput *DilloHtmlForm::getInput (void *v_resource)". Regards, Jeremy Henty

May 29, 2008

[patch]: simplify a_Html_form_event_handler()

by onepoint＠starurchin.org

The a_Html_form_event_handler() function displays an amusing anti-pattern (which I wish I knew the name of) where it's not given enough data and has to go searching for the missing information. Specifically, it gets a pointer to the DilloHtml of the page, but not not the DilloHtmlForm that submitted it, so it has to search the form list of the DilloHtml to find the form. This patch passes the DilloHtmlForm to the handler and adds a pointer from the DilloHtmlForm to the DilloHtml , so the handler can now directly access the form and the html without messing around. Regards, Jeremy Henty

May 29, 2008

[patch]: convert Html_submit_form2() to DilloHtmlForm::buildQueryUrl()

by onepoint＠starurchin.org

The function Html_submit_form2() does two jobs rolled into one: most of its code creates a url from a DilloHtmlForm and a few lines push the url to a DilloHtml . This patch takes advantage of the fact that Html_submit_form2() is only called from a_Html_form_event_handler() ; it moves the url push out into the caller and the rest of the code into a new method "DilloUrl *DilloHtmlForm::buildQueryUrl()". This separates concerns nicely: the DilloHtmlForm creates the url and a_Html_form_event_handler() pushes it to the DilloHtml . We're getting close to having a proper API for DilloHtmlForm , unfortunately some of the remaining code is very messy. I'll do the rest of the easy stuff and then summarise what's left. Regards, Jeremy Henty

May 29, 2008

Previous patches a la camelCase

by onepoint＠starurchin.org

In case Jorge prefers them, here are revised versions of today's patches with camelCased method names. Regards, Jeremy Henty

May 28, 2008

[patch]: html.cc: change Html_make_multipart_boundary() to DilloHtmlForm::make_multipart_boundary()

by onepoint＠starurchin.org

More of the same. I'll hold off sending any more patches until these three have been reviewed. (Especially since I just remembered Jorge will probably want to camelCase the method names. D'oh!) Regards, Jeremy Henty

May 28, 2008

[patch]: html.cc: rename Html_build_query_data() to DilloHtmlForm::build_query_data()

by onepoint＠starurchin.org

Does what it says on the tin! There's no "move diff" for this one due to declaration order dependencies. I expect the move will happen after the functions that access DilloHtmlInput internals are converted to DilloHtmlInput methods. Regards, Jeremy Henty

May 28, 2008

[patch]: html.cc: change Html_add_input() to HtmlForm::add_input()

by onepoint＠starurchin.org

This changes the Html_add_input() function to an HtmlForm::add_input() method. As before I'm submitting this as a "change diff" + "move diff" to make it easier to review. Reviewers please tell me if it makes things harder instead! Regards, Jeremy Henty

May 28, 2008

html.cc: convert Html_*_reset functions to methods

by onepoint＠starurchin.org

On Tue, May 27, 2008 at 02:18:29PM -0400, Jorge Arellano Cid wrote: > On Tue, May 27, 2008 at 05:03:13PM +0100, Jeremy Henty wrote: > > > > The patch is in two parts: the first makes the changes and the > > second moves the new methods to the right place in the file. If I > > roll the changes and the move into one then "diff" gets confused > > and creates an unreadable monster of a patch. > > [...] BTW, here diff made a nice single patch. I might have messed up the cut and paste on the first attempt and moved more code than I intended, which is why I got the monster diff. However I think that splitting up the patch into a change diff and a move diff might be better for reviewers as it gives them a diff that shows exactly what has changed rather than forcing them to manually compare a delete chunk in one place with an add chunk elsewhere. So I might continue splitting up diffs this way, unless you and the other reviewers think it just makes more work. > BUG: Please notice that forms "reset" doesn't reset selection > lists. (it also wasn't working before the patch). to_do_list++; Regards, Jeremy Henty

May 28, 2008