- Dillo-dev - lists.mailman3.com

[patch] remove asap parameter

by jcid＠dillo.org

On Wed, Sep 10, 2008 at 04:20:50PM +0200, Johannes Hofmann wrote: > On Tue, Sep 09, 2008 at 07:32:14PM -0400, Jorge Arellano Cid wrote: > > On Tue, Sep 09, 2008 at 06:07:16PM +0200, Johannes Hofmann wrote: > > > Hi Jorge, > > > > > > any objections to remove the asap parameter as in attached patch? > > > It has been disabled for quite some time now. > > > > I made a mistake during the dw2 commit, then fixed it, and it > > looks OK, but please check it. > > Looks good. Just a comment replacing a ifdef'd block is missing. > See attached patch. Committed. -- Cheers Jorge.-

Sept. 10, 2008

patch: more widget coloring

by corvid＠lavabit.com

Johannes wrote: > On Wed, Sep 10, 2008 at 04:56:47AM +0000, corvid wrote: > > > By the way, I was looking at that big page of inputs with > > > differently-colored backgrounds that I made in February... > > > At the time, I wrote that you guys had gotten the page down to > > > 0:06 to load with clear_double_buffer(), > > > immediate to load without it, and > > > 0:09 to destroy the page. > > > > > > The good news is that it now takes the same amount of time > > > with or without clear_double_buffer(), but > > > the bad news is that it takes 0:12 to load and 0:48 to close. > > > > If I assume that you can only have one instance of a widget in a view > > and add a break to the loop in FltkWidgetView::removeFltkWidget() > > once it finds it, the 0:48 becomes 0:03. > > Ah, interesting. In that case I'd ditch the canvasWidgets list > entirely as in attached patch. > > Cheers, > Johannes > > PS: Can you share that test page? I just meant the one generated from the code on: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-February/003760.html

Sept. 10, 2008

patch: more widget coloring

by Johannes.Hofmann＠gmx.de

ok, here's the patch ... On Wed, Sep 10, 2008 at 05:05:34PM +0200, Johannes Hofmann wrote: > On Wed, Sep 10, 2008 at 04:56:47AM +0000, corvid wrote: > > > By the way, I was looking at that big page of inputs with > > > differently-colored backgrounds that I made in February... > > > At the time, I wrote that you guys had gotten the page down to > > > 0:06 to load with clear_double_buffer(), > > > immediate to load without it, and > > > 0:09 to destroy the page. > > > > > > The good news is that it now takes the same amount of time > > > with or without clear_double_buffer(), but > > > the bad news is that it takes 0:12 to load and 0:48 to close. > > > > If I assume that you can only have one instance of a widget in a view > > and add a break to the loop in FltkWidgetView::removeFltkWidget() > > once it finds it, the 0:48 becomes 0:03. > > Ah, interesting. In that case I'd ditch the canvasWidgets list > entirely as in attached patch. > > Cheers, > Johannes > > PS: Can you share that test page? >

Sept. 10, 2008

patch: more widget coloring

by Johannes.Hofmann＠gmx.de

On Wed, Sep 10, 2008 at 04:56:47AM +0000, corvid wrote: > > By the way, I was looking at that big page of inputs with > > differently-colored backgrounds that I made in February... > > At the time, I wrote that you guys had gotten the page down to > > 0:06 to load with clear_double_buffer(), > > immediate to load without it, and > > 0:09 to destroy the page. > > > > The good news is that it now takes the same amount of time > > with or without clear_double_buffer(), but > > the bad news is that it takes 0:12 to load and 0:48 to close. > > If I assume that you can only have one instance of a widget in a view > and add a break to the loop in FltkWidgetView::removeFltkWidget() > once it finds it, the 0:48 becomes 0:03. Ah, interesting. In that case I'd ditch the canvasWidgets list entirely as in attached patch. Cheers, Johannes PS: Can you share that test page?

Sept. 10, 2008

[patch] remove asap parameter

by Johannes.Hofmann＠gmx.de

On Tue, Sep 09, 2008 at 06:26:05PM -0400, Jorge Arellano Cid wrote: > On Tue, Sep 09, 2008 at 06:07:16PM +0200, Johannes Hofmann wrote: > > Hi Jorge, > > > > any objections to remove the asap parameter as in attached patch? > > It has been disabled for quite some time now. > > I read it, made some tests and it looks like the cleanup > can even reduce the number of resize calls! Not sure wether I'm happy about that. It should not change anything... I will have a further look. Cheers, Johannes

Sept. 10, 2008

[patch] remove asap parameter

by Johannes.Hofmann＠gmx.de

On Tue, Sep 09, 2008 at 07:32:14PM -0400, Jorge Arellano Cid wrote: > On Tue, Sep 09, 2008 at 06:07:16PM +0200, Johannes Hofmann wrote: > > Hi Jorge, > > > > any objections to remove the asap parameter as in attached patch? > > It has been disabled for quite some time now. > > I made a mistake during the dw2 commit, then fixed it, and it > looks OK, but please check it. Looks good. Just a comment replacing a ifdef'd block is missing. See attached patch. Cheers, Johannes

Sept. 10, 2008

assertion failed during wildly clicking on links

by akemnade＠tzi.de

Hi, that was a false alarm. My mistake. fltk decided to put -Dbool=char for some reason into the compile flags in fltk-config. As some files do not use the fltk cflags, there are type conflicts. So I did without any further thinking I did a make CXX=".... -Dbool=char" And now... there is a cast in misc::asserrt() from a pointer to a char (because it is no macro). And if the least significant byte of the pointer is zero... After recompiling fltk the problem disappeared and I did not need any magic to compile dillo. Greetings Andreas Kemnade

Sept. 10, 2008

patch: more widget coloring

by corvid＠lavabit.com

> By the way, I was looking at that big page of inputs with > differently-colored backgrounds that I made in February... > At the time, I wrote that you guys had gotten the page down to > 0:06 to load with clear_double_buffer(), > immediate to load without it, and > 0:09 to destroy the page. > > The good news is that it now takes the same amount of time > with or without clear_double_buffer(), but > the bad news is that it takes 0:12 to load and 0:48 to close. If I assume that you can only have one instance of a widget in a view and add a break to the loop in FltkWidgetView::removeFltkWidget() once it finds it, the 0:48 becomes 0:03.

Sept. 10, 2008

patch: more widget coloring

by corvid＠lavabit.com

My main forms testing page has bg #00ffff from when I was first experimenting with widget colors. Some time ago, fltk changed so that selected checkboxes and radio buttons use selection_color(). I had this set to the inverse of the background. Red. Not a good combination to say the least. Well, I finally got around to trying to fix it up a little. By the way, I was looking at that big page of inputs with differently-colored backgrounds that I made in February... At the time, I wrote that you guys had gotten the page down to 0:06 to load with clear_double_buffer(), immediate to load without it, and 0:09 to destroy the page. The good news is that it now takes the same amount of time with or without clear_double_buffer(), but the bad news is that it takes 0:12 to load and 0:48 to close.

Sept. 10, 2008

[patch] remove asap parameter

by jcid＠dillo.org

On Tue, Sep 09, 2008 at 06:07:16PM +0200, Johannes Hofmann wrote: > Hi Jorge, > > any objections to remove the asap parameter as in attached patch? > It has been disabled for quite some time now. I made a mistake during the dw2 commit, then fixed it, and it looks OK, but please check it. TIA. -- Cheers Jorge.-

Sept. 10, 2008