- Dillo-dev - lists.mailman3.com

PATCH: select new tabs

by corvid＠lavabit.com

Jeremy wrote: > On Mon, Sep 22, 2008 at 12:06:27AM +0000, corvid wrote: > > Jeremy wrote: > > > > > This patch is more of a call for discussion than a fix as it > > > fiddles with the UI. It makes Dillo select the new tab after > > > creating it. As a special case, middle-clicking a link does not > > > select the new tab unless the Shift key is down. (This is the > > > same behaviour as Firefox which saves learning a new set of > > > reflexes.) What do people think? > > > > It does seem that "I want to see this in a new tab/window now" has > > been more common for me than "I want to look at this in a different > > tab/window later". > > So do you think that a middle button click on a link should always > select the new tab? I often go down a list opening up new tabs to > look at later so I get frustrated when I have to switch back each > time. On the other hand when I create a new blank tab I always want > to switch to it immediately so I prefer Dillo to do that for me. Well, I've never been in the habit of using tabs, so I don't have too much of an opinion about the particulars yet. I will agree that allowing both "see this now" and "see this later" in some way is good.

Sept. 22, 2008

Tabs!!!

by corvid＠lavabit.com

Johannes wrote: > On Mon, Sep 22, 2008 at 05:06:35AM +0000, corvid wrote: > > I wrote: > > > Johannes wrote: > > > > On Fri, Sep 19, 2008 at 03:21:58PM +0000, corvid wrote: > > > > > I wrote: > > > > > > Sometimes the window closes when I click on a page. > > > > > > A quick fprintf() says PUSH causing a recursive FOCUS_CHANGE, > > > > > > and then HIDE. > > > > > > (I only had one tab, in case that matters.) > > > > > > > > > > Okay, that was not accurate. > > > > > It looks like PUSH and FOCUS_CHANGE is from clicking > > > > > and HIDE is from pressing Space to page down. > > > > > > > > I'm also seeing that. No idea yet... > > > > > > I finally sat down and worked out what the problem is. > > > It's not only click-space, but that's the most common case. > > > > > > <title>...&[character]...</title> > > > > > > causes click-[character] to close it. > > > > > > So fltk must think that's a shortcut in > > > the tab text, and it tries to do whatever > > > it does with shortcuts -- but there's a > > > shortcut-handling piece missing, so it > > > just closes the window. > > > > It doesn't care about the tab text. > > It's the UI->window() label stuff that's causing the problem. > > It appears that you can escape &-as-shortcut in general > > by doubling them, but I end up with doubled && in the > > title bar. > > Why wasn't this a problem in the past? I don't know; maybe it > > _was_ regarded as a shortcut but handle() took care of it. > > > > Thanks for tracking this down! > I could also reproduce it with pre-tabs versions. I have a dillo from Sept. 5 around, and space doesn't close the window for me. > Please try attached patch. It works! RAW_LABEL is so much better than trying to escape &.

Sept. 22, 2008

Redraw storms

by jcid＠dillo.org

On Mon, Sep 22, 2008 at 10:51:57AM +0100, Jeremy Henty wrote: > > Since dillo got tabs I'm seeing "redraw storms": sometimes after > opening a new tab every movement of the mouse triggers a redraw. It > doesn't seem to depend on the number of tabs. Usually it will go away > eventually (just after a tab is closed). I upgraded to the latest > FLTK2 snapshot but it has made no difference. Is anyone else seeing > this? I saw something similar while developing it. When opening more tabs than the horizontal space, a menu appears to the right. It seldom happened that activating the menu started a "redraw storm" (full CPU usage on mouse MOVE event). I "disappeared" somehow until now... Most probably this is a bug in FLTK2, but it would be good to track it down. Discovering a way to reproduce it reliably would be a big step forward. -- Cheers Jorge.-

Sept. 22, 2008

Tabs!!!

by Johannes.Hofmann＠gmx.de

On Mon, Sep 22, 2008 at 05:06:35AM +0000, corvid wrote: > I wrote: > > Johannes wrote: > > > On Fri, Sep 19, 2008 at 03:21:58PM +0000, corvid wrote: > > > > I wrote: > > > > > Sometimes the window closes when I click on a page. > > > > > A quick fprintf() says PUSH causing a recursive FOCUS_CHANGE, > > > > > and then HIDE. > > > > > (I only had one tab, in case that matters.) > > > > > > > > Okay, that was not accurate. > > > > It looks like PUSH and FOCUS_CHANGE is from clicking > > > > and HIDE is from pressing Space to page down. > > > > > > I'm also seeing that. No idea yet... > > > > I finally sat down and worked out what the problem is. > > It's not only click-space, but that's the most common case. > > > > <title>...&[character]...</title> > > > > causes click-[character] to close it. > > > > So fltk must think that's a shortcut in > > the tab text, and it tries to do whatever > > it does with shortcuts -- but there's a > > shortcut-handling piece missing, so it > > just closes the window. > > It doesn't care about the tab text. > It's the UI->window() label stuff that's causing the problem. > It appears that you can escape &-as-shortcut in general > by doubling them, but I end up with doubled && in the > title bar. > Why wasn't this a problem in the past? I don't know; maybe it > _was_ regarded as a shortcut but handle() took care of it. > Thanks for tracking this down! I could also reproduce it with pre-tabs versions. Please try attached patch. Cheers, Johannes PS: We will need to set RAW_LABEL for all widgets that get their labels fom html...

Sept. 22, 2008

Redraw storms

by onepoint＠starurchin.org

Since dillo got tabs I'm seeing "redraw storms": sometimes after opening a new tab every movement of the mouse triggers a redraw. It doesn't seem to depend on the number of tabs. Usually it will go away eventually (just after a tab is closed). I upgraded to the latest FLTK2 snapshot but it has made no difference. Is anyone else seeing this? Regards, Jeremy Henty

Sept. 22, 2008

PATCH: select new tabs

by onepoint＠starurchin.org

On Mon, Sep 22, 2008 at 12:06:27AM +0000, corvid wrote: > Jeremy wrote: > > > This patch is more of a call for discussion than a fix as it > > fiddles with the UI. It makes Dillo select the new tab after > > creating it. As a special case, middle-clicking a link does not > > select the new tab unless the Shift key is down. (This is the > > same behaviour as Firefox which saves learning a new set of > > reflexes.) What do people think? > > It does seem that "I want to see this in a new tab/window now" has > been more common for me than "I want to look at this in a different > tab/window later". So do you think that a middle button click on a link should always select the new tab? I often go down a list opening up new tabs to look at later so I get frustrated when I have to switch back each time. On the other hand when I create a new blank tab I always want to switch to it immediately so I prefer Dillo to do that for me. Regards, Jeremy Henty

Sept. 22, 2008

Tabs!!!

by corvid＠lavabit.com

I wrote: > Johannes wrote: > > On Fri, Sep 19, 2008 at 03:21:58PM +0000, corvid wrote: > > > I wrote: > > > > Sometimes the window closes when I click on a page. > > > > A quick fprintf() says PUSH causing a recursive FOCUS_CHANGE, > > > > and then HIDE. > > > > (I only had one tab, in case that matters.) > > > > > > Okay, that was not accurate. > > > It looks like PUSH and FOCUS_CHANGE is from clicking > > > and HIDE is from pressing Space to page down. > > > > I'm also seeing that. No idea yet... > > I finally sat down and worked out what the problem is. > It's not only click-space, but that's the most common case. > > <title>...&[character]...</title> > > causes click-[character] to close it. > > So fltk must think that's a shortcut in > the tab text, and it tries to do whatever > it does with shortcuts -- but there's a > shortcut-handling piece missing, so it > just closes the window. It doesn't care about the tab text. It's the UI->window() label stuff that's causing the problem. It appears that you can escape &-as-shortcut in general by doubling them, but I end up with doubled && in the title bar. Why wasn't this a problem in the past? I don't know; maybe it _was_ regarded as a shortcut but handle() took care of it.

Sept. 22, 2008

PATCH: select new tabs

by corvid＠lavabit.com

Jeremy wrote: > This patch is more of a call for discussion than a fix as it fiddles > with the UI. It makes Dillo select the new tab after creating it. As > a special case, middle-clicking a link does not select the new tab > unless the Shift key is down. (This is the same behaviour as Firefox > which saves learning a new set of reflexes.) What do people think? It does seem that "I want to see this in a new tab/window now" has been more common for me than "I want to look at this in a different tab/window later".

Sept. 22, 2008

Tabs!!!

by corvid＠lavabit.com

Johannes wrote: > On Fri, Sep 19, 2008 at 03:21:58PM +0000, corvid wrote: > > I wrote: > > > Sometimes the window closes when I click on a page. > > > A quick fprintf() says PUSH causing a recursive FOCUS_CHANGE, > > > and then HIDE. > > > (I only had one tab, in case that matters.) > > > > Okay, that was not accurate. > > It looks like PUSH and FOCUS_CHANGE is from clicking > > and HIDE is from pressing Space to page down. > > I'm also seeing that. No idea yet... I finally sat down and worked out what the problem is. It's not only click-space, but that's the most common case. <title>...&[character]...</title> causes click-[character] to close it. So fltk must think that's a shortcut in the tab text, and it tries to do whatever it does with shortcuts -- but there's a shortcut-handling piece missing, so it just closes the window.

Sept. 22, 2008

PATCH: select new tabs

by onepoint＠starurchin.org

This patch is more of a call for discussion than a fix as it fiddles with the UI. It makes Dillo select the new tab after creating it. As a special case, middle-clicking a link does not select the new tab unless the Shift key is down. (This is the same behaviour as Firefox which saves learning a new set of reflexes.) What do people think? Regards, Jeremy Henty

Sept. 22, 2008