- Dillo-dev - lists.mailman3.com

IMG ratio

by Johannes.Hofmann＠gmx.de

On Sun, Jan 11, 2009 at 03:38:04PM -0300, Jorge Arellano Cid wrote: > On Sun, Jan 11, 2009 at 06:31:35PM +0000, corvid wrote: > > Johannes wrote: > > > On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote: > > > > I wrote: > > > > > Johannes wrote: > > > > > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > > > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > > > > > Johannes wrote: > > > > > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > > > > > I think the html part needs not be changed. Everything is available > > > > > > > > > > in style already. > > > > > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > > > > > 0) for inclusion into main. > > > > > > > > > > > > > > > > Loading an image scales properly for me, but I still see > > > > > > > > lack of scaling when I leave a page and come back. > > > > > > > > Is that supposed to work now? > > > > > > > > > > > > > > Yes, it is supposed to work. > > > > > > > > > > > > > > Altough now that you mention it, I have problems the *first* > > > > > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > > > > > it works OK. This is because the second time the image dimensions > > > > > > > are known from the dicache. > > > > > > > > > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > > > > > > > > > Johannes: please test and merge. > > > > > > > > > > > > Done. > > > > > > > > > > > > corvid, can you please verify that this fixes the issue you were > > > > > > seeing? > > > > > > > > > > Same problem for me still. > > > > > It turns out that > > > > > > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > > > > > > in isolation works fine, but > > > > > > > > > > <a href="http://auriga.wearlab.de/"> > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > </a> > > > > > > > > > > doesn't. > > > > > > > > Ah, it works for me with css-prototype but not with main. > > > > I didn't realize there would be any difference. > > > > > > There shouldn't be any difference... > > > > main works for you, then? Hmm. > > It works for me. Try going to: <a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a> then hit the bookmark button and then go back to the above page. First time scaling works, but when going back it's not scaled anymore. Cheers, Johannes

Jan. 11, 2009

IMG ratio

by Johannes.Hofmann＠gmx.de

On Sun, Jan 11, 2009 at 06:31:35PM +0000, corvid wrote: > Johannes wrote: > > On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote: > > > I wrote: > > > > Johannes wrote: > > > > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > > > > Johannes wrote: > > > > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > > > > I think the html part needs not be changed. Everything is available > > > > > > > > > in style already. > > > > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > > > > 0) for inclusion into main. > > > > > > > > > > > > > > Loading an image scales properly for me, but I still see > > > > > > > lack of scaling when I leave a page and come back. > > > > > > > Is that supposed to work now? > > > > > > > > > > > > Yes, it is supposed to work. > > > > > > > > > > > > Altough now that you mention it, I have problems the *first* > > > > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > > > > it works OK. This is because the second time the image dimensions > > > > > > are known from the dicache. > > > > > > > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > > > > > > > Johannes: please test and merge. > > > > > > > > > > Done. > > > > > > > > > > corvid, can you please verify that this fixes the issue you were > > > > > seeing? > > > > > > > > Same problem for me still. > > > > It turns out that > > > > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > > > > in isolation works fine, but > > > > > > > > <a href="http://auriga.wearlab.de/"> > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > </a> > > > > > > > > doesn't. > > > > > > Ah, it works for me with css-prototype but not with main. > > > I didn't realize there would be any difference. > > > > There shouldn't be any difference... > > main works for you, then? Hmm. > > It gets the size of the box right, but > then the rgb data inside it isn't scaled. Ok, I'm seeing the problem now with main and the example you have provided. css-prototype indeed seems to work fine. Not sure why :-) Cheers, Johannes

Jan. 11, 2009

IMG ratio

by jcid＠dillo.org

On Sun, Jan 11, 2009 at 06:31:35PM +0000, corvid wrote: > Johannes wrote: > > On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote: > > > I wrote: > > > > Johannes wrote: > > > > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > > > > Johannes wrote: > > > > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > > > > I think the html part needs not be changed. Everything is available > > > > > > > > > in style already. > > > > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > > > > 0) for inclusion into main. > > > > > > > > > > > > > > Loading an image scales properly for me, but I still see > > > > > > > lack of scaling when I leave a page and come back. > > > > > > > Is that supposed to work now? > > > > > > > > > > > > Yes, it is supposed to work. > > > > > > > > > > > > Altough now that you mention it, I have problems the *first* > > > > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > > > > it works OK. This is because the second time the image dimensions > > > > > > are known from the dicache. > > > > > > > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > > > > > > > Johannes: please test and merge. > > > > > > > > > > Done. > > > > > > > > > > corvid, can you please verify that this fixes the issue you were > > > > > seeing? > > > > > > > > Same problem for me still. > > > > It turns out that > > > > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > > > > in isolation works fine, but > > > > > > > > <a href="http://auriga.wearlab.de/"> > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > </a> > > > > > > > > doesn't. > > > > > > Ah, it works for me with css-prototype but not with main. > > > I didn't realize there would be any difference. > > > > There shouldn't be any difference... > > main works for you, then? Hmm. It works for me. > It gets the size of the box right, but > then the rgb data inside it isn't scaled. > > (...which is the behaviour I've always seen > with fltk-era dillo when returning to pages. > On the original load, I would get stretched > images, but that's been fixed now.) If main doesn't work for you, please share the sample HTML/img code that faults? -- Cheers Jorge.-

Jan. 11, 2009

IMG ratio

by corvid＠lavabit.com

Johannes wrote: > On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote: > > I wrote: > > > Johannes wrote: > > > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > > > Johannes wrote: > > > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > > > I think the html part needs not be changed. Everything is available > > > > > > > > in style already. > > > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > > > 0) for inclusion into main. > > > > > > > > > > > > Loading an image scales properly for me, but I still see > > > > > > lack of scaling when I leave a page and come back. > > > > > > Is that supposed to work now? > > > > > > > > > > Yes, it is supposed to work. > > > > > > > > > > Altough now that you mention it, I have problems the *first* > > > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > > > it works OK. This is because the second time the image dimensions > > > > > are known from the dicache. > > > > > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > > > > > Johannes: please test and merge. > > > > > > > > Done. > > > > > > > > corvid, can you please verify that this fixes the issue you were > > > > seeing? > > > > > > Same problem for me still. > > > It turns out that > > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > > in isolation works fine, but > > > > > > <a href="http://auriga.wearlab.de/"> > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > </a> > > > > > > doesn't. > > > > Ah, it works for me with css-prototype but not with main. > > I didn't realize there would be any difference. > > There shouldn't be any difference... main works for you, then? Hmm. It gets the size of the box right, but then the rgb data inside it isn't scaled. (...which is the behaviour I've always seen with fltk-era dillo when returning to pages. On the original load, I would get stretched images, but that's been fixed now.)

Jan. 11, 2009

IMG ratio

by Johannes.Hofmann＠gmx.de

On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote: > I wrote: > > Johannes wrote: > > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > > Johannes wrote: > > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > > I think the html part needs not be changed. Everything is available > > > > > > > in style already. > > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > > 0) for inclusion into main. > > > > > > > > > > Loading an image scales properly for me, but I still see > > > > > lack of scaling when I leave a page and come back. > > > > > Is that supposed to work now? > > > > > > > > Yes, it is supposed to work. > > > > > > > > Altough now that you mention it, I have problems the *first* > > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > > it works OK. This is because the second time the image dimensions > > > > are known from the dicache. > > > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > > > Johannes: please test and merge. > > > > > > Done. > > > > > > corvid, can you please verify that this fixes the issue you were > > > seeing? > > > > Same problem for me still. > > It turns out that > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > in isolation works fine, but > > > > <a href="http://auriga.wearlab.de/"> > > <img src="http://www.dillo.org/wearlab.png" height=20> > > </a> > > > > doesn't. > > Ah, it works for me with css-prototype but not with main. > I didn't realize there would be any difference. There shouldn't be any difference... > Sorry for any confusion... I'm confused now. Cheers, Johannes

Jan. 11, 2009

IMG ratio

by corvid＠lavabit.com

I wrote: > Johannes wrote: > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > Johannes wrote: > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > I think the html part needs not be changed. Everything is available > > > > > > in style already. > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > 0) for inclusion into main. > > > > > > > > Loading an image scales properly for me, but I still see > > > > lack of scaling when I leave a page and come back. > > > > Is that supposed to work now? > > > > > > Yes, it is supposed to work. > > > > > > Altough now that you mention it, I have problems the *first* > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > it works OK. This is because the second time the image dimensions > > > are known from the dicache. > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > Johannes: please test and merge. > > > > Done. > > > > corvid, can you please verify that this fixes the issue you were > > seeing? > > Same problem for me still. > It turns out that > > <img src="http://www.dillo.org/wearlab.png" height=20> > > in isolation works fine, but > > <a href="http://auriga.wearlab.de/"> > <img src="http://www.dillo.org/wearlab.png" height=20> > </a> > > doesn't. Ah, it works for me with css-prototype but not with main. I didn't realize there would be any difference. Sorry for any confusion...

Jan. 11, 2009

IMG ratio

by corvid＠lavabit.com

Johannes wrote: > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > Johannes wrote: > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > I think the html part needs not be changed. Everything is available > > > > > in style already. > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > It does not handle something like width="50%" however. > > > > > > > > As the patch works rather well for me and improves the current > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > 0) for inclusion into main. > > > > > > Loading an image scales properly for me, but I still see > > > lack of scaling when I leave a page and come back. > > > Is that supposed to work now? > > > > Yes, it is supposed to work. > > > > Altough now that you mention it, I have problems the *first* > > time a only-one-dimension-specified image tag is loaded. Once coming back > > it works OK. This is because the second time the image dimensions > > are known from the dicache. > > > > Patch 8f7293125059 from main fixes this. > > > > Johannes: please test and merge. > > Done. > > corvid, can you please verify that this fixes the issue you were > seeing? Same problem for me still. It turns out that <img src="http://www.dillo.org/wearlab.png" height=20> in isolation works fine, but <a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a> doesn't.

Jan. 11, 2009

IMG ratio

by Johannes.Hofmann＠gmx.de

On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > Johannes wrote: > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > I think the html part needs not be changed. Everything is available > > > > in style already. > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > It does not handle something like width="50%" however. > > > > > > As the patch works rather well for me and improves the current > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > 0) for inclusion into main. > > > > Loading an image scales properly for me, but I still see > > lack of scaling when I leave a page and come back. > > Is that supposed to work now? > > Yes, it is supposed to work. > > Altough now that you mention it, I have problems the *first* > time a only-one-dimension-specified image tag is loaded. Once coming back > it works OK. This is because the second time the image dimensions > are known from the dicache. > > Patch 8f7293125059 from main fixes this. > > Johannes: please test and merge. Done. corvid, can you please verify that this fixes the issue you were seeing? Cheers, Johannes

Jan. 11, 2009

Blimey, when was this fixed? Selections are fast!

by onepoint＠starurchin.org

I used to complain that drawing the text selection was desperately slow when I dragged the mouse across the contents of a table with two columns and very many rows. Today I suddenly realised that this hadn't bothered me for a while, so I checked the problem page and indeed the selection now draws itself as fast I can drag the mouse. Big thanks to whoever fixed this performance bug! Regards, Jeremy Henty

Jan. 11, 2009

IMG ratio

by jcid＠dillo.org

On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > Johannes wrote: > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > I think the html part needs not be changed. Everything is available > > > in style already. > > > I've attached a quick patch that seems to work for fixed sizes. > > > It does not handle something like width="50%" however. > > > > As the patch works rather well for me and improves the current > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > 0) for inclusion into main. > > Loading an image scales properly for me, but I still see > lack of scaling when I leave a page and come back. > Is that supposed to work now? Yes, it is supposed to work. Altough now that you mention it, I have problems the *first* time a only-one-dimension-specified image tag is loaded. Once coming back it works OK. This is because the second time the image dimensions are known from the dicache. Patch 8f7293125059 from main fixes this. Johannes: please test and merge. -- Cheers Jorge.-

Jan. 11, 2009