- Dillo-dev - lists.mailman3.com

Valgrind errors: big improvement!

by onepoint＠starurchin.org

The very latest dillo is vastly more valgrind-clean than before: I got no errors from my latest browsing session! I'll keep monitoring it and look at the leak reports too. Regards, Jeremy Henty

Jan. 24, 2009

Valgrind errors

by Johannes.Hofmann＠gmx.de

On Fri, Jan 23, 2009 at 05:11:54PM -0300, Jorge Arellano Cid wrote: > On Fri, Jan 23, 2009 at 07:56:33AM +0000, Jeremy Henty wrote: > > On Fri, Jan 23, 2009 at 03:13:10AM +0000, corvid wrote: > > > > > I realized we should really be using entry->Data regardless of > > > character encoding when showing progress in receiving the > > > page. Attached. > > > > OK, then ignore my earlier patch. Do you expect this to fix both of > > the valgrind errors, or just the second one as your previous > > suggestion did? > > The new patches added expect to fix the remaining. > The small patch (2 lines) aims to this problem, and the others are > cleanups and logic fixes that hope to avoid future troubles. > > Please test. The amazon.de crash is fixed. And I don't see any other crashes. Thanks, Johannes

Jan. 24, 2009

dillo CSS and charset

by furaisanjin＠gmail.com

Hi. This is work around for www.amazon.de. diff -r 93de73875a8c src/cache.c --- a/src/cache.c Thu Jan 22 08:31:44 2009 -0300 +++ b/src/cache.c Sat Jan 24 14:53:50 2009 +0900 @@ -747,6 +747,7 @@ dStr_free(entry->Data, 1); entry->Data = dStr_sized_new(MIN(entry->ExpectedSize, MAX_INIT_BUF)); } + Cache_ref_data(entry); /* Get Content-Type */ if ((Type = Cache_parse_field(header, "Content-Type")) == NULL) { @@ -762,7 +763,6 @@ _MSG("TypeMeta {%s}\n", entry->TypeMeta); dFree(Type); } - Cache_ref_data(entry); } /* I found that Cache_ref_data position was moved to the bottom. I don't fully understand the logic but somehow this change helps. Regards, furaisanjin

Jan. 24, 2009

dillo CSS and charset

by furaisanjin＠gmail.com

Hi 2009/1/23 Jorge Arellano Cid <jcid(a)dillo.org>: > On Fri, Jan 23, 2009 at 07:31:56AM +0900, furaisanjin wrote: > OK, but I still want to commit the proposed patch. > Please test it and comment. I have browsed several pages and I don't encounter problem. Still www.amazon.de causes dillo crashed but I guess that would be different issue. Regards, furaisanjin

Jan. 23, 2009

Valgrind errors

by jcid＠dillo.org

On Fri, Jan 23, 2009 at 07:56:33AM +0000, Jeremy Henty wrote: > On Fri, Jan 23, 2009 at 03:13:10AM +0000, corvid wrote: > > > I realized we should really be using entry->Data regardless of > > character encoding when showing progress in receiving the > > page. Attached. > > OK, then ignore my earlier patch. Do you expect this to fix both of > the valgrind errors, or just the second one as your previous > suggestion did? The new patches added expect to fix the remaining. The small patch (2 lines) aims to this problem, and the others are cleanups and logic fixes that hope to avoid future troubles. Please test. -- Cheers Jorge.-

Jan. 23, 2009

dillo CSS and charset

by Johannes.Hofmann＠gmx.de

On Fri, Jan 23, 2009 at 03:54:42AM +0000, corvid wrote: > Johannes wrote: > > On Thu, Jan 22, 2009 at 06:53:46PM +0000, corvid wrote: > > > Johannes wrote: > > > > On Thu, Jan 22, 2009 at 05:57:42PM +0000, corvid wrote: > > > > > Johannes wrote: > > > > > > BTW. now you can set vw_fontname in dillorc again. This font will > > > > > > then be used when CSS specifies "sans" as font, e.g: > > > > > > vw_fontname="VL Gothic" > > > > > > > > > > If I put a serif font in vw_fontname and then use > > > > > sans in style.css for some things, it'll use > > > > > the serif font. > > > > > > > > True. We need to make new config options > > > > > > > > sans-serif_fontname > > > > serif_fontname > > > > cursive_fontname > > > > fantasy_fontname > > > > monospace_fontname > > > > > > > > maybe even dropping the "_fontname" suffix. > > > > > > > > But of course that would no longer be compatible with older > > > > versions of dillorc. > > > > > > I would add the new options and remove the old options. > > > CSS is big and certainly worth some incompatibility. > > > > Ok, attached is a patch for discussion. > > You meant to write font_monospace in dialog.cc and plain.cc. Yes, that's what I meant. > > PS I approve of cursive and fantasy defaulting to sans :) :) Cheers, Johannes

Jan. 23, 2009

Valgrind errors

by corvid＠lavabit.com

Jeremy wrote: > On Fri, Jan 23, 2009 at 03:13:10AM +0000, corvid wrote: > > > I realized we should really be using entry->Data regardless of > > character encoding when showing progress in receiving the > > page. Attached. > > OK, then ignore my earlier patch. Do you expect this to fix both of > the valgrind errors, or just the second one as your previous > suggestion did? Just the second one. The other error looks like it's upset that we're trying to look at start and tag after set_content_type made buf go away.

Jan. 23, 2009

Valgrind errors

by onepoint＠starurchin.org

On Fri, Jan 23, 2009 at 03:13:10AM +0000, corvid wrote: > I realized we should really be using entry->Data regardless of > character encoding when showing progress in receiving the > page. Attached. OK, then ignore my earlier patch. Do you expect this to fix both of the valgrind errors, or just the second one as your previous suggestion did? Regards, Jeremy Henty

Jan. 23, 2009

dillo CSS and charset

by corvid＠lavabit.com

Johannes wrote: > On Thu, Jan 22, 2009 at 06:53:46PM +0000, corvid wrote: > > Johannes wrote: > > > On Thu, Jan 22, 2009 at 05:57:42PM +0000, corvid wrote: > > > > Johannes wrote: > > > > > BTW. now you can set vw_fontname in dillorc again. This font will > > > > > then be used when CSS specifies "sans" as font, e.g: > > > > > vw_fontname="VL Gothic" > > > > > > > > If I put a serif font in vw_fontname and then use > > > > sans in style.css for some things, it'll use > > > > the serif font. > > > > > > True. We need to make new config options > > > > > > sans-serif_fontname > > > serif_fontname > > > cursive_fontname > > > fantasy_fontname > > > monospace_fontname > > > > > > maybe even dropping the "_fontname" suffix. > > > > > > But of course that would no longer be compatible with older > > > versions of dillorc. > > > > I would add the new options and remove the old options. > > CSS is big and certainly worth some incompatibility. > > Ok, attached is a patch for discussion. You meant to write font_monospace in dialog.cc and plain.cc. PS I approve of cursive and fantasy defaulting to sans :)

Jan. 23, 2009

Valgrind errors

by corvid＠lavabit.com

Jeremy wrote: > On Thu, Jan 22, 2009 at 10:37:41PM +0000, corvid wrote: > > Jeremy wrote: > > > ==20949== by 0x806065B: a_Cache_process_dbuf (cache.c:865) > > > ==20949== > > > ==20949== Invalid read of size 4 > > > ==20949== at 0x8060E9B: Cache_process_queue (cache.c:1145) > > > > Does this part of it stop complaining if the > > a_UIcmd_set_page_prog(Client_bw, data->len, 1); > > in Cache_process_queue() uses Cache_data(entry)->len instead? > > Yes. Patch attached. I realized we should really be using entry->Data regardless of character encoding when showing progress in receiving the page. Attached.

Jan. 23, 2009