- Dillo-dev - lists.mailman3.com

Close-tab Button

by jcid＠dillo.org

On Mon, Feb 09, 2009 at 09:23:38PM +0000, Jo?o Ricardo Louren?o wrote: > A simple update. > > I've fixed most issues I found. For instance, we were processing the > click on PUSH and not RELEASE, that was causing some problems and The > issue I talked about earlier (working while not visible). Good. > I've got a working tooltip, added to CustTabGroup. Good 2. I feared this could be harder. > The only problem is drawing into the button. Should I use an image (or > multiple images, mouseover, etc...)? Should I add a cross ('X') to it? > Adding a cross is easy, adding an image involves digging some more but > it is obviously doable. Try drawing a cross with a couple of lines. After all this is a well-baheved workaround, but no more. At some point in time it will be fixed in FLTK (I hope). -- Cheers Jorge.-

Feb. 10, 2009

perhaps an iterator bug

by corvid＠lavabit.com

I was trying the new search functionality a bit more and found this (it's also present in my Dec 2008 dillo*). With the page: <table> <tr><td>no close-tr <tr><td>has a close-tr</tr> <tr><td>here's another line</tr> </table> if I search for "rh", it finds one instance of it split between the second and third table rows. * My older dillos were lost in a tragic "I don't think I need my CVS stuff anymore" accident.

Feb. 9, 2009

Close-tab Button

by jorl17.8＠gmail.com

Seg, 2009-02-09 ?s 21:23 +0000, Jo?o Ricardo Louren?o escreveu: > A simple update. > > I've fixed most issues I found. For instance, we were processing the > click on PUSH and not RELEASE, that was causing some problems and The > issue I talked about earlier (working while not visible). > > I've got a working tooltip, added to CustTabGroup. > > The only problem is drawing into the button. Should I use an image (or > multiple images, mouseover, etc...)? Should I add a cross ('X') to it? > > Adding a cross is easy, adding an image involves digging some more but > it is obviously doable. > > Thanks, > > Jo?o Oh, not to mention preventing tabs from going over the button. However, I was testing multiple clicks on the button and it seems that dragging the pressing, dragging and quickly releasing the mouse button makes the events not reach its destination - I'm guessing a DRAG messages is being sent, we have to prevent for that too. Jo?o

Feb. 9, 2009

Close-tab Button

by jorl17.8＠gmail.com

A simple update. I've fixed most issues I found. For instance, we were processing the click on PUSH and not RELEASE, that was causing some problems and The issue I talked about earlier (working while not visible). I've got a working tooltip, added to CustTabGroup. The only problem is drawing into the button. Should I use an image (or multiple images, mouseover, etc...)? Should I add a cross ('X') to it? Adding a cross is easy, adding an image involves digging some more but it is obviously doable. Thanks, Jo?o

Feb. 9, 2009

Leaking image structures

by corvid＠lavabit.com

Probably not related, but occasionally progressive jpegs haven't been displaying some of the later scans. (But it's rare and doesn't repeat itself when I try again.)

Feb. 9, 2009

Leaking image structures

by jcid＠dillo.org

On Wed, Feb 04, 2009 at 02:47:51PM +0000, Jeremy Henty wrote: > > One of the biggest leaks that valgrind reports is image structures. > I'm attaching logs that show memory being allocated by a_Png_new() and > cousins and not being freed. There are also frequent leaks of memory > allocated by the image libraries from within the various image > callbacks, but I suspect these are just another effect of the Dillo > image structures not being freed. > > Unfortunately I'm having a hard time tracking these leaks down. They > regularly appear after long browsing sessions, but I haven't found any > single page that reproduces them. I suspect they are caused by some > race condition inside the CCC rather than the HTML parser. I am > browsing with image loading enabled, and if I understand the code > correctly that means that the Web structures in the CCC own all the > references to image structures. > > The fact that image structures are reference counted makes it hard to > know when the structures should be freed anyway. Indeed, does Dillo > even ensure that image structures are freed? Maybe this is just a > symptom of incomplete cleanup at exit rather than a true leak? > > I've looked over the code and can't see any obvious leaks so I'm > rather stuck. Any tips for tracking this down? Even if it's not a > true leak it would be good to have a fix that cleaned up the valgrind > logs. To me it looks like something akin to an aborted request may be the responsible for the reported leaks. Maybe an image redirection, or something that should be an image but ends actually being HTML content. In this case the process is aborted and probably there's an unref missing. A test case would be really valuable. In trying to build a test case, I'd start checking the above suggested cases. -- Cheers Jorge.-

Feb. 9, 2009

[patch] Search Previous

by jcid＠dillo.org

On Mon, Feb 09, 2009 at 06:11:36PM +0000, Jo?o Ricardo Louren?o wrote: > Dom, 2009-02-08 ?s 20:59 +0000, corvid escreveu: > > Nice! > > > > I notice that if I search backward for a space, > > it won't loop back to the end after reaching the top. > > > > > > > > Thanks for reporting that. > > I've been digging through the code, seeking for an explanation, but > can't seem to find it. Any ideas? > > It's odd that it happens only with a space, and I've been checking and > it *seems* that the code finds the character, what can be wrong? > > Anyway, I'll keep digging... Please assign less priority to this bug, than to the close-tab button. -- Cheers Jorge.-

Feb. 9, 2009

[patch] Search Previous

by jorl17.8＠gmail.com

Dom, 2009-02-08 ?s 20:59 +0000, corvid escreveu: > Nice! > > I notice that if I search backward for a space, > it won't loop back to the end after reaching the top. > > > Thanks for reporting that. I've been digging through the code, seeking for an explanation, but can't seem to find it. Any ideas? It's odd that it happens only with a space, and I've been checking and it *seems* that the code finds the character, what can be wrong? Anyway, I'll keep digging... Jo?o

Feb. 9, 2009

CSS update committed

by Johannes.Hofmann＠gmx.de

On Sun, Feb 08, 2009 at 07:38:53PM -0300, Jorge Arellano Cid wrote: > On Sun, Feb 08, 2009 at 09:18:04PM +0100, Hofmann Johannes wrote: > > Hi, > > > > I just committed a major update of the CSS code. CSS values now have > > a type and the CSS parser can accept multiple types for one > > property. One example is font-size, which can either be a length or > > an enum (xx-small, x-small, ...). > > This fixes the font size issue on wikipedia.org. > > I just saw the big commit! > > It'd be very good if you provide us with examples of what > is changing (just as you did, just a bit more for non CSS-savvy > guys like me ;). The visible change is that "font-size: normal", "font-size: smaller", or "font-size: xx-large", etc. should work now as expected. In addition font-weight handling has been moved to the new scheme. The commit also provides the ground work to support the "inherit" special value in the future. Cheers, Johannes

Feb. 9, 2009

CSS update committed

by jcid＠dillo.org

On Sun, Feb 08, 2009 at 09:18:04PM +0100, Hofmann Johannes wrote: > Hi, > > I just committed a major update of the CSS code. CSS values now have > a type and the CSS parser can accept multiple types for one > property. One example is font-size, which can either be a length or > an enum (xx-small, x-small, ...). > This fixes the font size issue on wikipedia.org. I just saw the big commit! It'd be very good if you provide us with examples of what is changing (just as you did, just a bit more for non CSS-savvy guys like me ;). -- Cheers Jorge.-

Feb. 8, 2009