- Dillo-dev - lists.mailman3.com

bug tracker doesn't work with dillo?

by corvid＠lavabit.com

Johannes wrote > On Wed, Mar 25, 2009 at 12:37:54PM -0400, Jorge Arellano Cid wrote: > > On Wed, Mar 25, 2009 at 05:19:48PM +0100, Hofmann Johannes wrote: > > > On Wed, Mar 25, 2009 at 08:33:28AM -0400, Jorge Arellano Cid wrote: > > > > On Wed, Mar 25, 2009 at 01:21:25AM +0100, Joerg Sonnenberger wrote: > > > > > On Wed, Mar 25, 2009 at 12:03:05AM +0000, corvid wrote: > > > > > > Jorge wrote: > > > > > > > Skimming the code it looks like the cast to long for int is > > > > > > > the way to go. If a: > > > > > > > > > > > > > > - URL_DATA(url)->len, content_type->str, > > > > > > > + (long)URL_DATA(url)->len, content_type->str, > > > > > > > > > > > > > > solves it. I'd commit it and let the explanation come after > > > > > > > the patch. > > > > > > > > > > > > I was thinking of adding long casts for the Content-Length headers > > > > > > in file.c as well. Sound good? > > > > > > > > > > Shouldn't that be (s)size_t? > > > > > > > > The parameter is specified as %ld, so long seems OK. > > > > > > I think Joerg is suggesting to switch the len field of struct Dstr > > > to size_t/ssize_t and to use this consistently (e.g. using %zd for > > > printing it). > > > Standard string functions also use size_t for string length. > > > > It took a long way to define 'len' as int. I wouldn't awake > > that dragon. > > Ah ok. I will browse CVS history a bit :) All right, then. I'll put a (long) in http.c and life will be pleasant.

March 25, 2009

bug tracker doesn't work with dillo?

by Johannes.Hofmann＠gmx.de

On Wed, Mar 25, 2009 at 12:37:54PM -0400, Jorge Arellano Cid wrote: > On Wed, Mar 25, 2009 at 05:19:48PM +0100, Hofmann Johannes wrote: > > On Wed, Mar 25, 2009 at 08:33:28AM -0400, Jorge Arellano Cid wrote: > > > On Wed, Mar 25, 2009 at 01:21:25AM +0100, Joerg Sonnenberger wrote: > > > > On Wed, Mar 25, 2009 at 12:03:05AM +0000, corvid wrote: > > > > > Jorge wrote: > > > > > > Skimming the code it looks like the cast to long for int is > > > > > > the way to go. If a: > > > > > > > > > > > > - URL_DATA(url)->len, content_type->str, > > > > > > + (long)URL_DATA(url)->len, content_type->str, > > > > > > > > > > > > solves it. I'd commit it and let the explanation come after > > > > > > the patch. > > > > > > > > > > I was thinking of adding long casts for the Content-Length headers > > > > > in file.c as well. Sound good? > > > > > > > > Shouldn't that be (s)size_t? > > > > > > The parameter is specified as %ld, so long seems OK. > > > > I think Joerg is suggesting to switch the len field of struct Dstr > > to size_t/ssize_t and to use this consistently (e.g. using %zd for > > printing it). > > Standard string functions also use size_t for string length. > > It took a long way to define 'len' as int. I wouldn't awake > that dragon. Ah ok. I will browse CVS history a bit :) Cheers, Johannes

March 25, 2009

[patch] Configurable key bindings

by corvid＠lavabit.com

Jorge wrote: > On Wed, Mar 25, 2009 at 04:20:19PM +0000, corvid wrote: > > Jorge wrote: > > > - Removed a_Prefs_freeall because it was not used anywhere. > > > > Should we rip out all of the *_freeall()s? > > Ooops! It slipped. > > The idea of those functions is to free memory there. > They don't harm when empty. Let's keep them until something > better springs up. Should we add calls to them like in dillo1 and get them working, then?

March 25, 2009

[patch] Configurable key bindings

by jcid＠dillo.org

On Wed, Mar 25, 2009 at 04:20:19PM +0000, corvid wrote: > Jorge wrote: > > - Removed a_Prefs_freeall because it was not used anywhere. > > Should we rip out all of the *_freeall()s? Ooops! It slipped. The idea of those functions is to free memory there. They don't harm when empty. Let's keep them until something better springs up. -- Cheers Jorge.-

March 25, 2009

bug tracker doesn't work with dillo?

by Johannes.Hofmann＠gmx.de

On Wed, Mar 25, 2009 at 08:33:28AM -0400, Jorge Arellano Cid wrote: > On Wed, Mar 25, 2009 at 01:21:25AM +0100, Joerg Sonnenberger wrote: > > On Wed, Mar 25, 2009 at 12:03:05AM +0000, corvid wrote: > > > Jorge wrote: > > > > Skimming the code it looks like the cast to long for int is > > > > the way to go. If a: > > > > > > > > - URL_DATA(url)->len, content_type->str, > > > > + (long)URL_DATA(url)->len, content_type->str, > > > > > > > > solves it. I'd commit it and let the explanation come after > > > > the patch. > > > > > > I was thinking of adding long casts for the Content-Length headers > > > in file.c as well. Sound good? > > > > Shouldn't that be (s)size_t? > > The parameter is specified as %ld, so long seems OK. I think Joerg is suggesting to switch the len field of struct Dstr to size_t/ssize_t and to use this consistently (e.g. using %zd for printing it). Standard string functions also use size_t for string length. Cheers, Johannes

March 25, 2009

[patch] Configurable key bindings

by corvid＠lavabit.com

Jorge wrote: > - Removed a_Prefs_freeall because it was not used anywhere. Should we rip out all of the *_freeall()s?

March 25, 2009

[patch] Configurable key bindings

by jcid＠dillo.org

Hi Tim, On Mon, Mar 09, 2009 at 04:54:57PM +0100, Tim Nieradzik wrote: > Here is an updated version of the patch. It aims to be fully > backward compatible. You do not need to change anything in your > dillorc (put the key bindings into ~/.dillo/keysrc). Good. > Changes: > - Ported src/dir\.[ch] to C++ (now called src/paths\.(cc|hh)). > - Split src/prefs.c (parser is now in src/prefsparser.c). > - Changed method names in src/dillo.cc to use camel case. > - Added meta-modifier and function keys F10-F12. > - Fixed some inconsistent white spaces. > - Shortened some license headers. > - Key bindings are to be defined in keysrc (previously dillorc). > - Minor code cleanups such as using "TODO:" instead of "\todo". > - Removed a_Prefs_freeall because it was not used anywhere. After giving a couple of read-passes to the patch, and considering that we still have some time before April (when I'll have time to focus on the release), we can merge this long patch in small independent chunks. Please separate them into different patch files. For instance: Simple ones: - Changed method names in src/dillo.cc to use camel case. - Fixed some inconsistent white spaces. - Shortened some license headers. - Minor code cleanups such as using "TODO:" instead of "\todo". - Removed a_Prefs_freeall because it was not used anywhere. Refactors: - Split src/prefs.c (parser is now in src/prefsparser.c). Core of it: - Key bindings are to be defined in keysrc (previously dillorc). - Added meta-modifier and function keys F10-F12. > PS: I would like to port some C files to C++ in order to achieve > more consistency. What is your opinion on this? As explained before. Not unless we're forced or there's a compelling reason. For instance I'd decline this: - Ported src/dir\.[ch] to C++ (now called src/paths\.(cc|hh)). (unless there's a strong reason I've not seen). -- Cheers Jorge.-

March 25, 2009

bug tracker doesn't work with dillo?

by jcid＠dillo.org

On Wed, Mar 25, 2009 at 12:03:05AM +0000, corvid wrote: > Jorge wrote: > > Skimming the code it looks like the cast to long for int is > > the way to go. If a: > > > > - URL_DATA(url)->len, content_type->str, > > + (long)URL_DATA(url)->len, content_type->str, > > > > solves it. I'd commit it and let the explanation come after > > the patch. > > I was thinking of adding long casts for the Content-Length headers > in file.c as well. Sound good? Sure, but after the test is known to work OK. -- Cheers Jorge.-

March 25, 2009

bug tracker doesn't work with dillo?

by jcid＠dillo.org

On Wed, Mar 25, 2009 at 01:21:25AM +0100, Joerg Sonnenberger wrote: > On Wed, Mar 25, 2009 at 12:03:05AM +0000, corvid wrote: > > Jorge wrote: > > > Skimming the code it looks like the cast to long for int is > > > the way to go. If a: > > > > > > - URL_DATA(url)->len, content_type->str, > > > + (long)URL_DATA(url)->len, content_type->str, > > > > > > solves it. I'd commit it and let the explanation come after > > > the patch. > > > > I was thinking of adding long casts for the Content-Length headers > > in file.c as well. Sound good? > > Shouldn't that be (s)size_t? The parameter is specified as %ld, so long seems OK. Now the number of parameters is relevant (quite irregular). > At least one vendor was smart enough to > produce a 64bit platform with long != ssize_t and support for files > larger than 32bit sounds highly useful... I'd like to have the result of the suggested test. -- Cheers Jorge.-

March 25, 2009

bug tracker doesn't work with dillo?

by corvid＠lavabit.com

Joerg wrote: > On Wed, Mar 25, 2009 at 12:03:05AM +0000, corvid wrote: > > Jorge wrote: > > > Skimming the code it looks like the cast to long for int is > > > the way to go. If a: > > > > > > - URL_DATA(url)->len, content_type->str, > > > + (long)URL_DATA(url)->len, content_type->str, > > > > > > solves it. I'd commit it and let the explanation come after > > > the patch. > > > > I was thinking of adding long casts for the Content-Length headers > > in file.c as well. Sound good? > > Shouldn't that be (s)size_t? At least one vendor was smart enough to > produce a 64bit platform with long != ssize_t and support for files > larger than 32bit sounds highly useful... Well, you know these issues better than I do. These two cases use %ld currently. One is given a size_t, and one is given an off_t.

March 25, 2009