- Dillo-dev - lists.mailman3.com

Re: Dark mode screenshot and tutorial

by Kevin Koster

Rodrigo Arias <rodarima-Re5JQEeQqe8AvxtiuMwx3w(a)public.gmane.org> wrote: > On Tue, Jul 02, 2024 at 08:24:59PM +0200, Rodrigo Arias wrote: >>The background color of the image is being assigned from the color of >>the <html> background. Try this patch to override it from the current >>element: >> >>diff --git a/src/html.cc b/src/html.cc >>index a55fd2a8..649e7556 100644 >>--- a/src/html.cc >>+++ b/src/html.cc >>@@ -2156,6 +2156,9 @@ DilloImage *a_Html_image_new(DilloHtml *html, const char *tag, int tagsize) >> if (HT2TB(html)->getBgColor()) >> image->bg_color = HT2TB(html)->getBgColor()->getColor(); >> >>+ if (html->styleEngine->backgroundColor()) >>+ image->bg_color = html->styleEngine->backgroundColor()->getColor(); >>+ >> DilloHtmlImage *hi = dNew(DilloHtmlImage, 1); >> hi->url = url; >> html->images->increase(); > > And this extra rule in style.css: > > html {background-color: gray !important} Thanks, yes together those changes work to set the PNG background colour.

July 2, 2024

Re: extra /tmp on file name line when save html

by Rodrigo Arias

>This is a FLTK bug, here is a small program that reproduces. I will >report it to the FLTK project. Reported here: https://github.com/fltk/fltk/issues/1004

July 2, 2024

Re: extra /tmp on file name line when save html

by Rodrigo Arias

Hi, On Mon, Jul 01, 2024 at 03:31:40PM -0600, pastebin(a)gmx.com wrote: >Hi > >i got it to reproduce > >dillo any url > >right click mouse -> 'save page as' in the Filename: text box it shows /html/ highlighted in blue > >/html is my default save dir from dillorc save_dir=/html > >the i just type r (or any key) and it now shows /tmp/r hitting any key now just dups the /tmp/r on an on > >if the blue highlight is erased by clicking mouse in text box then it is normal > >it is the highlighting that is the problem Thanks!, I can reproduce it now. This is a FLTK bug, here is a small program that reproduces. I will report it to the FLTK project. /* Build with: g++ test.cpp -o test -lfltk */ #include <cstdlib> #include <unistd.h> #include <FL/Fl.H> #include <FL/Fl_Window.H> #include <FL/Fl_Button.H> #include <FL/Fl_File_Chooser.H> void cb_file_select(Fl_Widget *o, void *v) { char msg[256]; char *newfile = fl_file_chooser("Choose a file", NULL, NULL); if (newfile != NULL) { sprintf(msg, "You choose %s", newfile); fl_message(msg); } } int main (int argc, char ** argv) { chdir("/tmp"); Fl_Window *window = new Fl_Window(300, 300, 200, 200, "Foo"); Fl_Button *button = new Fl_Button(60, 40, 80, 40, "Select file"); button->callback(cb_file_select); window->end(); window->show(argc, argv); return(Fl::run()); }

July 2, 2024

Re: Dark mode screenshot and tutorial

by Rodrigo Arias

On Tue, Jul 02, 2024 at 08:24:59PM +0200, Rodrigo Arias wrote: >The implementation seems to be incomplete: > >https://github.com/dillo-browser/dillo/blob/8c97be233a600f414952e458f59768e… > >The background color of the image is being assigned from the color of >the <html> background. Try this patch to override it from the current >element: > >diff --git a/src/html.cc b/src/html.cc >index a55fd2a8..649e7556 100644 >--- a/src/html.cc >+++ b/src/html.cc >@@ -2156,6 +2156,9 @@ DilloImage *a_Html_image_new(DilloHtml *html, const char *tag, int tagsize) > if (HT2TB(html)->getBgColor()) > image->bg_color = HT2TB(html)->getBgColor()->getColor(); > >+ if (html->styleEngine->backgroundColor()) >+ image->bg_color = html->styleEngine->backgroundColor()->getColor(); >+ > DilloHtmlImage *hi = dNew(DilloHtmlImage, 1); > hi->url = url; > html->images->increase(); And this extra rule in style.css: html {background-color: gray !important} (I need to check it in more detail)

July 2, 2024

Re: Dark mode screenshot and tutorial

by Rodrigo Arias

Hi, On Tue, Jul 02, 2024 at 11:28:01AM +1000, Kevin Koster wrote: >One issue with dark background colours is that PNG/GIF images with >transparent backgrounds often have text in black and therefore become >unreadable, such as this image on Wikipedia: >https://en.wikipedia.org/wiki/File:Unix_timeline.en.svg > >I'm not good at CSS, but I just made an attempt to work around this by >not setting img elements to black in my version of a dark-theme >style.css, but it doesn't work, images backgrounds are still black: > >* {color: #00f400} > body, div, span, nav, p, a, form, h1, h2, h3, h4, h5, h6, ul, ol, li, table, tr, td {background-color: black} > img, map {background-color: gray !important} > :link {text-decoration: none !important; color: #00f5e8 !important} > :visited {text-decoration: none !important; color: #a020f0 !important} > >I don't know whether my CSS is invalid or if it's a bug in Dillo, but >hints for applying black background-color to everything except images >would be welcome. The image background is also black when I open it on >its own with "isolate image" from the right-click menu, even though >there it's on a light-colour background due to the 'bg_color' setting >in dillorc being set to default. Presumably that's because the image >in the cache already, loading a new PNG image URL the background is >bg_color: >https://upload.wikimedia.org/wikipedia/commons/thumb/c/cd/Unix_timeline.en.… The implementation seems to be incomplete: https://github.com/dillo-browser/dillo/blob/8c97be233a600f414952e458f59768e… The background color of the image is being assigned from the color of the <html> background. Try this patch to override it from the current element: diff --git a/src/html.cc b/src/html.cc index a55fd2a8..649e7556 100644 --- a/src/html.cc +++ b/src/html.cc @@ -2156,6 +2156,9 @@ DilloImage *a_Html_image_new(DilloHtml *html, const char *tag, int tagsize) if (HT2TB(html)->getBgColor()) image->bg_color = HT2TB(html)->getBgColor()->getColor(); + if (html->styleEngine->backgroundColor()) + image->bg_color = html->styleEngine->backgroundColor()->getColor(); + DilloHtmlImage *hi = dNew(DilloHtmlImage, 1); hi->url = url; html->images->increase();

July 2, 2024

Re: Dark mode screenshot and tutorial

by Kevin Koster

On Sun, 5 May 2024 18:00:26 +0200 <a1ex(a)dismail.de> wrote: > Attached is a screenshot of Dillo with a simple "Dark Mode" theme. > > For those interested in how to do this, here is a small tutorial: > > > Put this in ~/.dillo/style.css: > > * { background-color: #000000 !important; color: #999999 ! important; } > :link { color: #ffffff !important; text-decoration: none !important; } > :visited { color: #ffffff !important; text-decoration: underline !important; } One issue with dark background colours is that PNG/GIF images with transparent backgrounds often have text in black and therefore become unreadable, such as this image on Wikipedia: https://en.wikipedia.org/wiki/File:Unix_timeline.en.svg I'm not good at CSS, but I just made an attempt to work around this by not setting img elements to black in my version of a dark-theme style.css, but it doesn't work, images backgrounds are still black: * {color: #00f400} body, div, span, nav, p, a, form, h1, h2, h3, h4, h5, h6, ul, ol, li, table, tr, td {background-color: black} img, map {background-color: gray !important} :link {text-decoration: none !important; color: #00f5e8 !important} :visited {text-decoration: none !important; color: #a020f0 !important} I don't know whether my CSS is invalid or if it's a bug in Dillo, but hints for applying black background-color to everything except images would be welcome. The image background is also black when I open it on its own with "isolate image" from the right-click menu, even though there it's on a light-colour background due to the 'bg_color' setting in dillorc being set to default. Presumably that's because the image in the cache already, loading a new PNG image URL the background is bg_color: https://upload.wikimedia.org/wikipedia/commons/thumb/c/cd/Unix_timeline.en.…

July 2, 2024

Re: extra /tmp on file name line when save html

by pastebin＠gmx.com

Hi i got it to reproduce dillo any url right click mouse -> 'save page as' in the Filename: text box it shows /html/ highlighted in blue /html is my default save dir from dillorc save_dir=/html the i just type r (or any key) and it now shows /tmp/r hitting any key now just dups the /tmp/r on an on if the blue highlight is erased by clicking mouse in text box then it is normal it is the highlighting that is the problem Mon, 3 Jun 2024 16:35:03 -0600 pastebin(a)gmx.com wrote: > Hi > > i save html files in a dir called /html (dillo saves them correctly there 99.99% of the time) > > i have a dir /html/tmp (dir named tmp in /html) > > but sometimes and i can't pin down what causes it the file line becomes /tmp and if i try to backspace it just adds more /tmp/tmp/tmp etc so i have to cancel the file save and redo the dialog > i can click on tmp and the dir changes to /html/tmp and saving file there is no problem > > any one experiencing something similar or any ideas? > _______________________________________________ > Dillo-dev mailing list -- dillo-dev(a)mailman3.com > To unsubscribe send an email to dillo-dev-leave(a)mailman3.com

July 1, 2024

Re: Unexpected behaviour.

by D

2024-06-26 22:26:13 (+0200), Rodrigo Arias wrote: > On Wed, Jun 26, 2024 at 12:47:08AM +0300, D wrote: > > html tag <caption> makes the table wider. > > The caption tag is not supported yet. Do you have a test case? Any <table> with <caption> may serve as test case. --

June 27, 2024

Re: HTTPS Proxy Support

by Kevin Koster

Rodrigo Arias wrote: > On Wed, Jun 26, 2024 at 08:52:37AM +1000, Kevin Koster wrote: >>Rodrigo Arias <rodarima-Re5JQEeQqe8AvxtiuMwx3w-XMD5yJDbdMReXY1tMh2IBg(a)public.gmane.org> wrote: >>This is why I now think it best to avoid the 'https_proxy' name, >>because the behaviour with it will never be consistent with other >>software without changing how Dillo already handles the >>'http_proxy' variable/setting. > > I undertand, but I think this is a good moment to plan how to change how > Dillo handles the http_proxy variable, so it only affects HTTP traffic > and not HTTPS too. > > What about this: > > Setting the env vars as: > http_proxy=http://localhost:1234 > https_proxy= > > Now causes a warning (maybe also in the UI): > > $ dillo https://www.google.com > WARNING: Setting http_proxy to specify the HTTPS proxy is deprecated, > use https_proxy to define it instead. > > But still makes Dillo use the http_proxy both for HTTP and HTTPS for > now. > > Also: > > http_proxy=http://localhost:1234 > https_proxy=http://localhost:1235 > > No warning: > > $ dillo https://www.google.com > > But Dillo uses both proxies independently (like curl or wget), instead > of the current implementation that would use http_proxy for HTTP and > HTTPS. > > Same with the dillorc options http_proxy and https_proxy (new), keeping > the preference for the env vars if defined. Yes that sounds like a good way to bring Dillo into line with other software, and also means that the environment variables apply consistently to downloads since they use Wget. > The only unexpected change may be for a user that had previously set > https_proxy that was not being used by Dillo, and now it would be. But I > think that 1) is unlikely they use a different value for HTTP and HTTPS > and 2) it is probably intended to use the https_proxy for HTTPS anyway. > We could emit a warning about this too, but maybe not needed if we > explain that Dillo will handle now the https_proxy variable. Affected users would have already been seeing inconsistent behaviour with file downloads since Wget is already using https_proxy. > In any case, this should be properly explained in the release notes, > leaving one release with the deprecation warning for users to take time > to change the behavior, before we stop using http_proxy as the HTTPS > proxy. Yep, and obviously in the changelog too, to be better than Wget and its undocumented past switch to tunneling HTTPS connections through https_proxy. > I think this has the benefit of being the implementation most users > would expect, as it is consisten with other tools, while having the > least amount of pain for current users of proxies as they would have > time to realize the deprecation notice. Yes I agree. > That would allow you to specify *only* the https_proxy like this: > > http_proxy= > https_proxy=http://localhost:1235 > > $ dillo https://www.google.com > > No warning and Dillo uses https_proxy for HTTPS and HTTP doesn't use a > proxy. > > And over this change, you can add your specific option in dillorc only > to change the way Dillo communicates with the HTTPS proxy to avoid the > CONNECT, with the "https_proxy_use_http=TRUE" or similar option. That would be fine. > Lastly, a similar option was mentioned by Daniel (curl lead developer) > some time ago: https://stackoverflow.com/a/34268925 It doesn't appear that anyone implemented it in Curl though.

June 26, 2024

Re: dillorc long line word wrap

by pastebin＠gmx.com

Hi, yes i see : the text in the alt is treated differently from the text in the html - i can't cut n paste the alt text but can the html text --- Just for completeness i have the images from this site blocked in /etc/hosts but have the tools/load images checked the result is the same appearance wise On Wed, 26 Jun 2024 23:57:05 +0200 Rodrigo Arias <rodarima(a)gmail.com> wrote: > Hi, > > On Wed, Jun 26, 2024 at 03:22:57PM -0600, pastebin(a)gmx.com wrote: > >2 attached pngs > >first with no cursor movement to right > >second with cursor movement to right > > Thanks, it seems to be caused by the long alt text when images are > disabled. I have opened an issue here: > > https://github.com/dillo-browser/dillo/issues/207 > > Best, > Rodrigo. > _______________________________________________ > Dillo-dev mailing list -- dillo-dev(a)mailman3.com > To unsubscribe send an email to dillo-dev-leave(a)mailman3.com

June 26, 2024