- Dillo-dev - lists.mailman3.com

modify bookmarks (Re: [Dillo-dev] EAGAIN loop in IO_read)

by jcid＠dillo.org

On Thu, Nov 12, 2009 at 12:08:33AM +0000, corvid wrote: > Jorge wrote: > > BTW, I chasing a very weird bug here. I can't modify a bookmark > > unless I comment closing a stream on an unrelated file! > > > > This is: > > > > @@ -417,8 +417,10 @@ static int Dpi_read_comm_keys(int *port) > > SharedKey[i] = 0; > > ret = 1; > > } > > - if (In) > > - fclose(In); > > > > > > Then it works! :-P > > > > @all: The question is, is this happening only in my system or do you > > see the problem as well. In other words: can you modify a bookmark? > > I don't normally use bookmarks, but if I try it, I click submit, get > Nav_open_url: new url='dpi:/bm/modify?operation=modify&submit=submit.&s0=on&url1=on' > Nav_open_url: new url='dpi:/bm/modify' > > and...nothing else seems to happen. Exactly as here... and if you apply the above patch? -- Cheers Jorge.-

Nov. 12, 2009

modify bookmarks (Re: [Dillo-dev] EAGAIN loop in IO_read)

by corvid＠lavabit.com

Jorge wrote: > BTW, I chasing a very weird bug here. I can't modify a bookmark > unless I comment closing a stream on an unrelated file! > > This is: > > @@ -417,8 +417,10 @@ static int Dpi_read_comm_keys(int *port) > SharedKey[i] = 0; > ret = 1; > } > - if (In) > - fclose(In); > > > Then it works! :-P > > @all: The question is, is this happening only in my system or do you > see the problem as well. In other words: can you modify a bookmark? I don't normally use bookmarks, but if I try it, I click submit, get Nav_open_url: new url='dpi:/bm/modify?operation=modify&submit=submit.&s0=on&url1=on' Nav_open_url: new url='dpi:/bm/modify' and...nothing else seems to happen.

Nov. 12, 2009

EAGAIN loop in IO_read

by jcid＠dillo.org

On Thu, Nov 12, 2009 at 07:54:25AM +0900, furaisanjin wrote: > Hi. > > My problem also seems to be fixed because it's very harder to > reproduce the problem now. Is still possible to trigger the problem (but very hard)? > By the way, I'm a bit wondering this code > and I suppose something like this. > > --- dillo/src/IO/dpi.c 2009-11-11 05:51:28.000000000 +0900 > +++ dillo-test/src/IO/dpi.c 2009-11-11 22:05:42.000000000 +0900 > @@ -793,12 +793,15 @@ char *a_Dpi_send_blocking_cmd(const char > > if ((sock_fd = Dpi_connect_socket(server_name, TRUE)) == -1) { > MSG_ERR("[a_Dpi_send_blocking_cmd] Can't connect to server.\n"); > - } else if (Dpi_blocking_write(sock_fd, cmd, strlen(cmd)) == -1) { > - MSG_ERR("[a_Dpi_send_blocking_cmd] Can't send message.\n"); > - } if ((ret = Dpi_blocking_read(sock_fd)) == NULL) { > - MSG_ERR("[a_Dpi_send_blocking_cmd] Can't read message.\n"); > + } else { > + if (Dpi_blocking_write(sock_fd, cmd, strlen(cmd)) == -1) { > + MSG_ERR("[a_Dpi_send_blocking_cmd] Can't send message.\n"); > + } > + if ((ret = Dpi_blocking_read(sock_fd)) == NULL) { > + MSG_ERR("[a_Dpi_send_blocking_cmd] Can't read message.\n"); > + } > + Dpi_close_fd(sock_fd); > } > - Dpi_close_fd(sock_fd); Dpi_close_fd() checks fd != -1 so AFAIS it's OK. BTW, I chasing a very weird bug here. I can't modify a bookmark unless I comment closing a stream on an unrelated file! This is: @@ -417,8 +417,10 @@ static int Dpi_read_comm_keys(int *port) SharedKey[i] = 0; ret = 1; } - if (In) - fclose(In); Then it works! :-P @all: The question is, is this happening only in my system or do you see the problem as well. In other words: can you modify a bookmark? -- Cheers Jorge.-

Nov. 12, 2009

EAGAIN loop in IO_read

by furaisanjin＠gmail.com

Hi. My problem also seems to be fixed because it's very harder to reproduce the problem now. By the way, I'm a bit wondering this code and I suppose something like this. --- dillo/src/IO/dpi.c 2009-11-11 05:51:28.000000000 +0900 +++ dillo-test/src/IO/dpi.c 2009-11-11 22:05:42.000000000 +0900 @@ -793,12 +793,15 @@ char *a_Dpi_send_blocking_cmd(const char if ((sock_fd = Dpi_connect_socket(server_name, TRUE)) == -1) { MSG_ERR("[a_Dpi_send_blocking_cmd] Can't connect to server.\n"); - } else if (Dpi_blocking_write(sock_fd, cmd, strlen(cmd)) == -1) { - MSG_ERR("[a_Dpi_send_blocking_cmd] Can't send message.\n"); - } if ((ret = Dpi_blocking_read(sock_fd)) == NULL) { - MSG_ERR("[a_Dpi_send_blocking_cmd] Can't read message.\n"); + } else { + if (Dpi_blocking_write(sock_fd, cmd, strlen(cmd)) == -1) { + MSG_ERR("[a_Dpi_send_blocking_cmd] Can't send message.\n"); + } + if ((ret = Dpi_blocking_read(sock_fd)) == NULL) { + MSG_ERR("[a_Dpi_send_blocking_cmd] Can't read message.\n"); + } + Dpi_close_fd(sock_fd); } - Dpi_close_fd(sock_fd); return ret; } Regards, furaisanjin

Nov. 11, 2009

weird font

by jcid＠dillo.org

On Tue, Nov 10, 2009 at 11:06:30PM +0100, Johannes Hofmann wrote: > Hi Jorge, > > On Tue, Nov 10, 2009 at 06:46:45PM -0300, Jorge Arellano Cid wrote: > > Hi, > > > > On some sites I get weird fonts. Today I got to isolate the > > problem. See attached file. Here it displays like this: > > > > http://www.dillo.org/test/xmp2.png > > > > The embedded CSS says: > > > > pre { font-family: MS Courier New, Courier, monospace; } > > > > If I remove "MS Courier New", it works OK. > > Any clues? > > There are multiple issues with font selection: > > * The CSS parser only returns the part until the first blank > ('MS' in this case). > * StyleEngine currently does not handle comma separated font name > lists (see \todo comment). > * ::fltk::font(name, fa); in fltkplatform.cc does not offer a way to > determine whether a font with that name actually exists on the > system. Instead if no exact match can be found, it guesses a > replacement font. This makes it impossible for dillo to choose the > right one from a given list. > > In your specific case, fltk gets the string 'MS' and on your system > it seems to find some funny font that has a similar name. Thanks for the detailed explanation. -- Cheers Jorge.-

Nov. 11, 2009

weird font

by marc＠marcengelhardt.com

Jorge wrote: If I remove "MS Courier New", it works OK. Any clues? I think the problem is the missing quote signs ("") before and after the font name (MS Courier New). I can be wrong, but I think that Dillo doesn't recognizes that the three words (MS, Courier, New), which normally builds the font, must be combined to build a valid font. The problem can be fixed if you add a feature to Dillo, which let Dillo recognizes that a string in a CSS rule (before a comma) represents a valid font and should be applied to the elements on the page, which are affected by the CSS rule. So, Dillo should be recognizes fonts, which are one, two or three words in length. Please keep in mind, that font names, which are between the quote signs, must also be recognized by Dillo.

Nov. 10, 2009

weird font

by Johannes.Hofmann＠gmx.de

Hi Jorge, On Tue, Nov 10, 2009 at 06:46:45PM -0300, Jorge Arellano Cid wrote: > Hi, > > On some sites I get weird fonts. Today I got to isolate the > problem. See attached file. Here it displays like this: > > http://www.dillo.org/test/xmp2.png > > The embedded CSS says: > > pre { font-family: MS Courier New, Courier, monospace; } > > If I remove "MS Courier New", it works OK. > Any clues? There are multiple issues with font selection: * The CSS parser only returns the part until the first blank ('MS' in this case). * StyleEngine currently does not handle comma separated font name lists (see \todo comment). * ::fltk::font(name, fa); in fltkplatform.cc does not offer a way to determine whether a font with that name actually exists on the system. Instead if no exact match can be found, it guesses a replacement font. This makes it impossible for dillo to choose the right one from a given list. In your specific case, fltk gets the string 'MS' and on your system it seems to find some funny font that has a similar name. Cheers, Johannes

Nov. 10, 2009

weird font

by jcid＠dillo.org

Hi, On some sites I get weird fonts. Today I got to isolate the problem. See attached file. Here it displays like this: http://www.dillo.org/test/xmp2.png The embedded CSS says: pre { font-family: MS Courier New, Courier, monospace; } If I remove "MS Courier New", it works OK. Any clues? -- Cheers Jorge.-

Nov. 10, 2009

EAGAIN loop in IO_read

by Johannes.Hofmann＠gmx.de

On Tue, Nov 10, 2009 at 05:51:08PM -0300, Jorge Arellano Cid wrote: > On Mon, Nov 09, 2009 at 08:27:23PM +0100, Johannes Hofmann wrote: > > On Mon, Nov 09, 2009 at 03:40:58PM -0300, Jorge Arellano Cid wrote: > > > On Mon, Nov 09, 2009 at 07:24:45PM +0100, Johannes Hofmann wrote: > > > > On Mon, Nov 09, 2009 at 11:34:36AM -0300, Jorge Arellano Cid wrote: > > > > > On Mon, Nov 09, 2009 at 12:05:30PM +0900, furaisanjin wrote: > > > > > > I dont't know any trigger yet. I just browse pages and occasionally > > > > > > the problem happens. There isn't any specific page either. > > > > > > > > > > The point is we have massive changes in the DPI area, not in > > > > > dillo. If you trigger it while browsing HTTP, DPI is out of the > > > > > equation. If it happens with HTTPS, DPI participates. > > > > > > > > > > I'd expect you not being able to trigger the bug by using the > > > > > file dpi, but if you can with plain HTTP it's a surprise. > > > > > > > > Not 100% sure if it is the same issue, but I can crash dillo by > > > > going to the bookmark page and then keep Ctrl-r pressed so that it > > > > reloads continiously. After a while I get a segmentation fault, but > > > > no proper stack unfortunately. > > > > > > Was the crash possible before the DPI changes? > > > > One more thing. There is a file descriptor leak you can see with > > > > diff -r 8535113920b1 src/IO/dpi.c > > --- a/src/IO/dpi.cgiMon Nov 09 14:22:27 2009 -0300 > > +++ b/src/IO/dpi.cgiMon Nov 09 20:25:34 2009 +0100 > > @@ -90,7 +90,7 @@ > > static void Dpi_close_fd(int fd) > > { > > int st; > > - > > +fprintf(stderr, "===> close %d\n", fd); > > dReturn_if (fd < 0); > > do > > st = close(fd); > > @@ -432,6 +432,7 @@ > > if ((fd = socket(AF_INET, SOCK_STREAM, 0)) != -1) { > > ret = fd; > > } > > +fprintf(stderr, "===> socket %d\n", fd); > > return ret; > > } > > > > > > Each time one accesses the bookmarks page one fd is leaked. I think > > there is also some close()'s missing in the error cases. > > No FD leak here, the respective FD is closed by IO, although > there were a couple of FD leaks elsewhere (fixed in repo). Yes, problem is gone, nice! Cheers, Johannes

Nov. 10, 2009

EAGAIN loop in IO_read

by Johannes.Hofmann＠gmx.de

On Tue, Nov 10, 2009 at 05:48:12PM -0300, Jorge Arellano Cid wrote: > On Mon, Nov 09, 2009 at 08:00:43PM +0100, Johannes Hofmann wrote: > > > > PS: While looking at the code I found that Dpi_make_socket_fd() > > could be simplified to just: > > > > return socket(AF_INET, SOCK_STREAM, 0); > > Yes, it was coded that way to set socket options from a single > function easily. When those proved unnecessary, the skeleton was > left just in case. Understood, but I thought the body of the function could be simplified like this: static int Dpi_make_socket_fd() { return socket(AF_INET, SOCK_STREAM, 0); } Cheers, Johannes

Nov. 10, 2009