- Dillo-dev - lists.mailman3.com

take_focus on a new tab

by onepoint＠starurchin.org

On Tue, Nov 24, 2009 at 11:03:23PM +0100, Johannes Hofmann wrote: > I would propose something as in attached patch to ensure that > Location is focused when opening a new (empty) tab. +1 Jeremy Henty

Nov. 26, 2009

take_focus on a new tab

by Johannes.Hofmann＠gmx.de

On Sat, Nov 21, 2009 at 05:33:24PM +0900, furaisanjin wrote: > Hi all. > > I'm wondering if > "BW2UI(new_bw)->tabs()->selected_child()->take_focus()" is really > needed in a_UIcmd_open_url_nt. I usually hit space bar to scroll down > but I can't do this when I open a new tab by clicking middle mouse > button. The reason is that cursor stays on address bar so that I just > add space at the end of url if I hit space bar. Good point. I would propose something as in attached patch to ensure that Location is focused when opening a new (empty) tab. Cheers, Johannes

Nov. 24, 2009

take_focus on a new tab

by furaisanjin＠gmail.com

Hi all. I'm wondering if "BW2UI(new_bw)->tabs()->selected_child()->take_focus()" is really needed in a_UIcmd_open_url_nt. I usually hit space bar to scroll down but I can't do this when I open a new tab by clicking middle mouse button. The reason is that cursor stays on address bar so that I just add space at the end of url if I hit space bar. Regards, furaisanjin

Nov. 21, 2009

[patch]: trim the labels of the stylesheet menu

by corvid＠lavabit.com

Jeremy wrote: > On Fri, Nov 20, 2009 at 09:28:25PM +0000, corvid wrote: > > Jeremy wrote: > > > > > It's interesting that FLTK decides to clip a little bit from the end > > there. I wonder what it was thinking... > > Me too, but I didn't feel like wading through FLTK code tonight! :-) Turns out that it doesn't do it to me when I run it. So let's blame the font... > > > We just copy the pointer to the DilloUrl structure, so we are > > > assuming it will never be free()-ed while the menu is up. If I'm > > > wrong about this the patch will need to be revised. > > > > I don't know the details of when Jorge's code decides to free cache > > entries, but I think it would be best not to assume that the url > > remains valid. > > OK, I agree: robust code should ensure its own safety, not depend on > other code to look after it. Here's a patch to do that. It applies > on top of the previous patch. Committed.

Nov. 21, 2009

modify bookmarks (Re: [Dillo-dev] EAGAIN loop in IO_read)

by furaisanjin＠gmail.com

2009/11/20 Jorge Arellano Cid <jcid(a)dillo.org>: > ?@all: please test the patch in the repo and report. Bookmark problem is fixed on FreeBSD. > ?The ?problem with HTTP proxy *may* be a different thing, but it > also may be fixed now. Please check and report. Still I need to modify for HTTP proxy, so the root cause is different. Regards, furaisanjin

Nov. 21, 2009

[patch]: trim the labels of the stylesheet menu

by onepoint＠starurchin.org

On Fri, Nov 20, 2009 at 09:28:25PM +0000, corvid wrote: > Jeremy wrote: > > > It's interesting that FLTK decides to clip a little bit from the end > there. I wonder what it was thinking... Me too, but I didn't feel like wading through FLTK code tonight! :-) > > We just copy the pointer to the DilloUrl structure, so we are > > assuming it will never be free()-ed while the menu is up. If I'm > > wrong about this the patch will need to be revised. > > I don't know the details of when Jorge's code decides to free cache > entries, but I think it would be best not to assume that the url > remains valid. OK, I agree: robust code should ensure its own safety, not depend on other code to look after it. Here's a patch to do that. It applies on top of the previous patch. Jeremy

Nov. 20, 2009

[patch]: trim the labels of the stylesheet menu

by corvid＠lavabit.com

Jeremy wrote: > > While thinking about stylesheet issues I noticed a UI problem: the > stylesheet menu uses URLs as the labels of the menu items. This is > unfortunate because some sites have stylesheets with insanely long > URLs. (Try Wikipedia if you don't believe me!) So I'm attaching a > patch that trims long URLs in the menu. This is just a UI change - no > functionality is affected. > > Here's a demonstration of the patch on the front page of Wikipedia: > > http://starurchin.org/dillo/stylesheet_menu/ Good. It would be nice to improve the labels. It's interesting that FLTK decides to clip a little bit from the end there. I wonder what it was thinking... > Notes: > > Since the label is no longer always the same as the label the callback > must find the URL elsewhere. We put it in the user_data() of the menu > item. > > We just copy the pointer to the DilloUrl structure, so we are assuming > it will never be free()-ed while the menu is up. If I'm wrong about > this the patch will need to be revised. I don't know the details of when Jorge's code decides to free cache entries, but I think it would be best not to assume that the url remains valid.

Nov. 20, 2009

[patch]: trim the labels of the stylesheet menu

by onepoint＠starurchin.org

While thinking about stylesheet issues I noticed a UI problem: the stylesheet menu uses URLs as the labels of the menu items. This is unfortunate because some sites have stylesheets with insanely long URLs. (Try Wikipedia if you don't believe me!) So I'm attaching a patch that trims long URLs in the menu. This is just a UI change - no functionality is affected. Here's a demonstration of the patch on the front page of Wikipedia: http://starurchin.org/dillo/stylesheet_menu/ Notes: Since the label is no longer always the same as the label the callback must find the URL elsewhere. We put it in the user_data() of the menu item. We just copy the pointer to the DilloUrl structure, so we are assuming it will never be free()-ed while the menu is up. If I'm wrong about this the patch will need to be revised. We get a nice cleanup for free: we loose the mysterious magic constant 5 in the callback. (Bonus points if you can see what that magic constant is! Double bonus points if you can see why the code still worked when I erroneously left it in!) Please comment, Jeremy Henty

Nov. 20, 2009

modify bookmarks (Re: [Dillo-dev] EAGAIN loop in IO_read)

by jcid＠dillo.org

On Thu, Nov 19, 2009 at 08:10:44AM +0900, furaisanjin wrote: > Hi. > > I see the problem on FreeBSD (6.4) as well. But if I modify dillo like this, > > diff -r 0a016f48a68b src/capi.c > --- a/src/capi.c Sun Nov 15 13:00:56 2009 +0100 > +++ b/src/capi.c Thu Nov 19 08:04:20 2009 +0900 > @@ -519,7 +519,7 @@ > _MSG("a_Capi_stop_client: force=%d\n", force); > > Client = a_Cache_client_get_if_unique(Key); > - if (Client && (force || Client->BufSize == 0)) { > + if (Client && force) { > /* remove empty entries too */ > a_Capi_conn_abort_by_url(Client->Url); > } > > I don't see the problem. Because the original Dillo didn't work well > with my local HTTP proxy, I modified like above. I didn't dig out > deeper but it seems that Dillo didn't close socket connection properly > so that HTTP proxy thought the connection was still opened. Excellent! This explains the race condition to me. @all: please test the patch in the repo and report. The problem with HTTP proxy *may* be a different thing, but it also may be fixed now. Please check and report. -- Cheers Jorge.-

Nov. 20, 2009

auth segfault (Re: [Dillo-dev] Q: why do we defer loading linked stylesheets?)

by corvid＠lavabit.com

Jeremy wrote: > On Sun, Nov 15, 2009 at 05:55:11PM +0000, corvid wrote: > > Jeremy wrote: > > > On Sat, Nov 14, 2009 at 03:42:00PM +0000, corvid wrote: > > > > > > > Speaking of repush, I see that there's another bug about auth > > > > and segfaults in the bug tracker. > > > > > > Which one? > > > > 928 > > Ouch! Unfortunately this report doesn't give us much to work on. I > just reran all my auth tests and they still work. Without a specific > page to debug there's not much I can do. Any ideas? Could the fact > that the page uses frames have anything to do with the problem? It looks like a_Nav_cancel_expect() and a NULL bw is what caused the old crash, so maybe it's actually a similar problem of using stylesheets/images outside the auth domain. http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-April/006248.html

Nov. 20, 2009