- Dillo-dev - lists.mailman3.com

Misbehaving dw-demos

by tim.nieradzik＠gmx.de

The dw-demos stopped working for me with revision 2b0ed71ccec6. The changeset results in only printing the first character of each word followed by a line break. --Tim

Dec. 5, 2009

take_focus on a new tab

by Johannes.Hofmann＠gmx.de

On Wed, Dec 02, 2009 at 12:28:12AM +0000, corvid wrote: > furaisanjin wrote: > > 2. When URL is given on address bar, cursor stays on address bar after > > the page rendering finishes. This isn't side effect. This may be > > matter of taste but I don't like this behavior. > > We'll need to be careful if changing focus in this case, since > the user may be in the middle of typing something somewhere. > > (My local public library's site, if used in firefox, likes to reset > form fields with javascript when a page finishes loading, and it's > irritating.) What do all think about attached patch. It switches the focus when the user hits return. So the focus switch does not happen at some random time when the page has loaded which might be irritating. Cheers, Johannes

Dec. 2, 2009

take_focus on a new tab

by Johannes.Hofmann＠gmx.de

On Wed, Dec 02, 2009 at 09:33:45PM +0900, furaisanjin wrote: > 2009/12/2 corvid <corvid(a)lavabit.com>: > > furaisanjin wrote: > >> 2. When URL is given on address bar, cursor stays on address bar after > >> the page rendering finishes. This isn't side effect. This may be > >> matter of taste but I don't like this behavior. > > > > We'll need to be careful if changing focus in this case, since > > the user may be in the middle of typing something somewhere. > > I agree but current dillo behavior isn't good either. If I type > something on address bar before a page rendering finishes, typed > characters are appended after URL when URL is pushed on address bar. I > think only typed characters should remain there when the page > rendering finishes. Yes, that's annoying, but I think it's a separate issue. Regards, Johannes

Dec. 2, 2009

take_focus on a new tab

by furaisanjin＠gmail.com

2009/12/2 corvid <corvid(a)lavabit.com>: > furaisanjin wrote: >> 2. When URL is given on address bar, cursor stays on address bar after >> the page rendering finishes. This isn't side effect. This may be >> matter of taste but I don't like this behavior. > > We'll need to be careful if changing focus in this case, since > the user may be in the middle of typing something somewhere. I agree but current dillo behavior isn't good either. If I type something on address bar before a page rendering finishes, typed characters are appended after URL when URL is pushed on address bar. I think only typed characters should remain there when the page rendering finishes. Regards, furaisanjin

Dec. 2, 2009

take_focus on a new tab

by corvid＠lavabit.com

furaisanjin wrote: > 2. When URL is given on address bar, cursor stays on address bar after > the page rendering finishes. This isn't side effect. This may be > matter of taste but I don't like this behavior. We'll need to be careful if changing focus in this case, since the user may be in the middle of typing something somewhere. (My local public library's site, if used in firefox, likes to reset form fields with javascript when a page finishes loading, and it's irritating.)

Dec. 2, 2009

take_focus on a new tab

by furaisanjin＠gmail.com

2009/12/2 Johannes Hofmann <Johannes.Hofmann(a)gmx.de>: > Can you please describe the situation where it happens? There are 2 cases. 1. When dillo starts, cursor stays on address bar and this is the side effect of the updated codes. 2. When URL is given on address bar, cursor stays on address bar after the page rendering finishes. This isn't side effect. This may be matter of taste but I don't like this behavior. Regards, furaisanjin

Dec. 2, 2009

take_focus on a new tab

by Johannes.Hofmann＠gmx.de

On Sat, Nov 28, 2009 at 01:06:21PM +0900, furaisanjin wrote: > 2009/11/28 Johannes Hofmann <Johannes.Hofmann(a)gmx.de>: > > I committed a slightly different patch to also cover the case when > > middle_click_opens_new_tab=NO > > > > Please test, > > I tested but I found still there were cases where cursor stayed on > address bar. Could you consider this patch? Can you please describe the situation where it happens? I'm a bit reluctant to sprinkle focus handling code all over the place. Regards, Johannes

Dec. 1, 2009

patch: anchors no longer words

by corvid＠lavabit.com

Johannes wrote: > Looks fine to me too. Maybe you could also garbage collect > core::Content::ANCHOR to avoid confusion, or is it still used? Yes, I plan to remove it.

Nov. 30, 2009

patch: anchors no longer words

by Johannes.Hofmann＠gmx.de

On Mon, Nov 30, 2009 at 10:38:08AM -0300, Jorge Arellano Cid wrote: > On Mon, Nov 30, 2009 at 07:29:13AM +0000, corvid wrote: > > A few days ago, I tried to make addParbreak() work properly when listitems > > have anchors in the beginning (that's why they often show breaks before > > their contents), but it was quite icky -- and required more extensive > > changes than I expected. > > > > So instead, here's what we get if we pull the anchors out of the Word > > list and store them separately. Less icky. > > It looks OK to me, especially if it helps to fix the list item's > extra-line-break bug, by means of code clarity. Looks fine to me too. Maybe you could also garbage collect core::Content::ANCHOR to avoid confusion, or is it still used? Cheers, Johannes

Nov. 30, 2009

patch: anchors no longer words

by jcid＠dillo.org

On Mon, Nov 30, 2009 at 07:29:13AM +0000, corvid wrote: > A few days ago, I tried to make addParbreak() work properly when listitems > have anchors in the beginning (that's why they often show breaks before > their contents), but it was quite icky -- and required more extensive > changes than I expected. > > So instead, here's what we get if we pull the anchors out of the Word > list and store them separately. Less icky. It looks OK to me, especially if it helps to fix the list item's extra-line-break bug, by means of code clarity. -- Cheers Jorge.-

Nov. 30, 2009