- Dillo-dev - lists.mailman3.com

Re: [PATCH] Toolbar button to control zoom level

by pastebin＠gmx.com

Hi Rodrigo and alex, both your patches work on fresh source and the zoom button works nicely (left mouse click for zoom out and right mouse click for zoom in Rodrigos patch applied in dillo-3.1.1 patching file src/bw.c patching file src/bw.h patching file src/keys.cc patching file src/keys.hh patching file src/prefs.c patching file src/prefs.h patching file src/styleengine.cc patching file src/ui.cc Reversed (or previously applied) patch detected! Assume -R? [n] n Apply anyway? [n] n Skipping patch. 2 out of 2 hunks ignored -- saving rejects to file src/ui.cc.rej alex's patch applied in dillo-3.1.1/src patching file src/uicmd.cc patching file src/uicmd.hh patching file pixmaps.h patching file ui.cc patching file ui.hh all that is needed now is the 'magnifying glass' icon above the word Zoom 'borrowed' from the 'search button' :) On Sun, 7 Jul 2024 21:02:19 +0200 <a1ex(a)dismail.de> wrote: > Hi, > > Here is an updated patch with a better icon and fixed tooltip. > Hopefully somebody finds it useful :) > > > diff -u ./pixmaps.h mod/pixmaps.h > --- ./pixmaps.h Sat Jul 6 18:03:43 2024 > +++ mod/pixmaps.h Sat Jul 6 18:23:27 2024 > @@ -1410,6 +1410,28 @@ > }; > > /* XPM */ > +static const char *const zoom_xpm[] = { > +"16 16 2 1", > +" c None", > +"@ c gray70", > +" ", > +" @@@@@@ ", > +" @ @ ", > +" @ @ ", > +" @ @@ @ ", > +" @ @@ @ ", > +" @ @@ @ ", > +" @ @@@@@@@@ @ ", > +" @ @@@@@@@@ @ ", > +" @ @@ @ ", > +" @ @@ @ ", > +" @ @@ @ ", > +" @ @@@@ ", > +" @@@@@@ @@@", > +" @@", > +" "}; > + > +/* XPM */ > static const char *const new_s_xpm[] = { > "11 11 35 1", > " c None", > diff -u ./ui.cc mod/ui.cc > --- ./ui.cc Sat Jul 6 18:26:52 2024 > +++ mod/ui.cc Sat Jul 6 18:03:57 2024 > @@ -38,7 +38,7 @@ > > struct iconset { > Fl_Image *ImgMeterOK, *ImgMeterBug, > - *ImgHome, *ImgReload, *ImgSave, *ImgBook, *ImgTools, > + *ImgHome, *ImgReload, *ImgSave, *ImgBook, *ImgTools, *ImgZoom, > *ImgClear,*ImgSearch, *ImgHelp, *ImgLeft, *ImgLeftIn, > *ImgRight, *ImgRightIn, *ImgStop, *ImgStopIn; > }; > @@ -51,6 +51,7 @@ > new Fl_Pixmap(save_xpm), > new Fl_Pixmap(bm_xpm), > new Fl_Pixmap(tools_xpm), > + new Fl_Pixmap(zoom_xpm), > new Fl_Pixmap(new_s_xpm), > new Fl_Pixmap(search_xpm), > new Fl_Pixmap(help_xpm), > @@ -70,6 +71,7 @@ > new Fl_Pixmap(save_s_xpm), > new Fl_Pixmap(bm_s_xpm), > new Fl_Pixmap(tools_s_xpm), > + new Fl_Pixmap(zoom_xpm), > new Fl_Pixmap(new_s_xpm), > standard_icons.ImgSearch, > standard_icons.ImgHelp, > @@ -356,6 +358,13 @@ > wid->y() + wid->h()); > } > break; > + case UI_ZOOM: > + if (b == FL_LEFT_MOUSE) { > + a_UIcmd_zoom_in(a_UIcmd_get_bw_by_widget(wid)); > + } else if (b == FL_RIGHT_MOUSE) { > + a_UIcmd_zoom_out(a_UIcmd_get_bw_by_widget(wid)); > + } > + break; > default: > break; > } > @@ -433,6 +442,7 @@ > Stop = make_button("Stop", icons->ImgStop, icons->ImgStopIn, UI_STOP); > Bookmarks = make_button("Book", icons->ImgBook, NULL, UI_BOOK); > Tools = make_button("Tools", icons->ImgTools, NULL, UI_TOOLS); > + Zoom = make_button("Zoom", icons->ImgZoom, NULL, UI_ZOOM); > > Back->set_tooltip("Previous page"); > Forw->set_tooltip("Next page"); > @@ -442,6 +452,7 @@ > Stop->set_tooltip("Stop loading"); > Bookmarks->set_tooltip("View bookmarks"); > Tools->set_tooltip("Settings"); > + Zoom->set_tooltip("Zoom in: left-click, Zoom out: right-click"); > } > > /** > diff -u ./ui.hh mod/ui.hh > --- ./ui.hh Sat Jul 6 18:03:43 2024 > +++ mod/ui.hh Sat Jul 6 18:03:57 2024 > @@ -23,6 +23,7 @@ > UI_STOP, > UI_BOOK, > UI_TOOLS, > + UI_ZOOM, > UI_CLEAR, > UI_SEARCH > } UIButton; > @@ -125,7 +126,7 @@ > > CustGroupVertical *TopGroup; > CustButton *Back, *Forw, *Home, *Reload, *Save, *Stop, *Bookmarks, > - *Tools, *Clear, *Search, *Help, *BugMeter, *FileButton; > + *Tools, *Zoom, *Clear, *Search, *Help, *BugMeter, *FileButton; > CustGroupHorizontal *LocBar, *NavBar, *StatusBar; > Fl_Input *Location; > CustProgressBox *PProg, *IProg; > > > -Alex

July 7, 2024

Re: dillo mouse cursor

by a1ex＠dismail.de

On Sun, 7 Jul 2024 14:17:31 -0600 Hi pastebin, pastebin(a)gmx.com wrote: > Hi alex > > i did the .Xdefaults file but there are a lot of pointers in the > /usr/share/icons/DMZ-Black/cursors/ > dir - how to tell it to use left_ptr? With the right settings, it should happen automatically if you have the cursors in the correct directory. > btw it happens with seamonkey too - so it isn't just a dillo thing Maybe also try this in ~/.config/gtk-3.0/settings.ini: gtk-cursor-theme-name=DMZ-Black gtk-cursor-theme-size=48 You may need to restart X or reboot to see if it works. -Alex

July 7, 2024

Re: RFC repository

by Rodrigo Arias

Hi, On Sun, Jul 07, 2024 at 02:08:30PM -0600, pastebin(a)gmx.com wrote: >Rodrigo this looks pretty amazing Thanks! >are you thinking along the lines of a plugin that will take for example on the page >https://github.com/dillo-browser/rfc >the drop down box - when viewed with dillo gives > >Product >Actions >Automate any workflow >Packages >Host and manage packages >Security >Find and fix vulnerabilities >Codespaces >Instant dev environments >GitHub Copilot >Write better code with AI >Code review >Manage code changes >Issues >Plan and track work >Discussions >Collaborate outside of code >Sun, 7 Jul 2024 20:53:34 +0200 >Rodrigo Arias <rodarima(a)gmail.com> wrote: > >and put them into a drop down box? Yeah, that would be one of the use cases: HTML content rewriting. I think it would be easy to have a community maintained repository of rules to "fix the web" so it can be read by Dillo more easily. For now you can use the raw Markdown version to read it from Dillo: https://raw.githubusercontent.com/dillo-browser/rfc/rfc-002/rfc-002-rule-ba… Best, Rodrigo.

July 7, 2024

Re: dillo mouse cursor

by pastebin＠gmx.com

Hi alex i did the .Xdefaults file but there are a lot of pointers in the /usr/share/icons/DMZ-Black/cursors/ dir - how to tell it to use left_ptr? btw it happens with seamonkey too - so it isn't just a dillo thing On Sun, 7 Jul 2024 20:29:32 +0200 <a1ex(a)dismail.de> wrote: > On Sun, 7 Jul 2024 11:47:37 -0600 > pastebin(a)gmx.com wrote: > > > Hi > > > > this is my original mouse pointer > > xsetroot -cursor_name left_ptr > > > > when playing around with mouse cursors (i like this size) > > xsetroot -xcf /usr/share/icons/DMZ-Black/cursors/left_ptr 48 > > > > when i go into a text box on a site or move mouse to dillo's buttons > > on top the cursor changes to the original mouse pointer > > > > if i load a new dillo the large cursor comes back - until i pass the > > mouse cursor over a text box or dillo's top buttons again > > > > the large cursor isn't affected by text boxes on other program > > > I don't know what type of system you are running, but you could try > putting the following in your ~/.Xdefaults file: > > Xcursor.theme: DMZ-Black > Xcursor.size: 48 > > > Regards, > Alex > _______________________________________________ > Dillo-dev mailing list -- dillo-dev(a)mailman3.com > To unsubscribe send an email to dillo-dev-leave(a)mailman3.com

July 7, 2024

Re: RFC repository

by pastebin＠gmx.com

Rodrigo this looks pretty amazing are you thinking along the lines of a plugin that will take for example on the page https://github.com/dillo-browser/rfc the drop down box - when viewed with dillo gives Product Actions Automate any workflow Packages Host and manage packages Security Find and fix vulnerabilities Codespaces Instant dev environments GitHub Copilot Write better code with AI Code review Manage code changes Issues Plan and track work Discussions Collaborate outside of code Sun, 7 Jul 2024 20:53:34 +0200 Rodrigo Arias <rodarima(a)gmail.com> wrote: and put them into a drop down box? > Hi, > > I've decided to open a RFC-like repository for Dillo here: > > https://github.com/dillo-browser/rfc > > So we can have a centralized place to propose and discuss non-arbitrary > changes or other topics regarding Dillo. For now they are just Markdown > files so they are easy to read and write from any editor and we don't > rely much on GitHub. This also allows contributions by sending patches > via email. > > I'll be collecting more thoughts about the rule-based mechanism I was > talking about in other threads in the RFC-002: Rule-based content > manipulation, here: > > https://github.com/dillo-browser/rfc/blob/rfc-002/rfc-002-rule-based-conten… > > I may also add the PEC proposal I did the other day to classify how > broken are pages when you disable JS, although it not very Dillo > specific: > > https://dillo-browser.github.io/pec/ > > Best, > Rodrigo. > _______________________________________________ > Dillo-dev mailing list -- dillo-dev(a)mailman3.com > To unsubscribe send an email to dillo-dev-leave(a)mailman3.com

July 7, 2024

[PATCH] Toolbar button to control zoom level

by a1ex＠dismail.de

Hi, Here is an updated patch with a better icon and fixed tooltip. Hopefully somebody finds it useful :) diff -u ./pixmaps.h mod/pixmaps.h --- ./pixmaps.h Sat Jul 6 18:03:43 2024 +++ mod/pixmaps.h Sat Jul 6 18:23:27 2024 @@ -1410,6 +1410,28 @@ }; /* XPM */ +static const char *const zoom_xpm[] = { +"16 16 2 1", +" c None", +"@ c gray70", +" ", +" @@@@@@ ", +" @ @ ", +" @ @ ", +" @ @@ @ ", +" @ @@ @ ", +" @ @@ @ ", +" @ @@@@@@@@ @ ", +" @ @@@@@@@@ @ ", +" @ @@ @ ", +" @ @@ @ ", +" @ @@ @ ", +" @ @@@@ ", +" @@@@@@ @@@", +" @@", +" "}; + +/* XPM */ static const char *const new_s_xpm[] = { "11 11 35 1", " c None", diff -u ./ui.cc mod/ui.cc --- ./ui.cc Sat Jul 6 18:26:52 2024 +++ mod/ui.cc Sat Jul 6 18:03:57 2024 @@ -38,7 +38,7 @@ struct iconset { Fl_Image *ImgMeterOK, *ImgMeterBug, - *ImgHome, *ImgReload, *ImgSave, *ImgBook, *ImgTools, + *ImgHome, *ImgReload, *ImgSave, *ImgBook, *ImgTools, *ImgZoom, *ImgClear,*ImgSearch, *ImgHelp, *ImgLeft, *ImgLeftIn, *ImgRight, *ImgRightIn, *ImgStop, *ImgStopIn; }; @@ -51,6 +51,7 @@ new Fl_Pixmap(save_xpm), new Fl_Pixmap(bm_xpm), new Fl_Pixmap(tools_xpm), + new Fl_Pixmap(zoom_xpm), new Fl_Pixmap(new_s_xpm), new Fl_Pixmap(search_xpm), new Fl_Pixmap(help_xpm), @@ -70,6 +71,7 @@ new Fl_Pixmap(save_s_xpm), new Fl_Pixmap(bm_s_xpm), new Fl_Pixmap(tools_s_xpm), + new Fl_Pixmap(zoom_xpm), new Fl_Pixmap(new_s_xpm), standard_icons.ImgSearch, standard_icons.ImgHelp, @@ -356,6 +358,13 @@ wid->y() + wid->h()); } break; + case UI_ZOOM: + if (b == FL_LEFT_MOUSE) { + a_UIcmd_zoom_in(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_RIGHT_MOUSE) { + a_UIcmd_zoom_out(a_UIcmd_get_bw_by_widget(wid)); + } + break; default: break; } @@ -433,6 +442,7 @@ Stop = make_button("Stop", icons->ImgStop, icons->ImgStopIn, UI_STOP); Bookmarks = make_button("Book", icons->ImgBook, NULL, UI_BOOK); Tools = make_button("Tools", icons->ImgTools, NULL, UI_TOOLS); + Zoom = make_button("Zoom", icons->ImgZoom, NULL, UI_ZOOM); Back->set_tooltip("Previous page"); Forw->set_tooltip("Next page"); @@ -442,6 +452,7 @@ Stop->set_tooltip("Stop loading"); Bookmarks->set_tooltip("View bookmarks"); Tools->set_tooltip("Settings"); + Zoom->set_tooltip("Zoom in: left-click, Zoom out: right-click"); } /** diff -u ./ui.hh mod/ui.hh --- ./ui.hh Sat Jul 6 18:03:43 2024 +++ mod/ui.hh Sat Jul 6 18:03:57 2024 @@ -23,6 +23,7 @@ UI_STOP, UI_BOOK, UI_TOOLS, + UI_ZOOM, UI_CLEAR, UI_SEARCH } UIButton; @@ -125,7 +126,7 @@ CustGroupVertical *TopGroup; CustButton *Back, *Forw, *Home, *Reload, *Save, *Stop, *Bookmarks, - *Tools, *Clear, *Search, *Help, *BugMeter, *FileButton; + *Tools, *Zoom, *Clear, *Search, *Help, *BugMeter, *FileButton; CustGroupHorizontal *LocBar, *NavBar, *StatusBar; Fl_Input *Location; CustProgressBox *PProg, *IProg; -Alex

July 7, 2024

RFC repository

by Rodrigo Arias

Hi, I've decided to open a RFC-like repository for Dillo here: https://github.com/dillo-browser/rfc So we can have a centralized place to propose and discuss non-arbitrary changes or other topics regarding Dillo. For now they are just Markdown files so they are easy to read and write from any editor and we don't rely much on GitHub. This also allows contributions by sending patches via email. I'll be collecting more thoughts about the rule-based mechanism I was talking about in other threads in the RFC-002: Rule-based content manipulation, here: https://github.com/dillo-browser/rfc/blob/rfc-002/rfc-002-rule-based-conten… I may also add the PEC proposal I did the other day to classify how broken are pages when you disable JS, although it not very Dillo specific: https://dillo-browser.github.io/pec/ Best, Rodrigo.

July 7, 2024

Re: dillo mouse cursor

by a1ex＠dismail.de

On Sun, 7 Jul 2024 11:47:37 -0600 pastebin(a)gmx.com wrote: > Hi > > this is my original mouse pointer > xsetroot -cursor_name left_ptr > > when playing around with mouse cursors (i like this size) > xsetroot -xcf /usr/share/icons/DMZ-Black/cursors/left_ptr 48 > > when i go into a text box on a site or move mouse to dillo's buttons > on top the cursor changes to the original mouse pointer > > if i load a new dillo the large cursor comes back - until i pass the > mouse cursor over a text box or dillo's top buttons again > > the large cursor isn't affected by text boxes on other program I don't know what type of system you are running, but you could try putting the following in your ~/.Xdefaults file: Xcursor.theme: DMZ-Black Xcursor.size: 48 Regards, Alex

July 7, 2024

Re: extra /tmp on file name line when save html

by pastebin＠gmx.com

Hi besides changing the rc = chdir("/tmp"); in src/paths.c to rc = chdir("/html"); i also changed the rc = chdir("/tmp"); to rc = chdir("/html"); in dpi/datauri.c and dpi/ftp.c everything seems okay but if these are 'wrong' please let me know On Sun, 7 Jul 2024 19:15:57 +0200 Rodrigo Arias <rodarima(a)gmail.com> wrote: > Hi, > > On Sat, Jul 06, 2024 at 09:56:17AM -0600, pastebin(a)gmx.com wrote: > >Hi, > > > >Thanks Rodrigo for working with Albrecht-S > > > >i think this issue is now resolved for me > > > >when saving an html > > > >1. if i like the highlightd name given in the Filename: box i just click 'ok' > > > >2. if i want to add more text or suffix to the highlighted name given in the Filename: box i just hit 'end' key (easier then using mouse click in filename box) and enter what i want > > > >3, if i want to enter a completely new name to save in save_dir (problem being dillo enters /tmp now) > > > >i don't know if changing rc = chdir("/tmp"); to rc = chdir("/html"); in src/paths.cc is what you meant by your suggestion : > > > >> One option to work around it is to chdir() to the save_dir, so at least > >> it would make a bit more sense. > > > >but by doing so now > > > >it now puts /html/'firstkeypressed' an i can put the name i want there > >(i didn't know how to put the save_dir variable there instead of my > >hardcoded "/html" which would be better) (i get make error ->? > >save_dir not defined in this scope) > > > >so all seems fixed - for me anyway > > Yeah, that's what I meant, but instead of hard-coding the "/html" we > pick it from the preferences as `pref.save_dir` (should be an easy > patch). > > > > >thank Albrecht-S for his work and interesting posts in the > >https://github.com/fltk/fltk/issues/1004#issuecomment-2210810570 > > > >i think the only issue left here is Albrecht-S saying that hitting '/' leaves a '/' there > >my hitting the '/' key just erases highlight and leaves nothing in the filename box :) > > Yeah, I'll try to find where it is coming from, but I want finish other > things first. > > Best, > Rodrigo. > _______________________________________________ > Dillo-dev mailing list -- dillo-dev(a)mailman3.com > To unsubscribe send an email to dillo-dev-leave(a)mailman3.com

July 7, 2024

Re: dillo mouse cursor

by pastebin＠gmx.com

Hi this is my original mouse pointer xsetroot -cursor_name left_ptr when playing around with mouse cursors (i like this size) xsetroot -xcf /usr/share/icons/DMZ-Black/cursors/left_ptr 48 when i go into a text box on a site or move mouse to dillo's buttons on top the cursor changes to the original mouse pointer if i load a new dillo the large cursor comes back - until i pass the mouse cursor over a text box or dillo's top buttons again the large cursor isn't affected by text boxes on other programs

July 7, 2024