- Dillo-dev - lists.mailman3.com

Dillo-Win32 patches, split and ready to merge

by obeythepenguin＠gmail.com

Here are the split Dillo-Win32 patches, ready to merge into the upstream tree: http://dillo-win32.sourceforge.net/patches.html I've cleaned up the code somewhat, such as removing the ugly conditionals from dsock.h. This version no longer includes the infamous "timeout kludge"; however, it must be built against a patched FLTK2 library, as the upstream implementation is still very badly broken. (The necessary patch is available from the Dillo-Win32 SourceForge site.) These patches produce a working ./src/dillo.exe. DPI has not yet been ported, as I presently have neither the time nor interest to do so. I'll probably get a binary package and installer up sometime in the next few days for anyone who wants to play around with the latest and greatest. Let me know if I need to double-check anything. Cheers, ~Benjamin

Nov. 12, 2010

patch: text-indent

by corvid＠lavabit.com

Johannes wrote: > We probabely want some isBlockLevelWidget() function... Using Widget::Flags, perhaps, or would you think it best generally to save the flags for state that changes during a widget's life?

Nov. 11, 2010

patch: text-indent

by Johannes.Hofmann＠gmx.de

On Tue, Nov 09, 2010 at 09:40:19PM +0000, corvid wrote: > Johannes wrote: > > I just noticed one thing that might complicate stuff a bit. Consider > > the following page: > > > > <div style="text-indent: 3em; border: 1px solid"> > > <div style="text-indent: 3em; border: 1px solid"> > > foo > > </div> > > bar > > </div> > > > > It seems that the inner <div> should not be indented, just text. The > > spec says: "More precisely, it specifies the indentation of the > > first box that flows into the block's first line box" > > > > I'd interpet it in dillo terms as to do the indent only if the first > > word is not a textblock widget. > > As in the attached? Yes, but also for Tables. What other widgets do we have? Bullet I guess they are inline Images are inline I think Ruler this is block level, so needs no indent ListItem do we need to check for it or will it show up as Textblock::CLASS_ID? TableCell same as for ListItem We probabely want some isBlockLevelWidget() function... > > > The question is then whether the "bar" should be indented. From the > > spec I would say yes, but firefox does not seem to do it... > > > > What do you think? > > My impression is that the inner div is a block, and the bar goes into > an anonymous block according to the spec, and the anonymous block > inherits text-indent, and would indent it, but the spec is a little > monstrous, so there may be some reason why that's not it. I would think > the intention of text-indent is only to indent the first thing... > Sounds reasonable. Cheers, Johannes

Nov. 10, 2010

News from FLTK

by Johannes.Hofmann＠gmx.de

On Wed, Nov 10, 2010 at 04:24:19PM -0300, Jorge Arellano Cid wrote: > Hi there, > > FYI: > > http://fltk.org/newsgroups.php?s9941+gfltk.development+v9960+T0 Hey cool! Seems we really need to get ready to port dillo to 1.3. Cheers, Johannes

Nov. 10, 2010

News from FLTK

by jcid＠dillo.org

Hi there, FYI: http://fltk.org/newsgroups.php?s9941+gfltk.development+v9960+T0 -- Cheers Jorge.-

Nov. 10, 2010

patch: text-indent

by corvid＠lavabit.com

Johannes wrote: > I just noticed one thing that might complicate stuff a bit. Consider > the following page: > > <div style="text-indent: 3em; border: 1px solid"> > <div style="text-indent: 3em; border: 1px solid"> > foo > </div> > bar > </div> > > It seems that the inner <div> should not be indented, just text. The > spec says: "More precisely, it specifies the indentation of the > first box that flows into the block's first line box" > > I'd interpet it in dillo terms as to do the indent only if the first > word is not a textblock widget. As in the attached? > The question is then whether the "bar" should be indented. From the > spec I would say yes, but firefox does not seem to do it... > > What do you think? My impression is that the inner div is a block, and the bar goes into an anonymous block according to the spec, and the anonymous block inherits text-indent, and would indent it, but the spec is a little monstrous, so there may be some reason why that's not it. I would think the intention of text-indent is only to indent the first thing...

Nov. 9, 2010

patch: text-indent

by Johannes.Hofmann＠gmx.de

On Sun, Nov 07, 2010 at 12:43:42AM +0000, corvid wrote: > Johannes wrote: > > On Sat, Nov 06, 2010 at 03:04:16PM +0000, corvid wrote: > > > "Percentage values: refer to parent element's width" > > > > > > So a Textblock wants to decide how big it is, and it asks its children > > > how big they are, and the child has, say, text-indent: 50%, and so it > > > gets to wordWrap and asks "So, ah...how big are _you_?". And the parent > > > doesn't know yet. > > > > Ah interesting.... > > > > What about using something like availWidth in Textblock::wordWrap() as an > > aproximation of the future width of the Textblock? > > Maybe this would be good enough. > > In which cases would this be way off? > > That's a good idea! > It seems to work pretty well in general... > > (You will note that this ignores negative values (LENGTH_PERCENTAGE) and > allows overflow.) Thanks for committing the patch! I just noticed one thing that might complicate stuff a bit. Consider the following page: <div style="text-indent: 3em; border: 1px solid"> <div style="text-indent: 3em; border: 1px solid"> foo </div> bar </div> It seems that the inner <div> should not be indented, just text. The spec says: "More precisely, it specifies the indentation of the first box that flows into the block's first line box" I'd interpet it in dillo terms as to do the indent only if the first word is not a textblock widget. The question is then whether the "bar" should be indented. From the spec I would say yes, but firefox does not seem to do it... What do you think? Cheers, Johannes

Nov. 9, 2010

patch: text-indent

by Johannes.Hofmann＠gmx.de

On Sun, Nov 07, 2010 at 12:43:42AM +0000, corvid wrote: > Johannes wrote: > > On Sat, Nov 06, 2010 at 03:04:16PM +0000, corvid wrote: > > > "Percentage values: refer to parent element's width" > > > > > > So a Textblock wants to decide how big it is, and it asks its children > > > how big they are, and the child has, say, text-indent: 50%, and so it > > > gets to wordWrap and asks "So, ah...how big are _you_?". And the parent > > > doesn't know yet. > > > > Ah interesting.... > > > > What about using something like availWidth in Textblock::wordWrap() as an > > aproximation of the future width of the Textblock? > > Maybe this would be good enough. > > In which cases would this be way off? > > That's a good idea! > It seems to work pretty well in general... Wow nice! >From looking at the specs I think it should use the whole width of the block including margin and padding, like this: indent = misc::roundInt(this->availWidth * core::style::perLengthVal (getStyle()->textIndent)); As far as I can tell firefox is also doing it that way in: <div style="text-indent: 50%; border: 1px solid; padding: 2cm; margin: 2cm"> foo bar </div> Cheers, Johannes PS: Feel free to commit your patch!

Nov. 7, 2010

patch: text-indent

by corvid＠lavabit.com

Johannes wrote: > On Sat, Nov 06, 2010 at 03:04:16PM +0000, corvid wrote: > > "Percentage values: refer to parent element's width" > > > > So a Textblock wants to decide how big it is, and it asks its children > > how big they are, and the child has, say, text-indent: 50%, and so it > > gets to wordWrap and asks "So, ah...how big are _you_?". And the parent > > doesn't know yet. > > Ah interesting.... > > What about using something like availWidth in Textblock::wordWrap() as an > aproximation of the future width of the Textblock? > Maybe this would be good enough. > In which cases would this be way off? That's a good idea! It seems to work pretty well in general... (You will note that this ignores negative values (LENGTH_PERCENTAGE) and allows overflow.)

Nov. 7, 2010

vertical gaps

by jcid＠dillo.org

On Tue, Nov 02, 2010 at 08:59:05PM +0100, Johannes Hofmann wrote: > On Tue, Nov 02, 2010 at 11:02:55AM -0300, Jorge Arellano Cid wrote: > > Hi, > > > > Just noticed large vertical rendering gaps with: > > > > http://www.monotone.ca/ > > > > I'd guess it's: > > padding-bottom: 300em; > margin-bottom: -300em; > > in .box-small style. > I'm not sure what it's supposed to do, but negative margins > currently don't work. Oh, I thought it could be related with the uninitialized values Jeremy reported. > > Note1: dillo-2.1.1 doesn't have the problem > > Probabely because CSS didn't work with multiple classes > (class="box box-small" in this case) back then. Thanks for the explanation. -- Cheers Jorge.-

Nov. 3, 2010