- Dillo-dev - lists.mailman3.com

[bug]: CSS image crash

by onepoint＠starurchin.org

Jorge Arellano Cid wrote: > On Sat, Mar 26, 2011 at 09:30:37AM +0000, Jeremy Henty wrote: > > > > So how do we fix 2.0? With my latest patch? Or should we port > > yours from 1.3 to 2.0? > > From a quick review they're the same. > The one you posted surely applies cleanly to 2.0. > Just commit it. OK, it's done. Regards, Jeremy Henty

March 27, 2011

[bug]: CSS image crash

by jcid＠dillo.org

On Sat, Mar 26, 2011 at 09:30:37AM +0000, Jeremy Henty wrote: > Jorge Arellano Cid wrote: > > On Fri, Mar 25, 2011 at 06:12:48PM +0000, Jeremy Henty wrote: > > > > > > Jorge Arellano Cid wrote: > > > > > > > Patch committed (just typos). > > > > > > Is it pushed? I just did a pull and got nothing newer than a > > > commit from corvid on Feb 11th. > > > > Yes, in the 1.3 branch. > > So how do we fix 2.0? With my latest patch? Or should we port yours > from 1.3 to 2.0? From a quick review they're the same. The one you posted surely applies cleanly to 2.0. Just commit it. -- Cheers Jorge.-

March 26, 2011

[bug]: CSS image crash

by onepoint＠starurchin.org

Jorge Arellano Cid wrote: > On Fri, Mar 25, 2011 at 06:12:48PM +0000, Jeremy Henty wrote: > > > > Jorge Arellano Cid wrote: > > > > > Patch committed (just typos). > > > > Is it pushed? I just did a pull and got nothing newer than a > > commit from corvid on Feb 11th. > > Yes, in the 1.3 branch. So how do we fix 2.0? With my latest patch? Or should we port yours from 1.3 to 2.0? Regards, Jeremy Henty

March 26, 2011

[bug]: CSS image crash

by jcid＠dillo.org

On Fri, Mar 25, 2011 at 06:12:48PM +0000, Jeremy Henty wrote: > > Jorge Arellano Cid wrote: > > > Patch committed (just typos). > > Is it pushed? I just did a pull and got nothing newer than a commit > from corvid on Feb 11th. Yes, in the 1.3 branch. -- Cheers Jorge.-

March 25, 2011

[bug]: CSS image crash

by onepoint＠starurchin.org

Jorge Arellano Cid wrote: > Patch committed (just typos). Is it pushed? I just did a pull and got nothing newer than a commit from corvid on Feb 11th. Regards, Jeremy Henty

March 25, 2011

[bug]: CSS image crash

by jcid＠dillo.org

On Wed, Mar 23, 2011 at 08:56:53PM +0100, Johannes Hofmann wrote: > On Tue, Mar 22, 2011 at 04:04:06PM +0000, Jeremy Henty wrote: > > > > OK, patch attached. Please comment. I just added checks for a NULL > > borderColor.top where necessary. I am still not sure if the > > drawBorder* functions are doing exactly the right thing but at the > > least the patch stops the crash and I don't think it makes the > > behaviour any worse. > > > > Please comment, > > To me the references to style->borderColor.top in drawBorder*() other > than drawBorderTop() look like a typo, but I might be wrong. > Jorge, can you please have a look? Patch committed (just typos). I took some time to review it because borders are not simple. There's pixel matching, the case of simulated "collapsing" mode with asymmetric tricks, etc. Funny how we all were looking at it at the same time. :-) Attached goes an example that shows the corrected flaws. -- Cheers Jorge.-

March 25, 2011

[bug]: CSS image crash

by jcid＠dillo.org

On Wed, Mar 23, 2011 at 08:56:53PM +0100, Johannes Hofmann wrote: > On Tue, Mar 22, 2011 at 04:04:06PM +0000, Jeremy Henty wrote: > > > > OK, patch attached. Please comment. I just added checks for a NULL > > borderColor.top where necessary. I am still not sure if the > > drawBorder* functions are doing exactly the right thing but at the > > least the patch stops the crash and I don't think it makes the > > behaviour any worse. > > > > Please comment, > > To me the references to style->borderColor.top in drawBorder*() other > than drawBorderTop() look like a typo, but I might be wrong. > Jorge, can you please have a look? I'm checking it now... -- Cheers Jorge.-

March 24, 2011

[bug]: CSS image crash

by onepoint＠starurchin.org

Johannes Hofmann wrote: > ... I made a test case > (http://www.dillo.org/css_compat/tests/border-color.html) and it > looks wrong when compared e.g. with firefox, so I guess it's a typo. That is very convincing. I find that changing the drawBorderFoo() functions to use only the foo color fixes the crash *and* gives the same results as Firefox. <charlie_sheen>BI-WINNING!!!</charlie_sheen> I withdraw the previous patch and attach a new one. Thanks for the test case. Regards, Jeremy Henty

March 24, 2011

[bug]: CSS image crash

by Johannes.Hofmann＠gmx.de

On Wed, Mar 23, 2011 at 10:10:35PM +0000, Jeremy Henty wrote: > > Johannes Hofmann wrote: > > > To me the references to style->borderColor.top in drawBorder*() > > other than drawBorderTop() look like a typo, > > I thought so too at first but it's less simple than I realised. The > challenge is rendering borders in fancy styles. Check out the > examples[1]. It is not obvious to me how to choose the right colors. > > The CSS spec does not help[2] - it leaves the choice of colors up to > the user agent. It gives informal descriptions of the border styles > but they really just say "it must look how it should obviously look". Yeah, I also remember something like that, but I made a test case (http://www.dillo.org/css_compat/tests/border-color.html) and it looks wrong when compared e.g. with firefox, so I guess it's a typo. Regards, Johannes

March 24, 2011

[bug]: CSS image crash

by onepoint＠starurchin.org

Johannes Hofmann wrote: > To me the references to style->borderColor.top in drawBorder*() > other than drawBorderTop() look like a typo, I thought so too at first but it's less simple than I realised. The challenge is rendering borders in fancy styles. Check out the examples[1]. It is not obvious to me how to choose the right colors. The CSS spec does not help[2] - it leaves the choice of colors up to the user agent. It gives informal descriptions of the border styles but they really just say "it must look how it should obviously look". Regards, Jeremy Henty [1] http://www.dillo.org/css_compat/tests/border-style.html [2] http://www.w3.org/TR/CSS2/box.html - search for "8.5.3 Border style:"

March 23, 2011