- Dillo-dev - lists.mailman3.com

dpi/downloads.cc patch

by corvid＠lavabit.com

Rob wrote: > I built the latest version, and I can confirm that Jorges patch for > the search dialogue seems to be working nicely. When I built it > though, I got a warning from Clang. The following seems to quiet the > warning in Clang, and does not seem to generate any issues with gcc > for the compile: Committed.

July 30, 2011

dpi/downloads.cc patch

by mr_semantics＠hotmail.com

Hello all, I have been away for a bit, and had to catch up with some of the mail on the list. Looks like you are moving things along quite nicely! I built the latest version, and I can confirm that Jorges patch for the search dialogue seems to be working nicely. When I built it though, I got a warning from Clang. The following seems to quiet the warning in Clang, and does not seem to generate any issues with gcc for the compile: diff -r 49c3e24bf746 dpi/downloads.cc --- a/dpi/downloads.cc Fri Jul 29 20:19:08 2011 -0400 +++ b/dpi/downloads.cc Sat Jul 30 08:19:02 2011 -0400 @@ -516,7 +516,7 @@ // FSM to remove wget's "dot-progress" (i.e. "^ " || "^[0-9]+K") q = log_text + log_len; - for (p = esc_str; (p - esc_str) < esc_len; ++p) { + for (p = esc_str; (size_t)(p - esc_str) < esc_len; ++p) { switch (log_state) { case ST_newline: if (*p == ' ') { Regards, Rob

July 30, 2011

Segfault at <CTRL> s

by Hole.destructor＠gmx.de

Hi Jorge and Corvid. On Fri, Jul 29, 2011 at 08:24:30PM -0400, Jorge Arellano Cid wrote: > Please try the current repo (it has a better patch). Thank you for the fast reply. The current repository fixes the segfault for me. (By the way, the idea of switchable search engines is great!) Kind regards, Alexander

July 30, 2011

Segfault at <CTRL> s

by jcid＠dillo.org

On Fri, Jul 29, 2011 at 07:02:17PM -0400, Jorge Arellano Cid wrote: > On Sat, Jul 30, 2011 at 12:14:30AM +0200, Alexander Voigt wrote: > > Dear Dillo developers, > > > > since some days I get a segfault when starting the web search via > > <CTRL>s (using the dillo 3.0 trunk). Here is the backtrace: > > [...] > > Does this fix it? > > dialog.cc:167 > > - if (a_Misc_parse_search_url(source, &label, &url) < 0) > + if (!source || a_Misc_parse_search_url(source, &label, &url) < 0) Please try the current repo (it has a better patch). -- Cheers Jorge.-

July 30, 2011

Segfault at <CTRL> s

by jcid＠dillo.org

On Sat, Jul 30, 2011 at 12:14:30AM +0200, Alexander Voigt wrote: > Dear Dillo developers, > > since some days I get a segfault when starting the web search via > <CTRL>s (using the dillo 3.0 trunk). Here is the backtrace: > > > $ gdb ./dillo > GNU gdb (GDB) 7.0.1-debian > Copyright (C) 2009 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. Type "show copying" > and "show warranty" for details. > This GDB was configured as "x86_64-linux-gnu". > For bug reporting instructions, please see: > <http://www.gnu.org/software/gdb/bugs/>... > Reading symbols from /PATH/TO/DILLO/dillo...done. > (gdb) r > Starting program: /PATH/TO/DILLO/dillo > [Thread debugging using libthread_db enabled] > dillo_dns_init: Here we go! (threaded) > Disabling cookies. > Nav_open_url: new url='http://www.google.de' > [New Thread 0x7ffff5111700 (LWP 21693)] > Dns_server [0]: www.google.de is 74.125.43.106 74.125.43.104 74.125.43.99 74.125.43.147 74.125.43.105 74.125.43.103 > [Thread 0x7ffff5111700 (LWP 21693) exited] > Connecting to 74.125.43.106 > > <snip>Now I press <CTRL> s</snip> > > Program received signal SIGSEGV, Segmentation fault. > __strrchr_sse2 () at ../sysdeps/x86_64/multiarch/../strrchr.S:33 > 33 ../sysdeps/x86_64/multiarch/../strrchr.S: Can't find file or directory. > in ../sysdeps/x86_64/multiarch/../strrchr.S > Current language: auto > The current source language is "auto; currently asm". > (gdb) l > 28 in ../sysdeps/x86_64/multiarch/../strrchr.S > (gdb) bt > #0 __strrchr_sse2 () at ../sysdeps/x86_64/multiarch/../strrchr.S:33 > #1 0x0000000000410640 in a_Misc_parse_search_url (source=0x0, > label=0x7fffffffdb58, urlstr=0x7fffffffdb50) at misc.c:395 > #2 0x0000000000414ddf in a_Dialog_input (msg=<value optimized out>) > at dialog.cc:167 > #3 0x000000000040d137 in a_UIcmd_search_dialog (vbw=0x774180) at uicmd.cc:820 > #4 0x000000000040a9fd in UI::handle (this=0x7951a0, event=12) at ui.cc:821 > #5 0x000000000046451b in send(int, Fl_Widget*, Fl_Window*) () > #6 0x0000000000465415 in Fl::handle_(int, Fl_Window*) () > #7 0x000000000046533c in Fl::handle_(int, Fl_Window*) () > #8 0x0000000000485530 in fl_handle(_XEvent const&) () > #9 0x000000000048558d in do_queued_events() () > #10 0x00000000004857ac in fl_wait(double) () > #11 0x0000000000465c23 in Fl::wait(double) () > #12 0x0000000000465c93 in Fl::run() () > #13 0x0000000000407f14 in main (argc=1, argv=0x7fffffffe3c8) at dillo.cc:429 Does this fix it? dialog.cc:167 - if (a_Misc_parse_search_url(source, &label, &url) < 0) + if (!source || a_Misc_parse_search_url(source, &label, &url) < 0) -- Cheers Jorge.-

July 30, 2011

are we officially at feature freeze yet?

by jcid＠dillo.org

On Fri, Jul 29, 2011 at 03:53:45PM -0400, Jorge Arellano Cid wrote: > On Tue, Jul 26, 2011 at 07:48:18PM +0000, corvid wrote: > > > > It would be nice just to make some fixes and get 3.0 out... So far we have: [ok] moveToWidget(). Jorge has code for this. [ok] downloads dpi string escaping. [ ] UI_TEMPORARILY_SHOW_PANELS [ ] the panel problems when resizing from very small. [ok] alt text wrapping (which looks like a nice feature). [ok] remove large panel. [ok] https dialog storm (BUG#868). [ok] The findbar input doesn't know about Ctrl+{a,e,d,k}. [ ] something other than "ctab%d" for initial tab label. [ ] single close tab button with tooltip. [ ] segfault with Ctrl-s (web search) I'm working on the last one... -- Cheers Jorge.-

July 30, 2011

Segfault at <CTRL> s

by Hole.destructor＠gmx.de

Dear Dillo developers, since some days I get a segfault when starting the web search via <CTRL>s (using the dillo 3.0 trunk). Here is the backtrace: $ gdb ./dillo GNU gdb (GDB) 7.0.1-debian Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>... Reading symbols from /PATH/TO/DILLO/dillo...done. (gdb) r Starting program: /PATH/TO/DILLO/dillo [Thread debugging using libthread_db enabled] dillo_dns_init: Here we go! (threaded) Disabling cookies. Nav_open_url: new url='http://www.google.de' [New Thread 0x7ffff5111700 (LWP 21693)] Dns_server [0]: www.google.de is 74.125.43.106 74.125.43.104 74.125.43.99 74.125.43.147 74.125.43.105 74.125.43.103 [Thread 0x7ffff5111700 (LWP 21693) exited] Connecting to 74.125.43.106 <snip>Now I press <CTRL> s</snip> Program received signal SIGSEGV, Segmentation fault. __strrchr_sse2 () at ../sysdeps/x86_64/multiarch/../strrchr.S:33 33 ../sysdeps/x86_64/multiarch/../strrchr.S: Can't find file or directory. in ../sysdeps/x86_64/multiarch/../strrchr.S Current language: auto The current source language is "auto; currently asm". (gdb) l 28 in ../sysdeps/x86_64/multiarch/../strrchr.S (gdb) bt #0 __strrchr_sse2 () at ../sysdeps/x86_64/multiarch/../strrchr.S:33 #1 0x0000000000410640 in a_Misc_parse_search_url (source=0x0, label=0x7fffffffdb58, urlstr=0x7fffffffdb50) at misc.c:395 #2 0x0000000000414ddf in a_Dialog_input (msg=<value optimized out>) at dialog.cc:167 #3 0x000000000040d137 in a_UIcmd_search_dialog (vbw=0x774180) at uicmd.cc:820 #4 0x000000000040a9fd in UI::handle (this=0x7951a0, event=12) at ui.cc:821 #5 0x000000000046451b in send(int, Fl_Widget*, Fl_Window*) () #6 0x0000000000465415 in Fl::handle_(int, Fl_Window*) () #7 0x000000000046533c in Fl::handle_(int, Fl_Window*) () #8 0x0000000000485530 in fl_handle(_XEvent const&) () #9 0x000000000048558d in do_queued_events() () #10 0x00000000004857ac in fl_wait(double) () #11 0x0000000000465c23 in Fl::wait(double) () #12 0x0000000000465c93 in Fl::run() () #13 0x0000000000407f14 in main (argc=1, argv=0x7fffffffe3c8) at dillo.cc:429 Kind regards, Alexander

July 30, 2011

Re: What's pending in dillo-3.0 for a release

by obeythepenguin＠gmail.com

On Fri, 29 Jul 2011 16:12:12 -0400, Jorge Arellano Cid <jcid(a)dillo.org> wrote: > This avoids the dialog bombing that stems from loading multiple > https images/resources in a single page. A proper fix would take > either to implement the https-dpi as a server (with state), > or to move back https handling into dillo. > > As both paths would take considerable effort, and taking into > account that even deciding which approach/library to use is non > trivial, the workaround looks like a good compromise. Actually, the second one's already done -- I implemented it as part of Dillo-Win32. The patches of interest are: http://dillo-win32.sourceforge.net/files/03-dillo-r1819.dsock.diff http://dillo-win32.sourceforge.net/files/22-dillo-r1819.https.diff http://dillo-win32.sourceforge.net/files/24-dillo-r1819.sslconfig.diff The first one introduces dsock, a sockets abstraction layer patterned on dlib, which I originally wrote to add Windows networking support. The next one extends dsock to provide SSL support: all you need to do is tell it to "go secure," then dsock handles read/write operations transparently. So you get both portability *and* security, with only minimal modification to the existing Dillo code. The last patch is optional -- it just modifies the ./configure script so it can link against CyaSSL[1], an embedded SSL library. It's probably not as useful on Unix, since every distro these days ships OpenSSL, but it's nice on Windows since it dramatically reduces the binary's download size. There are a couple caveats: the HTTP CONNECT code is a mess right now, because I couldn't figure how to hook that through the CCC's, and I haven't yet added the SSL dialogs. But both of those should be relatively easy to fix. [1] http://www.yassl.com/yaSSL/Home.html Just thought I'd share, ~Benjamin

July 29, 2011

Re: What's pending in dillo-3.0 for a release

by jcid＠dillo.org

On Fri, Jul 08, 2011 at 10:25:04AM -0400, Dennis Nezic wrote: > On Wed, 29 Jun 2011 11:37:21 -0400, Jorge Arellano Cid wrote: > > Hi there, > > > > Fltk-1.3 is out there, and we've worked our pending issues list. > > What's still pending? > > /me hopes the Choice5-popup dialog, regarding unverified certificates, > has been fixed. And/or perhaps an option similar to wget's > "--no-check-certificate" is implemented :). Please check the just committed patch for this (BUG#868). Quoting the log: "Workaround: request to only check the root URL's certificate (https). This avoids the dialog bombing that stems from loading multiple https images/resources in a single page. A proper fix would take either to implement the https-dpi as a server (with state), or to move back https handling into dillo." As both paths would take considerable effort, and taking into account that even deciding which approach/library to use is non trivial, the workaround looks like a good compromise. -- Cheers Jorge.-

July 29, 2011

are we officially at feature freeze yet?

by jcid＠dillo.org

On Tue, Jul 26, 2011 at 07:48:18PM +0000, corvid wrote: > > It would be nice just to make some fixes and get 3.0 out... Just committed a patch for one of my pet peeves: "After going back or forward to any page, there were two redraws: one from the origin and another from the scroll position. This patch avoids flicker, and makes rendering 100% faster in this case." A good way to test this is to load a page with a colorful image at its top, then scroll away the image, and go to bookmars (no images here). Then go back and forward with the keyboard; w/o the patch you'll see the image flash before the page is drawn at the scroll position it was left at. So far, I'm very happy with it! :-) -- Cheers Jorge.-

July 29, 2011