- Dillo-dev - lists.mailman3.com

white-space patch

by Johannes.Hofmann＠gmx.de

On Sat, Oct 01, 2011 at 03:17:09PM -0300, Jorge Arellano Cid wrote: > On Sat, Oct 01, 2011 at 04:45:52PM +0000, corvid wrote: > > Jorge wrote: > > > On Sat, Oct 01, 2011 at 11:03:18AM -0300, Jorge Arellano Cid wrote: > > > > On Fri, Sep 30, 2011 at 08:54:39AM +0200, Johannes Hofmann wrote: > > > > > On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > > > > > > > > > [...] > > > > > > Please explain the non-deterministical behaviour at google. > > > > > > > > > > If I search for e.g. dillo on google, the first line (the link) of a > > > > > result entry is sometimes broken into two lines, sometimes not. > > > > > > > > Thanks for the explanation. > > > > > > > > After some time reviewing it and guessing, I succeeded to isolate > > > > a small testcase which I'm reviewing now. > > > > > > Sorry, it was not a reliable testcase... :-P > > > > I haven't looked into this, but do you suppose it could have to do with the > > part in html.cc that goes > > > > if (isspace(buf[buf_index])) { > > /* whitespace: group all available whitespace */ > > while (++buf_index < bufsize && isspace(buf[buf_index])) ; > > Html_process_space(html, buf + token_start, buf_index - token_start); > > token_start = buf_index; > > } ... > > > > that is, sends off whatever it's accumulated at the end of a packet? > > Not sure, but I don't think so. > > Without the whitespace patch, dillo also doesn't seem to get > right the available horizontal space for the link [1]. > > To me it looks related to the way ParMin propagates upwards in > a textblock, but I'm just starting to look into it. Yes, I also think it's related to that. Textblock::getExtremesImpl() starts from wrapRef and uses the precomputed line->maxWordMin, line->maxParMax, line->parMin, and line->parMax. From there it does compute the stuff on it's own. So if the computation of line->maxWordMin, line->maxParMax, line->parMin, and line->parMax in wordWrap() doesn't agree with what Textblock::getExtremesImpl() does afterwards, the result becomes unreliable. Cheers, Johannes

Oct. 2, 2011

white-space patch

by jcid＠dillo.org

On Sat, Oct 01, 2011 at 04:45:52PM +0000, corvid wrote: > Jorge wrote: > > On Sat, Oct 01, 2011 at 11:03:18AM -0300, Jorge Arellano Cid wrote: > > > On Fri, Sep 30, 2011 at 08:54:39AM +0200, Johannes Hofmann wrote: > > > > On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > > > > > > > [...] > > > > > Please explain the non-deterministical behaviour at google. > > > > > > > > If I search for e.g. dillo on google, the first line (the link) of a > > > > result entry is sometimes broken into two lines, sometimes not. > > > > > > Thanks for the explanation. > > > > > > After some time reviewing it and guessing, I succeeded to isolate > > > a small testcase which I'm reviewing now. > > > > Sorry, it was not a reliable testcase... :-P > > I haven't looked into this, but do you suppose it could have to do with the > part in html.cc that goes > > if (isspace(buf[buf_index])) { > /* whitespace: group all available whitespace */ > while (++buf_index < bufsize && isspace(buf[buf_index])) ; > Html_process_space(html, buf + token_start, buf_index - token_start); > token_start = buf_index; > } ... > > that is, sends off whatever it's accumulated at the end of a packet? Not sure, but I don't think so. Without the whitespace patch, dillo also doesn't seem to get right the available horizontal space for the link [1]. To me it looks related to the way ParMin propagates upwards in a textblock, but I'm just starting to look into it. BTW, adding these lines to style.css helps to visualize it: table {border: 1px solid red !important} td {border: 1px solid green !important} div {border: 1px solid black !important} [1] http://www.google.com/search?ie=UTF-8&oe=UTF-8&q=dillo -- Cheers Jorge.-

Oct. 1, 2011

white-space patch

by corvid＠lavabit.com

Jorge wrote: > On Sat, Oct 01, 2011 at 11:03:18AM -0300, Jorge Arellano Cid wrote: > > On Fri, Sep 30, 2011 at 08:54:39AM +0200, Johannes Hofmann wrote: > > > On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > > > > > [...] > > > > Please explain the non-deterministical behaviour at google. > > > > > > If I search for e.g. dillo on google, the first line (the link) of a > > > result entry is sometimes broken into two lines, sometimes not. > > > > Thanks for the explanation. > > > > After some time reviewing it and guessing, I succeeded to isolate > > a small testcase which I'm reviewing now. > > Sorry, it was not a reliable testcase... :-P I haven't looked into this, but do you suppose it could have to do with the part in html.cc that goes if (isspace(buf[buf_index])) { /* whitespace: group all available whitespace */ while (++buf_index < bufsize && isspace(buf[buf_index])) ; Html_process_space(html, buf + token_start, buf_index - token_start); token_start = buf_index; } ... that is, sends off whatever it's accumulated at the end of a packet?

Oct. 1, 2011

white-space patch

by jcid＠dillo.org

On Sat, Oct 01, 2011 at 11:03:18AM -0300, Jorge Arellano Cid wrote: > On Fri, Sep 30, 2011 at 08:54:39AM +0200, Johannes Hofmann wrote: > > On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > > > [...] > > > Please explain the non-deterministical behaviour at google. > > > > If I search for e.g. dillo on google, the first line (the link) of a > > result entry is sometimes broken into two lines, sometimes not. > > Thanks for the explanation. > > After some time reviewing it and guessing, I succeeded to isolate > a small testcase which I'm reviewing now. Sorry, it was not a reliable testcase... :-P -- Cheers Jorge.-

Oct. 1, 2011

white-space patch

by jcid＠dillo.org

On Fri, Sep 30, 2011 at 08:54:39AM +0200, Johannes Hofmann wrote: > On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > > Hi Johannes, > > > > On Tue, Sep 27, 2011 at 09:30:24PM +0200, Johannes Hofmann wrote: > > > Hi, > > > > > > attached is a preliminary patch for white-space: nowrap handling. > > > It' supposed to fix the following issues: > > > > > > * Weird page width in combination with white-space:nowrap sequences > > > (e.g. on http://en.wikipedia.org/wiki/Web_browser. > > > * Line breaks at tags (e.g. Dillo should not break after > > > the "D". (similar issue on > > > http://fltk.org/newsgroups.php?gfltk.development+T) > > > > > > without breaking: > > > > > > * zero width space handling. > > > * ideographic character handling. > > > > > > It's not ready for commit yet, as google results don't render > > > deterministically the same way. > > > Nevertheless please give it a try and report how it works for you. > > > > Good! > > > > I'm reviewing the patch and it seems to work well so far. > > > > Please explain the non-deterministical behaviour at google. > > If I search for e.g. dillo on google, the first line (the link) of a > result entry is sometimes broken into two lines, sometimes not. Thanks for the explanation. After some time reviewing it and guessing, I succeeded to isolate a small testcase which I'm reviewing now. -- Cheers Jorge.-

Oct. 1, 2011

white-space patch

by Johannes.Hofmann＠gmx.de

On Thu, Sep 29, 2011 at 03:02:24PM +0000, corvid wrote: > Jorge wrote: > > On Tue, Sep 27, 2011 at 09:30:24PM +0200, Johannes Hofmann wrote: > > > attached is a preliminary patch for white-space: nowrap handling. > > > It' supposed to fix the following issues: > > > > > > * Weird page width in combination with white-space:nowrap sequences > > > (e.g. on http://en.wikipedia.org/wiki/Web_browser. > > > * Line breaks at tags (e.g. Dillo should not break after > > > the "D". (similar issue on > > > http://fltk.org/newsgroups.php?gfltk.development+T) > > > > > > without breaking: > > > > > > * zero width space handling. > > > * ideographic character handling. > > > > > > It's not ready for commit yet, as google results don't render > > > deterministically the same way. > > > Nevertheless please give it a try and report how it works for you. > > > > Good! > > > > I'm reviewing the patch and it seems to work well so far. > > I just noticed that page source isn't wrapping. Ah good point. Seems I broke white-space:pre-wrap. I will try to fix that.

Sept. 30, 2011

white-space patch

by johannes.hofmann＠gmx.de

On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > Hi Johannes, > > On Tue, Sep 27, 2011 at 09:30:24PM +0200, Johannes Hofmann wrote: > > Hi, > > > > attached is a preliminary patch for white-space: nowrap handling. > > It' supposed to fix the following issues: > > > > * Weird page width in combination with white-space:nowrap sequences > > (e.g. on http://en.wikipedia.org/wiki/Web_browser. > > * Line breaks at tags (e.g. Dillo should not break after > > the "D". (similar issue on > > http://fltk.org/newsgroups.php?gfltk.development+T) > > > > without breaking: > > > > * zero width space handling. > > * ideographic character handling. > > > > It's not ready for commit yet, as google results don't render > > deterministically the same way. > > Nevertheless please give it a try and report how it works for you. > > Good! > > I'm reviewing the patch and it seems to work well so far. > > Please explain the non-deterministical behaviour at google. If I search for e.g. dillo on google, the first line (the link) of a result entry is sometimes broken into two lines, sometimes not. Cheers, Johannes

Sept. 30, 2011

remember digest authentication?

by 4winter＠informatik.uni-hamburg.de

Hey everyone :) Quoting corvid (2011-09-29 18:53:15) > >I dug up Justus's old http auth patch a little while back, got everything >ironed out, and it's working well for me now, so I just committed it. >Please test! Nice to hear that :) Cheers, Justus

Sept. 29, 2011

remember digest authentication?

by corvid＠lavabit.com

I dug up Justus's old http auth patch a little while back, got everything ironed out, and it's working well for me now, so I just committed it. Please test!

Sept. 29, 2011

white-space patch

by corvid＠lavabit.com

Jorge wrote: > On Tue, Sep 27, 2011 at 09:30:24PM +0200, Johannes Hofmann wrote: > > attached is a preliminary patch for white-space: nowrap handling. > > It' supposed to fix the following issues: > > > > * Weird page width in combination with white-space:nowrap sequences > > (e.g. on http://en.wikipedia.org/wiki/Web_browser. > > * Line breaks at tags (e.g. Dillo should not break after > > the "D". (similar issue on > > http://fltk.org/newsgroups.php?gfltk.development+T) > > > > without breaking: > > > > * zero width space handling. > > * ideographic character handling. > > > > It's not ready for commit yet, as google results don't render > > deterministically the same way. > > Nevertheless please give it a try and report how it works for you. > > Good! > > I'm reviewing the patch and it seems to work well so far. I just noticed that page source isn't wrapping.

Sept. 29, 2011