- Dillo-dev - lists.mailman3.com

class attributes

by corvid＠lavabit.com

Is there a reason why we don't parse entities when we get the class attr? (I was looking at how we use Html_get_attr2() in all cases for Html_parse_common_attrs(), and a_Html_get_attr() the rest of the time, and I haven't noticed anything yet in the html4 spec that makes it sound like we shouldn't parse entities for class.)

Sept. 11, 2012

hyphenation in dillo

by corvid＠lavabit.com

I was looking at the src for http://distrowatch.com , and the source page is very wide -- wider than any lines, so far as I could see.

Sept. 10, 2012

hyphenation in dillo

by sgeerken＠dillo.org

On Thu, Sep 06, Alexander Voigt wrote: > Hi Dillo developers and Sebastian. > > On Wed, Sep 05, 2012 at 02:30:32PM -0300, Jorge Arellano Cid wrote: > > Several sites I visit don't trigger hyphenation because they lack > > the "lang" attribute. I'm experimenting with a very simple language > > guess routine, to get an idea of how it could help in this regard. > > Is the xml:lang attribute (in the <html> tag) currently supported? No, not yet. BTW: I haven't understood whether "xml:" is a normal namespace prefix (for which namespace?) or is specialy reserved (and may so not be used as namespace prefix). In the latter case, support would be rather simple. Sebastian

Sept. 10, 2012

hyphenation in dillo

by sgeerken＠dillo.org

On Sun, Sep 09, Johannes Hofmann wrote: > On Thu, Sep 06, 2012 at 08:46:04PM +0200, Johannes Hofmann wrote: > > I found another example, where it still crashes: > > http://www.x.org/archive/X11R7.5/doc/man/man3/Xft.3.html > > > > It crashes here if I make the window smaller. > > Update: The following patch fixes the crash for me: [...] I could not reproduce the bug, but the patch is correct and neccessary, so I've committed it. Sebastian

Sept. 10, 2012

hyphenation in dillo

by Johannes.Hofmann＠gmx.de

On Thu, Sep 06, 2012 at 08:46:04PM +0200, Johannes Hofmann wrote: > On Thu, Sep 06, 2012 at 07:51:08PM +0200, Johannes Hofmann wrote: > > On Thu, Sep 06, 2012 at 10:22:15AM +0200, Sebastian Geerken wrote: > > > On Wed, Sep 05, Johannes Hofmann wrote: > > > > On Tue, Sep 04, 2012 at 02:36:29PM +0200, Sebastian Geerken wrote: > > > > > > I'm mostly finished with cleaning up the calculation of extremes (used > > > > > > for tables). This should already work now, please test it again. > > > > > > > > > > Just pushed some more changes; should be complete now. Please test > > > > > thoroughly. > > > > > > > > > > > > > For me it crashes on e.g. focus.de after resizing the window or > > > > clicking a link. The stack is pretty long: ... > > > > > > Still? I found test/anchrors.html as a test case (crashing when the > > > window is resized), but this is now fix. Please test again. > > > > Works fine now! Very nice. > > I found another example, where it still crashes: > http://www.x.org/archive/X11R7.5/doc/man/man3/Xft.3.html > > It crashes here if I make the window smaller. Update: The following patch fixes the crash for me: diff -r 8671009fbcaf dw/textblock_linebreaking.cc --- a/dw/textblock_linebreaking.cc Thu Sep 06 18:09:03 2012 +0200 +++ b/dw/textblock_linebreaking.cc Sun Sep 09 22:31:01 2012 +0200 @@ -588,6 +588,9 @@ wordIndexEnd += n; PRINTF ("[%p] -> new searchUntil = %d ...\n", this, searchUntil); lineAdded = false; + // update word pointer as hyphenateWord() can trigger a + // reorganization of the words structure + word = words->getRef (wordIndex); } PRINTF ("[%p] accumulating again from %d to %d\n",

Sept. 9, 2012

paragraphs

by Johannes.Hofmann＠gmx.de

On Wed, Sep 05, 2012 at 10:43:42PM +0200, Johannes Hofmann wrote: > On Tue, Sep 04, 2012 at 09:57:59PM +0200, Johannes Hofmann wrote: > > On Tue, Sep 04, 2012 at 03:22:39PM +0000, corvid wrote: > > > > > > IIRC, the space between paragraphs went away when display was > > > implemented. Do you have an idea of what the problem was in the > > > code? (I'm so used to it now that I rarely remember that it > > > isn't supposed to be that way.) > > > > > > > I only know that things changed quite a bit due to paragraphs being > > textblocks now. > > I guess we need to make a testcase and compare the rendering to e.g. > > firefox and then see how to fix problems. > > I looked a bit at it and it's probabely just a missing line in the > user-agent style, e.g: > > diff -r 773b79919a0b src/styleengine.cc > --- a/src/styleengine.ccTue Sep 04 15:09:40 2012 +0000 > +++ b/src/styleengine.ccWed Sep 05 22:42:33 2012 +0200 > @@ -831,6 +831,7 @@ > "i, em, cite, address, var {font-style: italic}" > ":link img, :visited img {border: 1px solid}" > "frameset, ul, ol, dir {margin-left: 40px}" > + "p {margin: 1em 0}" > "h1 {font-size: 2em; margin-top: .67em; margin-bottom: 0}" > "h2 {font-size: 1.5em; margin-top: .75em; margin-bottom: 0}" > "h3 {font-size: 1.17em; margin-top: .83em; margin-bottom: 0}" > > > I'm still researching, why 1em seems to be a bit more in dillo than > in firefox. Ok I remember now. Adding "p {margin: 1em 0}" to our user agent style is correct. However we need to implement collapsing bottom-margin and top-margins for subsequent block level elements to make it look nice.

Sept. 6, 2012

hyphenation in dillo

by Johannes.Hofmann＠gmx.de

On Thu, Sep 06, 2012 at 07:51:08PM +0200, Johannes Hofmann wrote: > On Thu, Sep 06, 2012 at 10:22:15AM +0200, Sebastian Geerken wrote: > > On Wed, Sep 05, Johannes Hofmann wrote: > > > On Tue, Sep 04, 2012 at 02:36:29PM +0200, Sebastian Geerken wrote: > > > > > I'm mostly finished with cleaning up the calculation of extremes (used > > > > > for tables). This should already work now, please test it again. > > > > > > > > Just pushed some more changes; should be complete now. Please test > > > > thoroughly. > > > > > > > > > > For me it crashes on e.g. focus.de after resizing the window or > > > clicking a link. The stack is pretty long: ... > > > > Still? I found test/anchrors.html as a test case (crashing when the > > window is resized), but this is now fix. Please test again. > > Works fine now! Very nice. I found another example, where it still crashes: http://www.x.org/archive/X11R7.5/doc/man/man3/Xft.3.html It crashes here if I make the window smaller.

Sept. 6, 2012

hyphenation in dillo

by Hole.destructor＠gmx.de

Hi Dillo developers and Sebastian. On Wed, Sep 05, 2012 at 02:30:32PM -0300, Jorge Arellano Cid wrote: > Several sites I visit don't trigger hyphenation because they lack > the "lang" attribute. I'm experimenting with a very simple language > guess routine, to get an idea of how it could help in this regard. Is the xml:lang attribute (in the <html> tag) currently supported? Best, Alexander

Sept. 6, 2012

hyphenation in dillo

by Johannes.Hofmann＠gmx.de

On Thu, Sep 06, 2012 at 10:22:15AM +0200, Sebastian Geerken wrote: > On Wed, Sep 05, Johannes Hofmann wrote: > > On Tue, Sep 04, 2012 at 02:36:29PM +0200, Sebastian Geerken wrote: > > > > I'm mostly finished with cleaning up the calculation of extremes (used > > > > for tables). This should already work now, please test it again. > > > > > > Just pushed some more changes; should be complete now. Please test > > > thoroughly. > > > > > > > For me it crashes on e.g. focus.de after resizing the window or > > clicking a link. The stack is pretty long: ... > > Still? I found test/anchrors.html as a test case (crashing when the > window is resized), but this is now fix. Please test again. Works fine now! Very nice. Thanks, Johannes

Sept. 6, 2012

hyphenation in dillo

by sgeerken＠dillo.org

On Wed, Sep 05, Johannes Hofmann wrote: > On Tue, Sep 04, 2012 at 02:36:29PM +0200, Sebastian Geerken wrote: > > > I'm mostly finished with cleaning up the calculation of extremes (used > > > for tables). This should already work now, please test it again. > > > > Just pushed some more changes; should be complete now. Please test > > thoroughly. > > > > For me it crashes on e.g. focus.de after resizing the window or > clicking a link. The stack is pretty long: ... Still? I found test/anchrors.html as a test case (crashing when the window is resized), but this is now fix. Please test again. Sebastian

Sept. 6, 2012