- Dillo-dev - lists.mailman3.com

Patch for xembed (text corrected)

by Johannes.Hofmann＠gmx.de

Hi, I test xembed support with the claws mail dillo plugin[1] and tabbed[2]. My guess is that the embedder needs to send some X events to the embedded program (dillo in this case) to make it work properly. Even with your patch dillo doesn't resize properly for me when I change the embedding window. I would look into the tabbed source code[2], which is pretty minimal. Cheers, Johannes [1] http://www.claws-mail.org/plugin.php?plugin=dillo [2] http://tools.suckless.org/tabbed/ On Mon, Dec 10, 2012 at 02:12:34PM +0100, podarcis wrote: > Hi all, > > Here is a patch to make embedding dillo into an X-window work. > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > diff -r 9bad41ea1dde src/xembed.cc > --- a/src/xembed.cc Wed Dec 05 13:03:04 2012 +0100 > +++ b/src/xembed.cc Sun Dec 09 10:12:36 2012 +0100 > // TODO: Implement more XEMBED support; > > -void Xembed::show() { > +void Xembed::create() { > createInternal(xid); > setXembedInfo(1); > Fl::event_dispatch(event_handler); > diff -r 9bad41ea1dde src/xembed.hh > --- a/src/xembed.hh Wed Dec 05 13:03:04 2012 +0100 > +++ b/src/xembed.hh Sun Dec 09 10:12:36 2012 +0100 > @@ -14,10 +14,11 @@ > > public: > Xembed(uint32_t xid, int _w, int _h) : Fl_Window(_w, _h) { > - this->xid = xid; > + this->xid = xid; create(); > }; > - void show(); > + void create(); > int handle(int event); > + void resize(int x, int y, int w, int h); > }; > > #endif > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > tested with this FLTK program: > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > #include <FL/Fl.H> > #include <FL/Fl_Window.H> > #include <FL/x.H> > #include <cstdio> > #include <iostream> > #include <sstream> > #include <string> > > using namespace std; > > > int main( int argc_, char *argv_[] ) > { > Fl_Window dw( 800, 600, "dillo embedded" ); > dw.resizable( &dw ); > dw.show(); > cout << "dw.xid = " << (unsigned long)fl_xid(&dw) << endl; > ostringstream cmd; > cmd << "dillo -f -g " << > dw.w() << "x" << dw.h() << " --xid " << > (unsigned long)fl_xid(&dw); > if ( argc_ > 1 ) > cmd << " " << argv_[1]; > cmd << " &"; > cout << "system '" << cmd.str() << "'" << endl; > system( cmd.str().c_str() ); > return Fl::run(); > } > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > What does NOT work is automatic resizing of the embedded dillo window, > when the size is changed. This would be nice to have. > > I do not know enough of the embedding stuff, but I wonder if the static > int event_handler() ever gets called with type ClientMessage - at least > I could not make it get there.. > > podarcis > > > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev at dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 11, 2012

Tooltip bugs revisited

by corvid＠lavabit.com

Jorge wrote: > So far (and despite the warning inside FLTK), I've experimented > with a custom tooltip handling class, and a couple custom UI > widgets, that seem to work well together (i.e. solve the problem > without the workaround :) ). I see that this code is derived from the code at http://seriss.com/people/erco/fltk/#SliderTooltip I think we should mention that at the tops of the tipwin files and in AUTHORS.

Dec. 11, 2012

complex button layout and bgColor

by corvid＠lavabit.com

All of the copies of dillo that I happen to have around from the dillo3 era break on: <body text=white bgcolor=purple> <form> <button style="margin-top:200px">inside</button> </form> </body> I can get the purple if I add diff -r 0c1b7af7bf72 dw/ui.cc --- a/dw/ui.cc Mon Dec 10 22:55:07 2012 +0000 +++ b/dw/ui.cc Tue Dec 11 01:24:32 2012 +0000 @@ -285,6 +285,7 @@ layout = new Layout (createPlatform ()); setLayout (layout); layout->setWidget (widget); + layout->setBgColor (widget->getStyle()->backgroundColor); layout->connect (&layoutReceiver); } but I don't know how this is supposed to fit together.

Dec. 11, 2012

Patch for xembed (text corrected)

by podarcis＠lavabit.com

Hi all, Here is a patch to make embedding dillo into an X-window work. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff -r 9bad41ea1dde src/xembed.cc --- a/src/xembed.cc Wed Dec 05 13:03:04 2012 +0100 +++ b/src/xembed.cc Sun Dec 09 10:12:36 2012 +0100 // TODO: Implement more XEMBED support; -void Xembed::show() { +void Xembed::create() { createInternal(xid); setXembedInfo(1); Fl::event_dispatch(event_handler); diff -r 9bad41ea1dde src/xembed.hh --- a/src/xembed.hh Wed Dec 05 13:03:04 2012 +0100 +++ b/src/xembed.hh Sun Dec 09 10:12:36 2012 +0100 @@ -14,10 +14,11 @@ public: Xembed(uint32_t xid, int _w, int _h) : Fl_Window(_w, _h) { - this->xid = xid; + this->xid = xid; create(); }; - void show(); + void create(); int handle(int event); + void resize(int x, int y, int w, int h); }; #endif ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tested with this FLTK program: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ #include <FL/Fl.H> #include <FL/Fl_Window.H> #include <FL/x.H> #include <cstdio> #include <iostream> #include <sstream> #include <string> using namespace std; int main( int argc_, char *argv_[] ) { Fl_Window dw( 800, 600, "dillo embedded" ); dw.resizable( &dw ); dw.show(); cout << "dw.xid = " << (unsigned long)fl_xid(&dw) << endl; ostringstream cmd; cmd << "dillo -f -g " << dw.w() << "x" << dw.h() << " --xid " << (unsigned long)fl_xid(&dw); if ( argc_ > 1 ) cmd << " " << argv_[1]; cmd << " &"; cout << "system '" << cmd.str() << "'" << endl; system( cmd.str().c_str() ); return Fl::run(); } ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ What does NOT work is automatic resizing of the embedded dillo window, when the size is changed. This would be nice to have. I do not know enough of the embedding stuff, but I wonder if the static int event_handler() ever gets called with type ClientMessage - at least I could not make it get there.. podarcis

Dec. 10, 2012

Patch for xembed

by podarcis＠lavabit.com

Hi all, Here is a patch to make embedding dillo into an X-window work. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff -r 9bad41ea1dde src/xembed.cc --- a/src/xembed.cc Wed Dec 05 13:03:04 2012 +0100 +++ b/src/xembed.cc Sun Dec 09 10:12:36 2012 +0100 // TODO: Implement more XEMBED support; -void Xembed::show() { +void Xembed::create() { createInternal(xid); setXembedInfo(1); Fl::event_dispatch(event_handler); diff -r 9bad41ea1dde src/xembed.hh --- a/src/xembed.hh Wed Dec 05 13:03:04 2012 +0100 +++ b/src/xembed.hh Sun Dec 09 10:12:36 2012 +0100 @@ -14,10 +14,11 @@ public: Xembed(uint32_t xid, int _w, int _h) : Fl_Window(_w, _h) { - this->xid = xid; + this->xid = xid; create(); }; - void show(); + void create(); int handle(int event); + void resize(int x, int y, int w, int h); }; #endif ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tested with this FLTK program: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I do not know enough of the embedding stuff, but I wonder if the static int event_handler~~~~~~~~~~~~~~~ #include <FL/Fl.H> #include <FL/Fl_Window.H> #include <FL/x.H> #include <cstdio> #include <iostream> #include <sstream> #include <string> using namespace std; int main( int argc_, char *argv_[] ) { Fl_Window dw( 800, 600, "dillo embedded" ); dw.resizable( &dw ); dw.show(); cout << "dw.xid = " << (unsigned long)fl_xid(&dw) << endl; ostringstream cmd; cmd << "dillo -f -g " << dw.w() << "x" << dw.h() << " --xid " << (unsigned long)fl_xid(&dw); if ( argc_ > 1 ) cmd << " " << argv_[1]; cmd << " &"; cout << "system '" << cmd.str() << "'" << endl; system( cmd.str().c_str() ); return Fl::run(); } ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ What does NOT work is automatic resizing of the embedded dillo window, when the size is changed. This would be nice to have. podarcis

Dec. 10, 2012

<button> rendering

by corvid＠lavabit.com

As Html_tag_open_button() says, /* * Buttons are rendered on one line, this is (at several levels) a * bit simpler. May be changed in the future. */ For some time I've wondered: How hard would it be to fix that?

Dec. 10, 2012

BUG #1109

by corvid＠lavabit.com

I wrote: > Jorge wrote: > > If you open [1] with dillo, the "Component:" selection list > > gets overdrawn over and over. > > I see what you mean about the overdrawing now. I had been seeing wait times > of like 20 seconds with this page, but I just tried linking with 1.3.0, > and now it's fast but scribbles all over itself. Hmm... Redraws: Problem with 1.3.0, but not with 1.3.1 or newer. Slowness: A very, very, very, very, very extreme case of what can happen if you have -g -pg -O0. The Fl_Tree code is a touch sluggish with 18000 options and ordinary optimisation, but nothing that I'd feel bad about having in 3.0.3.

Dec. 9, 2012

BUG #1109

by corvid＠lavabit.com

Jorge wrote: > If you open [1] with dillo, the "Component:" selection list > gets overdrawn over and over. I see what you mean about the overdrawing now. I had been seeing wait times of like 20 seconds with this page, but I just tried linking with 1.3.0, and now it's fast but scribbles all over itself. Hmm...

Dec. 9, 2012

BUG #1109

by corvid＠lavabit.com

Jorge wrote: > On Sun, Dec 09, 2012 at 06:59:01PM +0000, corvid wrote: > > Jorge wrote: > > > As from the backtraces, it crashed with event 11 (MOVE) inside > > > a FLTK menu. I wonder what makes this particular menu different from > > > the others in the same page. > > > > Do you know which of the option menus it broke in? > > Unfortunately not. > > Sergio reports it having crashed a few times, but he can't force > it to crash, nor succeeded when I asked him to try to find a way to > reproduce the crash. In the backtrace, I saw a "numitems = 146", and the Product menu has 145 items, but that uses the selection list instead of selection option menu because it very plainly says 'multiple="multiple"'. Strange.

Dec. 9, 2012

Unused?: the url tag in the DPI start_send_page command

by onepoint＠starurchin.org

Jorge Arellano Cid wrote: > On Sun, Dec 09, 2012 at 04:14:01PM +0000, Jeremy Henty wrote: > > > > Everything that sends the start_send_page DPI command also sends a > > url attribute with it, but I think this attribute is always > > ignored. > > > > Dillo processes the command in capi.c but it does nothing with it > > because the Cache is already set up to receive the following raw > > data. So it doesn't look at any attributes. The only other thing > > that receives a start_send_page is the view source DPI and it > > doesn't look at any of the attributes either (it extracts a url > > from the previous tag in the stream, which it then sends back to > > Dillo to be ignored). > > View source shows the URL as page title. Yes, but it gets that url from the open_url tag that Dillo sends first. The DPI then reads the start_send_page tag but ignores its url attribute. Nothing reads the url attribute from any start_send_page tag. Regards, Jeremy Henty

Dec. 9, 2012