- Dillo-dev - lists.mailman3.com

#1113 (was: How to link to a specific bug report?)

by abe＠deuxchevaux.org

Hi Corvid, On Mon, Dec 24, 2012 at 12:28:01AM +0000, corvid wrote: > As for the bug itself, at least, does the attached fix everything? Applied it against 3.0.2 with a little fuzz and it seems to work for me. Thanks! Kind regards, Axel -- /~\ Plain Text Ribbon Campaign | Axel Beckert \ / Say No to HTML in E-Mail and News | abe at deuxchevaux.org (Mail) X See http://www.asciiribbon.org/ | abe at noone.org (Mail+Jabber) / \ I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)

Dec. 24, 2012

How to link to a specific bug report?

by corvid＠lavabit.com

As for the bug itself, at least, does the attached fix everything?

Dec. 24, 2012

How to link to a specific bug report?

by abe＠deuxchevaux.org

Hi, I just submitted a (forwarded) bug report (#1113) and would like to link to it directly. Is there any query string parameter where I can enter the bug number? Neither "bug_number" like for the volunteer and remove CGI scripts does work nor does what=1113. In case there isn't such a featre yet, I'd be happy if you could at least e.g. <a name="1113">...</a> jump mark. Thta should be quite easy with regards to the CGI script's current output. TIA. Kind regards, Axel -- /~\ Plain Text Ribbon Campaign | Axel Beckert \ / Say No to HTML in E-Mail and News | abe at deuxchevaux.org (Mail) X See http://www.asciiribbon.org/ | abe at noone.org (Mail+Jabber) / \ I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)

Dec. 23, 2012

Extensions for hyphenation

by sgeerken＠dillo.org

On Thu, Dec 20, corvid wrote: > The text spills over into the following cell in > > <table border=1> > <tr> > <td>W d<whatever>aaaaaaaaaaaa*<br> > <td>WW d<whatever>aaaaaaaaaaaa*<br> > <td>WWW d<whatever>aaaaaaaaaaaa*<br> > <td>WWWW d<whatever>aaaaaaaaaaaa*<br> > <td>WWWWW d<whatever>aaaaaaaaaaaa*<br> > <td>WWWWWW d<whatever>aaaaaaaaaaaa*<br> > > </table> > > if I make the browser window narrowish. Fixed. Sebastian

Dec. 23, 2012

ui colors again

by corvid＠lavabit.com

Today I dug up the old ui colors patch from last September, ripped out the part that used system colors as defaults that was a problem*, and played around with it a little. I really like configurable colors, so, since I haven't heard anyone say anything like feature freeze yet, I'll make another push for this thing. One difference from the previous code is that I'm using inactive() on the images for inactive toolbar buttons because our gray pixmaps tend not to look so good with different UI colors. It might be good to pull it somewhat closer to the background color, but I'm not sure yet. * Under X, FLTK tries to "Read colors that KDE writes to the xrdb database", which may or may not work fine for those people running KDE, but...

Dec. 21, 2012

[patch] dns.c: missing break in a_Dns_dillohost_to_string

by Johannes.Hofmann＠gmx.de

On Thu, Dec 20, 2012 at 08:20:41PM +0400, p37sitdu at lavabit.com wrote: > Fix is attached. Committed! Thanks, Johannes

Dec. 20, 2012

config.h.in and configure.in

by onepoint＠starurchin.org

Jorge Arellano Cid wrote: > On Wed, Dec 19, 2012 at 01:24:21PM +0000, Jeremy Henty wrote: > > > > I thought that we agreed[1] to remove config.h.in from the > > repository and to rename configure.in to configure.ac . Can I > > make these changes or is more discussion needed? > > Go ahead! OK, done. Regards, Jeremy Henty

Dec. 20, 2012

[patch] dns.c: missing break in a_Dns_dillohost_to_string

by p37sitdu＠lavabit.com

Fix is attached.

Dec. 20, 2012

[patch] send_dpip_tag in vsource.c is unused

by p37sitdu＠lavabit.com

Attached patch removes unused function send_dpip_tag. Functions send_plain_text, send_numbered_text and send_html_text are made static.

Dec. 20, 2012

Dpi_connect_socket retry

by p37sitdu＠lavabit.com

On Sun, Dec 16, 2012 at 07:43:19PM -0300, Jorge Arellano Cid wrote: > On Sun, Dec 09, 2012 at 02:58:43PM +0400, p37sitdu at lavabit.com wrote: > > Also, comment says "the server closes sock_fd on error". However, > > sock_fd should still be closed by client to free allocated file > > descriptor. OS don't know if Dillo is going to read from it (in which > > case error such as ECONNRESET should happen) so file descriptor can't > > be reused. > > > > File descriptor should be closed in case of error in a_Dpip_build_cmd > > too. > > The file descriptor is properly closed by its CCC afterwards > (Visible by defining VERBOSE in chain.c). > > The CCC manages the error propagation/handling, in both the > requesting and answer branches. File descriptor is properly closed if there were no errors. But if there is an error in a_Dpip_build_cmd or Dpi_blocking_write, sock_fd should be closed before returning from Dpi_connect_socket. Dpi_connect_socket calls a_Dpip_build_cmd to build command and Dpi_blocking_write to write this command to sock_fd. a_Dpip_build_cmd does not accept sock_fd as its argument so it can't close it. Dpi_blocking_write only writes to fd, but does not close it on error. So if one of these two function fails, Dpi_connect_socket should close sock_fd before returning -1. In the current state it just returns -1 and leave sock_fd open. By the time Dpi_connect_socket returns, sock_fd is lost and will not be closed by any code outside Dpi_connect_socket. Attached patch adds code to close sock_fd in case of error.

Dec. 20, 2012