- Dillo-dev - lists.mailman3.com

dereferencing type-punned pointer warning

by Johannes.Hofmann＠gmx.de

Hi, line 135 in lout object.cc: return ((int*)&value)[0] ^ ((int*)&value)[1]; causes the following error on 64bit systems for me: warning: dereferencing type-punned pointer will break strict-aliasing rules Can we replace it like this: diff -r dd6f2d1eb15a lout/object.cc --- a/lout/object.cc Mon Jan 14 10:26:37 2013 -0300 +++ b/lout/object.cc Mon Jan 14 21:56:46 2013 +0100 @@ -21,6 +21,7 @@ #include "object.hh" #include <stdio.h> +#include <stdint.h> #include <config.h> namespace lout { @@ -132,7 +133,7 @@ // Combine both parts of the pointer value *itself*, not what it // points to, by first referencing it (operator "&"), then // dereferencing it again (operator "[]"). - return ((int*)&value)[0] ^ ((int*)&value)[1]; + return ((intptr_t)value >> 32) ^ ((intptr_t)value); #endif } Cheers, Johannes

Jan. 14, 2013

[patch] a_Dpip_send_cmd

by jcid＠dillo.org

Hi, On Sun, Jan 13, 2013 at 01:41:37AM +0400, p37sitdu at lavabit.com wrote: > http://www.inventati.org/noname/dillo/dpip-send-cmd.patch > > Patch adds a_Dpip_send_cmd and helper function a_Dpip_vbuild_cmd. > > This way common pattern > > d_cmd = a_Dpip_build_cmd(format, ...); > st = a_Dpip_dsh_write_str(sh, flush, d_cmd); > dFree(d_cmd); > > can be replaced with > > st = a_Dpip_send_cmd(sh, flush, format, ...); The idea looks good, and after applying it, the patch doesn't compile; the problem is trivial but it makes me hesitate. Please at least check the patch compiles, and that the functionality it changes/modifies works for every case, before submitting. TIA. -- Cheers Jorge.-

Jan. 14, 2013

mare patches for dpid

by jcid＠dillo.org

On Sat, Jan 12, 2013 at 10:39:54PM +0400, p37sitdu at lavabit.com wrote: > http://www.inventati.org/noname/dillo/dpid-dclose.patch > http://www.inventati.org/noname/dillo/dpid-no_dotfiles.patch Committed. -- Cheers Jorge.-

Jan. 14, 2013

Patch for xembed updated

by higuita7＠yahoo.co.uk

Hi > I don't know if the claws plugin is still used by anyone, but I > don't want to remove the code, that proved to be working. I use both dillo and claws-mail, where i load the dillo plugin... so, yes, it is still used, at least by me :) Thanks for dillo :) higuita -- Naturally the common people don't want war... but after all it is the leaders of a country who determine the policy, and it is always a simple matter to drag the people along, whether it is a democracy, or a fascist dictatorship, or a parliament, or a communist dictatorship. Voice or no voice, the people can always be brought to the bidding of the leaders. That is easy. All you have to do is tell them they are being attacked, and denounce the pacifists for lack of patriotism and exposing the country to danger. It works the same in every country. -- Hermann Goering, Nazi and war criminal, 1883-1946

Jan. 14, 2013

Patch for xembed updated

by Johannes.Hofmann＠gmx.de

On Fri, Jan 11, 2013 at 06:17:08PM +0100, podarcis wrote: > > > Please have a look at the enclosed diff 'xembed_removed_demo.diff', > > that removes the *WHOLE* xembed protocol implementation and only > > keeps the window creation. > > > > Still embedding with 'tabbed' works as before. This really makes me > > wonder... > > Update: > I just tested Claws Mail (writing this mail with it) from the Ubuntu > 12.04 distribution together with the 'Dillo_Viewer' plugin (which was > not so easy to get, because it is not longer in this distribution - I > had to take it from another distibution, openSuse-12.2) > > Result: > dillo with the *removed xembed support* (see previous posting) > integrates perfectly (including resizing) into the Claws Mail preview > window! > > Also does dillo with *my patch*. > > Just to let you know.. I know that it works partly with just simple reparenting, but it has problems. We went through all this see the thread starting with: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-May/006453.html and the final success messages from claws-mail people here: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-June/006533.html I don't know if the claws plugin is still used by anyone, but I don't want to remove the code, that proved to be working. Cheers, Johannes

Jan. 13, 2013

ui colors again

by corvid＠lavabit.com

http://www.dillo.org/test/color_themes.diff I was just playing around with making themes selectable. I typed in some color themes that Jorge has suggested, and typos in them are possible. I tried using some of the fltk color indices for our tab colors and button highlight color in order to make the code more uniform, placing the #defines in prefs for lack of an obviously good location. It has code to fix the deactivated icons when the background color changes, but I'm still not very pleased with it.

Jan. 13, 2013

font_factor

by Johannes.Hofmann＠gmx.de

On Fri, Jan 11, 2013 at 05:24:51PM -0300, Jorge Arellano Cid wrote: > On Wed, Jan 09, 2013 at 09:16:08AM +0100, Johannes Hofmann wrote: > > On Tue, Jan 08, 2013 at 11:55:42PM +0000, corvid wrote: > > > > > > I wrote: > > > > In styleengine, we use font_factor for calculation of larger and x-small > > > > and so forth, but we don't apply it when given an ordinary font size like > > > > 11px. > > > > > > Just to double-check: That's not intended behaviour, right? > > > > > > > sorry for the delay... > > This is intentional, but we know that there is a usability issue. > > In CSS px, mm, pt etc. define absolute sizes [1]. > > So if we want to adhere to the CSS spec strictly I think we can't > > just scale them. > > On the other hand web designers just use px without thinking about > > the implications. Also other browsers allow scaling of those fonts > > afaik. > > I think we have the following options: > > > > * ignore CSS and apply font_factor also to absolute font sizes > > I'd apply font_factor, especially if that's what other browsers do. > > > * implement a zoom feature that displays everything larger (also > > images etc. > > Scaling images may hurt (think of PDAs). > An image_factor may help for those (just a wild thought). > > > * check other browsers for more alternatives > > Should check before making a decision. My Firefox has a zoom option, that zooms all text and images and an additional option to zoom text only. I also tend to a apply font_factor to all text. Cheers, Johannes

Jan. 12, 2013

[patch] a_Dpip_send_cmd

by p37sitdu＠lavabit.com

http://www.inventati.org/noname/dillo/dpip-send-cmd.patch Patch adds a_Dpip_send_cmd and helper function a_Dpip_vbuild_cmd. This way common pattern d_cmd = a_Dpip_build_cmd(format, ...); st = a_Dpip_dsh_write_str(sh, flush, d_cmd); dFree(d_cmd); can be replaced with st = a_Dpip_send_cmd(sh, flush, format, ...);

Jan. 12, 2013

mare patches for dpid

by p37sitdu＠lavabit.com

http://www.inventati.org/noname/dillo/dpid-dclose.patch http://www.inventati.org/noname/dillo/dpid-no_dotfiles.patch

Jan. 12, 2013

[patch] list.h cleanup

by p37sitdu＠lavabit.com

http://www.inventati.org/noname/dillo/list.h.patch

Jan. 12, 2013