- Dillo-dev - lists.mailman3.com

CustChoice

by corvid＠lavabit.com

Jorge wrote: > I also made FORM option menus activable with down key. I'm not > sure this is a good thing though. > > @corvid: as a keyboard user, please check whether this improves > things or not. It's quite easy to reverse if not (old behaviour: > scroll page. new: activate menu if option is focused). I'm not sure either.

Jan. 28, 2013

CustChoice

by jcid＠dillo.org

On Sat, Jan 26, 2013 at 04:55:53PM +0000, corvid wrote: > Jorge wrote: > > On Wed, Jan 16, 2013 at 08:03:31PM +0000, corvid wrote: > > > > > > I was looking into why the search dialog would no longer let me tab to > > > the search engine list and press down arrow to switch between them... > > > It seems that, once Jorge added a CustChoice in fltkui.cc, the dialog code > > > started to use _that_ one and not its own. > > > > Funny how this also annoys me, while thinking it was one of your > > patches that changed the behaviour! ;-) > > > > Of course I'm not sure, and will review the issue, but *feel* > > happy about not being alone in longing for the old bahaviour. > > Perhaps we could have one CustChoice that everything uses, although I > don't know where we'd put it. OK, simple patch committed (avoiding compiler/linker confusion) Currently dw is mainly self contained so there's no easy place to put a custom class used by both. They're a bit different anyway, so it doesn't hurt. I also made FORM option menus activable with down key. I'm not sure this is a good thing though. @corvid: as a keyboard user, please check whether this improves things or not. It's quite easy to reverse if not (old behaviour: scroll page. new: activate menu if option is focused). -- Cheers Jorge.-

Jan. 28, 2013

CustChoice

by jcid＠dillo.org

On Sat, Jan 26, 2013 at 04:55:53PM +0000, corvid wrote: > Jorge wrote: > > On Wed, Jan 16, 2013 at 08:03:31PM +0000, corvid wrote: > > > > > > I was looking into why the search dialog would no longer let me tab to > > > the search engine list and press down arrow to switch between them... > > > It seems that, once Jorge added a CustChoice in fltkui.cc, the dialog code > > > started to use _that_ one and not its own. > > > > Funny how this also annoys me, while thinking it was one of your > > patches that changed the behaviour! ;-) > > > > Of course I'm not sure, and will review the issue, but *feel* > > happy about not being alone in longing for the old bahaviour. > > Perhaps we could have one CustChoice that everything uses, although I > don't know where we'd put it. Yes, I'm also looking on that... Well, at least I have code to "fix" the dialog issue and also let FORM options also work as the search dialog. I'm yet to find out why the compiler/linker *seems* to be picking the wrong CustomChoice class. I focused on fixing the practical problem first. Patch soon. -- Cheers Jorge.-

Jan. 28, 2013

Another SGI compiler problem

by csoren＠isd.net

> > Any problem if you change > bool FltkToggleButtonResource::FltkToggleButtonResource::isActivated () > to > bool FltkToggleButtonResource::isActivated () > ? > Thanks that worked!

Jan. 27, 2013

CustChoice

by corvid＠lavabit.com

Jorge wrote: > On Wed, Jan 16, 2013 at 08:03:31PM +0000, corvid wrote: > > > > I was looking into why the search dialog would no longer let me tab to > > the search engine list and press down arrow to switch between them... > > It seems that, once Jorge added a CustChoice in fltkui.cc, the dialog code > > started to use _that_ one and not its own. > > Funny how this also annoys me, while thinking it was one of your > patches that changed the behaviour! ;-) > > Of course I'm not sure, and will review the issue, but *feel* > happy about not being alone in longing for the old bahaviour. Perhaps we could have one CustChoice that everything uses, although I don't know where we'd put it.

Jan. 26, 2013

CustChoice

by jcid＠dillo.org

On Wed, Jan 16, 2013 at 08:03:31PM +0000, corvid wrote: > > I was looking into why the search dialog would no longer let me tab to > the search engine list and press down arrow to switch between them... > It seems that, once Jorge added a CustChoice in fltkui.cc, the dialog code > started to use _that_ one and not its own. Funny how this also annoys me, while thinking it was one of your patches that changed the behaviour! ;-) Of course I'm not sure, and will review the issue, but *feel* happy about not being alone in longing for the old bahaviour. -- Cheers Jorge.-

Jan. 26, 2013

Another SGi compiler problem

by corvid＠lavabit.com

Chris wrote: > Fourteen files compiled so far but then this happened in > fltkflatview.cc: > > ---------------------------------------------- > cc-3168 CC: ERROR File = fltkui.cc, Line = 782 > A name followed by "::" must be a class or namespace name. > > bool > FltkToggleButtonResource::FltkToggleButtonResource::isActivated > () > ^ > > cc-1443 CC: ERROR File = fltkui.cc, Line = 782 > > "dw::fltk::ui::FltkToggleButtonResource::FltkToggleButtonResource" > is not a > class template. > > bool > FltkToggleButtonResource::FltkToggleButtonResource::isActivated > () > ^ > > 2 errors detected in the compilation of "fltkflatview.cc". > ----------------------------------------------- > > Thoughts? Any problem if you change bool FltkToggleButtonResource::FltkToggleButtonResource::isActivated () to bool FltkToggleButtonResource::isActivated () ?

Jan. 24, 2013

Another SGi compiler problem

by csoren＠isd.net

> > > > Greets all, > > > > I'm trying to compile on Silicon Graphics (IRIX O.S.) > > using their MIPSPro 7.4 > > compiler, but getting this error in dialog.cc: > > > > <pre> > > cc-1028 CC: ERROR File = dialog.cc, Line = 180 > > The expression used must have a constant value. > > > > memset(pm, '\0', sizeof(Fl_Menu_Item[n_it+1])); > > ^ > > </pre> > > > > Thoughts? > > You may try something like: > > memset(pm, '\0', (n_it+1)*sizeof(Fl_Menu_Item)); > > -- > Cheers > Jorge.- Thanks Jorge that worked! :) Fourteen files compiled so far but then this happened in fltkflatview.cc: ---------------------------------------------- cc-3168 CC: ERROR File = fltkui.cc, Line = 782 A name followed by "::" must be a class or namespace name. bool FltkToggleButtonResource::FltkToggleButtonResource::isActivated () ^ cc-1443 CC: ERROR File = fltkui.cc, Line = 782 "dw::fltk::ui::FltkToggleButtonResource::FltkToggleButtonResource" is not a class template. bool FltkToggleButtonResource::FltkToggleButtonResource::isActivated () ^ 2 errors detected in the compilation of "fltkflatview.cc". ----------------------------------------------- Thoughts?

Jan. 24, 2013

[patch] dCalloc

by p37sitdu＠lavabit.com

dNew macro hides multiplication and can lead to integer overflows. Patch implements dCalloc and replaces dNew with dCalloc wrapper so no integer overflows are possible: http://www.inventati.org/noname/dillo/dlib/dcalloc.patch dwrite.patch is moved to http://www.inventati.org/noname/dillo/dlib/

Jan. 24, 2013

_t suffix

by p37sitdu＠lavabit.com

Suffix _t is reverved by POSIX and should not be used: <http://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html> I have made patches that remove _t suffix from some modules: http://www.inventati.org/noname/dillo/_t/

Jan. 23, 2013